Re: [FFmpeg-devel] [PATCH] compat/atomics: fix atomic_fetch_xor()

2017-04-01 Thread James Almer
On 3/29/2017 4:02 PM, wm4 wrote: > On Wed, 29 Mar 2017 15:57:45 -0300 > James Almer wrote: > >> --- >> compat/atomics/dummy/stdatomic.h | 2 +- >> compat/atomics/gcc/stdatomic.h | 4 ++-- >> compat/atomics/pthread/stdatomic.h | 2 +- >> compat/atomics/suncc/stdatomic.h | 2 +- >> compat/

Re: [FFmpeg-devel] [PATCH] frame_thread_encoder: make task indexing deterministic.

2017-04-01 Thread Michael Niedermayer
On Sat, Apr 01, 2017 at 06:34:50PM -0400, Ronald S. Bultje wrote: > Hi, > > On Sat, Apr 1, 2017 at 5:44 PM, Michael Niedermayer > wrote: > > > On Sat, Apr 01, 2017 at 08:50:37AM -0400, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Sat, Apr 1, 2017 at 6:15 AM, Michael Niedermayer > > > > > wr

[FFmpeg-devel] [PATCH v2] lavf: use the new bitstream filter for extracting extradata

2017-04-01 Thread James Almer
This merges commits 8e2ea691351c5079cdab245ff7bfa5c0f3e3bfe4 and 096a8effa3f8f3455292c958c3ed07e798def7bd by Anton Khirnov, with the following change: - extract_extradata_check() is added to know if the codec is supported by the bsf before trying to initialize it. This behaviour is similar to the

Re: [FFmpeg-devel] [PATCH] avcodec/extract_extradata_bsf: make sure parameter set NAL units were found for h264/hevc

2017-04-01 Thread James Almer
On 3/24/2017 11:13 PM, James Almer wrote: > Signed-off-by: James Almer > --- > This is an actual fix for the existing parsing code instead of a copy > of the AVCodecParser code, as an alternative to patches 2 and 3 of this > set. > > Five FATE tests will have to be updated with patch 6 if this is

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration&In-Reply-To=<98109900.4785518.1490351969...@mail.yahoo.com>

2017-04-01 Thread Thomas Mundt
>>>Thomas Mundt schrieb am Fr, 24.3.2017: > Hi, > > > attached patch will fix ticket #2674. > Tested with examples from ticket 2674 and other files at various frame rates. > > v2: Use av_frame_get_pkt_duration to calculate count of duplication of last > frame. > Use average of the earlier pts ste

Re: [FFmpeg-devel] [PATCH] frame_thread_encoder: make task indexing deterministic.

2017-04-01 Thread Ronald S. Bultje
Hi, On Sat, Apr 1, 2017 at 5:44 PM, Michael Niedermayer wrote: > On Sat, Apr 01, 2017 at 08:50:37AM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Sat, Apr 1, 2017 at 6:15 AM, Michael Niedermayer > > > wrote: > > [.] > > > > > > about the patch itself, the changes done to indexing seem not t

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-04-01 Thread wm4
On Sat, 1 Apr 2017 22:34:26 +0200 Alexander Strasser wrote: > On 2017-04-01 13:12 +0200, wm4 wrote: > > On Sat, 1 Apr 2017 10:01:15 +0200 > > Nicolas George wrote: > [...] > > > Therefore, it was not acceptable as is and should not have been pushed. > > > > > > Pushing while leaving only half

Re: [FFmpeg-devel] [PATCH] frame_thread_encoder: make task indexing deterministic.

2017-04-01 Thread Michael Niedermayer
On Sat, Apr 01, 2017 at 08:50:37AM -0400, Ronald S. Bultje wrote: > Hi, > > On Sat, Apr 1, 2017 at 6:15 AM, Michael Niedermayer > wrote: > [.] > > > > about the patch itself, the changes done to indexing seem not to > > change anything, it makes it possible for the variables to overflow > > thoug

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-04-01 Thread Thomas Mundt
>>>Thomas Mundt schrieb am Fr, 24.3.2017: > Hi, > > > attached patch will fix ticket #2674. > Tested with examples from ticket 2674 and other files at various frame rates. > > v2: Use av_frame_get_pkt_duration to calculate count of duplication of last > frame. > Use average of the earlier pts s

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-04-01 Thread Nicolas George
Le duodi 12 germinal, an CCXXV, Thomas Mundt a écrit : > Ping Replied to the patch itself. For some reason your mail is not connected to it. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmp

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-04-01 Thread Nicolas George
Le quartidi 4 germinal, an CCXXV, Thomas Mundt a écrit : > v2: Use av_frame_get_pkt_duration to calculate count of duplication of last > frame. > Use average of the earlier pts steps when av_frame_get_pkt_duration is not > set. Sorry for missing it earlier. pkt_duration is not used by lavfi. Th

Re: [FFmpeg-devel] fate/exr : add test for exr with offsets set to zero

2017-04-01 Thread Michael Niedermayer
On Sat, Apr 01, 2017 at 10:11:41PM +0200, Michael Niedermayer wrote: > On Sat, Apr 01, 2017 at 09:29:53PM +0200, Martin Vignali wrote: > > Hello, > > > > This patch can now be apply (the patch avcodec/exr detect invalid line > > offset table and recreate table have been apply) > > will be in my n

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-04-01 Thread Alexander Strasser
On 2017-04-01 13:12 +0200, wm4 wrote: > On Sat, 1 Apr 2017 10:01:15 +0200 > Nicolas George wrote: [...] > > Therefore, it was not acceptable as is and should not have been pushed. > > > > Pushing while leaving only half a day to answer this was UNACCEPTABLE. > > Do not ever do it again please. >

Re: [FFmpeg-devel] fate/exr : add test for exr with offsets set to zero

2017-04-01 Thread Michael Niedermayer
On Sat, Apr 01, 2017 at 09:29:53PM +0200, Martin Vignali wrote: > Hello, > > This patch can now be apply (the patch avcodec/exr detect invalid line > offset table and recreate table have been apply) will be in my next push thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611

Re: [FFmpeg-devel] [PATCH 2/3] avformat/oggparsedaala: Do not leave an invalid value in gpshift

2017-04-01 Thread Michael Niedermayer
On Sat, Apr 01, 2017 at 09:04:48PM +0100, Rostislav Pehlivanov wrote: > On 1 April 2017 at 18:18, Michael Niedermayer > wrote: > > > Fixes: undefined behavior > > Fixes: 702974 > > > > Found-by: Thomas Guilbert > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/oggparsedaala.c | 1

Re: [FFmpeg-devel] [PATCH 1/3] avformat/oggparsedaala: Check duration for AV_NOPTS_VALUE

2017-04-01 Thread Michael Niedermayer
On Sat, Apr 01, 2017 at 09:05:10PM +0100, Rostislav Pehlivanov wrote: > On 1 April 2017 at 18:18, Michael Niedermayer > wrote: > > > This avoids an integer overflow > > the solution matches oggparsevorbis.c and 45581ed15d2ad5955e24d809820c16 > > 75da68f500 > > > > Fixes: 700242 > > > > Found-by:

Re: [FFmpeg-devel] [PATCH 1/3] avformat/oggparsedaala: Check duration for AV_NOPTS_VALUE

2017-04-01 Thread Rostislav Pehlivanov
On 1 April 2017 at 18:18, Michael Niedermayer wrote: > This avoids an integer overflow > the solution matches oggparsevorbis.c and 45581ed15d2ad5955e24d809820c16 > 75da68f500 > > Fixes: 700242 > > Found-by: Thomas Guilbert > Signed-off-by: Michael Niedermayer > --- > libavformat/oggparsedaala.

Re: [FFmpeg-devel] [PATCH 2/3] avformat/oggparsedaala: Do not leave an invalid value in gpshift

2017-04-01 Thread Rostislav Pehlivanov
On 1 April 2017 at 18:18, Michael Niedermayer wrote: > Fixes: undefined behavior > Fixes: 702974 > > Found-by: Thomas Guilbert > Signed-off-by: Michael Niedermayer > --- > libavformat/oggparsedaala.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/oggparsedaala.c b/libavfo

Re: [FFmpeg-devel] fate/exr : add test for exr with offsets set to zero

2017-04-01 Thread Martin Vignali
Hello, This patch can now be apply (the patch avcodec/exr detect invalid line offset table and recreate table have been apply) Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter: add ANSNR filter

2017-04-01 Thread Moritz Barsnick
On Thu, Mar 30, 2017 at 23:06:36 +0200, Betty Wu wrote: > A new filter ANSNR is added. libavfilter/Makefile is changed. That line isn't really needed in a commit message (too obvious). > +/* > + * Copyright 2016-2017 Netflix, Inc. > + * Copyright (c) 2017 Betty Wu > + * > + * This file is part of

Re: [FFmpeg-devel] [RFC] FFmpeg 3.3

2017-04-01 Thread Marton Balint
On Fri, 31 Mar 2017, James Almer wrote: Now, regarding merges, we're like 10 commits away from the massive bitstream reader batch, which is more or less the only thing committed to libav for a whole week. So how about we re-cut from master (should be a matter of merging master into release/3.3,

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/clearvideo: Do not loose the return code of decode_mb()

2017-04-01 Thread Moritz Barsnick
On Thu, Mar 30, 2017 at 22:20:13 +0200, Nicolas George wrote: > To loose means to set free, as in "the Forsaken are loose". Actually no: "loose" is an adjective. The verb would be "to loosen" (e.g. a leash, a rope around your neck, ... ;-)). Nitpicking, Moritz

Re: [FFmpeg-devel] [PATCH 1/3] lavu: add support for Content Light Level side metadata

2017-04-01 Thread Moritz Barsnick
On Thu, Mar 30, 2017 at 16:31:47 +0200, Steve Lhomme wrote: > + * Content light level (based on CEA 861.3). This payload containts data > in ^ contains > + * Max avereage light level per picture (cd/m^2). ^ ave

Re: [FFmpeg-devel] [PATCH 2/2] Add http cookie tests cases to fate

2017-04-01 Thread Micah Galizia
On 2017-03-31 06:10 AM, Michael Niedermayer wrote: On Thu, Mar 30, 2017 at 09:33:48PM -0400, Micah Galizia wrote: Signed-off-by: Micah Galizia --- libavformat/Makefile | 1 + libavformat/tests/http.c | 182 + tests/fate/libavformat.mak

Re: [FFmpeg-devel] [PATCH v12] avformat/dashdec: add dash demuxer base version

2017-04-01 Thread Michael Niedermayer
On Sat, Apr 01, 2017 at 03:28:37PM +0200, wm4 wrote: > On Sat, 1 Apr 2017 15:20:22 +0200 > Nicolas George wrote: > > > Le duodi 12 germinal, an CCXXV, Steven Liu a écrit : > > > oops, sorry, the reviewer name add by the members who have reply mail, if > > > you don't like to review this patch, i

[FFmpeg-devel] [PATCH] codec_desc: mark some lossless audio codecs as intraonly.

2017-04-01 Thread Ronald S. Bultje
--- libavcodec/avcodec.h| 2 +- libavcodec/codec_desc.c | 11 ++- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 60f7ace..39ea4fc 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -724,7 +724,7 @@ typedef

[FFmpeg-devel] [PATCH 3/3] avformat/mov: Check creation_time for overflow

2017-04-01 Thread Michael Niedermayer
Fixes integer overflow Fixes: 701640 Found-by: Found-by: Thomas Guilbert Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index c9d076ee21..9c1c36c4be 100644 --- a/libavformat/mov.c +++ b/lib

[FFmpeg-devel] [PATCH 1/3] avformat/oggparsedaala: Check duration for AV_NOPTS_VALUE

2017-04-01 Thread Michael Niedermayer
This avoids an integer overflow the solution matches oggparsevorbis.c and 45581ed15d2ad5955e24d809820c1675da68f500 Fixes: 700242 Found-by: Thomas Guilbert Signed-off-by: Michael Niedermayer --- libavformat/oggparsedaala.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib

[FFmpeg-devel] [PATCH 2/3] avformat/oggparsedaala: Do not leave an invalid value in gpshift

2017-04-01 Thread Michael Niedermayer
Fixes: undefined behavior Fixes: 702974 Found-by: Thomas Guilbert Signed-off-by: Michael Niedermayer --- libavformat/oggparsedaala.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/oggparsedaala.c b/libavformat/oggparsedaala.c index ce65b2bd7a..a373b41b4c 100644 --- a/libavforma

Re: [FFmpeg-devel] [PATCH] codec_desc: mark some lossless audio codecs as intraonly.

2017-04-01 Thread Paul B Mahol
On 3/31/17, Ronald S. Bultje wrote: > --- > libavcodec/codec_desc.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > Should be fine if you mark flag as video and audio only. Currently this intra only flag is marked as video only. _

[FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-04-01 Thread Thomas Mundt
>>>Thomas Mundt schrieb am Fr, 24.3.2017: > Hi, > > > attached patch will fix ticket #2674. > Tested with examples from ticket 2674 and other files at various frame rates. > > v2: Use av_frame_get_pkt_duration to calculate count of duplication of last > frame. > Use average of the earlier pts ste

Re: [FFmpeg-devel] [PATCH] Add MediaFoundation wrapper

2017-04-01 Thread wm4
On Sat, 1 Apr 2017 12:13:45 -0300 James Almer wrote: > On 4/1/2017 8:28 AM, wm4 wrote: > > Can do audio decoding, audio encoding, video decoding, video encoding, > > video HW encoding. I also had video HW decoding, but removed it for now, > > as thw hwframes integration wasn't very sane. > > > >

Re: [FFmpeg-devel] [PATCH] Add MediaFoundation wrapper

2017-04-01 Thread James Almer
On 4/1/2017 8:28 AM, wm4 wrote: > Can do audio decoding, audio encoding, video decoding, video encoding, > video HW encoding. I also had video HW decoding, but removed it for now, > as thw hwframes integration wasn't very sane. > > Some of the MS codecs aren't well tested, and might not work prope

Re: [FFmpeg-devel] [PATCH]configure: Fix decklink license dependency

2017-04-01 Thread Ricardo Constantino
On 1 April 2017 at 14:03, Hendrik Leppkes wrote: > > This is the Boost Software license, very similar to BSD/MIT, so if > that license is all that matters, its obviously fine. > > Just downloaded the latest 10.8.5 SDK and checked every file inside "Blackmagic DeckLink SDK 10.8.5\Win\include". All

Re: [FFmpeg-devel] [PATCH v12] avformat/dashdec: add dash demuxer base version

2017-04-01 Thread wm4
On Sat, 1 Apr 2017 15:20:22 +0200 Nicolas George wrote: > Le duodi 12 germinal, an CCXXV, Steven Liu a écrit : > > oops, sorry, the reviewer name add by the members who have reply mail, if > > you don't like to review this patch, i will remove your reviewed-by, sorry. > > > > I intend to revi

Re: [FFmpeg-devel] [PATCH v12] avformat/dashdec: add dash demuxer base version

2017-04-01 Thread Nicolas George
Le duodi 12 germinal, an CCXXV, Steven Liu a écrit : > oops, sorry, the reviewer name add by the members who have reply mail, if > you don't like to review this patch, i will remove your reviewed-by, sorry. I intend to review this patch as much as my time permits before it moves forward. My name c

Re: [FFmpeg-devel] [PATCH v12] avformat/dashdec: add dash demuxer base version

2017-04-01 Thread Steven Liu
2017-04-01 21:07 GMT+08:00 Nicolas George : > Le duodi 12 germinal, an CCXXV, Steven Liu a écrit : > > v2 fixed: > > > > All this does not belong in the commit message but in the mail comments, > i.e. below the first triple-dash line. > > > Reviewed-by: Nicolas George > > I do not believe I have

Re: [FFmpeg-devel] [PATCH]configure: Fix decklink license dependency

2017-04-01 Thread Hendrik Leppkes
On Sat, Apr 1, 2017 at 2:18 PM, Ricardo Constantino wrote: > On 1 April 2017 at 00:20, Carl Eugen Hoyos wrote: > >> Hi! >> >> To the best of my knowledge, decklink is a non-free dependency. >> >> Please comment, Carl Eugen >> >> ___ >> ffmpeg-devel mail

Re: [FFmpeg-devel] [PATCH v12] avformat/dashdec: add dash demuxer base version

2017-04-01 Thread Nicolas George
Le duodi 12 germinal, an CCXXV, Steven Liu a écrit : > v2 fixed: All this does not belong in the commit message but in the mail comments, i.e. below the first triple-dash line. > Reviewed-by: Nicolas George I do not believe I have actually reviewed the patch yet. Regards, -- Nicolas Geor

[FFmpeg-devel] [PATCH v12] avformat/dashdec: add dash demuxer base version

2017-04-01 Thread Steven Liu
ffmpeg need a dash demuxer for demux the dash formats base on https://github.com/samsamsam-iptvplayer/exteplayer3/blob/master/tmp/ffmpeg/patches/3.2.2/01_add_dash_demux.patch v2 fixed: 1. from autodetect to disabled 2. from camelCase code style to ffmpeg code style 3. from RepType to AVMediaTy

Re: [FFmpeg-devel] [PATCH] frame_thread_encoder: make task indexing deterministic.

2017-04-01 Thread Ronald S. Bultje
Hi, On Sat, Apr 1, 2017 at 6:15 AM, Michael Niedermayer wrote: [.] > > about the patch itself, the changes done to indexing seem not to > change anything, it makes it possible for the variables to overflow > though. > That's intentional, they're both unsigned and the one is guaranteed to be larg

Re: [FFmpeg-devel] [PATCH]configure: Fix decklink license dependency

2017-04-01 Thread Ricardo Constantino
On 1 April 2017 at 00:20, Carl Eugen Hoyos wrote: > Hi! > > To the best of my knowledge, decklink is a non-free dependency. > > Please comment, Carl Eugen > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo

Re: [FFmpeg-devel] [PATCH] Add MediaFoundation wrapper

2017-04-01 Thread Paul B Mahol
On 4/1/17, wm4 wrote: > Can do audio decoding, audio encoding, video decoding, video encoding, > video HW encoding. I also had video HW decoding, but removed it for now, > as thw hwframes integration wasn't very sane. > > Some of the MS codecs aren't well tested, and might not work properly. > ---

[FFmpeg-devel] [PATCH] Add MediaFoundation wrapper

2017-04-01 Thread wm4
Can do audio decoding, audio encoding, video decoding, video encoding, video HW encoding. I also had video HW decoding, but removed it for now, as thw hwframes integration wasn't very sane. Some of the MS codecs aren't well tested, and might not work properly. --- configure | 34 +

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-04-01 Thread wm4
On Sat, 1 Apr 2017 10:01:15 +0200 Nicolas George wrote: > Le primidi 11 germinal, an CCXXV, Steven Liu a écrit : > > I think just similar, not duplicating, and the simple functionality use > > BPrint maybe too complex. > > Well, I will say it unambiguously: > > Parts of this patch DO duplicat

Re: [FFmpeg-devel] [PATCH] dsddec: correct for DSD silence bit-ordering

2017-04-01 Thread Michael Niedermayer
On Fri, Mar 31, 2017 at 07:32:41PM +0200, Paul B Mahol wrote: > On 3/31/17, Takayuki 'January June' Suwa wrote: > > --- > > libavcodec/dsddec.c | 17 ++--- > > 1 file changed, 10 insertions(+), 7 deletions(-) > > > > diff --git a/libavcodec/dsddec.c b/libavcodec/dsddec.c > > index 880

Re: [FFmpeg-devel] [PATCH] frame_thread_encoder: make task indexing deterministic.

2017-04-01 Thread Michael Niedermayer
On Fri, Mar 31, 2017 at 10:20:43AM -0400, Ronald S. Bultje wrote: > Fixes tsan warnings in fate-utvideoenc. Example warning from > utvideoenc_rgb_left: > > WARNING: ThreadSanitizer: data race (pid=19929) > Read of size 8 at 0x7d840001cf18 by main thread: > #0 ff_thread_video_encode_frame src

[FFmpeg-devel] [PATCH] avcodec/dnxhdenc: DNxHR 444 and HQX support

2017-04-01 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/dnxhdenc.c | 280 ++ libavcodec/dnxhdenc.h | 6 +- 2 files changed, 216 insertions(+), 70 deletions(-) diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c index 33f25fb..fe420e5 100644 --- a/libav

Re: [FFmpeg-devel] [PATCH]configure: Fix GPL dependency of avisynth / avxsynth

2017-04-01 Thread Carl Eugen Hoyos
2017-04-01 3:51 GMT+02:00 Stephen Hutchinson : > On 3/31/2017 7:11 PM, Carl Eugen Hoyos wrote: >> >> Hi! >> >> Attached patch fixes the license requirement for --enable-avisynth. >> > > LGTM. Patch applied. > I'd presume this is because of the weirdly worded exception language > in the Av[i|x]Syn

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-04-01 Thread Steven Liu
2017-04-01 16:01 GMT+08:00 Nicolas George : > Le primidi 11 germinal, an CCXXV, Steven Liu a écrit : > > I think just similar, not duplicating, and the simple functionality use > > BPrint maybe too complex. > > Well, I will say it unambiguously: > > Parts of this patch DO duplicate logic that we a

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-04-01 Thread Nicolas George
Le primidi 11 germinal, an CCXXV, Steven Liu a écrit : > I think just similar, not duplicating, and the simple functionality use > BPrint maybe too complex. Well, I will say it unambiguously: Parts of this patch DO duplicate logic that we already have, and your statement about BPrint being too co