Re: [FFmpeg-devel] [PATCH] doc: clarify development rules

2017-02-25 Thread Hendrik Leppkes
On Sat, Feb 25, 2017 at 11:47 PM, Rostislav Pehlivanov wrote: >> >> This is the way it has been done for years and its the way the project has >>> been able to move as rapidly as it has. That would slow down anything >>> large >>> from being developed in the codebase, like encoders or decoders for

Re: [FFmpeg-devel] [PATCH] doc: clarify development rules

2017-02-25 Thread Rostislav Pehlivanov
On 25 February 2017 at 20:23, Marton Balint wrote: > > On Sat, 25 Feb 2017, Rostislav Pehlivanov wrote: > > On 25 February 2017 at 18:35, Marton Balint wrote: >> >> >>> On Sat, 25 Feb 2017, wm4 wrote: >>> >>> I'm documenting existing practice. >>> I'm pulling the "6 months" timeout out

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/flacdsp: Fix: runtime error: signed integer overflow: -1027555328 + -1226681270 cannot be represented in type 'int'

2017-02-25 Thread Michael Niedermayer
On Sat, Feb 25, 2017 at 10:00:36PM +0100, Paul B Mahol wrote: > On 2/25/17, Michael Niedermayer wrote: > > Fixes: 673/clusterfuzz-testcase-5948736536576000 > > > > Found-by: continuous fuzzing process > > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > > Signed-off-by: Michael Nied

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/ituh263dec: Check for the bitstream end in ff_h263_decode_mb()

2017-02-25 Thread Michael Niedermayer
On Sat, Feb 25, 2017 at 10:03:58PM +0100, Paul B Mahol wrote: > On 2/25/17, Michael Niedermayer wrote: > > Fixes invalid shift > > > > Fixes: 670/clusterfuzz-testcase-4852021066727424 > > > > Found-by: continuous fuzzing process > > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > >

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/ituh263dec: Check for the bitstream end in ff_h263_decode_mb()

2017-02-25 Thread Paul B Mahol
On 2/25/17, Michael Niedermayer wrote: > Fixes invalid shift > > Fixes: 670/clusterfuzz-testcase-4852021066727424 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/ituh263dec.c | 3 +++

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/eac3dec: Fix runtime error: left shift of negative value -3

2017-02-25 Thread Paul B Mahol
On 2/25/17, Michael Niedermayer wrote: > Fixes: 672/clusterfuzz-testcase-5595018867769344 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/eac3dec.c | 2 +- > 1 file changed, 1 inserti

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/mpeg12dec: Fix runtime error: left shift of negative value -2

2017-02-25 Thread Paul B Mahol
On 2/25/17, Michael Niedermayer wrote: > 671/clusterfuzz-testcase-4990381827555328 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg12dec.c | 4 ++-- > 1 file changed, 2 insertions

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/flacdsp: Fix: runtime error: signed integer overflow: -1027555328 + -1226681270 cannot be represented in type 'int'

2017-02-25 Thread Paul B Mahol
On 2/25/17, Michael Niedermayer wrote: > Fixes: 673/clusterfuzz-testcase-5948736536576000 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/flacdsp.c | 2 +- > 1 file changed, 1 inserti

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/wavpack: Check post_shift

2017-02-25 Thread Michael Niedermayer
On Thu, Feb 23, 2017 at 03:19:29PM +0100, Michael Niedermayer wrote: > Fixes: runtime error: shift exponent 34 is too large for 32-bit type 'int' > > Fixes: 653/clusterfuzz-testcase-5773837415219200 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/wavpack.c | 3 +++ > 1 file changed, 3

Re: [FFmpeg-devel] [PATCH] doc: clarify development rules

2017-02-25 Thread Lou Logan
On Sat, Feb 25, 2017, at 11:23 AM, Marton Balint wrote: > > I only want to have a chance to review before patches got pushed. I am > not > saying we should explicitly demand a review for each patch. So this > normally should only cause any developer an additional sent email to the > ML and 1-2 d

Re: [FFmpeg-devel] [PATCH 1/2] Re: deduplicated [PATCH] Cinepak: speed up decoding several-fold, depending on the scenario, by supporting multiple output pixel formats.

2017-02-25 Thread Paul B Mahol
On 2/25/17, u-9...@aetey.se wrote: > Hello, > > Here comes the latest version of the patch, with adjustments > made according to all substantial feedback comments. > > Among others the code has been further deduplicated to ease maintenance. > > Hopefully the 2-4 times improvement of the decoding s

Re: [FFmpeg-devel] [PATCH] doc: clarify development rules

2017-02-25 Thread Marton Balint
On Sat, 25 Feb 2017, Rostislav Pehlivanov wrote: On 25 February 2017 at 18:35, Marton Balint wrote: On Sat, 25 Feb 2017, wm4 wrote: I'm documenting existing practice. I'm pulling the "6 months" timeout out of my ass, but I think it's pretty suitable. --- [...] This is the way it has

[FFmpeg-devel] [PATCH 1/2] Re: deduplicated [PATCH] Cinepak: speed up decoding several-fold, depending on the scenario, by supporting multiple output pixel formats.

2017-02-25 Thread u-9iep
Hello, Here comes the latest version of the patch, with adjustments made according to all substantial feedback comments. Among others the code has been further deduplicated to ease maintenance. Hopefully the 2-4 times improvement of the decoding speed justifies the growth of the affected source

[FFmpeg-devel] [PATCH 3/5] avcodec/mpeg12dec: Fix runtime error: left shift of negative value -2

2017-02-25 Thread Michael Niedermayer
671/clusterfuzz-testcase-4990381827555328 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mpeg12dec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpeg12dec

[FFmpeg-devel] [PATCH 1/5] avcodec/vp56: Factorize vp56_render_mb() out

2017-02-25 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/vp56.c | 77 +-- 1 file changed, 23 insertions(+), 54 deletions(-) diff --git a/libavcodec/vp56.c b/libavcodec/vp56.c index b36c99fd33..a9a1a0c1d5 100644 --- a/libavcodec/vp56.c +++ b/libavcodec

[FFmpeg-devel] [PATCH 4/5] avcodec/eac3dec: Fix runtime error: left shift of negative value -3

2017-02-25 Thread Michael Niedermayer
Fixes: 672/clusterfuzz-testcase-5595018867769344 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/eac3dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/eac3dec.

[FFmpeg-devel] [PATCH 2/5] avcodec/ituh263dec: Check for the bitstream end in ff_h263_decode_mb()

2017-02-25 Thread Michael Niedermayer
Fixes invalid shift Fixes: 670/clusterfuzz-testcase-4852021066727424 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/ituh263dec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcod

[FFmpeg-devel] [PATCH 5/5] avcodec/flacdsp: Fix: runtime error: signed integer overflow: -1027555328 + -1226681270 cannot be represented in type 'int'

2017-02-25 Thread Michael Niedermayer
Fixes: 673/clusterfuzz-testcase-5948736536576000 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/flacdsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/flacdsp.

[FFmpeg-devel] [PATCH 2/2] Re: deduplicated [PATCH] Cinepak: speed up decoding several-fold, depending on the scenario, by supporting multiple output pixel formats.

2017-02-25 Thread u-9iep
Support for conditional compilation, a simple non-intrusive means to avoid binary bloat when this is relevant. OTOH this change adds some extra lines to the source, which may be acceptable or not. Regards, Rune >From 11b5906e5161748b77bbad242ac28a49851c8b4f Mon Sep 17 00:00:00 2001 From: Rl Date

Re: [FFmpeg-devel] [PATCH] avcodec: add ClearVideo decoder

2017-02-25 Thread Paul B Mahol
On 2/25/17, James Almer wrote: > On 2/25/2017 1:22 PM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> Only I-frames for now. >> --- >> doc/general.texi| 1 + >> libavcodec/Makefile | 1 + >> libavcodec/allcodecs.c | 1 + >> libavcodec/avcodec.h| 1 + >> lib

Re: [FFmpeg-devel] [PATCH] avcodec: add ClearVideo decoder

2017-02-25 Thread James Almer
On 2/25/2017 1:22 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > Only I-frames for now. > --- > doc/general.texi| 1 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/clearvideo.c | 388 > +

Re: [FFmpeg-devel] [PATCH] doc: clarify development rules

2017-02-25 Thread Rostislav Pehlivanov
On 25 February 2017 at 18:35, Marton Balint wrote: > > On Sat, 25 Feb 2017, wm4 wrote: > > I'm documenting existing practice. >> >> I'm pulling the "6 months" timeout out of my ass, but I think it's >> pretty suitable. >> --- >> doc/developer.texi | 10 +- >> 1 file changed, 9 insertions(+

[FFmpeg-devel] [PATCHv2 2/4] avdevice/decklink_enc: add support to specify field order

2017-02-25 Thread Marton Balint
Changes: handle AV_FIELD_TB and AV_FIELD_BT as well. Signed-off-by: Marton Balint --- doc/outdevs.texi| 4 ++-- libavdevice/decklink_common.cpp | 29 +++-- libavdevice/decklink_common.h | 2 +- libavdevice/decklink_enc.cpp| 4 ++-- libavdevice/ver

Re: [FFmpeg-devel] [PATCH 2/4] avdevice/decklink_enc: add support to specify field order

2017-02-25 Thread Marton Balint
On Fri, 24 Feb 2017, Matthias Hunstock wrote: Am 24.02.2017 um 00:32 schrieb Marton Balint: On Thu, 23 Feb 2017, Matthias Hunstock wrote: Am 23.02.2017 um 17:24 schrieb Marton Balint: The "@mode" syntax does not work for output devices. Let me add a patch, I will send it tonight. Please

Re: [FFmpeg-devel] [PATCH] doc: clarify development rules

2017-02-25 Thread Marton Balint
On Sat, 25 Feb 2017, wm4 wrote: I'm documenting existing practice. I'm pulling the "6 months" timeout out of my ass, but I think it's pretty suitable. --- doc/developer.texi | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/developer.texi b/doc/developer.texi ind

Re: [FFmpeg-devel] [PATCH] doc: clarify development rules

2017-02-25 Thread Rostislav Pehlivanov
On 25 February 2017 at 14:59, wm4 wrote: > I'm documenting existing practice. > > I'm pulling the "6 months" timeout out of my ass, but I think it's > pretty suitable. > --- > doc/developer.texi | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/doc/developer.texi

[FFmpeg-devel] [PATCH] avcodec: add ClearVideo decoder

2017-02-25 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- Only I-frames for now. --- doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/clearvideo.c | 388 libavcodec/codec_desc.c |

Re: [FFmpeg-devel] [PATCH] doc: clarify development rules

2017-02-25 Thread wm4
On Sat, 25 Feb 2017 17:03:58 +0200 Ivan Kalvachev wrote: > On 2/25/17, wm4 wrote: > > I'm documenting existing practice. > > > > I'm pulling the "6 months" timeout out of my ass, but I think it's > > pretty suitable. > > --- > > doc/developer.texi | 10 +- > > 1 file changed, 9 insertio

Re: [FFmpeg-devel] [PATCH] doc: clarify development rules

2017-02-25 Thread Ivan Kalvachev
On 2/25/17, wm4 wrote: > I'm documenting existing practice. > > I'm pulling the "6 months" timeout out of my ass, but I think it's > pretty suitable. > --- > doc/developer.texi | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/doc/developer.texi b/doc/developer.te

[FFmpeg-devel] [PATCH] doc: clarify development rules

2017-02-25 Thread wm4
I'm documenting existing practice. I'm pulling the "6 months" timeout out of my ass, but I think it's pretty suitable. --- doc/developer.texi | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/developer.texi b/doc/developer.texi index dbe1f5421f..41551498ad 100644 -