[FFmpeg-devel] [PATCH] lavc/vda_h264_dec.c Fix NULL pointer dereference

2017-02-09 Thread pkoshevoy
From: Pavel Koshevoy ps.sps_list entries may be NULL, so check before dereferencing --- libavcodec/vda_h264_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vda_h264_dec.c b/libavcodec/vda_h264_dec.c index 92839e2..972bd6b 100644 --- a/libavcodec/vda_h264_dec.

Re: [FFmpeg-devel] [PATCH 3/4] aacsbr: Associate SBR data with AAC elements on init

2017-02-09 Thread Carl Eugen Hoyos
2017-02-09 18:40 GMT+01:00 Alex Converse : > Quiets some log spam on pure upsampling mode. Please mention ticket #5163. For the whole patchset, I suggest you push as soon as everybody agrees on the function prefixes. Could you review my patch for ticket #1614? https://ffmpeg.org/pipermail/ffmpeg

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Avoid heap allocation wraps and OOB in mov_read_{senc, saiz, udta_string}()

2017-02-09 Thread Matthew Wolenetz
I've separated and updated the mov_read_{senc,saiz}() patch, attached. It avoids allocation wraps in those two functions. On Wed, Feb 8, 2017 at 3:48 PM, Matthew Wolenetz wrote: > I've separated and updated the mov_read_udta_string() patch, attached. > It prevents accessing MOVContext.meta_keys[

Re: [FFmpeg-devel] [PATCH 1/4] aac_latm: Allow unaligned AudioSpecificConfig

2017-02-09 Thread James Almer
On 2/9/2017 2:40 PM, Alex Converse wrote: > diff --git a/libavcodec/mpeg4audio.c b/libavcodec/mpeg4audio.c > index 5f85b64cb8..9fe257838c 100644 > --- a/libavcodec/mpeg4audio.c > +++ b/libavcodec/mpeg4audio.c > @@ -83,70 +83,62 @@ static inline int get_sample_rate(GetBitContext *gb, int > *index)

Re: [FFmpeg-devel] [PATCH] Implement optimal huffman encoding for (M)JPEG.

2017-02-09 Thread Michael Niedermayer
On Thu, Feb 09, 2017 at 01:20:09PM +0100, Michael Niedermayer wrote: [...] > > int ff_mjpeg_encode_stuffing(MpegEncContext *s) > > { > > int i; > > PutBitContext *pbc = &s->pb; > > int mb_y = s->mb_y - !s->mb_x; > >+int ret; > >+MJpegContext *m; > >+ > >+m = s->mjpeg_ctx; >

Re: [FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v3]

2017-02-09 Thread Mark Thompson
On 09/02/17 20:54, Mark Thompson wrote: > On 08/02/17 19:21, Takayuki 'January June' Suwa wrote: >> From: Takayuki 'January June' Suwa >> >> This adds "-profile[:v] profile_name"-style option IOW. >> >> Now default/unknown profile means FF_PROFILE_H264_HIGH strictly, for both >> better coding sty

[FFmpeg-devel] [PATCH] rtpdec: fix negative missed packet count

2017-02-09 Thread Stepan Salenikovich
Account for the RTP seq num restarting after 65535 when logging the number of missed RTP packets. Change-Id: I3510c2dfb830614e25f7b93de9b3b10aa724d00c --- libavformat/rtpdec.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavformat/rtpdec.c b/libavformat/rtpdec.

Re: [FFmpeg-devel] GSoC 2017

2017-02-09 Thread Ronald S. Bultje
Hi Pedro, On Thu, Feb 9, 2017 at 3:10 PM, Pedro Arthur wrote: > 2017-02-09 17:01 GMT-02:00 Ronald S. Bultje : > > > Before we get into adding new things to swscale: I will veto anything > that > > doesn't use the provided API in libavutil. So no new SWS_CS_*. > > > > Maybe is there something tha

Re: [FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v3]

2017-02-09 Thread Mark Thompson
On 08/02/17 19:21, Takayuki 'January June' Suwa wrote: > From: Takayuki 'January June' Suwa > > This adds "-profile[:v] profile_name"-style option IOW. > > Now default/unknown profile means FF_PROFILE_H264_HIGH strictly, for both > better coding style and preserving the original behavior. > ---

Re: [FFmpeg-devel] [PATCH] cuvid: Always calculate second field PTS from frame rate

2017-02-09 Thread Miroslav Slugeň
Dne 9.2.2017 v 07:49 wm4 napsal(a): On Wed, 8 Feb 2017 23:31:54 +0100 Miroslav Slugeň wrote: It is much more robust solution to always calculate second field (when deinterlacing) PTS from frame rate, then relating on previous PTS, because if there are B frames in input and some video frames ar

Re: [FFmpeg-devel] [PATCH] cuvid: Always calculate second field PTS from frame rate

2017-02-09 Thread Miroslav Slugeň
Dne 8.2.2017 v 23:59 Carl Eugen Hoyos napsal(a): 2017-02-08 23:31 GMT+01:00 Miroslav Slugeň : It is much more robust solution to always calculate second field (when deinterlacing) PTS from frame rate Without looking at your patch, I would have guessed that not every stream has a useful frame ra

Re: [FFmpeg-devel] GSoC 2017

2017-02-09 Thread Pedro Arthur
2017-02-09 17:01 GMT-02:00 Ronald S. Bultje : > Before we get into adding new things to swscale: I will veto anything that > doesn't use the provided API in libavutil. So no new SWS_CS_*. > > Maybe is there something that doesn't use libavutil in swscale that can be turned in a qualification task?

Re: [FFmpeg-devel] GSoC 2017

2017-02-09 Thread wm4
On Thu, 9 Feb 2017 14:01:59 -0500 "Ronald S. Bultje" wrote: > Hi, > > On Wed, Feb 8, 2017 at 8:21 PM, Michael Niedermayer > wrote: > > > On Thu, Feb 09, 2017 at 01:03:06AM +0100, Michael Niedermayer wrote: > > > On Wed, Feb 08, 2017 at 09:07:09PM -0200, Pedro Arthur wrote: > > > > 2017-01-

Re: [FFmpeg-devel] GSoC 2017

2017-02-09 Thread Ronald S. Bultje
Hi, On Wed, Feb 8, 2017 at 8:21 PM, Michael Niedermayer wrote: > On Thu, Feb 09, 2017 at 01:03:06AM +0100, Michael Niedermayer wrote: > > On Wed, Feb 08, 2017 at 09:07:09PM -0200, Pedro Arthur wrote: > > > 2017-01-27 1:01 GMT-02:00 Michael Niedermayer : > > > > > > > we need more (backup) mentor

[FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v3]

2017-02-09 Thread Takayuki 'January June' Suwa
From: Takayuki 'January June' Suwa This adds "-profile[:v] profile_name"-style option IOW. Now default/unknown profile means FF_PROFILE_H264_HIGH strictly, for both better coding style and preserving the original behavior. --- libavcodec/omx.c | 20 1 file changed, 20 inse

Re: [FFmpeg-devel] [community vote] add devs to -security alias

2017-02-09 Thread Compn
nevermind , bad idea. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [community vote] add devs to -security alias

2017-02-09 Thread Michael Niedermayer
On Thu, Feb 09, 2017 at 12:50:48PM -0500, Compn wrote: > as stated , this is a community issue, so heres the vote thread. > > vote to add kieran and wm4 to ffmpeg-security email alias. > > any votes for or against? > votes will be tallied in 2 weeks. active committers/contributors will be > count

[FFmpeg-devel] [PATCH 2/4] aac_latm: Copy whole AudioSpecificConfig when it is sized.

2017-02-09 Thread Alex Converse
This preserves sync extensions. --- libavcodec/aacdec.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index 709ac7cdf8..08d92fe145 100644 --- a/libavcodec/aacdec.c +++ b/libavcodec/aacdec.c @@ -289,17 +28

[FFmpeg-devel] [community vote] add devs to -security alias

2017-02-09 Thread Compn
as stated , this is a community issue, so heres the vote thread. vote to add kieran and wm4 to ffmpeg-security email alias. any votes for or against? votes will be tallied in 2 weeks. active committers/contributors will be counted. if you have ideas for how the -security should be handled, make

[FFmpeg-devel] [PATCH 4/4] aac_latm: Align inband PCE to the start of the payload

2017-02-09 Thread Alex Converse
A strict reading of the spec seems to imply that it should be aligned to the start of the element instance tag, but that would break all of the samples with PCEs. It seems like a well formed LATM stream should have its PCE in the ASC rather than inband. Fixes ticket 4544 --- libavcodec/aacdec_te

[FFmpeg-devel] [PATCH 1/4] aac_latm: Allow unaligned AudioSpecificConfig

2017-02-09 Thread Alex Converse
Fixes ticket 4730 --- libavcodec/aacdec.c | 26 -- libavcodec/aacdec_template.c | 82 libavcodec/mpeg4audio.c | 76 ++-- libavcodec/mpeg4audio.h | 12 ++- 4 files changed, 120 insert

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/huffyuvencdsp: use an actual unsigned long constant

2017-02-09 Thread Michael Niedermayer
On Wed, Feb 08, 2017 at 01:13:57PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/huffyuvencdsp.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Asymptotically

[FFmpeg-devel] [PATCH 3/4] aacsbr: Associate SBR data with AAC elements on init

2017-02-09 Thread Alex Converse
Quiets some log spam on pure upsampling mode. --- libavcodec/aacdec_template.c | 2 +- libavcodec/aacsbr.h | 2 +- libavcodec/aacsbr_template.c | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c index 2a06f82

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/huffyuvdsp: use an actual unsigned long constant

2017-02-09 Thread Michael Niedermayer
On Wed, Feb 08, 2017 at 01:13:56PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > Decent compilers are smart enough to truncate those ULL constants on targets > where long is 32 bits (and do things like shift+and/add instead of mul). > This is for those that are not. > > libavcod

Re: [FFmpeg-devel] [rfc] ffmpeg security issue mailing list

2017-02-09 Thread Kieran Kunhya
> > > > > > > I dont think we should give access to ffmpeg-security to everyone who > > > wants to be on the list. This is of course something the community > > > has to decide and not me, iam just err-ing on the safe side and am very > > > restrictive on who is added. > > > > > > > This is a bogus

Re: [FFmpeg-devel] new videofilters and parellelization

2017-02-09 Thread Thilo Borgmann
Am 09.02.17 um 16:01 schrieb Daniel Oberhoff: > [...] > we would like to contribute this back to ffmpeg as it may be useful > for others. do you think so to? if so, should we send one big patch > or split it up somehow? Yes. Try to conform to our developer documentation at http://ffmpeg.org/dev

[FFmpeg-devel] [PATCH 1/2] dashenc: properly determine bandwidth

2017-02-09 Thread s-ol
based on ligverds patch from https://ffmpeg.org/pipermail/ffmpeg-devel/2016-September/199183.html --- libavformat/dashenc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 534fa75..18c39c5 100644 --- a/libavformat/d

[FFmpeg-devel] [PATCH 2/2] dashenc: add profile_identifier option

2017-02-09 Thread s-ol
sets the MPEG-DASH profile identifier in the header (for example for specifying on-demand vs default live profile) Signed-off-by: Sol Bekic --- libavformat/dashenc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 18c3

Re: [FFmpeg-devel] [rfc] ffmpeg security issue mailing list

2017-02-09 Thread James Almer
On 2/9/2017 10:24 AM, Kieran Kunhya wrote: >> >> I dont think we should give access to ffmpeg-security to everyone who >> wants to be on the list. This is of course something the community >> has to decide and not me, iam just err-ing on the safe side and am very >> restrictive on who is added. >>

Re: [FFmpeg-devel] [rfc] ffmpeg security issue mailing list

2017-02-09 Thread Michael Niedermayer
On Thu, Feb 09, 2017 at 03:29:40PM +0100, Paul B Mahol wrote: > On 2/9/17, Michael Niedermayer wrote: > > On Thu, Feb 09, 2017 at 08:25:43AM +0100, wm4 wrote: > >> On Wed, 8 Feb 2017 22:07:24 +0100 > >> Michael Niedermayer wrote: > >> > >> > Hi all > >> > > >> > On Sat, Aug 08, 2015 at 03:51:11AM

[FFmpeg-devel] new videofilters and parellelization

2017-02-09 Thread Daniel Oberhoff
Hello all, We do some performance critical processing with ffmpeg involving image scaling and warping. To support this we did implemented some new algorithms and parallelized one. 1. parallelize remap 2. implement remap_frac that interprets data as 13.3 fixed point (i.e. 3 bits for subpixel wa

Re: [FFmpeg-devel] [rfc] ffmpeg security issue mailing list

2017-02-09 Thread Michael Niedermayer
On Thu, Feb 09, 2017 at 09:07:39AM -0500, Compn wrote: > On Thu, 09 Feb 2017 13:24:53 +, Kieran Kunhya > wrote: > > > > > > > I dont think we should give access to ffmpeg-security to everyone who > > > wants to be on the list. This is of course something the community > > > has to decide and

Re: [FFmpeg-devel] [rfc] ffmpeg security issue mailing list

2017-02-09 Thread wm4
On Thu, 9 Feb 2017 15:27:03 +0100 Michael Niedermayer wrote: > On Thu, Feb 09, 2017 at 08:25:43AM +0100, wm4 wrote: > > On Wed, 8 Feb 2017 22:07:24 +0100 > > Michael Niedermayer wrote: > > > > > Hi all > > > > > > On Sat, Aug 08, 2015 at 03:51:11AM +0200, Michael Niedermayer wrote: > > > >

Re: [FFmpeg-devel] [rfc] ffmpeg security issue mailing list

2017-02-09 Thread Paul B Mahol
On 2/9/17, Michael Niedermayer wrote: > On Thu, Feb 09, 2017 at 08:25:43AM +0100, wm4 wrote: >> On Wed, 8 Feb 2017 22:07:24 +0100 >> Michael Niedermayer wrote: >> >> > Hi all >> > >> > On Sat, Aug 08, 2015 at 03:51:11AM +0200, Michael Niedermayer wrote: >> > > On Fri, Aug 07, 2015 at 07:46:55PM -

Re: [FFmpeg-devel] [rfc] ffmpeg security issue mailing list

2017-02-09 Thread Michael Niedermayer
On Thu, Feb 09, 2017 at 08:25:43AM +0100, wm4 wrote: > On Wed, 8 Feb 2017 22:07:24 +0100 > Michael Niedermayer wrote: > > > Hi all > > > > On Sat, Aug 08, 2015 at 03:51:11AM +0200, Michael Niedermayer wrote: > > > On Fri, Aug 07, 2015 at 07:46:55PM -0400, compn wrote: > > > > hello, > > > > >

Re: [FFmpeg-devel] [rfc] ffmpeg security issue mailing list

2017-02-09 Thread Compn
On Thu, 09 Feb 2017 13:24:53 +, Kieran Kunhya wrote: > > > > I dont think we should give access to ffmpeg-security to everyone who > > wants to be on the list. This is of course something the community > > has to decide and not me, iam just err-ing on the safe side and am very > > restrictive

Re: [FFmpeg-devel] [rfc] ffmpeg security issue mailing list

2017-02-09 Thread Kieran Kunhya
> > I dont think we should give access to ffmpeg-security to everyone who > wants to be on the list. This is of course something the community > has to decide and not me, iam just err-ing on the safe side and am very > restrictive on who is added. > This is a bogus argument considering how many pe

Re: [FFmpeg-devel] [PATCH] Implement optimal huffman encoding for (M)JPEG.

2017-02-09 Thread Michael Niedermayer
On Thu, Feb 09, 2017 at 03:44:59AM +0100, Michael Niedermayer wrote: > On Wed, Feb 01, 2017 at 11:23:04PM -0800, Jerry Jiang wrote: [...] > i sadly dont have time to do a more complete review ATM (need sleep) > but this patch doesnt look like it was ready for being pushed more reviewing related to

[FFmpeg-devel] [PATCH v3] avformat/hlsenc: deprecate hls_wrap option

2017-02-09 Thread Steven Liu
When user use the hls_wrap, there have many problem: 1. some platform refersh the old but usefull segment 2. CDN(Content Delivery Network) Deliver HLS not friendly The hls_wrap is used to wrap segments for use little space, now user can use hls_list_size and hls_flags delete_segments instead it.

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: deprecate hls_wrap option

2017-02-09 Thread Steven Liu
2017-02-09 18:53 GMT+08:00 Carl Eugen Hoyos : > 2017-02-09 11:52 GMT+01:00 Steven Liu : > > 2017-02-09 18:46 GMT+08:00 Carl Eugen Hoyos : > > > >> 2017-02-09 8:58 GMT+01:00 Steven Liu : > >> > >> > +#if FF_API_HLS_WRAP > >> > {"hls_wrap", "set number after which the index wraps", > >> OF

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: deprecate hls_wrap option

2017-02-09 Thread Carl Eugen Hoyos
2017-02-09 11:52 GMT+01:00 Steven Liu : > 2017-02-09 18:46 GMT+08:00 Carl Eugen Hoyos : > >> 2017-02-09 8:58 GMT+01:00 Steven Liu : >> >> > +#if FF_API_HLS_WRAP >> > {"hls_wrap", "set number after which the index wraps", >> OFFSET(wrap),AV_OPT_TYPE_INT,{.i64 = 0}, 0, INT_MAX,

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: deprecate hls_wrap option

2017-02-09 Thread Steven Liu
2017-02-09 18:46 GMT+08:00 Carl Eugen Hoyos : > 2017-02-09 8:58 GMT+01:00 Steven Liu : > > > +#if FF_API_HLS_WRAP > > {"hls_wrap", "set number after which the index wraps", > OFFSET(wrap),AV_OPT_TYPE_INT,{.i64 = 0}, 0, INT_MAX, E}, > > +#endif > > (Even if this is not done fo

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: deprecate hls_wrap option

2017-02-09 Thread Carl Eugen Hoyos
2017-02-09 8:58 GMT+01:00 Steven Liu : > +#if FF_API_HLS_WRAP > {"hls_wrap", "set number after which the index wraps", > OFFSET(wrap),AV_OPT_TYPE_INT,{.i64 = 0}, 0, INT_MAX, E}, > +#endif (Even if this is not done for other deprecated options:) Imo, either add the word dep

Re: [FFmpeg-devel] GSoC 2017

2017-02-09 Thread Reto Kromer
Michael Niedermayer wrote: >also in absence of any other ideas, YCoCg support may be a >qualification task. Maybe not the best choice but certainly >usefull on its own +1 Y'CoCg support would be useful indeed. Best regards, Reto ___ ffmpeg-devel mail

Re: [FFmpeg-devel] [PATCHv2 3/3] avfilter/f_setcmd: fix null pointer dereference on using dash as interval

2017-02-09 Thread Paul B Mahol
On 2/9/17, Marton Balint wrote: > Fixes Coverity CID 1396259. > > Signed-off-by: Marton Balint > --- > libavfilter/f_sendcmd.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/libavfilter/f_sendcmd.c b/libavfilter/f_sendcmd.c > index fb30220..522d6ad 100644 > --- a/libavfilter/f_s