Re: [FFmpeg-devel] [PATCH] nvenc: Make AUD optional for h264_nvenc and hevc_nvenc

2016-12-30 0:02 GMT+03:00 Miroslav Slugeň : > Somebody changed AUD to active in NVENC by default, which is not very > clever, libx264 also has this future disabled, so we should stay in sync > with libx264 behavior. > > Enabled AUD will work only without B-frames. There is BUG in Nvidia NVENC > wh

Re: [FFmpeg-devel] [PATCH] configure: make the check for stdatomic.h stricter

On 12/27/2016 9:55 PM, James Almer wrote: > ICC stdatomic.h implementation seems to be incomplete or broken, > missing the ATOMIC_VAR_INIT() macro. > > Should fix ticket #6049 > > Signed-off-by: James Almer > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Pushed.

Re: [FFmpeg-devel] [PATCH] configure: Check build with some header not just preprocessing for testing --std=c11

On 12/29/2016 10:15 PM, Moritz Barsnick wrote: > On Thu, Dec 29, 2016 at 11:06:12 +0100, Michael Niedermayer wrote: >> On Thu, Dec 29, 2016 at 12:12:13AM -0300, James Almer wrote: >>> On 12/28/2016 7:41 PM, Michael Niedermayer wrote: Fixes build failure on FreeBSD with gcc 4.7 >>> >>> Does thi

Re: [FFmpeg-devel] [PATCH] avfilter/vf_pad: Add eval=frame support

On Wed, Dec 28, 2016 at 10:20:41AM -0900, Lou Logan wrote: > On Wed, 28 Dec 2016 02:52:54 +0100, Michael Niedermayer wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavfilter/vf_pad.c | 43 ++- > > 1 file changed, 42 insertions(+), 1 deletion

Re: [FFmpeg-devel] [PATCH] configure: Check build with some header not just preprocessing for testing --std=c11

On Thu, Dec 29, 2016 at 11:06:12 +0100, Michael Niedermayer wrote: > On Thu, Dec 29, 2016 at 12:12:13AM -0300, James Almer wrote: > > On 12/28/2016 7:41 PM, Michael Niedermayer wrote: > > > Fixes build failure on FreeBSD with gcc 4.7 > > > > Does this also fix ticket #6049? If so, please mention i

Re: [FFmpeg-devel] [PATCH] lavf/utils.c Protect against accessing entries[nb_entries]

On Thu, Dec 29, 2016 at 01:42:26PM -0800, Sasi Inguva wrote: > Sorry for the late review. this patch seems ok to me. applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning the gods, I have no means of knowing whether they exist or not or of what

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Set skip_samples according to first edit list, when -ignore_editlist is set.

Sent a patch adding a new option to lavf/mov.c . PTAL. Thanks. On Thu, Dec 29, 2016 at 2:15 PM, Sasi Inguva wrote: > True. Correct way would be to have another option controlling just the > mov_fix_index part for the edit list code. > > On Mon, Nov 14, 2016 at 5:48 AM, Derek Buitenhuis < > der

[FFmpeg-devel] [PATCH] lavf/mov.c: Add -editlist_fix_index option for mov format.

Signed-off-by: Sasi Inguva --- libavformat/isom.h | 1 + libavformat/mov.c | 23 --- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index 12cefc9..ff3a234 100644 --- a/libavformat/isom.h +++ b/libavformat/isom.h @@ -22

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Set skip_samples according to first edit list, when -ignore_editlist is set.

Because, AAC had this hack before my patch. http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavformat/mov.c;h=6e80b93271a4f998af6ba1af795d7d7c5d67f5a1;hb=7b3bc365f9923e30a925f8dece4fddd127a54c5d#l2800 On Tue, Dec 13, 2016 at 2:24 AM, wm4 wrote: > On Fri, 11 Nov 2016 22:02:28 -0800 > Sasi Inguv

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Set skip_samples according to first edit list, when -ignore_editlist is set.

True. Correct way would be to have another option controlling just the mov_fix_index part for the edit list code. On Mon, Nov 14, 2016 at 5:48 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 11/12/2016 6:02 AM, Sasi Inguva wrote: > > +/* Adjust skip_samples correctly when igno

Re: [FFmpeg-devel] [PATCH 08/17] lavfi: add helpers to consume frames from link FIFOs.

On Thu, Dec 29, 2016 at 03:33:54PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/avfilter.c | 52 > ++ > libavfilter/filters.h | 42 > 2 files changed, 94 insertions(+) >

Re: [FFmpeg-devel] [PATCH] lavf/utils.c Protect against accessing entries[nb_entries]

Sorry for the late review. this patch seems ok to me. On Wed, Dec 14, 2016 at 7:34 PM, Michael Niedermayer wrote: > On Wed, Dec 14, 2016 at 03:38:18PM -0800, Matthew Wolenetz wrote: > > In ff_index_search_timestamp(), if b == num_entries, > > m == num_entries - 1, and entries[m].flags & AVINDEX_D

Re: [FFmpeg-devel] [PATCH 02/17] lavfi: export ff_filter_set_ready() to the library.

On Thu, Dec 29, 2016 at 03:33:48PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/avfilter.c | 2 +- > libavfilter/filters.h | 5 + > 2 files changed, 6 insertions(+), 1 deletion(-) > > > Changes in this commit: rename ff_link -> ff_inlink and move to filt

[FFmpeg-devel] [PATCH] NVENC: Round qpIntra and qpInter calculation

Round qpIntra and qpInter calculation instead of old floor behavior. Adopted from vaapi_encode_h264.c -- Miroslav Slugeň >From f983a74bd055d2786de2f3f0227d444361310721 Mon Sep 17 00:00:00 2001 From: Miroslav Slugen Date: Thu, 29 Dec 2016 22:08:41 +0100 Subject: [PATCH 1/1] NVENC: Round qp

Re: [FFmpeg-devel] [PATCH 01/17] lavfi: add ff_inlink_acknowledge_status().

On Thu, Dec 29, 2016 at 03:33:47PM +0100, Nicolas George wrote: > Also introduce libavfilter/filters.h for all functions needed > to implement filters. > > Signed-off-by: Nicolas George > --- > libavfilter/avfilter.c | 14 ++ > libavfilter/filters.h | 37

[FFmpeg-devel] [PATCH] nvenc: Make AUD optional for h264_nvenc and hevc_nvenc

Somebody changed AUD to active in NVENC by default, which is not very clever, libx264 also has this future disabled, so we should stay in sync with libx264 behavior. Enabled AUD will work only without B-frames. There is BUG in Nvidia NVENC when you use AUD for H264 with B-frames, it will retur

Re: [FFmpeg-devel] [PATCH 05/17] lavfi: add ff_inlink_process_commands().

On Thu, Dec 29, 2016 at 03:33:51PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/avfilter.c | 24 +++- > libavfilter/filters.h | 6 ++ > 2 files changed, 21 insertions(+), 9 deletions(-) > > > Changes in this commit: rename ff_link ->

Re: [FFmpeg-devel] [PATCH 06/17] lavfi: add ff_inlink_process_timeline().

On Thu, Dec 29, 2016 at 03:33:52PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/avfilter.c | 34 +- > libavfilter/filters.h | 6 ++ > 2 files changed, 27 insertions(+), 13 deletions(-) > > > Changes in this commit: rename

Re: [FFmpeg-devel] [PATCH 07/17] lavfi: pass min explicitly to samples_ready().

On Thu, Dec 29, 2016 at 03:33:53PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/avfilter.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > > Unchanged. should be ok [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC78

Re: [FFmpeg-devel] [PATCH 04/17] lavfi: merge two variables after a recent commit.

On Thu, Dec 29, 2016 at 03:33:50PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/avfilter.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > > > Unchanged. LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC7

Re: [FFmpeg-devel] [PATCH 15/17] lavfi: make two functions static.

On Thu, Dec 29, 2016 at 03:34:01PM +0100, Nicolas George wrote: > ff_request_frame_to_filter() and ff_filter_frame_to_filter() > are only used in avfilter.c. > > Signed-off-by: Nicolas George > --- > libavfilter/avfilter.c | 4 ++-- > libavfilter/internal.h | 4 > 2 files changed, 2 inserti

Re: [FFmpeg-devel] [PATCH 03/17] lavfi: implement ff_inlink_make_frame_writable().

On Thu, Dec 29, 2016 at 03:33:49PM +0100, Nicolas George wrote: > Unlike av_frame_is_writable(), it uses the link's alloc callback, > making direct rendering possible. > > The code comes from ff_filter_frame_framed(), moved with mostly > trivial changes. > > Signed-off-by: Nicolas George > --- >

Re: [FFmpeg-devel] [PATCH] avcodec/hevc: Extract Content light level from HEVC SEI prefix message

Thanks for the patch. L'octidi 8 nivôse, an CCXXV, Nikola Kolarović a écrit : > From: Nikola Kolarović > > Extract max_content_light_level and max_frame_average_light_level > which are used in HEVC Main 10 (HDR10) for luminosity adjustment. > > Based on ISO/IEC 23008-2:2015 section D.2.35. > --

[FFmpeg-devel] [PATCH] avcodec/hevc: Extract Content light level from HEVC SEI prefix message

From: Nikola Kolarović Extract max_content_light_level and max_frame_average_light_level which are used in HEVC Main 10 (HDR10) for luminosity adjustment. Based on ISO/IEC 23008-2:2015 section D.2.35. --- libavcodec/hevc.h | 4 libavcodec/hevc_sei.c | 12 2 files changed,

Re: [FFmpeg-devel] [PATCH] configure: make the check for stdatomic.h stricter

On 12/28/2016 8:17 PM, Moritz Barsnick wrote: > On Tue, Dec 27, 2016 at 21:55:42 -0300, James Almer wrote: >> ICC stdatomic.h implementation seems to be incomplete or broken, >> missing the ATOMIC_VAR_INIT() macro. >> >> Should fix ticket #6049 > > Your patch works for me with ICC 14.0.3. I'm the

[FFmpeg-devel] [PATCH 12/17] lavfi: move ff_update_link_current_pts() into the utility functions.

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Unchanged. diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 715ecb3300..7e02d9ca8b 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -1116,7 +1116

[FFmpeg-devel] [PATCH 11/17] lavfi: cosmetic: remove forward declaration.

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 2 -- 1 file changed, 2 deletions(-) Unchanged, already LGTM. diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index f3a78d4f14..715ecb3300 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -45,8 +45,6 @@

[FFmpeg-devel] [PATCH 17/17] lavfi/buffersink: move to the new design.

Signed-off-by: Nicolas George --- libavfilter/buffersink.c | 214 +-- 1 file changed, 56 insertions(+), 158 deletions(-) Minor changes to accomodate the previous changes. Since diff is not very smart about it, better read the code than the patch. di

[FFmpeg-devel] [PATCH 16/17] lavfi: do not call ff_filter_frame() with activate.

avfilter_graph_request_oldest() does work that should be done by either the filter or the application. The principle of this function, calling ff_request_frame() from outside the filter was always shaky. This version is less elegant since it requires making special cases for each filter, but it is

[FFmpeg-devel] [PATCH 10/17] lavfi: add AVFilter.activate.

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 6 +- libavfilter/avfilter.h | 14 ++ 2 files changed, 19 insertions(+), 1 deletion(-) Change: more documentation. diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 2b2df67ae1..f3a78d4f14 100644 --- a

[FFmpeg-devel] [PATCH 15/17] lavfi: make two functions static.

ff_request_frame_to_filter() and ff_filter_frame_to_filter() are only used in avfilter.c. Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 4 ++-- libavfilter/internal.h | 4 2 files changed, 2 insertions(+), 6 deletions(-) Unchanged. diff --git a/libavfilter/avfilter.c b/liba

[FFmpeg-devel] [PATCH 08/17] lavfi: add helpers to consume frames from link FIFOs.

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 52 ++ libavfilter/filters.h | 42 2 files changed, 94 insertions(+) Changes in this commit: rename ff_link -> ff_inlink and move to filters.h, re

[FFmpeg-devel] [PATCH 09/17] lavfi: use the consume helpers in ff_filter_frame_to_filter().

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) Unchanged except ff_link -> ff_inlink due to the previous changes. diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 2183a84395..2b2df67ae1 1

[FFmpeg-devel] [PATCH 07/17] lavfi: pass min explicitly to samples_ready().

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Unchanged. diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index d1ba7d9bad..d31c9f738b 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -1177

[FFmpeg-devel] [PATCH 06/17] lavfi: add ff_inlink_process_timeline().

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 34 +- libavfilter/filters.h | 6 ++ 2 files changed, 27 insertions(+), 13 deletions(-) Changes in this commit: rename ff_link -> ff_inlink and move to filters.h. Already LGTM by Michael. diff --g

[FFmpeg-devel] [PATCH 14/17] lavfi: disallow ff_request_frame for filters using activate.

Having two different functions allows to have stricter tests and detect errors earlier. Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 1 + libavfilter/internal.h | 3 +++ 2 files changed, 4 insertions(+) Unchanged. diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c ind

[FFmpeg-devel] [PATCH 01/17] lavfi: add ff_inlink_acknowledge_status().

Also introduce libavfilter/filters.h for all functions needed to implement filters. Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 14 ++ libavfilter/filters.h | 37 + 2 files changed, 51 insertions(+) create mode 100644 libavfilter/f

[FFmpeg-devel] [PATCH 05/17] lavfi: add ff_inlink_process_commands().

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 24 +++- libavfilter/filters.h | 6 ++ 2 files changed, 21 insertions(+), 9 deletions(-) Changes in this commit: rename ff_link -> ff_inlink and move to filters.h. diff --git a/libavfilter/avfilter.c b/libavf

[FFmpeg-devel] [PATCH 04/17] lavfi: merge two variables after a recent commit.

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) Unchanged. diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index ccc22a1444..2c41ea8c22 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -

[FFmpeg-devel] [PATCH 13/17] lavfi: add ff_inlink_set_frame_wanted().

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 8 libavfilter/filters.h | 8 2 files changed, 16 insertions(+) Changes in this commit: rename ff_link -> ff_inlink and move to filters.h. diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 7e02d9ca8

[FFmpeg-devel] [PATCH 03/17] lavfi: implement ff_inlink_make_frame_writable().

Unlike av_frame_is_writable(), it uses the link's alloc callback, making direct rendering possible. The code comes from ff_filter_frame_framed(), moved with mostly trivial changes. Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 94 --

[FFmpeg-devel] [PATCH 02/17] lavfi: export ff_filter_set_ready() to the library.

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 2 +- libavfilter/filters.h | 5 + 2 files changed, 6 insertions(+), 1 deletion(-) Changes in this commit: rename ff_link -> ff_inlink and move to filters.h. diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 47a4

Re: [FFmpeg-devel] [PATCH] libavutil/random_seed: Ensure that get_generic_seed() spends at least 1/32 sec gathering entropy

On Thu, Dec 29, 2016 at 11:13 AM, Hendrik Leppkes wrote: > On Thu, Dec 29, 2016 at 3:37 AM, James Almer wrote: >> On 12/28/2016 8:34 PM, Michael Niedermayer wrote: >>> This may fix the failures on windows >> >> Not sure what failures this is about > > This failure, which keeps popping up sporadic

Re: [FFmpeg-devel] [PATCH] libavutil/random_seed: Ensure that get_generic_seed() spends at least 1/32 sec gathering entropy

On Thu, Dec 29, 2016 at 3:37 AM, James Almer wrote: > On 12/28/2016 8:34 PM, Michael Niedermayer wrote: >> This may fix the failures on windows > > Not sure what failures this is about This failure, which keeps popping up sporadically since c4152fc42e480c41efb7f761b1bbe5f0bc43d5bc, because Window

Re: [FFmpeg-devel] [PATCH] configure: Check build with some header not just preprocessing for testing --std=c11

On Thu, Dec 29, 2016 at 12:12:13AM -0300, James Almer wrote: > On 12/28/2016 7:41 PM, Michael Niedermayer wrote: > > Fixes build failure on FreeBSD with gcc 4.7 > > Does this also fix ticket #6049? If so, please mention it. I dont have ICC, so i dont know [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] lavfi, ffmpeg: simplify filter names.

Le quartidi 4 nivôse, an CCXXV, Nicolas George a écrit : > The names are only used for technical output and debugging. > Make them similar to C identifiers for easier quick reading > of debug dumps. > > Signed-off-by: Nicolas George > --- > ffmpeg_filter.c | 24 --