Re: [FFmpeg-devel] [PATCH] wmavoice: protect against zero-energy in adaptive gain control.

On 12/21/16, Ronald S. Bultje wrote: > Otherwise the scale factor becomes NaN, resulting in corrupt output. > Fixes #5426. > --- > libavcodec/wmavoice.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c > index 90dfe20..cd5958

Re: [FFmpeg-devel] Removing DCE

On 16 December 2016 at 13:48, Matt Oliver wrote: > Recently we have again received several patches that are trying to add > workarounds for ffmpegs use of DCE. This is not the first time this has > happened and wont be the last until a decision is made about the use of > DCE. So I think its time

[FFmpeg-devel] [PATCH 3/3] lavf/movdec: request probing for an ambiguous codec tag

--- libavformat/isom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/isom.c b/libavformat/isom.c index ae10cb7d3f..37bfd5af30 100644 --- a/libavformat/isom.c +++ b/libavformat/isom.c @@ -509,6 +509,8 @@ FF_ENABLE_DEPRECATION_WARNINGS codec_id= ff_codec_get_id(ff_mp4_obj_ty

[FFmpeg-devel] [PATCH 2/3] lavf/utils: add MP2 to the probing list

--- libavformat/utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index 50a30f6942..738211dd54 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -329,6 +329,7 @@ static int set_codec_from_probe_data(AVFormatContext *s, AVStream *st,

[FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

This allows us to report the correct codec ID here --- libavformat/allformats.c | 2 +- libavformat/mp3dec.c | 62 +++- libavformat/version.h| 2 +- 3 files changed, 42 insertions(+), 24 deletions(-) diff --git a/libavformat/allformats.c b/lib

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

On Tue, Dec 20, 2016 at 04:53:51PM -0800, Thomas Turner wrote: > Signed-off-by: Thomas Turner > --- > libavutil/Makefile | 1 + > libavutil/tests/audio_fifo.c | 196 + > tests/fate/libavutil.mak | 4 + > tests/ref/fate/audio_fifo| 228 > +

Re: [FFmpeg-devel] [PATCH 2/4] wmavoice: disable bitstream checking.

Hi, On Tue, Dec 20, 2016 at 7:59 PM, Michael Niedermayer wrote: > On Tue, Dec 20, 2016 at 07:51:05PM -0500, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, Dec 20, 2016 at 7:44 PM, Michael Niedermayer > > > wrote: > > > > > On Tue, Dec 20, 2016 at 05:23:06PM -0500, Ronald S. Bultje wrote: > > >

Re: [FFmpeg-devel] [PATCH] avutil: Improved code coverage for libavutil/random_seed.c

On Tue, Dec 20, 2016 at 05:07:29PM -0800, Thomas Turner wrote: > Signed-off-by: Thomas Turner > --- > libavutil/tests/random_seed.c | 40 > tests/ref/fate/random_seed| 1 + > 2 files changed, 25 insertions(+), 16 deletions(-) > > diff --git a/libavut

[FFmpeg-devel] [PATCH] avutil: Improved code coverage for libavutil/random_seed.c

Signed-off-by: Thomas Turner --- libavutil/tests/random_seed.c | 40 tests/ref/fate/random_seed| 1 + 2 files changed, 25 insertions(+), 16 deletions(-) diff --git a/libavutil/tests/random_seed.c b/libavutil/tests/random_seed.c index ebe9b3e..f00b962

Re: [FFmpeg-devel] [PATCH 2/4] wmavoice: disable bitstream checking.

On Tue, Dec 20, 2016 at 07:51:05PM -0500, Ronald S. Bultje wrote: > Hi, > > On Tue, Dec 20, 2016 at 7:44 PM, Michael Niedermayer > wrote: > > > On Tue, Dec 20, 2016 at 05:23:06PM -0500, Ronald S. Bultje wrote: > > > The checked bitstream reader does that already. To allow parsing of > > > superf

Re: [FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

On 20.12.2016 15:46, wm4 wrote: > In general, replacing public fields with macro-generated accessors is > really just a rename. Admittedly, it removes a confusing indirection > (though ->inputs[0]) in this case, but in general the improvements are > very minor. What does it matter if whether there

[FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

Signed-off-by: Thomas Turner --- libavutil/Makefile | 1 + libavutil/tests/audio_fifo.c | 196 + tests/fate/libavutil.mak | 4 + tests/ref/fate/audio_fifo| 228 +++ 4 files changed, 429 insertions(+)

Re: [FFmpeg-devel] [PATCH] avutil: Improved code coverage for libavutil/random_seed.c

On Tue, Dec 20, 2016 at 04:30:56PM -0800, Thomas Turner wrote: > Signed-off-by: Thomas Turner > --- > libavutil/tests/random_seed.c | 36 +--- > tests/ref/fate/random_seed| 1 + > 2 files changed, 22 insertions(+), 15 deletions(-) > > diff --git a/libavutil/t

Re: [FFmpeg-devel] [PATCH 2/4] wmavoice: disable bitstream checking.

Hi, On Tue, Dec 20, 2016 at 7:44 PM, Michael Niedermayer wrote: > On Tue, Dec 20, 2016 at 05:23:06PM -0500, Ronald S. Bultje wrote: > > The checked bitstream reader does that already. To allow parsing of > > superframes split over a packet boundary, we always decode the last > > superframe in ea

Re: [FFmpeg-devel] [PATCH 2/4] wmavoice: disable bitstream checking.

On Tue, Dec 20, 2016 at 05:23:06PM -0500, Ronald S. Bultje wrote: > The checked bitstream reader does that already. To allow parsing of > superframes split over a packet boundary, we always decode the last > superframe in each packet at the start of the next packet, even if > theoretically we could

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add FF_BAIL_ON_OVERFLOW

On 20.12.2016 15:22, wm4 wrote: > On Mon, 19 Dec 2016 23:36:11 +0100 > Andreas Cadhalpun wrote: > >> On 16.12.2016 17:22, wm4 wrote: >>> On Fri, 16 Dec 2016 03:32:07 +0100 >>> Andreas Cadhalpun wrote: >>> Suggested-by: Rodger Combs Signed-off-by: Andreas Cadhalpun --- l

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add FF_BAIL_ON_OVERFLOW

On 20.12.2016 10:23, Muhammad Faiz wrote: > On 12/20/16, Andreas Cadhalpun wrote: >> On 16.12.2016 07:36, Muhammad Faiz wrote: >>> On 12/16/16, Andreas Cadhalpun wrote: Suggested-by: Rodger Combs Signed-off-by: Andreas Cadhalpun --- libavutil/common.h | 2 ++ 1 file ch

Re: [FFmpeg-devel] [PATCH] swscale: also save ebx register when using PIE

On 20.12.2016 03:04, Michael Niedermayer wrote: > On Mon, Dec 19, 2016 at 11:28:44PM +0100, Andreas Cadhalpun wrote: >> On 16.12.2016 04:08, Michael Niedermayer wrote: >>> On Fri, Dec 16, 2016 at 02:36:53AM +0100, Andreas Cadhalpun wrote: Otherwise the build fails when configuring with --toolc

[FFmpeg-devel] [PATCH] avutil: Improved code coverage for libavutil/random_seed.c

Signed-off-by: Thomas Turner --- libavutil/tests/random_seed.c | 36 +--- tests/ref/fate/random_seed| 1 + 2 files changed, 22 insertions(+), 15 deletions(-) diff --git a/libavutil/tests/random_seed.c b/libavutil/tests/random_seed.c index ebe9b3e..ffcb74d 100

Re: [FFmpeg-devel] [PATCH] checkasm/vp9: benchmark all sub-IDCTs (but not WHT or ADST).

Hi, On Mon, Dec 5, 2016 at 4:15 PM, Ronald S. Bultje wrote: > --- > tests/checkasm/vp9dsp.c | 22 ++ > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git a/tests/checkasm/vp9dsp.c b/tests/checkasm/vp9dsp.c > index 441041c..f32b97c 100644 > --- a/tests/checkasm/v

[FFmpeg-devel] [PATCH] wmavoice: protect against zero-energy in adaptive gain control.

Otherwise the scale factor becomes NaN, resulting in corrupt output. Fixes #5426. --- libavcodec/wmavoice.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c index 90dfe20..cd5958c 100644 --- a/libavcodec/wmavoice.c +++ b/libavcodec

Re: [FFmpeg-devel] [PATCH 6/6] lavfi: make AVFilterLink opaque in two major bumps.

On Tue, Dec 20, 2016 at 07:24:44PM +0100, Nicolas George wrote: > Le nonidi 29 frimaire, an CCXXV, Michael Niedermayer a écrit : > > though i wonder what mistake we did to end here, the original design > > was intended to be very simple ... > > That was the mistake: trying for a simple design. >

[FFmpeg-devel] [PATCH 4/4] wmavoice: move overflow handling to common code.

--- libavcodec/wmavoice.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c index f31c9d2..90dfe20 100644 --- a/libavcodec/wmavoice.c +++ b/libavcodec/wmavoice.c @@ -1800,6 +1800,11 @@ static int synth_superframe(AV

[FFmpeg-devel] [PATCH 2/4] wmavoice: disable bitstream checking.

The checked bitstream reader does that already. To allow parsing of superframes split over a packet boundary, we always decode the last superframe in each packet at the start of the next packet, even if theoretically we could have decoded it. The last superframe in the last packet is decoded using

[FFmpeg-devel] [PATCH 1/4] wmavoice: move wmavoice_flush() up.

--- libavcodec/wmavoice.c | 56 +-- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c index ceac61f..4b3ab43 100644 --- a/libavcodec/wmavoice.c +++ b/libavcodec/wmavoice.c @@ -337,6 +337,34

[FFmpeg-devel] [PATCH 3/4] wmavoice: reindent.

--- libavcodec/wmavoice.c | 72 +-- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c index ae100fb..f31c9d2 100644 --- a/libavcodec/wmavoice.c +++ b/libavcodec/wmavoice.c @@ -1915,29 +1915,

Re: [FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

Le decadi 30 frimaire, an CCXXV, wm4 a écrit : > > You mean a single structure returned by a single accessor with all the > > stream's properties instead of individual accessors for individual > > properties? Well, the naive methods of returning a structure to the > > caller would make the size of

[FFmpeg-devel] [PATCH 1/2] wmavoice: disable bitstream checking.

The checked bitstream reader does that already. To allow parsing of superframes split over a packet boundary, we always decode the last superframe in each packet at the start of the next packet, even if theoretically we could have decoded it. The last superframe in the last packet is decoded using

[FFmpeg-devel] [PATCH 2/2] wmavoice: reindent.

--- libavcodec/wmavoice.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c index 5001b0b..5393003 100644 --- a/libavcodec/wmavoice.c +++ b/libavcodec/wmavoice.c @@ -1887,23 +1887,23 @@ static int

Re: [FFmpeg-devel] Trying to ftp upload sample video

On 12/20/2016 3:30 PM, Ray Pasco wrote: > There doesn't appear to be enough detail for uploading a sample file by ftp. > > [image: Inline image 1] > > What are the values for *port* and *password* ? It's FTP, so port 21. And any password should work since it's anonymous login. If you can't get

Re: [FFmpeg-devel] Trying to ftp upload sample video

On 12/20/16, Ray Pasco wrote: > There doesn't appear to be enough detail for uploading a sample file by > ftp. > > [image: Inline image 1] > > What are the values for *port* and *password* ? > Upload it somewhere else. ___ ffmpeg-devel mailing list ffmp

[FFmpeg-devel] Trying to ftp upload sample video

There doesn't appear to be enough detail for uploading a sample file by ftp. [image: Inline image 1] What are the values for *port* and *password* ? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 6/6] lavfi: make AVFilterLink opaque in two major bumps.

Le nonidi 29 frimaire, an CCXXV, Michael Niedermayer a écrit : > though i wonder what mistake we did to end here, the original design > was intended to be very simple ... That was the mistake: trying for a simple design. Ha ha! Only serious. Linear filter chains are simple, and could have worked

Re: [FFmpeg-devel] [PATCHv3] af_hdcd: more FATE tests

On Mon, Dec 19, 2016 at 10:27:20PM -0600, Burt P. wrote: > On Sun, Dec 18, 2016 at 6:54 PM, Michael Niedermayer > wrote: > > On Sun, Dec 18, 2016 at 12:48:45PM -0600, Burt P wrote: > >> Additional/Modified FATE tests improve code coverage from 63.7% to 98.1%. > >> > >> Changed fate-suite sample fi

Re: [FFmpeg-devel] [PATCH] avutil: Improved test coverage for avstring.c

On Mon, Dec 19, 2016 at 06:44:42PM -0800, Thomas Turner wrote: > Signed-off-by: Thomas Turner > --- > libavutil/tests/avstring.c | 26 +- > 1 file changed, 25 insertions(+), 1 deletion(-) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

On Mon, Dec 19, 2016 at 06:39:03PM -0800, Thomas Turner wrote: > Signed-off-by: Thomas Turner > --- > libavutil/Makefile | 1 + > libavutil/tests/audio_fifo.c | 195 > tests/fate/libavutil.mak | 4 + > tests/ref/fate/audio_fifo| 228 > ++

Re: [FFmpeg-devel] [PATCH] avutil/common: add FFRET/FFGOTO macro

On 12/20/16, Michael Niedermayer wrote: > On Tue, Dec 20, 2016 at 09:05:56PM +0700, Muhammad Faiz wrote: >> On 12/20/16, Michael Niedermayer wrote: >> > On Tue, Dec 20, 2016 at 04:38:34PM +0700, Muhammad Faiz wrote: >> >> FFRET_ERR and FFGOTO_ERR for common error handling >> >> FFRET_OOM and FFGO

Re: [FFmpeg-devel] [PATCH] avutil/common: add FFRET/FFGOTO macro

On Tue, Dec 20, 2016 at 09:05:56PM +0700, Muhammad Faiz wrote: > On 12/20/16, Michael Niedermayer wrote: > > On Tue, Dec 20, 2016 at 04:38:34PM +0700, Muhammad Faiz wrote: > >> FFRET_ERR and FFGOTO_ERR for common error handling > >> FFRET_OOM and FFGOTO_OOM for oom handling > >> > >> Signed-off-by

Re: [FFmpeg-devel] [PATCH] avcodec: add Apple Pixlet decoder

On Mon, Dec 19, 2016 at 03:18:00PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/general.texi| 1 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7 + > libavcodec/pixlet.c

Re: [FFmpeg-devel] [PATCH] avutil/common: add FFRET/FFGOTO macro

On 12/20/16, wm4 wrote: > On Tue, 20 Dec 2016 16:38:34 +0700 > Muhammad Faiz wrote: > >> FFRET_ERR and FFGOTO_ERR for common error handling >> FFRET_OOM and FFGOTO_OOM for oom handling >> >> Signed-off-by: Muhammad Faiz >> --- >> libavutil/common.h | 23 +++ >> 1 file change

Re: [FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

On Mon, 19 Dec 2016 09:40:41 +0100 Nicolas George wrote: > L'octidi 28 frimaire, an CCXXV, wm4 a écrit : > > For buffersink, you could simply return a struct with the parameters. > > As a value type, it'd be a copy and wouldn't need accessors. > > You mean a single structure returned by a sing

Re: [FFmpeg-devel] [PATCH] avutil/common: add FFRET/FFGOTO macro

On Tue, 20 Dec 2016 16:38:34 +0700 Muhammad Faiz wrote: > FFRET_ERR and FFGOTO_ERR for common error handling > FFRET_OOM and FFGOTO_OOM for oom handling > > Signed-off-by: Muhammad Faiz > --- > libavutil/common.h | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add FF_BAIL_ON_OVERFLOW

On 12/20/16, wm4 wrote: > On Mon, 19 Dec 2016 23:36:11 +0100 > Andreas Cadhalpun wrote: > >> On 16.12.2016 17:22, wm4 wrote: >> > On Fri, 16 Dec 2016 03:32:07 +0100 >> > Andreas Cadhalpun wrote: >> > >> >> Suggested-by: Rodger Combs >> >> Signed-off-by: Andreas Cadhalpun >> >> --- >> >> libav

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add FF_BAIL_ON_OVERFLOW

On Mon, 19 Dec 2016 23:36:11 +0100 Andreas Cadhalpun wrote: > On 16.12.2016 17:22, wm4 wrote: > > On Fri, 16 Dec 2016 03:32:07 +0100 > > Andreas Cadhalpun wrote: > > > >> Suggested-by: Rodger Combs > >> Signed-off-by: Andreas Cadhalpun > >> --- > >> libavutil/common.h | 2 ++ > >> 1 file c

Re: [FFmpeg-devel] [PATCH] avutil/common: add FFRET/FFGOTO macro

On 12/20/16, Michael Niedermayer wrote: > On Tue, Dec 20, 2016 at 04:38:34PM +0700, Muhammad Faiz wrote: >> FFRET_ERR and FFGOTO_ERR for common error handling >> FFRET_OOM and FFGOTO_OOM for oom handling >> >> Signed-off-by: Muhammad Faiz >> --- >> libavutil/common.h | 23 +++

Re: [FFmpeg-devel] [PATCH] avutil/common: add FFRET/FFGOTO macro

On Tue, Dec 20, 2016 at 04:38:34PM +0700, Muhammad Faiz wrote: > FFRET_ERR and FFGOTO_ERR for common error handling > FFRET_OOM and FFGOTO_OOM for oom handling > > Signed-off-by: Muhammad Faiz > --- > libavutil/common.h | 23 +++ > 1 file changed, 23 insertions(+) > > diff -

Re: [FFmpeg-devel] [PATCH]lavu/internal: Never use %t and %z on Windows

2016-12-20 10:37 GMT+01:00 Hendrik Leppkes : > On Tue, Dec 20, 2016 at 3:15 AM, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch is supposed to fix an issue reported by Blake Senftner >> on libav-user. > > Sorry, but those guys are just using it wrong. Those format specifiers > are perfectly va

Re: [FFmpeg-devel] [PATCH] avutil/common: add FFRET/FFGOTO macro

On 12/20/16, Hendrik Leppkes wrote: > On Tue, Dec 20, 2016 at 10:38 AM, Muhammad Faiz wrote: >> FFRET_ERR and FFGOTO_ERR for common error handling >> FFRET_OOM and FFGOTO_OOM for oom handling >> >> Signed-off-by: Muhammad Faiz >> --- >> libavutil/common.h | 23 +++ >> 1 file

Re: [FFmpeg-devel] [PATCH] avutil/common: add FFRET/FFGOTO macro

On Tue, Dec 20, 2016 at 10:38 AM, Muhammad Faiz wrote: > FFRET_ERR and FFGOTO_ERR for common error handling > FFRET_OOM and FFGOTO_OOM for oom handling > > Signed-off-by: Muhammad Faiz > --- > libavutil/common.h | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/li

[FFmpeg-devel] [PATCH] avutil/common: add FFRET/FFGOTO macro

FFRET_ERR and FFGOTO_ERR for common error handling FFRET_OOM and FFGOTO_OOM for oom handling Signed-off-by: Muhammad Faiz --- libavutil/common.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/libavutil/common.h b/libavutil/common.h index 8142b31..b868d60 100644 ---

Re: [FFmpeg-devel] [PATCH]lavu/internal: Never use %t and %z on Windows

On Tue, Dec 20, 2016 at 3:15 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch is supposed to fix an issue reported by Blake Senftner > on libav-user. > Sorry, but those guys are just using it wrong. Those format specifiers are perfectly valid in a mingw build, and if you mix different compile

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add FF_BAIL_ON_OVERFLOW

On 12/20/16, Andreas Cadhalpun wrote: > On 16.12.2016 07:36, Muhammad Faiz wrote: >> On 12/16/16, Andreas Cadhalpun wrote: >>> Suggested-by: Rodger Combs >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> libavutil/common.h | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/libavut

Re: [FFmpeg-devel] [PATCH] lavfi/framequeue: avoid empty structs.

Le decadi 30 frimaire, an CCXXV, Matt Oliver a écrit : > tested and it fixes the issue. LGTM. Thanks for testing, pushed. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org