Re: [FFmpeg-devel] [PATCH] lavfi/framequeue: avoid empty structs.

2016-12-19 Thread Matt Oliver
On 19 December 2016 at 18:58, Nicolas George wrote: > Le nonidi 29 frimaire, an CCXXV, Nicolas George a écrit : > > Fix compilation on MSVC. > > Forgot to write in the comment beore sending: this is obviously > untested. > tested and it fixes the issue. LGTM.

Re: [FFmpeg-devel] [PATCHv3] af_hdcd: more FATE tests

2016-12-19 Thread Burt P.
On Sun, Dec 18, 2016 at 6:54 PM, Michael Niedermayer wrote: > On Sun, Dec 18, 2016 at 12:48:45PM -0600, Burt P wrote: >> Additional/Modified FATE tests improve code coverage from 63.7% to 98.1%. >> >> Changed fate-suite sample files: >> * filter/hdcd-encoding-errors.flac (1.3M) replaced by >> a

[FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-19 Thread Thomas Turner
Signed-off-by: Thomas Turner --- libavutil/Makefile | 1 + libavutil/tests/audio_fifo.c | 195 tests/fate/libavutil.mak | 4 + tests/ref/fate/audio_fifo| 228 +++ 4 files changed, 428 insertions(+)

[FFmpeg-devel] [PATCH] avutil: Improved test coverage for avstring.c

2016-12-19 Thread Thomas Turner
Signed-off-by: Thomas Turner --- libavutil/tests/avstring.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/libavutil/tests/avstring.c b/libavutil/tests/avstring.c index 1242b3f..290b170 100644 --- a/libavutil/tests/avstring.c +++ b/libavutil/tests/a

[FFmpeg-devel] [PATCH]lavu/internal: Never use %t and %z on Windows

2016-12-19 Thread Carl Eugen Hoyos
Hi! Attached patch is supposed to fix an issue reported by Blake Senftner on libav-user. Please comment, Carl Eugen From dbb730692ebb81377bc3db0df50b3c32ca0def16 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Tue, 20 Dec 2016 03:11:54 +0100 Subject: [PATCH] lavu/internal: Never use %t or

Re: [FFmpeg-devel] [PATCH] swscale: also save ebx register when using PIE

2016-12-19 Thread Michael Niedermayer
On Mon, Dec 19, 2016 at 11:28:44PM +0100, Andreas Cadhalpun wrote: > On 16.12.2016 04:08, Michael Niedermayer wrote: > > On Fri, Dec 16, 2016 at 02:36:53AM +0100, Andreas Cadhalpun wrote: > >> Otherwise the build fails when configuring with --toolchain=hardened > >> --disable-pic on i386 using gcc

Re: [FFmpeg-devel] [PATCH 2/2] wmavoice: don't error out if we're skipping more bits than available.

2016-12-19 Thread Carl Eugen Hoyos
2016-12-20 1:10 GMT+01:00 Andreas Cadhalpun : > On 20.12.2016 00:59, Carl Eugen Hoyos wrote: >> 2016-12-19 23:45 GMT+01:00 Andreas Cadhalpun >> : >>> On 16.12.2016 14:19, Ronald S. Bultje wrote: This reverts 2a4700a4f03280fa8ba4fc0f8a9987bb550f0d1e and implements it correctly so streams

Re: [FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

2016-12-19 Thread Andreas Cadhalpun
On 18.12.2016 13:22, Nicolas George wrote: > av_buffersink_get_frame_rate() did already exist; its argument becomes const. > > TODO minor version bump > > API-Change: libavfilter > Signed-off-by: Nicolas George > --- > libavfilter/buffersink.c | 25 +++-- > libavfilter/buffe

Re: [FFmpeg-devel] [PATCH 2/2] wmavoice: don't error out if we're skipping more bits than available.

2016-12-19 Thread Andreas Cadhalpun
On 20.12.2016 00:59, Carl Eugen Hoyos wrote: > 2016-12-19 23:45 GMT+01:00 Andreas Cadhalpun > : >> On 16.12.2016 14:19, Ronald S. Bultje wrote: >>> This reverts 2a4700a4f03280fa8ba4fc0f8a9987bb550f0d1e and implements it >>> correctly so streams actually decode the way the encoder intended them >>>

Re: [FFmpeg-devel] [PATCH 2/2] wmavoice: don't error out if we're skipping more bits than available.

2016-12-19 Thread Carl Eugen Hoyos
2016-12-19 23:45 GMT+01:00 Andreas Cadhalpun : > On 16.12.2016 14:19, Ronald S. Bultje wrote: >> This reverts 2a4700a4f03280fa8ba4fc0f8a9987bb550f0d1e and implements it >> correctly so streams actually decode the way the encoder intended them >> to. > > Why is it correct? Because the patch introdu

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavfi: make filter_frame non-recursive.

2016-12-19 Thread Michael Niedermayer
On Tue, Dec 20, 2016 at 12:33:41AM +0100, Michael Niedermayer wrote: > On Mon, Dec 19, 2016 at 11:56:27PM +0100, Nicolas George wrote: > > Le nonidi 29 frimaire, an CCXXV, Michael Niedermayer a écrit : > > > i dont know if this is a bug or just somethig that by sheer bad luck > > > becomes vissible

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavfi: make filter_frame non-recursive.

2016-12-19 Thread Michael Niedermayer
On Mon, Dec 19, 2016 at 11:56:27PM +0100, Nicolas George wrote: > Le nonidi 29 frimaire, an CCXXV, Michael Niedermayer a écrit : > > i dont know if this is a bug or just somethig that by sheer bad luck > > becomes vissible after this but > > ./ffmpeg -i cvid/dday.mov -vframes 30 -vcodec huffyuv -y

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavfi: make filter_frame non-recursive.

2016-12-19 Thread Nicolas George
Le nonidi 29 frimaire, an CCXXV, Michael Niedermayer a écrit : > i dont know if this is a bug or just somethig that by sheer bad luck > becomes vissible after this but > ./ffmpeg -i cvid/dday.mov -vframes 30 -vcodec huffyuv -y -acodec pcm_s16le > out3b.avi ; md5sum out3b.avi > gives different out

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavfi: make filter_frame non-recursive.

2016-12-19 Thread Michael Niedermayer
On Sun, Dec 18, 2016 at 10:49:36AM +0100, Nicolas George wrote: > ffmpeg | branch: master | Nicolas George | Sun Jan 3 > 15:44:42 2016 +0100| [02aa0701ae0dc2def8db640c9e3c06dc1b5de70c] | committer: > Nicolas George > > lavfi: make filter_frame non-recursive. > > A lot of changes happen at the

Re: [FFmpeg-devel] [PATCH 2/2] wmavoice: don't error out if we're skipping more bits than available.

2016-12-19 Thread Andreas Cadhalpun
On 16.12.2016 14:19, Ronald S. Bultje wrote: > This reverts 2a4700a4f03280fa8ba4fc0f8a9987bb550f0d1e and implements it > correctly so streams actually decode the way the encoder intended them > to. Why is it correct? Is this behavior defined in a specification or reference decoder? > --- > libav

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add FF_BAIL_ON_OVERFLOW

2016-12-19 Thread Andreas Cadhalpun
On 16.12.2016 17:22, wm4 wrote: > On Fri, 16 Dec 2016 03:32:07 +0100 > Andreas Cadhalpun wrote: > >> Suggested-by: Rodger Combs >> Signed-off-by: Andreas Cadhalpun >> --- >> libavutil/common.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/libavutil/common.h b/libavutil/common.h

Re: [FFmpeg-devel] [PATCH] swscale: also save ebx register when using PIE

2016-12-19 Thread Andreas Cadhalpun
On 16.12.2016 04:08, Michael Niedermayer wrote: > On Fri, Dec 16, 2016 at 02:36:53AM +0100, Andreas Cadhalpun wrote: >> Otherwise the build fails when configuring with --toolchain=hardened >> --disable-pic on i386 using gcc 4.8: >> error: PIC register clobbered by '%ebx' in 'asm' >> >> Signed-off-b

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add FF_BAIL_ON_OVERFLOW

2016-12-19 Thread Andreas Cadhalpun
On 16.12.2016 07:36, Muhammad Faiz wrote: > On 12/16/16, Andreas Cadhalpun wrote: >> Suggested-by: Rodger Combs >> Signed-off-by: Andreas Cadhalpun >> --- >> libavutil/common.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/libavutil/common.h b/libavutil/common.h >> index 8142b31

Re: [FFmpeg-devel] [PATCH] Make the process of uuid-xmp atom faster.

2016-12-19 Thread Michael Niedermayer
On Fri, Nov 11, 2016 at 11:42:26AM +0800, Chen Meng wrote: > Ya. It’s really annoying everyone using patchwork. (So lng text.) I’m > trying to fix it. > Please use my name, Chen Meng, if nothing changed in a short time. > > 2016-11-11 10:36 GMT+08:00 Chen Meng : > --- > libavformat/mov.c | 3

Re: [FFmpeg-devel] [PATCH] lavfi/atempo: Avoid false triggering an assertion failure

2016-12-19 Thread Marton Balint
On Mon, 19 Dec 2016, Marton Balint wrote: On Sat, 17 Dec 2016, pkoshe...@gmail.com wrote: From: Pavel Koshevoy Steps to reproduce: ./ffmpeg_g -f s16be -i /dev/null -af atempo=0.5 -y /tmp/atempo.wav --- libavfilter/af_atempo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavfi: make filter_frame non-recursive.

2016-12-19 Thread Michael Niedermayer
On Sun, Dec 18, 2016 at 10:49:36AM +0100, Nicolas George wrote: > ffmpeg | branch: master | Nicolas George | Sun Jan 3 > 15:44:42 2016 +0100| [02aa0701ae0dc2def8db640c9e3c06dc1b5de70c] | committer: > Nicolas George > > lavfi: make filter_frame non-recursive. > > A lot of changes happen at the

Re: [FFmpeg-devel] [PATCH] avcodec: add Apple Pixlet decoder

2016-12-19 Thread Paul B Mahol
On 12/19/16, James Almer wrote: > On 12/19/2016 11:18 AM, Paul B Mahol wrote: >> +static int read_low_coeffs(AVCodecContext *avctx, int16_t *dst, int size) >> +{ >> +PixletContext *ctx = avctx->priv_data; >> +GetBitContext *b = &ctx->gbit; >> +unsigned value, cnt1, nbits, j, i = 0; >>

Re: [FFmpeg-devel] [PATCH] doc/examples/decoder_targeted: Limit max pixels for fuzzing

2016-12-19 Thread Michael Niedermayer
On Sat, Dec 17, 2016 at 06:40:53PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > doc/examples/decoder_targeted.c | 3 +++ > 1 file changed, 3 insertions(+) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay d

Re: [FFmpeg-devel] [PATCH 6/6] lavfi: make AVFilterLink opaque in two major bumps.

2016-12-19 Thread Michael Niedermayer
On Mon, Dec 19, 2016 at 05:39:53PM +0100, Nicolas George wrote: > Le nonidi 29 frimaire, an CCXXV, Michael Niedermayer a écrit : > > Changing from AVFilterFrame to AVFrame could have been done using > > a new set of API functions and deprecating the old. > > > > Things like that were not done as i

Re: [FFmpeg-devel] [PATCH] avcodec: add Apple Pixlet decoder

2016-12-19 Thread James Almer
On 12/19/2016 11:18 AM, Paul B Mahol wrote: > +static int read_low_coeffs(AVCodecContext *avctx, int16_t *dst, int size) > +{ > +PixletContext *ctx = avctx->priv_data; > +GetBitContext *b = &ctx->gbit; > +unsigned value, cnt1, nbits, j, i = 0; > +int rlen, flag = 0, escape; > +i

Re: [FFmpeg-devel] [PATCH 6/6] lavfi: make AVFilterLink opaque in two major bumps.

2016-12-19 Thread Nicolas George
Le nonidi 29 frimaire, an CCXXV, Michael Niedermayer a écrit : > Changing from AVFilterFrame to AVFrame could have been done using > a new set of API functions and deprecating the old. > > Things like that were not done as it wasnt needed without a public > API, i dont think theres anything we rea

[FFmpeg-devel] [PATCH] avcodec: add Apple Pixlet decoder

2016-12-19 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 + libavcodec/pixlet.c | 726 libavformat/isom.c

Re: [FFmpeg-devel] [PATCH 1/1] Fixing 3GPP Timed Text (TTXT / tx3g / mov_text) encoding for UTF-8 (ticket 6021)

2016-12-19 Thread Michael Niedermayer
On Sun, Dec 18, 2016 at 10:09:54PM +, Erik Bråthen Solem wrote: > Good question. Since text_pos_chars never exceeds the existing > variable text_pos, I did not think about this. > > No, there are no checks. The spec says that "Authors should limit the > string in each text sample to not more

Re: [FFmpeg-devel] [PATCH 6/6] lavfi: make AVFilterLink opaque in two major bumps.

2016-12-19 Thread Michael Niedermayer
On Mon, Dec 19, 2016 at 09:25:14AM +0100, Nicolas George wrote: > L'octidi 28 frimaire, an CCXXV, Michael Niedermayer a écrit : > > i know, but at the time all this closing down of the API happened it > > was said that this was temporary (not by you and i dont remember who > > said so and not limit

Re: [FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

2016-12-19 Thread Nicolas George
L'octidi 28 frimaire, an CCXXV, wm4 a écrit : > For buffersink, you could simply return a struct with the parameters. > As a value type, it'd be a copy and wouldn't need accessors. You mean a single structure returned by a single accessor with all the stream's properties instead of individual acce

Re: [FFmpeg-devel] [PATCH 6/6] lavfi: make AVFilterLink opaque in two major bumps.

2016-12-19 Thread Nicolas George
L'octidi 28 frimaire, an CCXXV, Michael Niedermayer a écrit : > i know, but at the time all this closing down of the API happened it > was said that this was temporary (not by you and i dont remember who > said so and not limited to libavfilter) and now over 4 years later > temporary seems to be ch