Re: [FFmpeg-devel] [PATCH] opus_celt: move quantization and band decoding to opus_pvq.c

2016-11-09 Thread Rostislav Pehlivanov
On 10 November 2016 at 03:13, Rostislav Pehlivanov wrote: > A huge amount can be reused by the encoder, as the only thing > which needs to be done would be to add a 10 line celt_icwrsi, > a wrapper around it (celt_alg_quant) and templating the > ff_celt_decode_band to replace entropy decoding fu

[FFmpeg-devel] [PATCH] opus_celt: move quantization and band decoding to opus_pvq.c

2016-11-09 Thread Rostislav Pehlivanov
A huge amount can be reused by the encoder, as the only thing which needs to be done would be to add a 10 line celt_icwrsi, a wrapper around it (celt_alg_quant) and templating the ff_celt_decode_band to replace entropy decoding functions with entropy encoding. There is no performance loss but in f

Re: [FFmpeg-devel] [PATCH v5] avformat/flvenc: add add_keyframe_index option

2016-11-09 Thread Steven Liu
2016-11-08 21:54 GMT+08:00 Michael Niedermayer : > On Tue, Nov 08, 2016 at 07:43:49PM +0800, Steven Liu wrote: > > Add keyframe index metadata > > Used to facilitate seeking; particularly for HTTP pseudo streaming. > > 1. read live streaming or file by sequence > > 2. if use add_keyframe_index o

Re: [FFmpeg-devel] [PATCH] pnmdec: make sure v is capped by maxval

2016-11-09 Thread Michael Niedermayer
On Wed, Nov 09, 2016 at 10:46:03PM +0100, Andreas Cadhalpun wrote: > On 09.11.2016 21:55, Michael Niedermayer wrote: > > On Wed, Nov 09, 2016 at 09:05:17PM +0100, Andreas Cadhalpun wrote: > >> On 09.11.2016 11:10, Michael Niedermayer wrote: > >>> On Wed, Nov 09, 2016 at 01:11:29AM +0100, Andreas Ca

[FFmpeg-devel] [PATCH] mov: extract stsd vendor field in metadata.

2016-11-09 Thread Zhenni Huang
Also updates fate ref for rgb24-mkv as the output video will contain the new metadata field and have different md5sum and file size. --- libavformat/mov.c| 18 -- tests/ref/fate/rgb24-mkv | 4 ++-- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/libavformat

[FFmpeg-devel] [PATCH] proresdec_lgpl: explicitly check coff[3] against slice_data_size

2016-11-09 Thread Andreas Cadhalpun
The implicit checks via v_data_size and a_data_size don't work in the case '(hdr_size > 7) && !ctx->alpha_info'. This fixes segmentation faults due to invalid reads. This problem was introduced in commit 547c2f002a87f4412a83c23b0d60364be5e7ce58. Signed-off-by: Andreas Cadhalpun --- libavcodec/

[FFmpeg-devel] [PATCH] pgssubdec: only set w/h/linesize when allocating data

2016-11-09 Thread Andreas Cadhalpun
Rects with positive w/h/linesize but no data are invalid. Signed-off-by: Andreas Cadhalpun --- libavcodec/pgssubdec.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/pgssubdec.c b/libavcodec/pgssubdec.c index cef477d..b50b37b 100644 --- a/libavcodec/pgssub

Re: [FFmpeg-devel] [PATCH] pnmdec: make sure v is capped by maxval

2016-11-09 Thread Andreas Cadhalpun
On 09.11.2016 21:55, Michael Niedermayer wrote: > On Wed, Nov 09, 2016 at 09:05:17PM +0100, Andreas Cadhalpun wrote: >> On 09.11.2016 11:10, Michael Niedermayer wrote: >>> On Wed, Nov 09, 2016 at 01:11:29AM +0100, Andreas Cadhalpun wrote: Otherwise put_bits can be called with a value that does

Re: [FFmpeg-devel] [PATCH] pnmdec: make sure v is capped by maxval

2016-11-09 Thread Michael Niedermayer
On Wed, Nov 09, 2016 at 09:05:17PM +0100, Andreas Cadhalpun wrote: > On 09.11.2016 11:10, Michael Niedermayer wrote: > > On Wed, Nov 09, 2016 at 01:11:29AM +0100, Andreas Cadhalpun wrote: > >> Otherwise put_bits can be called with a value that doesn't fit in the > >> sample_len, causing an assertio

Re: [FFmpeg-devel] [PATCH 2/2] iocodec: add ico_read_close to fix leaking ico->images

2016-11-09 Thread Andreas Cadhalpun
On 09.11.2016 17:27, Michael Niedermayer wrote: > On Wed, Nov 09, 2016 at 12:00:09AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/icodec.c | 8 >> 1 file changed, 8 insertions(+) > > LGTM with te typo fix Typo fixed and pushed. Best regards

Re: [FFmpeg-devel] [PATCH 1/2] icodec: fix leaking pkt on error

2016-11-09 Thread Andreas Cadhalpun
On 09.11.2016 17:25, Michael Niedermayer wrote: > On Tue, Nov 08, 2016 at 11:59:45PM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/icodec.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) > > should be ok Pushed (after rebasing). Best reg

Re: [FFmpeg-devel] [PATCH] escape124: reject codebook size 0

2016-11-09 Thread Andreas Cadhalpun
On 09.11.2016 11:12, Michael Niedermayer wrote: > On Wed, Nov 09, 2016 at 12:42:16AM +0100, Andreas Cadhalpun wrote: >> It causes a cb_depth of 32, leading to assertion failures in get_bits. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/escape124.c | 4 >> 1 file changed, 4 ins

Re: [FFmpeg-devel] [PATCH] pnmdec: make sure v is capped by maxval

2016-11-09 Thread Andreas Cadhalpun
On 09.11.2016 11:10, Michael Niedermayer wrote: > On Wed, Nov 09, 2016 at 01:11:29AM +0100, Andreas Cadhalpun wrote: >> Otherwise put_bits can be called with a value that doesn't fit in the >> sample_len, causing an assertion failure. >> --- >> libavcodec/pnmdec.c | 4 >> 1 file changed, 4 in

Re: [FFmpeg-devel] [PATCH] icodec: correctly check avio_read return value

2016-11-09 Thread Andreas Cadhalpun
On 09.11.2016 02:31, Michael Niedermayer wrote: > On Tue, Nov 08, 2016 at 11:36:58PM +0100, Andreas Cadhalpun wrote: >> It can read less than the requested amount, in which case buf contains >> uninitialized data, causing problems like segmentation faults later on. >> >> Signed-off-by: Andreas Cadh

Re: [FFmpeg-devel] [PATCH] dvbsubdec: fix division by zero in compute_default_clut

2016-11-09 Thread Andreas Cadhalpun
On 09.11.2016 02:27, Michael Niedermayer wrote: > On Tue, Nov 08, 2016 at 10:36:01PM +0100, Andreas Cadhalpun wrote: >> Since the loop goes down to i = 0 the number of iterations (variable >> count) is the original i, not i - 1. >> In the case of i originally being 1, this miscalculation resulted i

[FFmpeg-devel] [PATCH] lavc/alsdec: allow for predictor orders higher than block length which is valid in ALS.

2016-11-09 Thread Thilo Borgmann
Hi, fixes ticket #5297 reverting an old commit. -Thilo From 50f62f88696d1401d93c552d52fe1b9c396f8a00 Mon Sep 17 00:00:00 2001 From: Thilo Borgmann Date: Wed, 9 Nov 2016 20:00:02 +0100 Subject: [PATCH] lavc/alsdec: allow for predictor orders higher than block length which is valid in ALS. Rever

Re: [FFmpeg-devel] [PATCH] lavc/utils.c: Make sure skip_samples never goes negative.

2016-11-09 Thread Sasi Inguva
ping. On Sat, Nov 5, 2016 at 4:01 AM, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavcodec/utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index 87de15f..d6dca18 100644 > --- a/libavcodec/utils.c > +++ b/

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-09 Thread Sasi Inguva
I've modified the patch to fallback to rounding edit list media time to zero when it is negative, and added a strict_std_compliance check for edit lists. PTAL. Thanks. On Sun, Nov 6, 2016 at 7:07 PM, Derek Buitenhuis wrote: > On 11/6/2016 12:40 PM, Michael Niedermayer wrote: > > IMO we should su

[FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-09 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavformat/mov.c | 41 tests/fate/mov.mak | 6 +- tests/ref/fate/mp4-init-nonkeyframe | 120 3 files changed, 155 insertions(+), 12 deletions(-) create mode 100644 tests/ref/fa

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add myself to flvenc

2016-11-09 Thread Michael Niedermayer
On Wed, Nov 09, 2016 at 08:36:02AM +0800, Steven Liu wrote: > > Signed-off-by: Steven Liu > --- > MAINTAINERS |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Asymptotically faster alg

Re: [FFmpeg-devel] [PATCH 2/2] iocodec: add ico_read_close to fix leaking ico->images

2016-11-09 Thread Michael Niedermayer
On Wed, Nov 09, 2016 at 12:00:09AM +0100, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/icodec.c | 8 > 1 file changed, 8 insertions(+) LGTM with te typo fix thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is

Re: [FFmpeg-devel] [PATCH 1/2] icodec: fix leaking pkt on error

2016-11-09 Thread Michael Niedermayer
On Tue, Nov 08, 2016 at 11:59:45PM +0100, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/icodec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) should be ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Ever

Re: [FFmpeg-devel] [PATCH] Make the process for uuid-xmp data faster

2016-11-09 Thread Chen Meng
avio_skip(AVIOContext *s, int64_t offset) equals avio_seek(s, offset,  SEEK_CUR), of course, I have to say which has a better name. --From:Steven Liu Time:2016 Nov 9 (Wed) 21:00To:FFmpeg development discussions and patches Cc:Oliver

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/hap: add "compressor" option to Hap encoder to disable secondary compression

2016-11-09 Thread Tom Butterworth
Thanks Michael and Martin I'll push this and offer a new patch with documentation for the Hap encoder in doc/encoders.texi. On Wed, 9 Nov 2016 at 07:37 Martin Vignali wrote: > > > > > > Maybe can be useful, to have a log, > > > if chunk_count != 1 and compression is none, to show to the user, t

Re: [FFmpeg-devel] [PATCH] Make the process for uuid-xmp data faster

2016-11-09 Thread Steven Liu
2016-11-09 17:30 GMT+08:00 Chen Meng : > --- > libavformat/mov.c | 34 -- > 1 file changed, 20 insertions(+), 14 deletions(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index ca978c2..c358d17 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c

Re: [FFmpeg-devel] [PATCH] escape124: reject codebook size 0

2016-11-09 Thread Michael Niedermayer
On Wed, Nov 09, 2016 at 12:42:16AM +0100, Andreas Cadhalpun wrote: > It causes a cb_depth of 32, leading to assertion failures in get_bits. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/escape124.c | 4 > 1 file changed, 4 insertions(+) should be ok thx -- Michael GnuPG f

Re: [FFmpeg-devel] [PATCH] pnmdec: make sure v is capped by maxval

2016-11-09 Thread Michael Niedermayer
On Wed, Nov 09, 2016 at 01:11:29AM +0100, Andreas Cadhalpun wrote: > Otherwise put_bits can be called with a value that doesn't fit in the > sample_len, causing an assertion failure. > --- > libavcodec/pnmdec.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/pnmdec.c b/lib

Re: [FFmpeg-devel] [PATCH] Making process of uuid-xmp faster.

2016-11-09 Thread Chen Meng
Guess it because of the web-based mail client not pretty well for git patch.I'll try to mail a new patch by git directly.  --From:Michael Niedermayer Time:2016 Nov 9 (Wed) 17:10To:FFmpeg development discussions and patches Subject:R

[FFmpeg-devel] [PATCH] Make the process for uuid-xmp data faster

2016-11-09 Thread Chen Meng
--- libavformat/mov.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index ca978c2..c358d17 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4530,24 +4530,30 @@ static int mov_read_uuid(MOVCon

Re: [FFmpeg-devel] [PATCH 3/3] fate: Add h264 and hevc extradata reload tests

2016-11-09 Thread Michael Niedermayer
On Tue, Nov 08, 2016 at 10:39:41PM -0500, Vittorio Giovara wrote: > On Tue, Nov 8, 2016 at 7:15 PM, Michael Niedermayer > wrote: > > On Tue, Nov 08, 2016 at 05:03:28PM -0500, Vittorio Giovara wrote: > >> --- > >> Samples available at > >> - > >> https://www.dropbox.com/s/gkswnubzy6e6rgg/h264-extr

Re: [FFmpeg-devel] [PATCH] Making process of uuid-xmp faster.

2016-11-09 Thread Michael Niedermayer
On Wed, Nov 09, 2016 at 11:19:10AM +0800, Chen Meng wrote: > Sorry for that, I've taken code back into up-date master branch again.--- >  libavformat/mov.c | 34 -- >  1 file changed, 20 insertions(+), 14 deletions(-) the problem is not at the branch level, theres so