[FFmpeg-devel] [PATCH] libavcodec/dnxhd: Enable 12-bit DNxHR support.

2016-08-01 Thread Steven Robertson
10- and 12-bit DNxHR use the same DC coefficient decoding process and VLC table, just with a different shift value. From SMPTE 2019-1:2016, 8.2.4 DC Coefficient Decoding: "For 8-bit video sampling, the maximum value of η=11 and for 10-/12-bit video sampling, the maximum value of η=13." A sample f

[FFmpeg-devel] [PATCH] libavcodec/dnxhd: Enable 12-bit DNxHR support.

2016-08-01 Thread Steven Robertson
Apologies for the double-mail, Gmail didn't use the correct attachment type. Resending using git, hopefully. From the original message: DNxHR support for 12 bits wasn't waiting on a VLC table after all - there was just an improper dependence on the value of bitdepth. I've attached a patch and will

[FFmpeg-devel] [PATCH] libavcodec/dnxhd: Enable 12-bit DNxHR support.

2016-08-01 Thread Steven Robertson
Hey there, DNxHR support for 12 bits wasn't waiting on a VLC table after all - there was just an improper dependence on the value of bitdepth. I've attached a patch and will upload a reference file (Google Drive no-sign-in-required link below) as soon as the upload server's back up. https://drive

Re: [FFmpeg-devel] [PATCH] avfilter: Add new format for PSNR stats log

2016-08-01 Thread Lucas Cooper
I've sent a separate patch for the documentation but I'm not quite sure how to go about adding the FATE test. I've looked at a few examples but I don't see any existing tests for quality metrics or anything similar. The basics of how to add the test are clear enough but it's unclear whether there's

Re: [FFmpeg-devel] [PATCH 7/7] af_hdcd: Warn if there is any resampling or format conversion in the link chain

2016-08-01 Thread Michael Niedermayer
On Fri, Jul 29, 2016 at 12:36:22PM -0500, Burt P wrote: > HDCD is only encoded in s16@44100Hz. Scan the chain of AVFilterLinks > for any resampling or format conversion/truncation that might cause > problems for the filter and issue warnings. > > Signed-off-by: Burt P > --- > libavfilter/af_hdcd

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: Process stereo channels together, fix #5727

2016-08-01 Thread Michael Niedermayer
On Mon, Aug 01, 2016 at 02:28:39PM -0500, Burt P wrote: > Issue #5727: gain adjustment should only be applied if matching > gain value from a valid packet in both channels. The existing functions > process > each channel separately, so it was not possible. > > * New versions of hdcd_process(), hd

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: return AVERROR(EIO) rather than AVERROR_EOF on parse error

2016-08-01 Thread Sophia Wang
Thanks for the quick response. matroska_resync() is currently written to only return AVERROR_EOF, so using that error code directly wouldn't be any more informative. But your suggestion would work if matroska_resync() kept the error code returned by avio_seek(). Would such a change warrant splittin

[FFmpeg-devel] How to force key frame for h264_qsv encoder?

2016-08-01 Thread Chao Liu
Hi, Looks like h264_qsv doesn't respect AVFrame.pict_type now. It always encodes to non-key frames except for the first frame. Is this a bug of ffmpeg or QSV doesn't support key frames? Command I use: ffmpeg -debug_ts -i orig.mp4 -force_key_frames 'expr:gte(t,n_forced)' -look_ahead 0 -c:v h264_qsv

[FFmpeg-devel] [PATCHv2] af_hdcd: Process stereo channels together, fix #5727

2016-08-01 Thread Burt P
Issue #5727: gain adjustment should only be applied if matching gain value from a valid packet in both channels. The existing functions process each channel separately, so it was not possible. * New versions of hdcd_process(), hdcd_scan(), hdcd_integrate() named hdcd_*_stereo() that process both

Re: [FFmpeg-devel] Change bitrate on-the-fly

2016-08-01 Thread Bodecs Bela
2016.08.01. 19:46 keltezéssel, Aman Gupta írta: I would find your patch useful and am looking forward to reviewing it. Using a socket isn't a bad way to do it IMHO- it's portable and allows easy integration from any language. Another option would be to extend the existing ffmpeg interactive mo

Re: [FFmpeg-devel] [PATCH 6/7] af_hdcd: Process stereo channels together, fix #5727

2016-08-01 Thread Michael Niedermayer
On Fri, Jul 29, 2016 at 12:36:21PM -0500, Burt P wrote: > Issue #5727: gain adjustment should only be applied if matching > gain value from a valid packet in both channels. The existing functions > process > each channel separately, so it was not possible. > > * New versions of hdcd_process(), hd

Re: [FFmpeg-devel] [PATCH 5/7] af_hdcd: Move code detect/check into own function

2016-08-01 Thread Michael Niedermayer
On Fri, Jul 29, 2016 at 12:36:20PM -0500, Burt P wrote: > Signed-off-by: Burt P > --- > libavfilter/af_hdcd.c | 86 > +++ > 1 file changed, 60 insertions(+), 26 deletions(-) applied at maintainers request thx [...] -- Michael GnuPG fingerpr

Re: [FFmpeg-devel] [PATCH 4/7] af_hdcd: add force_pe filter option

2016-08-01 Thread Michael Niedermayer
On Fri, Jul 29, 2016 at 12:36:19PM -0500, Burt P wrote: > Used to attempt replication of some results from > http://www.audiomisc.co.uk/HFN/HDCD/Examined.html > May not be generally useful, defaults to off. > > Signed-off-by: Burt P > --- > libavfilter/af_hdcd.c | 26 ++ >

Re: [FFmpeg-devel] [PATCH 3/7] af_hdcd: Improve error detection logging

2016-08-01 Thread Michael Niedermayer
On Fri, Jul 29, 2016 at 12:36:18PM -0500, Burt P wrote: > * Moves the filter context member out of state and into HDCDContext > * More useful information when an error is detected > * Gives a location near where the error was detected > > Signed-off-by: Burt P > --- > libavfilter/af_hdcd.c | 34

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add myself for af_hdcd

2016-08-01 Thread Michael Niedermayer
On Sun, Jul 31, 2016 at 10:47:20AM -0500, Burt P wrote: > Signed-off-by: Burt P > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB While the State exists there can be no freedom; when there

Re: [FFmpeg-devel] Change bitrate on-the-fly

2016-08-01 Thread Aman Gupta
I would find your patch useful and am looking forward to reviewing it. Using a socket isn't a bad way to do it IMHO- it's portable and allows easy integration from any language. Another option would be to extend the existing ffmpeg interactive mode to handle your new command. Currently ffmpeg allo

[FFmpeg-devel] [PATCH] Add stats_version documentation to PSNR filter

2016-08-01 Thread Lucas Cooper
--- doc/filters.texi | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index c47dfee..923d481 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -10692,13 +10692,31 @@ The description of the accepted parameters follows

[FFmpeg-devel] af_hdcd: add flags to AVOption defs

2016-08-01 Thread Burt P
Fix for options not showing up in ffmpeg --help filter=hdcd Apply after the earlier set of 7 patches where options were introduced. -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] af_hdcd: add flags to AVOption defs

2016-08-01 Thread Burt P
Signed-off-by: Burt P --- libavfilter/af_hdcd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c index 2d7fe8d..7c90861 100644 --- a/libavfilter/af_hdcd.c +++ b/libavfilter/af_hdcd.c @@ -903,11 +903,12 @@ typedef struct HDCDCon

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_parser: Check the input frame sizes for being consistent

2016-08-01 Thread Michael Niedermayer
On Mon, Aug 01, 2016 at 02:28:34PM +0200, Michael Niedermayer wrote: > Suggested-by: BBB > Fixed-by: BBB > Signed-off-by: Michael Niedermayer > --- > libavcodec/vp9_parser.c | 17 + > 1 file changed, 17 insertions(+) applied thanks [...] -- Michael GnuPG fingerprint: 9FF

[FFmpeg-devel] [PATCH] avcodec/vp9_parser: Check the input frame sizes for being consistent

2016-08-01 Thread Michael Niedermayer
Suggested-by: BBB Fixed-by: BBB Signed-off-by: Michael Niedermayer --- libavcodec/vp9_parser.c | 17 + 1 file changed, 17 insertions(+) diff --git a/libavcodec/vp9_parser.c b/libavcodec/vp9_parser.c index 2e9235e..9900e7a 100644 --- a/libavcodec/vp9_parser.c +++ b/libavcodec/vp