Re: [FFmpeg-devel] Libavcodec/exr : add support for tile

2016-04-22 Thread James Almer
On 4/4/2016 3:40 PM, Paul B Mahol wrote: > On 4/4/16, Martin Vignali wrote: >> 2016-04-03 17:38 GMT+02:00 Paul B Mahol : >> >>> On 4/3/16, Martin Vignali wrote: 2016-04-03 17:12 GMT+02:00 Paul B Mahol : > On 4/3/16, Martin Vignali wrote: >> Hello, >> >> In attach a patc

Re: [FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-04-22 Thread Hendrik Leppkes
On Sat, Apr 23, 2016 at 1:02 AM, Bruce Dawson wrote: > I've noticed that when CONFIG_W64_DEMUXER is defined to zero that ffmpeg > compiles in a reference to ff_w64_guid_data but doesn't not link w64.o > (which defines that symbol). > > This normally works because most optimizers discard the refere

[FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-04-22 Thread Bruce Dawson
I've noticed that when CONFIG_W64_DEMUXER is defined to zero that ffmpeg compiles in a reference to ff_w64_guid_data but doesn't not link w64.o (which defines that symbol). This normally works because most optimizers discard the reference to ff_w64_guid_data early enough to not cause a linker fail

[FFmpeg-devel] [PATCH] pgssubdec: fix subpicture output colorspace and range

2016-04-22 Thread Jan Ekström
Functionality used before didn't widen the values from limited to full range. Additionally, now the decoder uses BT.709 where it should be used according to the video resolution. Default for not yet set colorimetry is BT.709 due to most observed HDMV content being HD. BT.709 coefficients were gat

Re: [FFmpeg-devel] [PATCH v11 3/3][GSOC] avformat/tee: Handling slave failure in tee muxer

2016-04-22 Thread Marton Balint
On Thu, 21 Apr 2016, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky Adds per slave option 'onfail' to the tee muxer allowing an output to fail,so other slave outputs can continue. Signed-off-by: Jan Sebechlebsky --- Changes from last version: -> Use av_err2str in tee_process_sla

Re: [FFmpeg-devel] [PATCH v10 2/3][GSOC] avformat/tee: Fix leaks in tee muxer when open_slave fails

2016-04-22 Thread Marton Balint
On Fri, 22 Apr 2016, Nicolas George wrote: Le duodi 2 floréal, an CCXXIV, sebechlebsky...@gmail.com a écrit : From: Jan Sebechlebsky In open_slave failure can happen before bsfs array is initialized, close_slave must check that bsfs is not NULL before accessing tee_slave->bsfs[i] element. S

[FFmpeg-devel] [PATCH] make debug output for bitrate more meaningful

2016-04-22 Thread Gerion Entrup
Currently on audio tracks: Applying option b:a (video bitrate (please use -b:v)) with argument 240k. but b:a is the recommendation: Applying option ab (audio bitrate (please use -b:a)) with argument 240k. Feel free to change the new string. Gerion>From ddc4a7af0b355a03775ea76fa192004028cead27 Mo

Re: [FFmpeg-devel] [PATCH 3/3] configure: Remove -Wredundant-decls on OS/2 to suppress noise.

2016-04-22 Thread Dave Yeo
On 04/20/16 11:46 PM, Reimar Döffinger wrote: On 21.04.2016, at 06:02, Dave Yeo wrote: On 04/20/16 07:40 PM, Michael Niedermayer wrote: On Thu, Apr 14, 2016 at 07:31:48PM -0700, Dave Yeo wrote: From a417fdf752bd7c704ed5ba0c94c5cea96e1a91ff Mon Sep 17 00:00:00 2001 From: Dmitriy Kuminov Dat

[FFmpeg-devel] [PATCH v2 06/12] lavc/videotoolboxenc: Fix DTS

2016-04-22 Thread Rick Kern
Some devices output an invalid DTS when B-frames aren't used. Using PTS for the DTS in this case. Signed-off-by: Rick Kern --- libavcodec/videotoolboxenc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 6a9a2fe..5594

[FFmpeg-devel] [PATCH v2 12/12] lavc/videotoolboxenc: Set colorimetry values

2016-04-22 Thread Rick Kern
Signed-off-by: Rick Kern --- configure| 5 +- libavcodec/videotoolboxenc.c | 209 +++ 2 files changed, 213 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 97f374b..c484a10 100755 --- a/configure +++ b/configure @

[FFmpeg-devel] [PATCH v2 11/12] lavc/videotoolboxenc: Support pixel aspect ratio

2016-04-22 Thread Rick Kern
Signed-off-by: Rick Kern --- libavcodec/videotoolboxenc.c | 63 1 file changed, 63 insertions(+) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 5935d09..768405d 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec

[FFmpeg-devel] [PATCH v2 07/12] lavc/videotoolboxenc: Handle out-of-memory and fix memory leak

2016-04-22 Thread Rick Kern
Signed-off-by: Rick Kern --- libavcodec/videotoolboxenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 5594e69..073b87a 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videotoolboxenc.c @@ -728,9 +728,12 @@ sta

[FFmpeg-devel] [PATCH v2 05/12] lavc/videotoolboxenc: Fix AVCodecContext.has_b_frames usage.

2016-04-22 Thread Rick Kern
Now set by the encoder, not used as an input parameter. Signed-off-by: Rick Kern --- libavcodec/videotoolboxenc.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 07577b6..6a9a2fe 100644 --- a/li

[FFmpeg-devel] [PATCH v2 10/12] lavc/videotoolboxenc: Support for forced I-frames

2016-04-22 Thread Rick Kern
Setting AVFrame.pic_type to AV_PICTURE_TYPE_I will force an I-frame. Signed-off-by: Rick Kern --- libavcodec/videotoolboxenc.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index c630825.

[FFmpeg-devel] [PATCH v2 09/12] lavc/videotoolboxenc: add concatentation properties

2016-04-22 Thread Rick Kern
Add frames_before and frames_after as hints that there will be frames before or after the frames produced in this session. This may help with concatenation issues like bit rate spikes. Signed-off-by: Rick Kern --- libavcodec/videotoolboxenc.c | 30 ++ 1 file changed,

[FFmpeg-devel] [PATCH v2 08/12] lavc/videotoolboxenc: Add realtime encoding property

2016-04-22 Thread Rick Kern
Hint to the encoder that encoding should be done in real-time, even at the expense of quality. Signed-off-by: Rick Kern --- libavcodec/videotoolboxenc.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 073b87a..

[FFmpeg-devel] [PATCH v2 04/12] lavc/videotoolboxenc: Add entropy setting

2016-04-22 Thread Rick Kern
Add an entropy setting to choose between CAVLC and CABAC. Signed-off-by: Rick Kern --- libavcodec/videotoolboxenc.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index ec69bb1..07577b6 100644 --- a

[FFmpeg-devel] [PATCH v2 02/12] lavc/videotoolboxenc: Handle hwaccel format as input

2016-04-22 Thread Rick Kern
Handle AV_PIX_FMT_VIDEOTOOLBOX. This results in better energy usage and faster encoding, especially on iOS. When the buffer comes from the media server, no memcpy's are needed. Signed-off-by: Rick Kern --- libavcodec/videotoolboxenc.c | 26 +- 1 file changed, 21 insertion

[FFmpeg-devel] [PATCH v2 03/12] lavc/videotoolboxenc: Require hardware encoding

2016-04-22 Thread Rick Kern
Software encoding can be allowed by setting allow_sw to 1. Signed-off-by: Rick Kern --- libavcodec/videotoolboxenc.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index

[FFmpeg-devel] [PATCH v2 00/12] videotoolbox encoder features and fixes

2016-04-22 Thread Rick Kern
Sorry for the delay. The commit for the keyframes_only property was removed - this was already supported with -g 1. Rick Kern (12): lavc/videotoolboxenc: Use shared pixel buffer pool lavc/videotoolboxenc: Handle hwaccel format as input lavc/videotoolboxenc: Require hardware encoding lavc/

[FFmpeg-devel] [PATCH v2 01/12] lavc/videotoolboxenc: Use shared pixel buffer pool

2016-04-22 Thread Rick Kern
This reduces the chance of a memcpy in the media server. Signed-off-by: Rick Kern --- libavcodec/videotoolboxenc.c | 224 ++- 1 file changed, 180 insertions(+), 44 deletions(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index

Re: [FFmpeg-devel] [PATCH 13/13] lavc/videotoolboxenc: Set colorimetry values

2016-04-22 Thread Richard Kern
> On Apr 10, 2016, at 12:27 AM, Carl Eugen Hoyos wrote: > > Rick Kern gmail.com> writes: > >> +enabled kCVImageBufferColorPrimaries_ITU_R_2020 && >> add_cppflags -DHAVE_VT_BT2020_KEYS > > This is not ok, the define should be added to config.h. > >> +#ifndef HAVE_VT_BT2020_KEYS >> +# define

Re: [FFmpeg-devel] [PATCH 12/13] lavc/videotoolboxenc: Support pixel aspect ratio

2016-04-22 Thread Richard Kern
> On Apr 10, 2016, at 12:24 AM, Carl Eugen Hoyos wrote: > > Rick Kern gmail.com> writes: > >> +if (status) { >> +av_log( >> + avctx, >> + AV_LOG_ERROR, >> + "Error setting pixel aspect ratio to %d:%d: %d.\n", > > Why wo

Re: [FFmpeg-devel] [PATCH v10 2/3][GSOC] avformat/tee: Fix leaks in tee muxer when open_slave fails

2016-04-22 Thread Nicolas George
Le duodi 2 floréal, an CCXXIV, sebechlebsky...@gmail.com a écrit : > From: Jan Sebechlebsky > > In open_slave failure can happen before bsfs array is initialized, > close_slave must check that bsfs is not NULL before accessing > tee_slave->bsfs[i] element. > > Slave muxer expects write_trailer t

Re: [FFmpeg-devel] libavfilter API design in a realtime environment

2016-04-22 Thread Nicolas George
Le quartidi 4 floréal, an CCXXIV, Paul B Mahol a écrit : > This is really, really bad. Frame do should have duration. And audio > ones do have. I used to think that, but after more careful thought I no longer do. Audio frames have a number samples, they can not work without and that gives us the

Re: [FFmpeg-devel] Line endings in Makefiles

2016-04-22 Thread Dave Yeo
On 04/22/16 05:45 AM, compn wrote: On Fri, 22 Apr 2016 07:52:56 +0200 Andreas Weis wrote: here) there are no drawbacks arising from the change. if we have mismatched line endings in makefiles it might screw up anyone wishing to make patches if their git has changed the line endings. i cant

Re: [FFmpeg-devel] [PATCH] avcodec/utils: do_decode: Assert that the decoder return value is not larger than the packet size

2016-04-22 Thread wm4
On Fri, 22 Apr 2016 11:59:14 +0200 Michael Niedermayer wrote: > On Fri, Apr 22, 2016 at 09:11:52AM +0200, wm4 wrote: > > On Fri, 22 Apr 2016 05:14:30 +0200 > > Michael Niedermayer wrote: > > > > > Signed-off-by: Michael Niedermayer > > > --- > > > libavcodec/utils.c |1 + > > > 1 file c

Re: [FFmpeg-devel] Line endings in Makefiles

2016-04-22 Thread compn
On Fri, 22 Apr 2016 07:52:56 +0200 Andreas Weis wrote: > here) there are no drawbacks arising from the change. if we have mismatched line endings in makefiles it might screw up anyone wishing to make patches if their git has changed the line endings. i cant remember if this is a problem however

Re: [FFmpeg-devel] [PATCH 2/3] configure: Do not create/install versioned DLLs on OS/2.

2016-04-22 Thread Dmitriy Kuminov
On 2016-04-21 00:05:57 +, Michael Niedermayer said: On Thu, Apr 21, 2016 at 01:48:22AM +0300, Dmitriy Kuminov wrote: you all want the same, a perfect solution iam sure you can reach some consensus about what to do and work together to do it. Iam happy to apply whatever patch the OS/2 people

Re: [FFmpeg-devel] libavfilter API design in a realtime environment

2016-04-22 Thread Paul B Mahol
On 4/19/16, Nicolas George wrote: > Le septidi 27 ventose, an CCXXIV, Kieran Kunhya a ecrit : >> I want to try and use the libavfilter API to overlay bitmap subtitles on >> video from a realtime source. This seems difficult/impossible to do with >> the current API hence asking on the main devel li

Re: [FFmpeg-devel] [PATCH] avcodec/utils: do_decode: Assert that the decoder return value is not larger than the packet size

2016-04-22 Thread Michael Niedermayer
On Fri, Apr 22, 2016 at 09:11:52AM +0200, wm4 wrote: > On Fri, 22 Apr 2016 05:14:30 +0200 > Michael Niedermayer wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/utils.c |1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/libavcodec/utils.c b/libavcodec/utils

Re: [FFmpeg-devel] [PATCH] avcodec/utils: do_decode: Assert that the decoder return value is not larger than the packet size

2016-04-22 Thread wm4
On Fri, 22 Apr 2016 05:14:30 +0200 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/utils.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index 52e0d92..b35fabc 100644 > --- a/libavcodec/utils.c > +++ b/l