Re: [FFmpeg-devel] [PATCH] lavfi/af_aemphasis: remove unnecessary complex number usage

2015-12-22 Thread Paul B Mahol
On 12/22/15, Ganesh Ajjanagadde wrote: > On Tue, Dec 22, 2015 at 2:10 PM, Paul B Mahol wrote: >> On 12/22/15, Ganesh Ajjanagadde wrote: >>> On Tue, Dec 22, 2015 at 12:46 AM, Paul B Mahol wrote: On 12/22/15, Ganesh Ajjanagadde wrote: > complex is not available on all platforms. Further

Re: [FFmpeg-devel] [PATCH] lavu/libm: add exp10 support

2015-12-22 Thread Ganesh Ajjanagadde
On Tue, Dec 22, 2015 at 4:17 PM, Hendrik Leppkes wrote: > On Wed, Dec 23, 2015 at 12:29 AM, Ganesh Ajjanagadde > wrote: >> exp10 is a function available in GNU libm. Looks like no other common >> libm has it. This adds support for it to FFmpeg. >> >> There are essentially 2 ways of handling the f

Re: [FFmpeg-devel] [PATCH] lavu/libm: add exp10 support

2015-12-22 Thread Hendrik Leppkes
On Wed, Dec 23, 2015 at 12:29 AM, Ganesh Ajjanagadde wrote: > exp10 is a function available in GNU libm. Looks like no other common > libm has it. This adds support for it to FFmpeg. > > There are essentially 2 ways of handling the fallback: > 1. Using pow(10, x) > 2. Using exp2(M_LOG2_10 * x). >

[FFmpeg-devel] [PATCH] lavu/libm: add exp10 support

2015-12-22 Thread Ganesh Ajjanagadde
exp10 is a function available in GNU libm. Looks like no other common libm has it. This adds support for it to FFmpeg. There are essentially 2 ways of handling the fallback: 1. Using pow(10, x) 2. Using exp2(M_LOG2_10 * x). First one represents a Pareto improvement, with no speed or accuracy regr

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2015-12-22 Thread Dave Rice
> On Dec 20, 2015, at 9:28 AM, Matthias Hunstock wrote: > > Am 20.12.2015 um 15:11 schrieb Nicolas George: >> Le decadi 30 frimaire, an CCXXIV, Matthias Hunstock a écrit : >>> Decklink cards actually do just some bitbanging: take digital input in >>> "raw" format (AFAIK UYVY422 10 bit, PCM 16bit

[FFmpeg-devel] [RFC] [PATCH] mp3: keep gapless information on stream-copy

2015-12-22 Thread Andreas Cadhalpun
Fixes Debian bug #797965, https://bugs.debian.org/797965 --- This can't be used as is, because it requires copying private stream fields in ffmpeg.c. Also the duplication between codec->initial_padding and st->start_skip_samples is less than ideal. Does someone have a better idea how to fix this?

Re: [FFmpeg-devel] [PATCH] lavfi/af_aemphasis: remove unnecessary complex number usage

2015-12-22 Thread Ganesh Ajjanagadde
On Tue, Dec 22, 2015 at 2:10 PM, Paul B Mahol wrote: > On 12/22/15, Ganesh Ajjanagadde wrote: >> On Tue, Dec 22, 2015 at 12:46 AM, Paul B Mahol wrote: >>> On 12/22/15, Ganesh Ajjanagadde wrote: complex is not available on all platforms. Furthermore, it is trivial to rewrite complex nu

Re: [FFmpeg-devel] [PATCH] lavfi/af_aemphasis: remove unnecessary complex number usage

2015-12-22 Thread Paul B Mahol
On 12/22/15, Ganesh Ajjanagadde wrote: > On Tue, Dec 22, 2015 at 12:46 AM, Paul B Mahol wrote: >> On 12/22/15, Ganesh Ajjanagadde wrote: >>> complex is not available on all platforms. Furthermore, it is trivial to >>> rewrite complex number expressions to real arithmetic, and in fact >>> sometim

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-22 Thread Eran Kornblau
> you are not subscribed (with this email address you used here at least > it seems) > Right, apparently the subscription confirmation message went to the junk folder... Anyway, glad this one is now resolved :-) and sorry for the trouble. > > > > > > > +id = mov_codec_id(st, format); > > > >

Re: [FFmpeg-devel] [PATCH] palettized QuickTime video in Matroska, round 3

2015-12-22 Thread Mats Peterson
On 12/22/2015 09:50 PM, Mats Peterson wrote: OK, Michael (among others), I have changed the name from get_qtpalette() to ff_get_qtpalette(). I've also added a *pb (AVIOContext) parameter to the ff_get_qtpalette() function, since one has to consume the full sample description when called from mov.

[FFmpeg-devel] [PATCH] palettized QuickTime video in Matroska, round 3

2015-12-22 Thread Mats Peterson
OK, Michael (among others), I have changed the name from get_qtpalette() to ff_get_qtpalette(). I've also added a *pb (AVIOContext) parameter to the ff_get_qtpalette() function, since one has to consume the full sample description when called from mov.c. This wasn't done before. In matroskadec.

Re: [FFmpeg-devel] [PATCH] avcodec/s302menc: set supported channel layouts by codec

2015-12-22 Thread Paul B Mahol
On 12/22/15, Kieran Kunhya wrote: > On 20 December 2015 at 00:14, Michael Niedermayer > wrote: >> On Sat, Dec 19, 2015 at 09:35:19PM +0100, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> --- >>> libavcodec/s302menc.c | 5 + >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/l

[FFmpeg-devel] [PATCH] lavu: add pthread asserts if ASSERT_LEVEL>1

2015-12-22 Thread Clément Bœsch
--- libavutil/thread.h | 96 ++ 1 file changed, 96 insertions(+) diff --git a/libavutil/thread.h b/libavutil/thread.h index 3d15737..0bb745e 100644 --- a/libavutil/thread.h +++ b/libavutil/thread.h @@ -30,6 +30,102 @@ #if HAVE_PTHREADS #incl

Re: [FFmpeg-devel] [PATCH][RFC] lavu/libm: add exp10 support

2015-12-22 Thread Ganesh Ajjanagadde
On Tue, Dec 22, 2015 at 11:34 AM, Ronald S. Bultje wrote: > Hi, > > On Tue, Dec 22, 2015 at 12:48 PM, Ganesh Ajjanagadde > wrote: >> >> On Tue, Dec 22, 2015 at 8:04 AM, Ganesh Ajjanagadde >> wrote: >> > On Tue, Dec 22, 2015 at 3:35 AM, Michael Niedermayer >> > wrote: >> [...] >> >> >> >> IMHO a

Re: [FFmpeg-devel] [PATCH][RFC] lavu/libm: add exp10 support

2015-12-22 Thread Ronald S. Bultje
Hi, On Tue, Dec 22, 2015 at 12:48 PM, Ganesh Ajjanagadde wrote: > On Tue, Dec 22, 2015 at 8:04 AM, Ganesh Ajjanagadde > wrote: > > On Tue, Dec 22, 2015 at 3:35 AM, Michael Niedermayer > > wrote: > [...] > >> > >> IMHO a exp10 fallback should be implemented using exp2() if that is > faster > >>

Re: [FFmpeg-devel] [PATCH] diracdec: add missing check for pixel_range_index

2015-12-22 Thread Andreas Cadhalpun
On 22.12.2015 20:12, Kieran Kunhya wrote: > On 22 December 2015 at 19:04, Andreas Cadhalpun > wrote: >> This fixes an out-of-bounds read introduced in commit 0379603. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/dirac.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git

Re: [FFmpeg-devel] [PATCH 06/11] diracdec: Add 10-bits to pix_fmt table

2015-12-22 Thread Kieran Kunhya
On 22 December 2015 at 19:04, Andreas Cadhalpun wrote: > On 16.12.2015 22:59, Kieran Kunhya wrote: >>> this is maybe missing a < 2 check >>> i see a > 4 check but didnt find a < 2 check from a quick look >> >> The check already exists. > > And where exactly can it be found? > > Spoiler: There is n

Re: [FFmpeg-devel] [PATCH] diracdec: add missing check for pixel_range_index

2015-12-22 Thread Kieran Kunhya
On 22 December 2015 at 19:04, Andreas Cadhalpun wrote: > This fixes an out-of-bounds read introduced in commit 0379603. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/dirac.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/dirac.c b/libavcodec/dirac.c > index 33cc

[FFmpeg-devel] [PATCH] diracdec: add missing check for pixel_range_index

2015-12-22 Thread Andreas Cadhalpun
This fixes an out-of-bounds read introduced in commit 0379603. Signed-off-by: Andreas Cadhalpun --- libavcodec/dirac.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/dirac.c b/libavcodec/dirac.c index 33cc960..faf5534 100644 --- a/libavcodec/dirac.c +++ b/libavcodec/dirac.c @@

Re: [FFmpeg-devel] [PATCH 06/11] diracdec: Add 10-bits to pix_fmt table

2015-12-22 Thread Andreas Cadhalpun
On 16.12.2015 22:59, Kieran Kunhya wrote: >> this is maybe missing a < 2 check >> i see a > 4 check but didnt find a < 2 check from a quick look > > The check already exists. And where exactly can it be found? Spoiler: There is no such check... Best regards, Andreas ___

Re: [FFmpeg-devel] [PATCH 2/3] mlvdec: validate bits_per_coded_sample

2015-12-22 Thread Andreas Cadhalpun
On 21.12.2015 02:18, Michael Niedermayer wrote: > On Sun, Dec 20, 2015 at 12:15:17PM +0100, Andreas Cadhalpun wrote: >> mlvdec.c | 12 >> 1 file changed, 12 insertions(+) >> 9870daae0ba6a9c826563645319ee38c694025e8 >> 0002-mlvdec-validate-bits_per_coded_sample.patch >> From 66a3af

Re: [FFmpeg-devel] [PATCH][RFC] lavu/libm: add exp10 support

2015-12-22 Thread Ganesh Ajjanagadde
On Tue, Dec 22, 2015 at 8:04 AM, Ganesh Ajjanagadde wrote: > On Tue, Dec 22, 2015 at 3:35 AM, Michael Niedermayer > wrote: [...] >> >> IMHO a exp10 fallback should be implemented using exp2() if that is faster >> and available. > > I don't know whether the fallback should use exp or exp2, need to

Re: [FFmpeg-devel] [PATCH] libavformat: palettized QuickTime in Matroska, round 2

2015-12-22 Thread Mats Peterson
On 12/22/2015 05:15 PM, Michael Niedermayer wrote: On Tue, Dec 22, 2015 at 03:55:48AM +0100, Mats Peterson wrote: Alright, this is take two of my fix for palettized QuickTime video in Matroska. I have reset the lower limit of V_QUICKTIME private data to 21 in matroskadec.c, in order to make that

Re: [FFmpeg-devel] [libav-commits] checkasm: add fmtconvert tests

2015-12-22 Thread Janne Grunau
On 2015-12-21 19:06:15 +0100, Janne Grunau wrote: > Module: libav > Branch: master > Commit: 489e6add4478b0f5717dbf644234c6f3a3baf02c > > Author:Janne Grunau > Committer: Janne Grunau > Date: Tue Dec 8 16:24:57 2015 +0100 > > checkasm: add fmtconvert tests This test fails unfortunat

Re: [FFmpeg-devel] [PATCH] avcodec/s302menc: set supported channel layouts by codec

2015-12-22 Thread Kieran Kunhya
On 20 December 2015 at 00:14, Michael Niedermayer wrote: > On Sat, Dec 19, 2015 at 09:35:19PM +0100, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/s302menc.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/libavcodec/s302menc.c b/libavcodec/s302menc.c >

Re: [FFmpeg-devel] [PATCHv2] lavu/libm: add erf hack and make dynaudnorm available everywhere

2015-12-22 Thread Ganesh Ajjanagadde
On Mon, Dec 21, 2015 at 10:54 PM, Clément Bœsch wrote: > On Mon, Dec 21, 2015 at 08:31:47PM -0800, Ganesh Ajjanagadde wrote: > [...] >> I unfortunately do not see an easy solution to avfilter testing in >> general: Paul [...] > > The problem with testing filters is not even remotely close to Paul;

Re: [FFmpeg-devel] [PATCH] libavformat: palettized QuickTime in Matroska, round 2

2015-12-22 Thread Michael Niedermayer
On Tue, Dec 22, 2015 at 03:55:48AM +0100, Mats Peterson wrote: > Alright, this is take two of my fix for palettized QuickTime video > in Matroska. I have reset the lower limit of V_QUICKTIME private > data to 21 in matroskadec.c, in order to make that broken file pass, > Michael. The minimum size o

Re: [FFmpeg-devel] [PATCH] lavfi/af_aemphasis: remove unnecessary complex number usage

2015-12-22 Thread Ganesh Ajjanagadde
On Tue, Dec 22, 2015 at 12:46 AM, Paul B Mahol wrote: > On 12/22/15, Ganesh Ajjanagadde wrote: >> complex is not available on all platforms. Furthermore, it is trivial to >> rewrite complex number expressions to real arithmetic, and in fact >> sometimes advantageous for performance reasons: by wr

Re: [FFmpeg-devel] [PATCHv2] lavu/libm: add erf hack and make dynaudnorm available everywhere

2015-12-22 Thread Ganesh Ajjanagadde
On Tue, Dec 22, 2015 at 12:15 AM, Hendrik Leppkes wrote: > Am 21.12.2015 18:18 schrieb "James Almer" : >> >> On 12/21/2015 2:08 PM, Ganesh Ajjanagadde wrote: >> > Pushed with slight modifications. >> > >> > This is a request to any running MSVC/other platform lacking erf: can >> > you please test

Re: [FFmpeg-devel] [PATCH][RFC] lavu/libm: add exp10 support

2015-12-22 Thread Ganesh Ajjanagadde
On Tue, Dec 22, 2015 at 3:35 AM, Michael Niedermayer wrote: > On Mon, Dec 21, 2015 at 07:19:50PM -0800, Ganesh Ajjanagadde wrote: >> exp10 is a function available in GNU libm. Looks like no other common >> libm has it. As such, I am mostly neutral about its inclusion, with a >> very slight bias in

Re: [FFmpeg-devel] phasing out asyntcs, resample

2015-12-22 Thread Nicolas George
Le duodi 2 nivôse, an CCXXIV, Rostislav Pehlivanov a écrit : > Also, I think that it's better to just send a patch which removes them > instead of only warning and then let the discussion go on there. Agreed, but such a patch would need to have a documentation side, to explain to users of the remo

Re: [FFmpeg-devel] [PATCH]lavfi/decimate: Do not drop first frame

2015-12-22 Thread Nicolas George
Le decadi 30 frimaire, an CCXXIV, Carl Eugen Hoyos a écrit : > > Can you explain? > The first frame still gets dropped with your patch > attached. > > > It worked when I submitted it, I think. > You think? Yes, I think so. And I just checked. Command-line: ./ffmpeg_g -lavfi testsrc2=r=4:d=5,fp

Re: [FFmpeg-devel] [PATCH 3/5] lavfi: deprecate avfilter_link_set_closed().

2015-12-22 Thread Nicolas George
Le tridi 13 frimaire, an CCXXIV, Nicolas George a écrit : > Will push the series soon if nobody objects and start working on the next > step. > > Thanks everybody for the reviews. Series pushed. Thanks again. Regards, -- Nicolas George signature.asc Description: Digital signature _

Re: [FFmpeg-devel] can't build the ffmpeg for iOS using the newest gas-preprocessor.pl

2015-12-22 Thread Michael Niedermayer
On Tue, Dec 22, 2015 at 08:38:29PM +0800, zhuhb wrote: > I download the newest gas-preprocessor.pl from > https://github.com/ffmpeg/gas-preprocessor and install it to the path. > > Then I try to build the ffmpeg v2.7.1 and failed. > > > > The build .sh is as follows: > > SDKVERSION="" > > M

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-22 Thread Michael Niedermayer
On Tue, Dec 22, 2015 at 07:36:41AM +, Eran Kornblau wrote: > > > You're right, didn't know that. > > > Please let me know if there are any changes you want me to apply in order > > > to push the third one (decryption support). > > > > sounds like you missed: > > http://ffmpeg.org/pipermail/ff

[FFmpeg-devel] can't build the ffmpeg for iOS using the newest gas-preprocessor.pl

2015-12-22 Thread zhuhb
I download the newest gas-preprocessor.pl from https://github.com/ffmpeg/gas-preprocessor and install it to the path. Then I try to build the ffmpeg v2.7.1 and failed. The build .sh is as follows: SDKVERSION="" MIN_IPHONE_VERSION="5.1" ARCHS="armv7 arm64" DEVELOPER=`xcode-select -pr

Re: [FFmpeg-devel] [PATCH][RFC] lavu/libm: add exp10 support

2015-12-22 Thread Michael Niedermayer
On Mon, Dec 21, 2015 at 07:19:50PM -0800, Ganesh Ajjanagadde wrote: > exp10 is a function available in GNU libm. Looks like no other common > libm has it. As such, I am mostly neutral about its inclusion, with a > very slight bias in favor since I am actually posting this. > > pros: > 1. It is fas

Re: [FFmpeg-devel] phasing out asyntcs, resample

2015-12-22 Thread Carl Eugen Hoyos
Rostislav Pehlivanov gmail.com> writes: > Also, I think that it's better to just send a patch which > removes them instead of only warning and then let the > discussion go on there. +1 Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

Re: [FFmpeg-devel] phasing out asyntcs, resample

2015-12-22 Thread Rostislav Pehlivanov
On Mon, 2015-12-21 at 14:32 -0800, Ganesh Ajjanagadde wrote: > Hi, > > While hunting through configure for some easy to remove filter > dependencies, I came across asyncts which depends on avresample. So I > started some work to port it over to swresample, and get rid of this > unnecessary depende

Re: [FFmpeg-devel] [PATCH] libavformat: palettized QuickTime in Matroska, round 2

2015-12-22 Thread Mats Peterson
On 12/22/2015 03:55 AM, Mats Peterson wrote: Alright, this is take two of my fix for palettized QuickTime video in Matroska. I have reset the lower limit of V_QUICKTIME private data to 21 in matroskadec.c, in order to make that broken file pass, Michael. The minimum size of a video sample descrip

Re: [FFmpeg-devel] [PATCH] lavfi/af_aemphasis: remove unnecessary complex number usage

2015-12-22 Thread Paul B Mahol
On 12/22/15, Ganesh Ajjanagadde wrote: > complex is not available on all platforms. Furthermore, it is trivial to > rewrite complex number expressions to real arithmetic, and in fact > sometimes advantageous for performance reasons: by wrapping as a complex, > one forces a particular Cartesian rep

[FFmpeg-devel] [PATCH]ffserver: Cast time_t value when using it in a format string.

2015-12-22 Thread Carl Eugen Hoyos
Hi! Attached patch should fix ticket #5103. Please comment, Carl Eugen diff --git a/ffserver.c b/ffserver.c index c7dbb16..788ee6e 100644 --- a/ffserver.c +++ b/ffserver.c @@ -3853,7 +3853,7 @@ static void handle_child_exit(int sig) fprintf(stderr, "%s: Pid %"PRI

Re: [FFmpeg-devel] [PATCHv2] lavu/libm: add erf hack and make dynaudnorm available everywhere

2015-12-22 Thread Hendrik Leppkes
Am 21.12.2015 18:18 schrieb "James Almer" : > > On 12/21/2015 2:08 PM, Ganesh Ajjanagadde wrote: > > Pushed with slight modifications. > > > > This is a request to any running MSVC/other platform lacking erf: can > > you please test to make sure this works? > > Check http://fate.ffmpeg.org/ for new