[FFmpeg-devel] [PATCH] doc/developer: Remove mentioning of sending pull requests

The _de facto_ policy on patch submission has always been "sending it to the mailing list." --- doc/developer.texi | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/doc/developer.texi b/doc/developer.texi index 9a901d8..9383b21 100644 --- a/doc/developer.texi +++ b/doc/develop

[FFmpeg-devel] [PATCH] fate: add limited_input_seek tests

Signed-off-by: Simon Thelen --- tests/fate/ffmpeg.mak| 6 ++ tests/ref/fate/limited_input_seek| 1 + tests/ref/fate/limited_input_seek-copyts | 1 + 3 files changed, 8 insertions(+) create mode 100644 tests/ref/fate/limited_input_seek create mode 100644 tests/ref

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

Hi > No, please merge them (without adding trailing whitespace, it cannot > be committed to our repository). > While at it, please fix this nit (several times): > > +} > > +else { > > should be on one line, there is tools/patcheck that should have told > you (and also tells you about tr

Re: [FFmpeg-devel] [PATCH 02/10] ffplay: use hypot()

On Sun, Nov 22, 2015 at 12:05 PM, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > ffplay.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ffplay.c b/ffplay.c > index 2c1817e..36da8a5 100644 > --- a/ffplay.c > +++ b/ffplay.c > @@ -1115,9 +1115

[FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

Hi! I prefer attached patch over removing the encoder immediately. Carl Eugen diff --git a/Changelog b/Changelog index ad13d88..6555351 100644 --- a/Changelog +++ b/Changelog @@ -42,6 +42,7 @@ version : - mipsdspr1 option has been renamed to mipsdsp - aemphasis filter - mips32r5 option has bee

Re: [FFmpeg-devel] [PATCH v2] news: add a news entry for the AAC encoder experimental flag removal

On Sat, Dec 5, 2015, at 12:59 PM, Lou Logan wrote: > Rest LGTM. I'm unable to commit at the moment, but I'll do that within 5 > hrs, including the typo Ganesh noticed, unless someone else does first. Pushed and I'll mention on Twitter. ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2] news: add a news entry for the AAC encoder experimental flag removal

On Sat, Dec 5, 2015, at 11:49 AM, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > src/index | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/src/index b/src/index > index d1d4a58..ea2ca7e 100644 > --- a/src/index > +++ b/src/index > @

Re: [FFmpeg-devel] [PATCH v2] news: add a news entry for the AAC encoder experimental flag removal

On Sat, Dec 5, 2015 at 3:49 PM, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > src/index | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/src/index b/src/index > index d1d4a58..ea2ca7e 100644 > --- a/src/index > +++ b/src/index > @@

Re: [FFmpeg-devel] [PATCH v2] news: add a news entry for the AAC encoder experimental flag removal

Feel free to edit the part about the GSoC or anything you think isn't enough. I know why it's important, so if you think it's not enough just add whatever you think sounds right. After all I'm not the best person to write about myself, I'm too biased :) On 5 December 2015 at 20:49, Rostislav Pehli

Re: [FFmpeg-devel] [PATCH 3/8] avfilter/af_channelmap: fix memory leak

On Sat, Dec 5, 2015 at 3:50 PM, Paul B Mahol wrote: > On 12/4/15, Ganesh Ajjanagadde wrote: >> Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and >> 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning >> up usage of the formats API, and in particular fixed possible NU

[FFmpeg-devel] [PATCH v2] news: add a news entry for the AAC encoder experimental flag removal

Signed-off-by: Rostislav Pehlivanov --- src/index | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/index b/src/index index d1d4a58..ea2ca7e 100644 --- a/src/index +++ b/src/index @@ -37,6 +37,32 @@ News + The native FFmpeg encoder is now stable! +

Re: [FFmpeg-devel] [PATCH 3/8] avfilter/af_channelmap: fix memory leak

On 12/4/15, Ganesh Ajjanagadde wrote: > Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and > 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning > up usage of the formats API, and in particular fixed possible NULL pointer > dereferences. > > This commit addresses the i

Re: [FFmpeg-devel] [PATCH 3/8] avfilter/af_channelmap: fix memory leak

On 12/4/15, Ganesh Ajjanagadde wrote: > Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and > 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning > up usage of the formats API, and in particular fixed possible NULL pointer > dereferences. > > This commit addresses the i

Re: [FFmpeg-devel] [PATCH] news: add a news entry for the AAC encoder experimental flag removal

On Sat, Dec 5, 2015 at 3:27 PM, Rostislav Pehlivanov wrote: > Sorry, sent out this email to Ganesh only at first. Posting it to the ML > now. > >>Consider adding a link to such tests/how to verify this. > Subjective tests. I did try to compare them using an SSIM audio filter > (based on a journal

Re: [FFmpeg-devel] [PATCH] news: add a news entry for the AAC encoder experimental flag removal

Sorry, sent out this email to Ganesh only at first. Posting it to the ML now. >Consider adding a link to such tests/how to verify this. Subjective tests. I did try to compare them using an SSIM audio filter (based on a journal paper) I wrote for lavfi a few months ago but I gave up. Spoke with the

Re: [FFmpeg-devel] [PATCH] news: add a news entry for the AAC encoder experimental flag removal

Sorry, sent out this email to Ganesh only at first. Posting it to the ML now. >Consider adding a link to such tests/how to verify this. Subjective tests. I did try to compare them using an SSIM audio filter (based on a journal paper) I wrote for lavfi a few months ago but I gave up. Spoke with the

Re: [FFmpeg-devel] [PATCH] avcodec/aacsbr_tablegen: always initialize tables at runtime

On Thu, Dec 3, 2015 at 8:13 PM, Ganesh Ajjanagadde wrote: > On Sun, Nov 29, 2015 at 10:58 PM, Ganesh Ajjanagadde > wrote: >> This gets rid of virtually useless hardcoded tables hackery. The reason >> it is useless is that a 320 element lut is anyway placed regardless of >> --enable-hardcoded-tabl

[FFmpeg-devel] [PATCHv2] avcodec/aacsbr_tablegen: always initialize tables at runtime

This gets rid of virtually useless hardcoded tables hackery. The reason it is useless is that a 320 element lut is anyway placed regardless of --enable-hardcoded-tables, from which all necessary tables are trivially derived at runtime at very low cost: sample benchmark (x86-64, Haswell, GNU/Linux,

Re: [FFmpeg-devel] [PATCH] probe TrueHD in MPEGTS

On Sat, Dec 05, 2015 at 08:19:51AM -0600, Rodger Combs wrote: > --- > libavformat/utils.c | 1 + > 1 file changed, 1 insertion(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope

Re: [FFmpeg-devel] [PATCH] avfilter: add panorama filter

On Sat, Dec 05, 2015 at 06:38:47PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_panorama.c | 437 > ++ > 3 files changed, 439 insertions(+) >

[FFmpeg-devel] [PATCH] avfilter/formats: fix segfault when allocation fails

This is a somewhat subtle failure that can occur when the realloc_array fails in FORMATS_REF. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/formats.c b/libavfilter/formats.c index 2b13cbf..95a6b11 10064

Re: [FFmpeg-devel] [PATCH] libavtuil: add version component accessor macros

On Sat, Dec 5, 2015 at 1:56 PM, Michael Niedermayer wrote: > On Sat, Dec 05, 2015 at 10:31:33AM -0800, Reynaldo H. Verdejo Pinochet wrote: >> Pretty standard macros, these should help libav* >> users avoid repeating ver.si.on parsing code, >> which aids in compatibility-checking tasks like >> iden

Re: [FFmpeg-devel] [PATCH] news: add a news entry for the AAC encoder experimental flag removal

On Sat, Dec 05, 2015 at 07:14:43PM +, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > src/index | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/src/index b/src/index > index d1d4a58..0c54046 100644 > --- a/src/index > +++ b/src/index

Re: [FFmpeg-devel] [PATCH] news: add a news entry for the AAC encoder experimental flag removal

On Sat, Dec 5, 2015 at 2:14 PM, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > src/index | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/src/index b/src/index > index d1d4a58..0c54046 100644 > --- a/src/index > +++ b/src/index > @@ -37,6

[FFmpeg-devel] [PATCH] news: add a news entry for the AAC encoder experimental flag removal

Signed-off-by: Rostislav Pehlivanov --- src/index | 21 + 1 file changed, 21 insertions(+) diff --git a/src/index b/src/index index d1d4a58..0c54046 100644 --- a/src/index +++ b/src/index @@ -37,6 +37,27 @@ News + The native FFmpeg encoder is out of experimental!

Re: [FFmpeg-devel] [PATCH] libavtuil: add version component accessor macros

On Sat, Dec 05, 2015 at 10:31:33AM -0800, Reynaldo H. Verdejo Pinochet wrote: > Pretty standard macros, these should help libav* > users avoid repeating ver.si.on parsing code, > which aids in compatibility-checking tasks like > identifying FFmpeg from Libav (_MICRO >= 100 check). > Something many

Re: [FFmpeg-devel] [PATCH] avfilter: add panorama filter

On Sat, Dec 5, 2015 at 1:40 PM, Clément Bœsch wrote: > On Sat, Dec 05, 2015 at 01:20:40PM -0500, Ganesh Ajjanagadde wrote: > [...] >> >> + >> >> +AVFilterFormats *fmts_list = ff_make_format_list(pix_fmts); >> >> +if (!fmts_list) >> >> +return AVERROR(ENOMEM); >> >> +return ff_s

Re: [FFmpeg-devel] [PATCH] avfilter: add panorama filter

On Sat, Dec 05, 2015 at 01:20:40PM -0500, Ganesh Ajjanagadde wrote: [...] > >> + > >> +AVFilterFormats *fmts_list = ff_make_format_list(pix_fmts); > >> +if (!fmts_list) > >> +return AVERROR(ENOMEM); > >> +return ff_set_common_formats(ctx, fmts_list); > > still leaky - when fmts

Re: [FFmpeg-devel] [PATCH] libavtuil: add version component accessor macros

On 12/05/2015 10:31 AM, Reynaldo H. Verdejo Pinochet wrote: > Pretty standard macros, these should help libav* > users avoid repeating ver.si.on parsing code, > which aids in compatibility-checking tasks like > identifying FFmpeg from Libav (_MICRO >= 100 check). Actually ran into this while wor

[FFmpeg-devel] [PATCH] libavtuil: add version component accessor macros

Pretty standard macros, these should help libav* users avoid repeating ver.si.on parsing code, which aids in compatibility-checking tasks like identifying FFmpeg from Libav (_MICRO >= 100 check). Something many are doing since we are not intercompatible anymore. Signed-off-by: Reynaldo H. Verdejo

Re: [FFmpeg-devel] [PATCH] avfilter: add panorama filter

> On Sat, Dec 05, 2015 at 06:38:47PM +0100, Paul B Mahol wrote: [...] >> +AVFILTER_DEFINE_CLASS(panorama); >> + >> +static int query_formats(AVFilterContext *ctx) >> +{ >> +static const enum AVPixelFormat pix_fmts[] = { >> +AV_PIX_FMT_YUVA444P, AV_PIX_FMT_YUVA422P, AV_PIX_FMT_YUVA420P,

Re: [FFmpeg-devel] [PATCH] avfilter: add panorama filter

On Sat, Dec 05, 2015 at 06:38:47PM +0100, Paul B Mahol wrote: [...] > +{ "input", "set input projection", OFFSET(in), AV_OPT_TYPE_INT, > {.i64=SPHERE}, 0, NB_PROJECTIONS-1, FLAGS, "in" }, > +{ "s", "spheric", 0, AV_OPT_TYPE_CONST, > {.i64=SPHERE}, 0,

[FFmpeg-devel] [PATCH] avfilter: add panorama filter

Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_panorama.c | 437 ++ 3 files changed, 439 insertions(+) create mode 100644 libavfilter/vf_panorama.c diff --git a/libavfilter/Makefile

Re: [FFmpeg-devel] Memory leaks in libavformat/segment.c

Ok, I will try av_reallocp /Best Regards, lvqier - lvq...@gmail.com / ** 青春如烟，唱一首笑忘歌 On 12/5/15 7:27 PM, Hendrik Leppkes wrote: On Sat, Dec 5, 2015 at 11:02 AM, Qier LU wrote: Hi Michael, The attached is against git master.

[FFmpeg-devel] My problem

http://pastebin.com/NrwLsu6J [C++] #include "RawVideoReader.h" #include #include #define AV_OU - Pastebin.com pastebin.com This is my code, I followed some steps I´ve found on line But the av_encode_video2 functi

[FFmpeg-devel] [PATCH] probe TrueHD in MPEGTS

--- libavformat/utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index 251b2c6..ae9ae5b 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -284,6 +284,7 @@ static int set_codec_from_probe_data(AVFormatContext *s, AVStream *st,

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

On Sat, Dec 5, 2015 at 1:20 AM, Paul B Mahol wrote: > On 12/4/15, Ganesh Ajjanagadde wrote: >> On Fri, Dec 4, 2015 at 3:49 PM, Paul B Mahol wrote: >>> On 12/4/15, Ganesh Ajjanagadde wrote: On Fri, Dec 4, 2015 at 11:36 AM, Paul B Mahol wrote: > On 12/4/15, Ganesh Ajjanagadde wrote: >>

Re: [FFmpeg-devel] [PATCH 3/3] avutil/threadmessage: fix condition broadcasting

On Sat, Dec 05, 2015 at 01:19:16PM +0100, Nicolas George wrote: > Le quintidi 15 frimaire, an CCXXIV, Clement Boesch a écrit : > > ping, I'd like to apply this fix soon > > I have already answered: > > http://ffmpeg.org/pipermail/ffmpeg-devel/2015-December/184285.html > This was before providin

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

On Fri, Dec 4, 2015 at 9:12 PM, Michael Niedermayer wrote: > On Fri, Dec 04, 2015 at 10:28:35PM +0100, Andreas Cadhalpun wrote: >> On 03.12.2015 23:09, Michael Niedermayer wrote: >> > From: Michael Niedermayer >> > >> > Fixes undefined behavior >> > Fixes: mozilla bug 1229208 >> > Fixes: >> > fb

Re: [FFmpeg-devel] [PATCH 3/3] avutil/threadmessage: fix condition broadcasting

Le quintidi 15 frimaire, an CCXXIV, Clement Boesch a écrit : > ping, I'd like to apply this fix soon I have already answered: http://ffmpeg.org/pipermail/ffmpeg-devel/2015-December/184285.html So please go ahead. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

Hi! On Saturday 05 December 2015 12:17:56 am Eran Kornblau wrote: > > Please send the patches to the mailing list. See > > https://github.com/FFmpeg/FFmpeg/pull/153 > > Attached, note there are two files, the second commit is just a tiny > fix to a bug in the first one, hope that's ok. No, pleas

[FFmpeg-devel] [PATCH] diracdec: Move strides to bytes, and pointer types to uint8_t.

Start templating functions for move to support 10-bit Parts of this patch were written by Rostislav Pehlivanov --- libavcodec/dirac.c | 10 +- libavcodec/dirac.h | 3 +- libavcodec/diracdec.c | 229 ++-- libavformat/oggparsedirac.c

Re: [FFmpeg-devel] [PATCH 3/3] avutil/threadmessage: fix condition broadcasting

On Wed, Dec 02, 2015 at 03:57:31PM +0100, Clément Bœsch wrote: [...] > This second solution replaces the condition with two: one to notify the > senders, and one to notify the receivers. This prevents senders from > notifying other senders instead of a reader, and the other way around. > It also av

Re: [FFmpeg-devel] [PATCH 6/8] avfilter/show_palette: fix memory leak

On Fri, Dec 04, 2015 at 05:56:12PM -0500, Ganesh Ajjanagadde wrote: > On Fri, Dec 4, 2015 at 5:29 PM, Marton Balint wrote: > if ((ret = ff_formats_ref(in , &ctx->inputs[0]->out_formats)) < 0 > || > (ret = ff_formats_ref(out, &ctx->outputs[0]->in_formats)) < 0) > -

Re: [FFmpeg-devel] [PATCH] avfilter/codecview/WIP: add QP support

On Sat, Dec 05, 2015 at 03:52:42AM +0100, Michael Niedermayer wrote: > On Fri, Dec 04, 2015 at 05:06:34PM +0100, Clément Bœsch wrote: > > On Mon, Aug 31, 2015 at 04:43:15PM +0200, Michael Niedermayer wrote: > > > On Mon, Aug 31, 2015 at 03:29:03PM +0200, Clément Bœsch wrote: > > > > From: Clément B

Re: [FFmpeg-devel] Memory leaks in libavformat/segment.c

On Sat, Dec 5, 2015 at 11:02 AM, Qier LU wrote: > Hi Michael, > > The attached is against git master. > The patch is probably fine now. Maybe it would be saner to actually use av_reallocp on the filename to avoid having to allocate and free it in different places? - Hendrik _

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

On Sat, Dec 05, 2015 at 06:20:29AM +, Paul B Mahol wrote: [...] > Yes, it was and still is wasted time, to find out that there is no > leaking at all. There is an allocation, so it could fail under certain context/system conditions. There is also branching in that code assuming it could fail,

Re: [FFmpeg-devel] Memory leaks in libavformat/segment.c

Hi Michael, The attached is against git master. On Sat, Dec 5, 2015 at 5:34 AM, Michael Niedermayer wrote: > On Fri, Dec 04, 2015 at 11:20:17AM +0800, Lvqier wrote: > > Hi, > > > > I am using FFmpeg to generate mpegts segments. FFmpeg has memory > > leaks, see the valgrind output in the attachm

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: implement vp9 dxva2 hwaccel

On Fri, Dec 4, 2015 at 3:24 PM, Hendrik Leppkes wrote: > On Fri, Dec 4, 2015 at 2:55 PM, Ronald S. Bultje wrote: >> Hi, >> >> On Thu, Dec 3, 2015 at 5:13 AM, Hendrik Leppkes wrote: >> >>> +/* Create an annex B bitstream buffer with only slice NAL and >>> finalize slice */ >>> >> >> What does