Re: [FFmpeg-devel] [PATCH] ffserver: cast PID to int64_t before printing

2015-08-20 Thread Clément Bœsch
On Thu, Aug 20, 2015 at 10:17:15PM -0400, Ganesh Ajjanagadde wrote: > On Thu, Aug 20, 2015 at 10:03 PM, Ganesh Ajjanagadde > wrote: > > On Thu, Aug 20, 2015 at 9:29 PM, Timothy Gu wrote: > >> On Thu, Aug 20, 2015 at 6:03 PM Ganesh Ajjanagadde > >> wrote: > >>> > >>> -avio_printf(pb,

Re: [FFmpeg-devel] [PATCH] all: use { 0 } for zero initializing compound data structures

2015-08-20 Thread Clément Bœsch
On Thu, Aug 20, 2015 at 10:19:51PM -0400, Ganesh Ajjanagadde wrote: > C Standard guarantees that { 0 } will do a correct zero initialization. > We use this for consistency across the project. > See 392b4b663c450f5522f7c1442da91f7647db6bf0 [...] -- Clément B. pgpdV6ih4k4YG.pgp Description: PG

[FFmpeg-devel] [PATCH] all: use { 0 } for zero initializing compound data structures

2015-08-20 Thread Ganesh Ajjanagadde
C Standard guarantees that { 0 } will do a correct zero initialization. We use this for consistency across the project. Signed-off-by: Ganesh Ajjanagadde --- ffplay.c | 2 +- ffserver.c| 2 +- libavcodec/aacdec_template.c | 2 +- libavcodec/aacpsy.c

Re: [FFmpeg-devel] [PATCH] ffserver: cast PID to int64_t before printing

2015-08-20 Thread Ganesh Ajjanagadde
On Thu, Aug 20, 2015 at 10:03 PM, Ganesh Ajjanagadde wrote: > On Thu, Aug 20, 2015 at 9:29 PM, Timothy Gu wrote: >> On Thu, Aug 20, 2015 at 6:03 PM Ganesh Ajjanagadde >> wrote: >>> >>> -avio_printf(pb, "Running as pid %d.\n", stream->pid); >>> +avio_printf(pb, "Running as

[FFmpeg-devel] [PATCHv2] ffserver: cast PID to int64_t before printing

2015-08-20 Thread Ganesh Ajjanagadde
Unfortunately, there is no portable format specifier for PID's. Furthermore, it is not safe to assume pid_t <= 32 bit in size, see e.g http://unix.derkeiler.com/Mailing-Lists/AIX-L/2010-08/msg8.html. Right now, it is ok to assume pid_t <= 32 bit in size, but this may change in the future. Also

Re: [FFmpeg-devel] [PATCH] ffserver: cast PID to int64_t before printing

2015-08-20 Thread Ganesh Ajjanagadde
On Thu, Aug 20, 2015 at 9:29 PM, Timothy Gu wrote: > On Thu, Aug 20, 2015 at 6:03 PM Ganesh Ajjanagadde > wrote: >> >> -avio_printf(pb, "Running as pid %d.\n", stream->pid); >> +avio_printf(pb, "Running as pid %ld.\n", (int64_t) >> stream->pid); > > > You need `"%" PRIi64`

Re: [FFmpeg-devel] [PATCH] ffserver: cast PID to int64_t before printing

2015-08-20 Thread Timothy Gu
On Thu, Aug 20, 2015 at 6:03 PM Ganesh Ajjanagadde wrote: > -avio_printf(pb, "Running as pid %d.\n", stream->pid); > +avio_printf(pb, "Running as pid %ld.\n", (int64_t) > stream->pid); > You need `"%" PRIi64` as the format specifier. Timothy _

[FFmpeg-devel] [PATCH] ffserver: cast PID to int64_t before printing

2015-08-20 Thread Ganesh Ajjanagadde
Unfortunately, there is no portable format specifier for PID's. Furthermore, it is not safe to assume pid_t <= 32 bit in size, see e.g http://unix.derkeiler.com/Mailing-Lists/AIX-L/2010-08/msg8.html. Right now, it is ok to assume pid_t <= 32 bit in size, but this may change in the future. Also

Re: [FFmpeg-devel] [PATCH 2/2] lavf/file: check for dirent.h support

2015-08-20 Thread Mariusz Szczepańczyk
On Thu, Jun 25, 2015 at 12:09 PM, Michael Niedermayer wrote: > On Wed, Jun 24, 2015 at 03:25:18AM +0200, Mariusz Szczepańczyk wrote: > > On Tue, Jun 23, 2015 at 8:34 PM, Michael Niedermayer > > wrote: > > > > > On Mon, Jun 22, 2015 at 12:01:33AM +0200, Mariusz Szczepańczyk wrote: > > > > --- > >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/jpeg2000: comment out unused variable

2015-08-20 Thread Ganesh Ajjanagadde
On Thu, Aug 20, 2015 at 7:28 PM, Ganesh Ajjanagadde wrote: > Fixes -Wunused-const-variable from > http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 > > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/jpeg2000.c | 2 +- > 1 file changed, 1 insertion(+),

[FFmpeg-devel] [PATCH 3/3] avcodec/jpeg2000: comment out unused variable

2015-08-20 Thread Ganesh Ajjanagadde
Fixes -Wunused-const-variable from http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 Signed-off-by: Ganesh Ajjanagadde --- libavcodec/jpeg2000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/jpeg2000.c b/libavcodec/jpeg2000.c

[FFmpeg-devel] [PATCH 1/3] avformat/hls: correct comment for ensure_playlist()

2015-08-20 Thread Ganesh Ajjanagadde
Comment was previously slightly incorrect. Also, it was placed in the wrong location. Signed-off-by: Ganesh Ajjanagadde --- libavformat/hls.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index caecbde..82dd744 100644 --- a/libavf

[FFmpeg-devel] [PATCH 2/3] avformat/hls: comment out unused function

2015-08-20 Thread Ganesh Ajjanagadde
Fixes -Wunused-function from http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 Signed-off-by: Ganesh Ajjanagadde --- libavformat/hls.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 82dd744..

Re: [FFmpeg-devel] [PATCH] lavf/http: implement directory listing callbacks for Apache

2015-08-20 Thread Mariusz Szczepańczyk
On Thu, Aug 20, 2015 at 11:59 PM, Ganesh Ajjanagadde wrote: > On Thu, Aug 20, 2015 at 5:48 PM, Mariusz Szczepańczyk > wrote: > > On Thu, Aug 20, 2015 at 11:38 PM, Ganesh Ajjanagadde > > wrote: > > > >> On Thu, Aug 20, 2015 at 5:32 PM, Mariusz Szczepańczyk > >> wrote: > >> > --- > >> > configu

Re: [FFmpeg-devel] [PATCH] QSV : Added look ahead rate control mode

2015-08-20 Thread Michael Niedermayer
On Thu, Aug 20, 2015 at 02:34:22PM +0100, Sven Dueking wrote: > From: Sven Dueking > > --- > libavcodec/qsvenc.c | 36 +--- > libavcodec/qsvenc.h | 12 > libavcodec/qsvenc_h264.c | 12 > 3 files changed, 57 insertions(+), 3 dele

Re: [FFmpeg-devel] [PATCH] lavf/http: implement directory listing callbacks for Apache

2015-08-20 Thread Ganesh Ajjanagadde
On Thu, Aug 20, 2015 at 5:48 PM, Mariusz Szczepańczyk wrote: > On Thu, Aug 20, 2015 at 11:38 PM, Ganesh Ajjanagadde > wrote: > >> On Thu, Aug 20, 2015 at 5:32 PM, Mariusz Szczepańczyk >> wrote: >> > --- >> > configure | 3 + >> > libavformat/http.c | 194 >> ++

Re: [FFmpeg-devel] [PATCH] avcodec/metasound_data: comment out unused variable

2015-08-20 Thread Michael Niedermayer
On Thu, Aug 20, 2015 at 05:34:52PM -0400, Ganesh Ajjanagadde wrote: > Fixes -Wunused-const-variable from > http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 > > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/metasound_data.c | 3 ++- > 1 file changed,

Re: [FFmpeg-devel] [PATCH] lavf/http: implement directory listing callbacks for Apache

2015-08-20 Thread Mariusz Szczepańczyk
On Thu, Aug 20, 2015 at 11:38 PM, Ganesh Ajjanagadde wrote: > On Thu, Aug 20, 2015 at 5:32 PM, Mariusz Szczepańczyk > wrote: > > --- > > configure | 3 + > > libavformat/http.c | 194 > + > > 2 files changed, 197 insertions(+) > > >

Re: [FFmpeg-devel] [PATCH] lavf/http: implement directory listing callbacks for Apache

2015-08-20 Thread Ganesh Ajjanagadde
On Thu, Aug 20, 2015 at 5:32 PM, Mariusz Szczepańczyk wrote: > --- > configure | 3 + > libavformat/http.c | 194 > + > 2 files changed, 197 insertions(+) > > diff --git a/configure b/configure > index e67ddf6..401e041 100755 > --- a

[FFmpeg-devel] [PATCH] avcodec/metasound_data: comment out unused variable

2015-08-20 Thread Ganesh Ajjanagadde
Fixes -Wunused-const-variable from http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 Signed-off-by: Ganesh Ajjanagadde --- libavcodec/metasound_data.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/metasound_data.c b/libavco

[FFmpeg-devel] [PATCH] lavf/http: implement directory listing callbacks for Apache

2015-08-20 Thread Mariusz Szczepańczyk
--- configure | 3 + libavformat/http.c | 194 + 2 files changed, 197 insertions(+) diff --git a/configure b/configure index e67ddf6..401e041 100755 --- a/configure +++ b/configure @@ -265,6 +265,7 @@ External library support: --en

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/metasound_data: remove unused variable

2015-08-20 Thread Michael Niedermayer
On Thu, Aug 20, 2015 at 05:12:40PM -0400, Ganesh Ajjanagadde wrote: > On Thu, Aug 20, 2015 at 6:37 AM, Michael Niedermayer > wrote: > > On Thu, Aug 20, 2015 at 04:34:19AM -0400, Ganesh Ajjanagadde wrote: > >> On Thu, Aug 20, 2015 at 4:28 AM, Ganesh Ajjanagadde > >> wrote: > >> > Fixes -Wunused-co

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/metasound_data: remove unused variable

2015-08-20 Thread Ganesh Ajjanagadde
On Thu, Aug 20, 2015 at 6:37 AM, Michael Niedermayer wrote: > On Thu, Aug 20, 2015 at 04:34:19AM -0400, Ganesh Ajjanagadde wrote: >> On Thu, Aug 20, 2015 at 4:28 AM, Ganesh Ajjanagadde >> wrote: >> > Fixes -Wunused-const-variable from >> > http://fate.ffmpeg.org/report.cgi?time=20150820031140&slo

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/aacsbr_fixed: remove unused variable

2015-08-20 Thread Michael Niedermayer
On Thu, Aug 20, 2015 at 04:44:17PM -0400, Ganesh Ajjanagadde wrote: > On Thu, Aug 20, 2015 at 3:31 PM, Michael Niedermayer > wrote: > > On Thu, Aug 20, 2015 at 09:33:31AM -0400, Ronald S. Bultje wrote: > >> Hi, > >> > >> On Thu, Aug 20, 2015 at 4:28 AM, Ganesh Ajjanagadde > >> > >> wrote: > >> >

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/aacsbr_fixed: remove unused variable

2015-08-20 Thread Ganesh Ajjanagadde
On Thu, Aug 20, 2015 at 3:31 PM, Michael Niedermayer wrote: > On Thu, Aug 20, 2015 at 09:33:31AM -0400, Ronald S. Bultje wrote: >> Hi, >> >> On Thu, Aug 20, 2015 at 4:28 AM, Ganesh Ajjanagadde >> wrote: >> >> > Fixes -Wunused-const-variable from >> > >> > http://fate.ffmpeg.org/report.cgi?time=20

Re: [FFmpeg-devel] [PATCH 02/13] avfilter: add missing FF_API_AVFILTERPAD_PUBLIC guard

2015-08-20 Thread Andreas Cadhalpun
On 20.08.2015 01:33, Michael Niedermayer wrote: > On Tue, Aug 18, 2015 at 11:47:45PM +0200, Andreas Cadhalpun wrote: >> graph2dot.c |3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> 560d5f42580115baf305ba8ff985202b248b4864 >> 0001-graph2dot-use-avfilter_pad_get_name-accessor-funct

Re: [FFmpeg-devel] [PATCH] api-band-test: first version

2015-08-20 Thread Michael Niedermayer
Hi ludmila did you see my reply on the ML (its also below)? as you didnt reply ... On Tue, Aug 11, 2015 at 03:31:05AM +0200, Michael Niedermayer wrote: > On Tue, Jul 28, 2015 at 09:54:06PM +0300, Ludmila Glinskih wrote: > > Works only for flv, h263 and huffyuv decoders, for video with yuv420p pix

Re: [FFmpeg-devel] [PATCH] api-seek-test: first version

2015-08-20 Thread Michael Niedermayer
On Fri, Jul 31, 2015 at 04:01:43PM +0300, Ludmila Glinskih wrote: > Works only with video stream. > First pass without seeking -- counts crcs of a frames and store it in an > array. > After that it seeks a lot in different places and checks if crcs of these > frames and crcs of frames in array ar

Re: [FFmpeg-devel] [PATCH] avfilter/vf_dejudder: use the name 's' for the pointer to the private context

2015-08-20 Thread Nicholas Robbins
On Thursday, August 20, 2015 3:13 PM, Ganesh Ajjanagadde wrote: > > >On Thu, Aug 20, 2015 at 2:59 PM, Michael Niedermayer > wrote: >> On Thu, Aug 20, 2015 at 02:06:18PM -0400, Ganesh Ajjanagadde wrote: >>> On Thu, Aug 20, 2015 at 1:53 PM, Clément Bœsch wrote: >>> > On Thu, Aug 20, 2015 at 01:10:

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/aacsbr_fixed: remove unused variable

2015-08-20 Thread Michael Niedermayer
On Thu, Aug 20, 2015 at 09:33:31AM -0400, Ronald S. Bultje wrote: > Hi, > > On Thu, Aug 20, 2015 at 4:28 AM, Ganesh Ajjanagadde > wrote: > > > Fixes -Wunused-const-variable from > > > > http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 > > > > Signed-off-by:

Re: [FFmpeg-devel] [PATCHv2] avformat/webmdashenc: fix uninitialized variable

2015-08-20 Thread Michael Niedermayer
On Thu, Aug 20, 2015 at 01:14:10PM -0400, Ronald S. Bultje wrote: > Hi, > > On Thu, Aug 20, 2015 at 11:18 AM, Ganesh Ajjanagadde > wrote: > > > Fixes -Wsometimes-uninitialized from > > > > http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 > > > > Signed-off-

Re: [FFmpeg-devel] [PATCH] avfilter/vf_dejudder: use the name 's' for the pointer to the private context

2015-08-20 Thread Ganesh Ajjanagadde
On Thu, Aug 20, 2015 at 2:59 PM, Michael Niedermayer wrote: > On Thu, Aug 20, 2015 at 02:06:18PM -0400, Ganesh Ajjanagadde wrote: >> On Thu, Aug 20, 2015 at 1:53 PM, Clément Bœsch wrote: >> > On Thu, Aug 20, 2015 at 01:10:43PM -0400, Ganesh Ajjanagadde wrote: >> > [...] >> >> I know what s is doi

Re: [FFmpeg-devel] [PATCH] ffserver: use -b instead of -ab for setting audio bitrate.

2015-08-20 Thread Paul B Mahol
On 8/18/15, Ronald S. Bultje wrote: > --- > ffserver_config.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ffserver_config.c b/ffserver_config.c > index 06bd8ac..de8a454 100644 > --- a/ffserver_config.c > +++ b/ffserver_config.c > @@ -230,9 +230,9 @@ static void

Re: [FFmpeg-devel] [PATCH] avfilter/vf_dejudder: use the name 's' for the pointer to the private context

2015-08-20 Thread Michael Niedermayer
On Thu, Aug 20, 2015 at 02:06:18PM -0400, Ganesh Ajjanagadde wrote: > On Thu, Aug 20, 2015 at 1:53 PM, Clément Bœsch wrote: > > On Thu, Aug 20, 2015 at 01:10:43PM -0400, Ganesh Ajjanagadde wrote: > > [...] > >> I know what s is doing, I just fail to see the connection between the name > >> "s" and

Re: [FFmpeg-devel] [PATCH] lavf/http: Export headers as AVDictionary

2015-08-20 Thread Stephan Holljes
Actually I just noticed that Pragma-headers may appear multiple times. What would be a good way to handle that? I thought about expanding the header tag from "Pragma" to "Pragma-%02d" with either an incrementing number or just using s->nb_headers. Is there a better solution? Regards, Stephan _

Re: [FFmpeg-devel] [PATCH] avfilter/vf_dejudder: use the name 's' for the pointer to the private context

2015-08-20 Thread Ganesh Ajjanagadde
On Thu, Aug 20, 2015 at 1:53 PM, Clément Bœsch wrote: > On Thu, Aug 20, 2015 at 01:10:43PM -0400, Ganesh Ajjanagadde wrote: > [...] >> I know what s is doing, I just fail to see the connection between the name >> "s" and "filter private context". > > s originally stands for struct iirc If that is

Re: [FFmpeg-devel] [PATCH] avfilter/vf_dejudder: use the name 's' for the pointer to the private context

2015-08-20 Thread Clément Bœsch
On Thu, Aug 20, 2015 at 01:10:43PM -0400, Ganesh Ajjanagadde wrote: [...] > I know what s is doing, I just fail to see the connection between the name > "s" and "filter private context". s originally stands for struct iirc -- Clément B. pgperHJDLxk01.pgp Description: PGP signature

[FFmpeg-devel] [PATCH] lavf/http: Export headers as AVDictionary

2015-08-20 Thread Stephan Holljes
Signed-off-by: Stephan Holljes --- libavformat/http.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavformat/http.c b/libavformat/http.c index 3fd0496..2c51491 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -48,6 +48,7 @@ #define MAX_REDIRECTS 8 #define HTTP_SINGL

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Stephan Holljes
On Thu, Aug 20, 2015 at 6:51 PM, Nicolas George wrote: > Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : >> In ffserver the User-Agent is used to decide how to deal with a >> client. (WMP being a special case.) > > Ok, but that is special case for a specific application. > >> That soun

Re: [FFmpeg-devel] [PATCHv2] avformat/webmdashenc: fix uninitialized variable

2015-08-20 Thread Ronald S. Bultje
Hi, On Thu, Aug 20, 2015 at 11:18 AM, Ganesh Ajjanagadde wrote: > Fixes -Wsometimes-uninitialized from > > http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 > > Signed-off-by: Ganesh Ajjanagadde > --- > libavformat/webmdashenc.c | 6 +++--- > 1 file change

Re: [FFmpeg-devel] [PATCH] avfilter/vf_dejudder: use the name 's' for the pointer to the private context

2015-08-20 Thread Ganesh Ajjanagadde
On Thu, Aug 20, 2015 at 12:59 PM, Paul B Mahol wrote: > On 8/20/15, Ganesh Ajjanagadde wrote: >> On Thu, Aug 20, 2015 at 11:24 AM, Paul B Mahol wrote: >>> This is shorter and consistent across filters. >>> >>> Signed-off-by: Paul B Mahol >>> --- >>> libavfilter/vf_dejudder.c | 66 >>> +

[FFmpeg-devel] [PATCH v9] Add support for Audible AA files

2015-08-20 Thread Vesselin Bontchev
This patch revision (v9) adds me to the MAINTAINERS file. VesselinFrom a9457dead0dac503c9aeca8d49bc89d5c9b607d9 Mon Sep 17 00:00:00 2001 From: Vesselin Bontchev Date: Sun, 19 Jul 2015 23:16:36 +0200 Subject: [PATCH] Add support for Audible AA files https://en.wikipedia.org/wiki/Audible.com#Quali

Re: [FFmpeg-devel] [PATCH] avfilter/vf_dejudder: use the name 's' for the pointer to the private context

2015-08-20 Thread Paul B Mahol
On 8/20/15, Ganesh Ajjanagadde wrote: > On Thu, Aug 20, 2015 at 11:24 AM, Paul B Mahol wrote: >> This is shorter and consistent across filters. >> >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/vf_dejudder.c | 66 >> +++ >> 1 file changed, 33 in

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Nicolas George
Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : > In ffserver the User-Agent is used to decide how to deal with a > client. (WMP being a special case.) Ok, but that is special case for a specific application. > That sounds pretty optimistic. Maybe it is trivial for you, but from > my

Re: [FFmpeg-devel] [PATCH] lavf/http: Fix parsing http request data to not read over '\0'.

2015-08-20 Thread Nicolas George
Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : > Signed-off-by: Stephan Holljes > --- > libavformat/http.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM, thanks. Note to Hendrik and the others who took over the merging: Until recently, Michael pulled from my tree

Re: [FFmpeg-devel] [PATCH] avfilter/vf_dejudder: use the name 's' for the pointer to the private context

2015-08-20 Thread Ganesh Ajjanagadde
On Thu, Aug 20, 2015 at 11:24 AM, Paul B Mahol wrote: > This is shorter and consistent across filters. > > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_dejudder.c | 66 > +++ > 1 file changed, 33 insertions(+), 33 deletions(-) > > diff --git a/l

[FFmpeg-devel] [PATCH 2/2] lavf/http: Rework http_write_reply()

2015-08-20 Thread Stephan Holljes
Add error codes 301 and 503, make replies more customizable and use AVBPrint for strings. Signed-off-by: Stephan Holljes --- libavformat/http.c | 75 +- 1 file changed, 63 insertions(+), 12 deletions(-) diff --git a/libavformat/http.c b/libavf

[FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Stephan Holljes
Introduce the ability to set reply body and reply text and read the url-query, http-version and host parameter. Signed-off-by: Stephan Holljes --- libavformat/http.c | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-) Does not export User-Agent, unlike the pr

[FFmpeg-devel] [PATCH] lavf/http: Fix parsing http request data to not read over '\0'.

2015-08-20 Thread Stephan Holljes
Signed-off-by: Stephan Holljes --- libavformat/http.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index a136918..18df34e 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -716,7 +716,7 @@ static int process_line(URLCont

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Stephan Holljes
On Thu, Aug 20, 2015 at 5:32 PM, Nicolas George wrote: > Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : >> Should the same be done for the Host-parameter sent by the client too? > > It can be discussed. > > On one hand, the Host field has a special meaning for the protocol, unlike > U

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Nicolas George
Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : > Should the same be done for the Host-parameter sent by the client too? It can be discussed. On one hand, the Host field has a special meaning for the protocol, unlike User-Agent that is only used for logging, so it makes sense to give

Re: [FFmpeg-devel] [PATCH 2/2] lavf/http: Add error codes 301 and 503 and make replies more customizable

2015-08-20 Thread Stephan Holljes
On Thu, Aug 20, 2015 at 5:17 PM, Nicolas George wrote: > Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : >> It's the opposite. When the request was HEAD, the location header is >> not set, otherwise it is. > > Indeed, but still, why? I just checked with a random Apache server, and HEAD

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Stephan Holljes
On Thu, Aug 20, 2015 at 5:15 PM, Nicolas George wrote: > Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : >> Added to all while(!av_isspace(p)) loops in the server code. > > You may want to send this part in a stand-alone patch, since it is actually > a bug in the current code. > >> Thi

[FFmpeg-devel] [PATCH] avfilter/vf_dejudder: use the name 's' for the pointer to the private context

2015-08-20 Thread Paul B Mahol
This is shorter and consistent across filters. Signed-off-by: Paul B Mahol --- libavfilter/vf_dejudder.c | 66 +++ 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/libavfilter/vf_dejudder.c b/libavfilter/vf_dejudder.c index ab525b6..4705

[FFmpeg-devel] [PATCHv2] avformat/webmdashenc: fix uninitialized variable

2015-08-20 Thread Ganesh Ajjanagadde
Fixes -Wsometimes-uninitialized from http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 Signed-off-by: Ganesh Ajjanagadde --- libavformat/webmdashenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/webmdashenc.c b/libav

Re: [FFmpeg-devel] [PATCH 2/2] lavf/http: Add error codes 301 and 503 and make replies more customizable

2015-08-20 Thread Nicolas George
Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : > It's the opposite. When the request was HEAD, the location header is > not set, otherwise it is. Indeed, but still, why? I just checked with a random Apache server, and HEAD also returns the Location header. Regards, -- Nicolas Geo

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Nicolas George
Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : > Added to all while(!av_isspace(p)) loops in the server code. You may want to send this part in a stand-alone patch, since it is actually a bug in the current code. > This is more or less temporal, since the user-agent field is/will be

Re: [FFmpeg-devel] [PATCH 2/2] lavf/http: Add error codes 301 and 503 and make replies more customizable

2015-08-20 Thread Stephan Holljes
On Thu, Aug 20, 2015 at 11:08 AM, Nicolas George wrote: > Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : >> Signed-off-by: Stephan Holljes >> --- >> libavformat/http.c | 44 +++- >> 1 file changed, 39 insertions(+), 5 deletions(-) >> >> diff -

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Stephan Holljes
On Thu, Aug 20, 2015 at 11:02 AM, Nicolas George wrote: > Thanks for the patch. A few remarks, specific to the stand-alone-commit > version or that I had not yet spotted. > > > Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : >> Signed-off-by: Stephan Holljes >> --- >> libavformat/htt

Re: [FFmpeg-devel] [PATCH 4/4] avformat/webmdashenc: fix uninitialized variable

2015-08-20 Thread Ronald S. Bultje
Hi, On Thu, Aug 20, 2015 at 4:29 AM, Ganesh Ajjanagadde wrote: > Fixes -Wsometimes-uninitialized from > > http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 > > Signed-off-by: Ganesh Ajjanagadde > --- > libavformat/webmdashenc.c | 2 +- > 1 file changed, 1

[FFmpeg-devel] [PATCH] QSV : Added look ahead rate control mode

2015-08-20 Thread Sven Dueking
From: Sven Dueking --- libavcodec/qsvenc.c | 36 +--- libavcodec/qsvenc.h | 12 libavcodec/qsvenc_h264.c | 12 3 files changed, 57 insertions(+), 3 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 15322

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/aacsbr_fixed: remove unused variable

2015-08-20 Thread Ronald S. Bultje
Hi, On Thu, Aug 20, 2015 at 4:28 AM, Ganesh Ajjanagadde wrote: > Fixes -Wunused-const-variable from > > http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 > > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/aacsbr_fixed.c | 1 - > 1 file changed, 1 del

[FFmpeg-devel] [RFC]fps filter

2015-08-20 Thread Carl Eugen Hoyos
Hi! I finally realized why -vf fps=3/1001,fieldmatch,decimate does not always work / produces ugly output. The issue is not related to fieldmatch and/or decimate but to the fps filter: It (sometimes) drops frames even if the framerate is increased. So the question is: Is it a good idea that

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/metasound_data: remove unused variable

2015-08-20 Thread Michael Niedermayer
On Thu, Aug 20, 2015 at 04:34:19AM -0400, Ganesh Ajjanagadde wrote: > On Thu, Aug 20, 2015 at 4:28 AM, Ganesh Ajjanagadde > wrote: > > Fixes -Wunused-const-variable from > > http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 > > > > Signed-off-by: Ganesh Ajjana

Re: [FFmpeg-devel] [PATCH 3/4] avformat/ftp: use correct enum type

2015-08-20 Thread Michael Niedermayer
On Thu, Aug 20, 2015 at 04:29:12AM -0400, Ganesh Ajjanagadde wrote: > Fixes -Wenum-conversion from > http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 > > Signed-off-by: Ganesh Ajjanagadde > --- > libavformat/ftp.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH v8] Add support for Audible AA files

2015-08-20 Thread Michael Niedermayer
On Thu, Aug 20, 2015 at 05:34:22AM +0300, Vesselin Bontchev wrote: > Hi! > > It would be awesome to have this patch merged in FFmpeg. > > Vesselin > doc/demuxers.texi|6 > doc/general.texi |2 > libavformat/Makefile |1 > libavformat/aadec.c | 303 > +++

Re: [FFmpeg-devel] [PATCH 2/2] lavf/http: Add error codes 301 and 503 and make replies more customizable

2015-08-20 Thread Nicolas George
Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : > Signed-off-by: Stephan Holljes > --- > libavformat/http.c | 44 +++- > 1 file changed, 39 insertions(+), 5 deletions(-) > > diff --git a/libavformat/http.c b/libavformat/http.c > index bfe6801..

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

2015-08-20 Thread Nicolas George
Thanks for the patch. A few remarks, specific to the stand-alone-commit version or that I had not yet spotted. Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit : > Signed-off-by: Stephan Holljes > --- > libavformat/http.c | 40 ++-- > 1 file changed,

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/metasound_data: remove unused variable

2015-08-20 Thread Ganesh Ajjanagadde
On Thu, Aug 20, 2015 at 4:28 AM, Ganesh Ajjanagadde wrote: > Fixes -Wunused-const-variable from > http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 > > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/metasound_data.c | 4 > 1 file changed, 4 deleti

[FFmpeg-devel] [PATCH 4/4] avformat/webmdashenc: fix uninitialized variable

2015-08-20 Thread Ganesh Ajjanagadde
Fixes -Wsometimes-uninitialized from http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 Signed-off-by: Ganesh Ajjanagadde --- libavformat/webmdashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/webmdashenc.c b/libavformat

[FFmpeg-devel] [PATCH 3/4] avformat/ftp: use correct enum type

2015-08-20 Thread Ganesh Ajjanagadde
Fixes -Wenum-conversion from http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 Signed-off-by: Ganesh Ajjanagadde --- libavformat/ftp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/ftp.c b/libavformat/ftp.c index 51f491c..dc

[FFmpeg-devel] [PATCH 2/4] avcodec/aacsbr_fixed: remove unused variable

2015-08-20 Thread Ganesh Ajjanagadde
Fixes -Wunused-const-variable from http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 Signed-off-by: Ganesh Ajjanagadde --- libavcodec/aacsbr_fixed.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/aacsbr_fixed.c b/libavcodec/aacsbr_fixed.c inde

[FFmpeg-devel] [PATCH 1/4] avcodec/metasound_data: remove unused variable

2015-08-20 Thread Ganesh Ajjanagadde
Fixes -Wunused-const-variable from http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 Signed-off-by: Ganesh Ajjanagadde --- libavcodec/metasound_data.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/metasound_data.c b/libavcodec/metasound_d