Re: [FFmpeg-devel] [libav-devel] [PATCH 5/6] Postpone API-incompatible changes until the next bump

2015-08-16 Thread Michael Niedermayer
On Sun, Aug 16, 2015 at 10:12:23PM +0200, Andreas Cadhalpun wrote: > Hi, > > On 16.08.2015 19:27, Ronald S. Bultje wrote: > > On Sat, Aug 8, 2015 at 7:37 AM, Andreas Cadhalpun < > > andreas.cadhal...@googlemail.com> wrote: > > > >> +#define FF_API_VOXWARE (LIBAVCODEC_VERSION_MAJOR < 58)

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-16 Thread Michael Niedermayer
On Sun, Aug 16, 2015 at 07:13:07PM -0300, Pedro Arthur wrote: > 2015-08-15 7:24 GMT-03:00 Michael Niedermayer : > > > these are not git patches > > > Yes, they are raw git diffs. > > > > > > A - New code > > > > doesnt compile (but that doesnt matter as you say this is slower anyway) > > libswsca

[FFmpeg-devel] [PATCH] lavfi: fix compilation with FF_API_OLD_FILTER_OPTS=0.

2015-08-16 Thread Ronald S. Bultje
--- ffmpeg_filter.c | 2 +- libavfilter/avfilter.c | 3 ++- libavfilter/vf_aspect.c | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ffmpeg_filter.c b/ffmpeg_filter.c index ce2ffc0..4c7f7e7 100644 --- a/ffmpeg_filter.c +++ b/ffmpeg_filter.c @@ -538,7 +538,7 @@ static

Re: [FFmpeg-devel] [PATCH] ffmpeg_vdpau: Ignore decoder's max supported level

2015-08-16 Thread Philip Langdale
On Sun, 16 Aug 2015 22:36:26 + (UTC) Carl Eugen Hoyos wrote: > Philip Langdale overt.org> writes: > > > -if (av_vdpau_bind_context(s, ctx->device, > > ctx->get_proc_address, 0)) > > +if (av_vdpau_bind_context(s, ctx->device, > > ctx->get_proc_address, AV_HWACCEL_FLAG_IGNORE_LEVEL))

Re: [FFmpeg-devel] [PATCH] ffmpeg_vdpau: Ignore decoder's max supported level

2015-08-16 Thread Carl Eugen Hoyos
Philip Langdale overt.org> writes: > -if (av_vdpau_bind_context(s, ctx->device, ctx->get_proc_address, 0)) > +if (av_vdpau_bind_context(s, ctx->device, ctx->get_proc_address, > AV_HWACCEL_FLAG_IGNORE_LEVEL)) Shouldn't this be the default? How can a level ever be a reason to fail? Carl

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-16 Thread Pedro Arthur
2015-08-15 7:24 GMT-03:00 Michael Niedermayer : > these are not git patches > Yes, they are raw git diffs. > > > A - New code > > doesnt compile (but that doesnt matter as you say this is slower anyway) > libswscale/swscale.c: In function ‘swscale’: > libswscale/swscale.c:529:18: error: ‘i’ undec

Re: [FFmpeg-devel] [PATCH] options: mark av_get_{int, double, q} as deprecated.

2015-08-16 Thread Ronald S. Bultje
Hi, On Sun, Aug 16, 2015 at 5:24 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 16.08.2015 22:15, Ronald S. Bultje wrote: > > Convert last users to av_opt_get_*() counterparts. > > --- > > libavfilter/af_aresample.c | 17 + > > libavutil/opt.h|

Re: [FFmpeg-devel] [PATCH] options: mark av_get_{int, double, q} as deprecated.

2015-08-16 Thread Andreas Cadhalpun
On 16.08.2015 22:15, Ronald S. Bultje wrote: > Convert last users to av_opt_get_*() counterparts. > --- > libavfilter/af_aresample.c | 17 + > libavutil/opt.h| 3 +++ > 2 files changed, 12 insertions(+), 8 deletions(-) I'm fine with this, but the patch is incomplete:

Re: [FFmpeg-devel] [PATCH] ffmpeg_vdpau: Ignore decoder's max supported level

2015-08-16 Thread Philip Langdale
On Sun, 16 Aug 2015 14:33:18 +0200 wm4 wrote: > On Sat, 15 Aug 2015 21:27:58 -0700 > Philip Langdale wrote: > > > The h264 decoder reports 4.1 as its maximum level, but it will > > decode 5.1 4K video just fine. In practice, the published level > > limits in vdpau do not communicate anything th

Re: [FFmpeg-devel] [PATCH] options: mark av_get_{int, double, q} as deprecated.

2015-08-16 Thread Michael Niedermayer
On Sun, Aug 16, 2015 at 04:15:47PM -0400, Ronald S. Bultje wrote: > Convert last users to av_opt_get_*() counterparts. > --- > libavfilter/af_aresample.c | 17 + > libavutil/opt.h| 3 +++ > 2 files changed, 12 insertions(+), 8 deletions(-) LGTM thanks [...] -- Mic

Re: [FFmpeg-devel] [PATCH 12/13] buffersink: use sizeof(void *) because AVFilterBufferRef is deprecated

2015-08-16 Thread Andreas Cadhalpun
On 16.08.2015 19:29, Michael Niedermayer wrote: > On Sun, Aug 16, 2015 at 06:12:19PM +0200, Andreas Cadhalpun wrote: >> buffersink.c | 16 >> 1 file changed, 8 insertions(+), 8 deletions(-) >> b75305dc96f2ec5839e29fb73102b31d62343d73 >> 0001-buffersink-introduce-FIFO_INIT_ELEM

Re: [FFmpeg-devel] [libav-devel] [PATCH 5/6] Postpone API-incompatible changes until the next bump

2015-08-16 Thread Michael Niedermayer
On Sun, Aug 16, 2015 at 03:55:55PM -0400, Ronald S. Bultje wrote: > Hi, > > On Sun, Aug 16, 2015 at 3:41 PM, Michael Niedermayer > wrote: > > > On Sun, Aug 16, 2015 at 01:27:03PM -0400, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Sat, Aug 8, 2015 at 7:37 AM, Andreas Cadhalpun < [...] > Wha

[FFmpeg-devel] [PATCH] options: mark av_get_{int, double, q} as deprecated.

2015-08-16 Thread Ronald S. Bultje
Convert last users to av_opt_get_*() counterparts. --- libavfilter/af_aresample.c | 17 + libavutil/opt.h| 3 +++ 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/libavfilter/af_aresample.c b/libavfilter/af_aresample.c index 6cb765d..f6fdd08 100644 --- a

Re: [FFmpeg-devel] [libav-devel] [PATCH 5/6] Postpone API-incompatible changes until the next bump

2015-08-16 Thread Andreas Cadhalpun
Hi, On 16.08.2015 19:27, Ronald S. Bultje wrote: > On Sat, Aug 8, 2015 at 7:37 AM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> +#define FF_API_VOXWARE (LIBAVCODEC_VERSION_MAJOR < 58) >> +#define FF_API_AC_VLC(LIBAVCODEC_VERSION_MAJOR < 58) >> +#define

Re: [FFmpeg-devel] [libav-devel] [PATCH 5/6] Postpone API-incompatible changes until the next bump

2015-08-16 Thread Ronald S. Bultje
Hi, On Sun, Aug 16, 2015 at 3:41 PM, Michael Niedermayer wrote: > On Sun, Aug 16, 2015 at 01:27:03PM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Sat, Aug 8, 2015 at 7:37 AM, Andreas Cadhalpun < > > andreas.cadhal...@googlemail.com> wrote: > > > > > Signed-off-by: Andreas Cadhalpun > > > -

Re: [FFmpeg-devel] [libav-devel] [PATCH 5/6] Postpone API-incompatible changes until the next bump

2015-08-16 Thread Michael Niedermayer
On Sun, Aug 16, 2015 at 01:27:03PM -0400, Ronald S. Bultje wrote: > Hi, > > On Sat, Aug 8, 2015 at 7:37 AM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > > > Signed-off-by: Andreas Cadhalpun > > --- > > libavcodec/version.h | 54 > > +-

Re: [FFmpeg-devel] [PATCH 5/6] Postpone API-incompatible changes until the next bump

2015-08-16 Thread Andreas Cadhalpun
On 16.08.2015 05:36, Michael Niedermayer wrote: > On Sun, Aug 16, 2015 at 05:27:12AM +0200, Michael Niedermayer wrote: >> On Sat, Aug 08, 2015 at 01:37:16PM +0200, Andreas Cadhalpun wrote: >>> Signed-off-by: Andreas Cadhalpun >> [...] >> >>> #ifndef FF_API_NOCONST_GET_NAME >>> -#define FF_API_NOC

Re: [FFmpeg-devel] [PATCH 12/13] buffersink: use sizeof(void *) because AVFilterBufferRef is deprecated

2015-08-16 Thread Michael Niedermayer
On Sun, Aug 16, 2015 at 06:12:19PM +0200, Andreas Cadhalpun wrote: > On 16.08.2015 04:53, Michael Niedermayer wrote: > > On Sat, Aug 08, 2015 at 01:33:14PM +0200, Andreas Cadhalpun wrote: > >> Signed-off-by: Andreas Cadhalpun > >> --- > >> libavfilter/buffersink.c | 12 ++-- > >> 1 file c

Re: [FFmpeg-devel] [libav-devel] [PATCH 5/6] Postpone API-incompatible changes until the next bump

2015-08-16 Thread Ronald S. Bultje
Hi, On Sat, Aug 8, 2015 at 7:37 AM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/version.h | 54 > +-- > libavfilter/version.h | 10 +- > libavformat/version.h | 6 +++

[FFmpeg-devel] [PATCH 2/2] checkasm: x86: properly save rdx/edx in checked_call()

2015-08-16 Thread Henrik Gramner
If the return value doesn't fit in a single register rdx/edx can in some cases be used in addition to rax/eax. Doesn't affect any of the existing checkasm tests but might be useful later. Also comment the relevant code a bit better. --- tests/checkasm/x86/checkasm.asm | 7 +++ 1 file changed

[FFmpeg-devel] [PATCH 1/2] checkasm: Explicitly declare function prototypes

2015-08-16 Thread Henrik Gramner
Now we no longer have to rely on function pointers intentionally declared without specified argument types. This makes it easier to support functions with floating point parameters or return values as well as functions returning 64-bit values on 32-bit architectures. It also avoids having to expli

Re: [FFmpeg-devel] [PATCH 11/13] ffmpeg: use av_buffersrc_add_frame instead of av_buffersrc_add_ref

2015-08-16 Thread Andreas Cadhalpun
On 16.08.2015 04:22, Michael Niedermayer wrote: > On Sat, Aug 08, 2015 at 01:33:06PM +0200, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> ffmpeg.c | 6 +- >> 1 file changed, 1 insertion(+), 5 deletions(-) > > probably ok Pushed. Best regards, Andreas _

Re: [FFmpeg-devel] [PATCH 03/13] avfilter: add missing FF_API_AVFILTERBUFFER guards

2015-08-16 Thread Andreas Cadhalpun
On 16.08.2015 12:28, Michael Niedermayer wrote: > On Sun, Aug 16, 2015 at 10:48:57AM +0200, Nicolas George wrote: >> Le nonidi 29 thermidor, an CCXXIII, Michael Niedermayer a écrit : >>> Why is av_buffersink_poll_frame deprecated and removed ? >> >> Its original semantic of recursing through the gr

Re: [FFmpeg-devel] [PATCH 12/13] buffersink: use sizeof(void *) because AVFilterBufferRef is deprecated

2015-08-16 Thread Andreas Cadhalpun
On 16.08.2015 04:53, Michael Niedermayer wrote: > On Sat, Aug 08, 2015 at 01:33:14PM +0200, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavfilter/buffersink.c | 12 ++-- >> 1 file changed, 6 insertions(+), 6 deletions(-) > > should be ok, if sizeof(type)is pr

Re: [FFmpeg-devel] [PATCH] ffmpeg_vdpau: Ignore decoder's max supported level

2015-08-16 Thread wm4
On Sat, 15 Aug 2015 21:27:58 -0700 Philip Langdale wrote: > The h264 decoder reports 4.1 as its maximum level, but it will decode > 5.1 4K video just fine. In practice, the published level limits in > vdpau do not communicate anything that's actually useful. > > Signed-off-by: Philip Langdale >

Re: [FFmpeg-devel] [PATCH 03/13] avfilter: add missing FF_API_AVFILTERBUFFER guards

2015-08-16 Thread Michael Niedermayer
On Sun, Aug 16, 2015 at 10:48:57AM +0200, Nicolas George wrote: > Le nonidi 29 thermidor, an CCXXIII, Michael Niedermayer a écrit : > > Why is av_buffersink_poll_frame deprecated and removed ? > > Its original semantic of recursing through the graph to count the available > frames was unsustainabl

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Fully parse and repack MP3 packets

2015-08-16 Thread Michael Niedermayer
On Sun, Aug 16, 2015 at 03:06:04AM -0500, Rodger Combs wrote: > Fixes https://trac.ffmpeg.org/ticket/4776 > --- > libavformat/matroskadec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) applied btw, if you want a git write account, send me your public ssh key thanks [...] -- Mich

Re: [FFmpeg-devel] [PATCH] avfilter: add allrgb

2015-08-16 Thread Nicolas George
Le nonidi 29 thermidor, an CCXXIII, Clement Boesch a écrit : > --- > TODO: bump lavfi version > --- > Changelog | 2 +- > doc/filters.texi | 5 ++- > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vsrc_testsrc.c | 84 > ++

Re: [FFmpeg-devel] [PATCH 03/13] avfilter: add missing FF_API_AVFILTERBUFFER guards

2015-08-16 Thread Nicolas George
Le nonidi 29 thermidor, an CCXXIII, Michael Niedermayer a écrit : > Why is av_buffersink_poll_frame deprecated and removed ? Its original semantic of recursing through the graph to count the available frames was unsustainable, some filters did return only a very rough estimate and some needed very

[FFmpeg-devel] [PATCH] lavf/matroskadec: Fully parse and repack MP3 packets

2015-08-16 Thread Rodger Combs
Fixes https://trac.ffmpeg.org/ticket/4776 --- libavformat/matroskadec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index b546798..f97ae16 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -206