Re: [FFmpeg-devel] [PATCH] avfilter/vf_colormatrix: add yuv444p support

2015-07-07 Thread Paul B Mahol
On 7/6/15, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_colormatrix.c | 53 > +++- > 1 file changed, 52 insertions(+), 1 deletion(-) applied ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] library.mak: add rpath to shared libraries

2015-07-07 Thread Ganesh Ajjanagadde
On Sun, Jul 5, 2015 at 1:01 PM, Michael Niedermayer wrote: > On Sat, Jul 04, 2015 at 10:21:47AM -0400, Ganesh Ajjanagadde wrote: >> On Sat, Jun 27, 2015 at 7:18 PM, Ganesh Ajjanagadde wrote: >> > On Sat, Jun 27, 2015 at 9:49 AM, Ganesh Ajjanagadde >> > wrote: >> >> On Sat, Jun 27, 2015 at 2:22

Re: [FFmpeg-devel] [PATCH]Tell users about Closed Captions in video streams

2015-07-07 Thread Michael Niedermayer
On Tue, Jul 07, 2015 at 10:12:05PM +, Carl Eugen Hoyos wrote: > Michael Niedermayer gmx.at> writes: > > > maybe adding the field to AVCodecInternal > > would work and be a solution ? > > enc->internal is NULL in avcodec_string(). > (That was my first try.) then i think your original patch

Re: [FFmpeg-devel] [PATCH] snow: remove strange av_assert2

2015-07-07 Thread Michael Niedermayer
On Tue, Jul 07, 2015 at 11:32:59PM +0200, Andreas Cadhalpun wrote: > On 06.07.2015 02:40, Michael Niedermayer wrote: > > On Sun, Jul 05, 2015 at 09:11:44PM +0200, Andreas Cadhalpun wrote: > >> Can you explain how elements can be too larger to fit? > > > > emulated_edge_mc() writes a block of width

Re: [FFmpeg-devel] [PATCH]Tell users about Closed Captions in video streams

2015-07-07 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > maybe adding the field to AVCodecInternal > would work and be a solution ? enc->internal is NULL in avcodec_string(). (That was my first try.) But I also wonder why library users would prefer to jump through loops to know if a video stream contains Close

Re: [FFmpeg-devel] [PATCH 2/2] wmalosslessdec: reset frame->nb_samples on packet loss

2015-07-07 Thread Andreas Cadhalpun
On 04.07.2015 02:04, Michael Niedermayer wrote: > On Fri, Jul 03, 2015 at 12:07:10AM +0200, Andreas Cadhalpun wrote: >> Otherwise a frame with non-zero nb_samples but without any data can be >> returned. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/wmalosslessdec.c | 1 + >> 1 file

Re: [FFmpeg-devel] [PATCH 1/2] wmalosslessdec: avoid reading 0 bits with get_bits

2015-07-07 Thread Andreas Cadhalpun
On 03.07.2015 00:36, Michael Niedermayer wrote: > On Fri, Jul 03, 2015 at 12:07:04AM +0200, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/wmalosslessdec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > LGTM Pushed. Best regards, Andreas __

Re: [FFmpeg-devel] [PATCH] snow: remove strange av_assert2

2015-07-07 Thread Andreas Cadhalpun
On 06.07.2015 02:40, Michael Niedermayer wrote: > On Sun, Jul 05, 2015 at 09:11:44PM +0200, Andreas Cadhalpun wrote: >> Can you explain how elements can be too larger to fit? > > emulated_edge_mc() writes a block of width x height, More precisely that's block_w x block_h. > if stride < width thi

Re: [FFmpeg-devel] [PATCH-v2] avcodec: add new Videotoolbox hwaccel.

2015-07-07 Thread Michael Niedermayer
On Sun, Jul 05, 2015 at 05:03:44PM +0200, Sebastien Zwickert wrote: > > > On 05 Jul 2015, at 16:41, Sebastien Zwickert wrote: > > > > delete mode 100644 ffmpeg_vda.c > > create mode 100644 ffmpeg_videotoolbox.c > > -M as arguments to the format-patch CLI does not detect these as rename... > >

Re: [FFmpeg-devel] [PATCH] aacenc: fix option descriptions

2015-07-07 Thread Michael Niedermayer
On Sun, Jul 05, 2015 at 04:48:19PM +0100, Rostislav Pehlivanov wrote: > Since the new PNS implementation has been merged and is no longer considered > proof of concept (as it's much more complex and better than the previous), > change the comments to reflect that. We need people testing it (since

Re: [FFmpeg-devel] [libav-devel] [PATCH 2/2] wmalosslessdec: reset frame->nb_samples on packet loss

2015-07-07 Thread Andreas Cadhalpun
On 06.07.2015 10:43, Luca Barbato wrote: > On 05/07/15 20:42, Andreas Cadhalpun wrote: >> Like that: >> if (s->packet_loss) { >> /* Reset number of saved bits so that the decoder does not start >> * to decode incomplete frames in the s->len_prefix == 0 case. */ >>

Re: [FFmpeg-devel] [PATCH] avcodec/libdcadec: export matrix encoding side data

2015-07-07 Thread James Almer
On 07/07/15 3:26 PM, Michael Niedermayer wrote: > On Tue, Jul 07, 2015 at 02:35:26PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> configure | 4 +++- >> libavcodec/libdcadec.c | 21 + >> 2 files changed, 24 insertions(+), 1 deletion(-) > > L

Re: [FFmpeg-devel] [PATCH] Put a space between string literals and macros.

2015-07-07 Thread Michael Niedermayer
On Tue, Jul 07, 2015 at 05:49:12PM +, Chris Watkins wrote: > Hi, > > This patch fixes a simple compiler warning: > > When compiling libavutil/internal.h as C++11, clang warns that a space is > required between a string literal and an identifier. Put spaces in > concatenations of string litera

Re: [FFmpeg-devel] [PATCH]Tell users about Closed Captions in video streams

2015-07-07 Thread Michael Niedermayer
On Tue, Jul 07, 2015 at 12:49:23PM +, Paul B Mahol wrote: > On 7/7/15, Carl Eugen Hoyos wrote: > > Paul B Mahol gmail.com> writes: > > > >> > How can we proceed? > >> > >> Adding side data. > > > > I was under the impression that side date > > is used for communication between different > > l

Re: [FFmpeg-devel] [PATCH 1/2] configure: loongson enabled local aligned 32

2015-07-07 Thread Michael Niedermayer
On Mon, Jul 06, 2015 at 05:16:49PM +0800, 周晓勇 wrote: > From 7cef687fac2f056a0f1a6e7cf65df5358b16a642 Mon Sep 17 00:00:00 2001 > From: ZhouXiaoyong > Date: Mon, 6 Jul 2015 09:42:17 +0800 > Subject: [PATCH 1/2] configure: loongson enabled local aligned 32 applied thanks [...] -- Michael GnuP

Re: [FFmpeg-devel] [PATCH] avcodec/libdcadec: export matrix encoding side data

2015-07-07 Thread Michael Niedermayer
On Tue, Jul 07, 2015 at 02:35:26PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > configure | 4 +++- > libavcodec/libdcadec.c | 21 + > 2 files changed, 24 insertions(+), 1 deletion(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF21

Re: [FFmpeg-devel] [PATCH 1/3] avutil: add AYVU16LE and AYVU16BE packed pixel format

2015-07-07 Thread wm4
On Tue, 7 Jul 2015 14:57:28 + (UTC) Carl Eugen Hoyos wrote: > Paul B Mahol gmail.com> writes: > > > +AV_PIX_FMT_AYUV16LE,///< packed AYUV 4:4:4,64bpp > > (1 Cr & Cb sample per 1x1 Y & A samples), little-endian > > +AV_PIX_FMT_AYUV16BE,///< packed AYUV 4:4:4,64bpp > > (1 Cr

Re: [FFmpeg-devel] [PATCH]Tell users about Closed Captions in video streams

2015-07-07 Thread Carl Eugen Hoyos
wm4 googlemail.com> writes: > > > Adding side data. > > > > I was under the impression that side date > > is used for communication between different > > libraries. Is that wrong? > > Yes. So how can avcodec_string() use side data? Carl Eugen ___

[FFmpeg-devel] [PATCH] Put a space between string literals and macros.

2015-07-07 Thread Chris Watkins
Hi, This patch fixes a simple compiler warning: When compiling libavutil/internal.h as C++11, clang warns that a space is required between a string literal and an identifier. Put spaces in concatenations of string literals and EXTERN_PREFIX. Thanks, Chris From e6a21650b18896ac14070a0237b68bf4d36

Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not unecessarily consume memory for cuepoints

2015-07-07 Thread Carl Eugen Hoyos
On Tuesday 07 July 2015 06:45:04 pm Michael Niedermayer wrote: > On Tue, Jul 07, 2015 at 03:13:06PM +0200, Carl Eugen Hoyos wrote: > > Hi! > > > > Matroska streaming currently consumes memory for > > cuepoints that are never used if the output stream > > is no seekable. This can lead to oom. > > At

Re: [FFmpeg-devel] [PATCH 1/3] avutil: add AYVU16LE and AYVU16BE packed pixel format

2015-07-07 Thread Michael Niedermayer
On Tue, Jul 07, 2015 at 02:57:28PM +, Carl Eugen Hoyos wrote: > Paul B Mahol gmail.com> writes: > > > +AV_PIX_FMT_AYUV16LE,///< packed AYUV 4:4:4,64bpp > > (1 Cr & Cb sample per 1x1 Y & A samples), little-endian > > +AV_PIX_FMT_AYUV16BE,///< packed AYUV 4:4:4,64bpp > > (1 Cr

[FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: incorrect loop condition has been fixed.

2015-07-07 Thread Ivan Uskov
Hello All, For example, the encoder may return MFX_WRN_INCOMPATIBLE_VIDEO_PARAM warning i.e. ret==5 old loop implementation will repeat several times until output buffer overflow. New implementation explicitly uses loop only for device busy case. -- Best regards, Ivan

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libdcadec: export matrix encoding side data

2015-07-07 Thread James Almer
On 07/07/15 1:23 PM, Michael Niedermayer wrote: > On Tue, Jul 07, 2015 at 05:29:17PM +0200, Hendrik Leppkes wrote: >> On Tue, Jul 7, 2015 at 1:46 PM, Michael Niedermayer wrote: >>> On Tue, Jul 07, 2015 at 03:06:23AM -0300, James Almer wrote: Signed-off-by: James Almer --- libavcod

Re: [FFmpeg-devel] [PATCH]Tell users about Closed Captions in video streams

2015-07-07 Thread wm4
On Tue, 7 Jul 2015 12:35:01 + (UTC) Carl Eugen Hoyos wrote: > Paul B Mahol gmail.com> writes: > > > > How can we proceed? > > > > Adding side data. > > I was under the impression that side date > is used for communication between different > libraries. Is that wrong? Yes. > This is ab

[FFmpeg-devel] [PATCH] avcodec/libdcadec: export matrix encoding side data

2015-07-07 Thread James Almer
Signed-off-by: James Almer --- configure | 4 +++- libavcodec/libdcadec.c | 21 + 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/configure b/configure index bb3041b..962afce 100755 --- a/configure +++ b/configure @@ -1829,6 +1829,7 @@ TYPES_LIST="

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/internal: Document how to avoid the internal->byte_buffer with ff_alloc_packet2()

2015-07-07 Thread Michael Niedermayer
On Mon, Jul 06, 2015 at 12:13:41PM +0200, Hendrik Leppkes wrote: > On Mon, Jul 6, 2015 at 12:07 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/internal.h |3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/libavcodec/internal.h b/lib

Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not unecessarily consume memory for cuepoints

2015-07-07 Thread Michael Niedermayer
On Tue, Jul 07, 2015 at 03:13:06PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Matroska streaming currently consumes memory for > cuepoints that are never used if the output stream > is no seekable. This can lead to oom. > Attached patch fixes ticket #4690. > > Please comment, Carl Eugen > matro

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libdcadec: export matrix encoding side data

2015-07-07 Thread Michael Niedermayer
On Tue, Jul 07, 2015 at 05:29:17PM +0200, Hendrik Leppkes wrote: > On Tue, Jul 7, 2015 at 1:46 PM, Michael Niedermayer wrote: > > On Tue, Jul 07, 2015 at 03:06:23AM -0300, James Almer wrote: > >> Signed-off-by: James Almer > >> --- > >> libavcodec/libdcadec.c | 19 +++ > >> 1 fil

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libdcadec: export matrix encoding side data

2015-07-07 Thread Hendrik Leppkes
On Tue, Jul 7, 2015 at 1:46 PM, Michael Niedermayer wrote: > On Tue, Jul 07, 2015 at 03:06:23AM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/libdcadec.c | 19 +++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/libavcodec/libdcadec.c b/libav

Re: [FFmpeg-devel] [PATCH 1/3] avutil: add AYVU16LE and AYVU16BE packed pixel format

2015-07-07 Thread Paul B Mahol
On 7/7/15, Carl Eugen Hoyos wrote: > Paul B Mahol gmail.com> writes: > >> +AV_PIX_FMT_AYUV16LE,///< packed AYUV 4:4:4,64bpp >> (1 Cr & Cb sample per 1x1 Y & A samples), little-endian >> +AV_PIX_FMT_AYUV16BE,///< packed AYUV 4:4:4,64bpp >> (1 Cr & Cb sample per 1x1 Y & A samples),

Re: [FFmpeg-devel] [PATCH] conversion of FFV1 specification from lyx to markdown

2015-07-07 Thread Dave Rice
Hi, > On Jul 7, 2015, at 10:35 AM, Michael Niedermayer wrote: > > On Thu, Jul 02, 2015 at 09:50:21AM -0400, Dave Rice wrote: >> Hi all, >> Last month I posted a draft of the FFV1 specification formatted in Markdown >> [1], whereas it currently lives in lyx. From that post there were responses

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for highlight and hilightcolor box

2015-07-07 Thread Niklesh Lalwani
On Tue, Jul 7, 2015 at 3:12 AM, Clément Bœsch wrote: > On Mon, Jul 06, 2015 at 10:27:47PM +0530, Niklesh Lalwani wrote: > > From: Niklesh > > > > Signed-off-by: Niklesh > > --- > > libavcodec/movtextdec.c | 254 > +--- > > 1 file changed, 173 inserti

Re: [FFmpeg-devel] [PATCH 1/3] avutil: add AYVU16LE and AYVU16BE packed pixel format

2015-07-07 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > +AV_PIX_FMT_AYUV16LE,///< packed AYUV 4:4:4,64bpp > (1 Cr & Cb sample per 1x1 Y & A samples), little-endian > +AV_PIX_FMT_AYUV16BE,///< packed AYUV 4:4:4,64bpp > (1 Cr & Cb sample per 1x1 Y & A samples), big-endian I believe only one should be

Re: [FFmpeg-devel] [PATCH] conversion of FFV1 specification from lyx to markdown

2015-07-07 Thread Michael Niedermayer
On Thu, Jul 02, 2015 at 09:50:21AM -0400, Dave Rice wrote: > Hi all, > Last month I posted a draft of the FFV1 specification formatted in Markdown > [1], whereas it currently lives in lyx. From that post there were responses > in favor of the use of Markdown formatting and suggestions to not use

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for idctdsp functions

2015-07-07 Thread Michael Niedermayer
On Mon, Jun 29, 2015 at 08:57:15PM +0530, shivraj.pa...@imgtec.com wrote: > From: Shivraj Patil > > This patch adds MSA (MIPS-SIMD-Arch) optimizations for idctdsp functions in > new file idctdsp_msa.c and simple_idct_msa.c > > Signed-off-by: Shivraj Patil > --- > libavcodec/idctdsp.c

Re: [FFmpeg-devel] [PATCH]Use av_log to print benchmark output

2015-07-07 Thread Michael Niedermayer
On Tue, Jul 07, 2015 at 03:29:49PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch stops -benchmark from using stdout. > > Please comment, Carl Eugen i wonder why this used printf() maybe wait a day or 2 before applying in case there was a reason that i forgot otherwise LGTM [...] --

[FFmpeg-devel] [PATCH]Use av_log to print benchmark output

2015-07-07 Thread Carl Eugen Hoyos
Hi! Attached patch stops -benchmark from using stdout. Please comment, Carl Eugen diff --git a/ffmpeg.c b/ffmpeg.c index e592629..32d0cf7 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -473,7 +473,7 @@ static void ffmpeg_cleanup(int ret) if (do_benchmark) { int maxrss = getmaxrss() / 102

[FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not unecessarily consume memory for cuepoints

2015-07-07 Thread Carl Eugen Hoyos
Hi! Matroska streaming currently consumes memory for cuepoints that are never used if the output stream is no seekable. This can lead to oom. Attached patch fixes ticket #4690. Please comment, Carl Eugen diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 3b525ad..f07851e 1

Re: [FFmpeg-devel] [PATCH]Tell users about Closed Captions in video streams

2015-07-07 Thread Paul B Mahol
On 7/7/15, Carl Eugen Hoyos wrote: > Paul B Mahol gmail.com> writes: > >> > How can we proceed? >> >> Adding side data. > > I was under the impression that side date > is used for communication between different > libraries. Is that wrong? > > This is about storing information about video > strea

Re: [FFmpeg-devel] [PATCH]Tell users about Closed Captions in video streams

2015-07-07 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > > How can we proceed? > > Adding side data. I was under the impression that side date is used for communication between different libraries. Is that wrong? This is about storing information about video streams and using this information within libavcodec.

Re: [FFmpeg-devel] [PATCH]Tell users about Closed Captions in video streams

2015-07-07 Thread Paul B Mahol
On 7/7/15, Carl Eugen Hoyos wrote: > Carl Eugen Hoyos ag.or.at> writes: > >> > > As in attached? >> > >> > If anything it should use the automatic accessor macros, >> >> I don't think that works, no setter is needed. >> >> > but I still find it a silly solution. >> >> Then please suggest another

Re: [FFmpeg-devel] Subject: [PATCH] libavcodec/qsv.c: Linux-only code part has been moved to separate function in order to avoid the "ISO C90 forbids mixed declarations and code" compiler warning.

2015-07-07 Thread Michael Niedermayer
On Mon, Jul 06, 2015 at 09:37:52PM +0300, Ivan Uskov wrote: > Hello All, > > Unfortunately, previous patch for libavcodec/qsv.c at the commit > db89f45535aa3e99bceb5f6bf957c90e7ca39841 does initiate the compiler warning > "ISO C90 forbids mixed declarations and code" under linux platform, > becau

Re: [FFmpeg-devel] [PATCH]Tell users about Closed Captions in video streams

2015-07-07 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > > > As in attached? > > > > If anything it should use the automatic accessor macros, > > I don't think that works, no setter is needed. > > > but I still find it a silly solution. > > Then please suggest another solution. Ping. How can we proceed? Carl

Re: [FFmpeg-devel] [PATCH]Only fail aac mpegts muxing if the first frame is broken

2015-07-07 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > Attached patch fixes ticket #3957 here, the output > file plays fine with WMP and QT. Reviewed an merged by Michael. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/m

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libdcadec: export matrix encoding side data

2015-07-07 Thread Michael Niedermayer
On Tue, Jul 07, 2015 at 03:06:23AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/libdcadec.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/libavcodec/libdcadec.c b/libavcodec/libdcadec.c > index 890d270..4bc3765 100644 > --- a/libavcode

[FFmpeg-devel] Bug with dvbsub codec on FFmpeg

2015-07-07 Thread Ilir Pruthi
Hello everyone, I would like to bring to your attention a known bug with FFMpeg's dvbsub codec that seems to work fine with VLC. It is well-documented on this ticket: https://trac.ffmpeg.org/ticket/4200 Can someone please take a look and see if a fix is possible in the near future? Thank you fo