On Tue, Jun 23, 2015 at 07:36:54AM -0700, Philip Langdale wrote:
> On Tue, 23 Jun 2015 11:14:36 +0530
> Niklesh Lalwani wrote:
>
> > On 6/23/15, Philip Langdale wrote:
> > > I got a bunch of warnings when I compiled it. Please fix.
> > >
> > > Thanks.
> > >
> > >
Signed-off-by: Paul B Mahol
---
libavcodec/evrcdec.c | 29 ++---
1 file changed, 26 insertions(+), 3 deletions(-)
diff --git a/libavcodec/evrcdec.c b/libavcodec/evrcdec.c
index c605a13..cb1b509 100644
--- a/libavcodec/evrcdec.c
+++ b/libavcodec/evrcdec.c
@@ -26,6 +26,7 @@
Thank you for the detailed reply. It has helped me understand the
structures a lot better than before.
Comments inline.
On Tue, Jun 23, 2015 at 5:25 PM, Nicolas George wrote:
> This has better go to the mailing list.
>
> Le quintidi 5 messidor, an CCXXIII, Stephan Holljes a écrit :
>> So far I ha
On Tue, Jun 23, 2015 at 4:18 PM, Ronald S. Bultje wrote:
> Hello,
>
> On Tue, Jun 23, 2015 at 6:21 PM, James Zern wrote:
>
>> ---
>> libavcodec/libvpxdec.c | 20
>> 1 file changed, 20 insertions(+)
>>
>
> lgtm.
>
> (This is probably a weird/stupid question, but I wonder if i
---
libavcodec/Makefile| 2 -
libavcodec/api-flac-test.c | 266 -
tests/Makefile | 1 +
tests/api/Makefile | 3 +
tests/api/api-flac-test.c | 266 +
tests/fate/api.mak
The intention of this change is to allow separation of API tests from the
existing tests, and also to have a place for the API test source/executable
files so they're not mixed in with the actual library code.
---
tests/Makefile | 3 +++
tests/api/Makefile | 9 +
2 files changed, 12 in
On Tue, Jun 23, 2015 at 8:34 PM, Michael Niedermayer
wrote:
> On Mon, Jun 22, 2015 at 12:01:33AM +0200, Mariusz Szczepańczyk wrote:
> > ---
> > configure | 2 ++
> > libavformat/file.c | 34 ++
> > 2 files changed, 36 insertions(+)
>
> this and the previ
On Tue, 23 Jun 2015 22:09:20 +0200
Michael Niedermayer wrote:
> On Wed, Jun 24, 2015 at 01:25:53AM +0530, Niklesh Lalwani wrote:
> > Updated patch.
> > Compiles without any warnings. Tested too.
>
> this changes the fate checksum
>
> --- ./tests/ref/fate/binsub-movtextenc 2015-06-23 21:52:17.7
On 23/06/15 7:21 PM, James Zern wrote:
> ---
> libavcodec/libvpxdec.c | 20
> 1 file changed, 20 insertions(+)
>
> diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c
> index c69e888..b31e7b9 100644
> --- a/libavcodec/libvpxdec.c
> +++ b/libavcodec/libvpxdec.c
> @@ -
Hi,
On Tue, Jun 23, 2015 at 6:21 PM, James Zern wrote:
> ---
> libavcodec/libvpxdec.c | 7 +++
> 1 file changed, 7 insertions(+)
sgtm.
Ronald
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Hello,
On Tue, Jun 23, 2015 at 6:21 PM, James Zern wrote:
> ---
> libavcodec/libvpxdec.c | 20
> 1 file changed, 20 insertions(+)
>
lgtm.
(This is probably a weird/stupid question, but I wonder if it makes sense,
conceptually, to share the profiles array between vp9.c and
On Tue, Jun 23, 2015 at 03:04:20AM +0200, Mariusz Szczepańczyk wrote:
> ---
> libavformat/libssh.c | 3 +++
> 1 file changed, 3 insertions(+)
applied
thanks
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
If you think the mosad wants you dead since a long time
On Tue, Jun 23, 2015 at 03:04:21AM +0200, Mariusz Szczepańczyk wrote:
> ---
> libavformat/libssh.c | 82
>
> 1 file changed, 82 insertions(+)
applied
thanks
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
R
On Tue, Jun 23, 2015 at 03:04:19AM +0200, Mariusz Szczepańczyk wrote:
> From: Lukasz Marek
>
> Signed-off-by: Lukasz Marek
> ---
> libavformat/libssh.c | 111
> ---
> 1 file changed, 105 insertions(+), 6 deletions(-)
applied
thanks
[...]
--
M
On Mon, Jun 22, 2015 at 04:58:00AM +0200, Mariusz Szczepańczyk wrote:
> ---
> libavformat/libsmbclient.c | 63
> ++
> 1 file changed, 63 insertions(+)
applied
thanks
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I
---
libavcodec/libvpxdec.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c
index b31e7b9..0e3ed6f 100644
--- a/libavcodec/libvpxdec.c
+++ b/libavcodec/libvpxdec.c
@@ -62,6 +62,13 @@ static av_cold int vpx_init(AVCodecContext *avctx,
// re
On Wed, Jun 24, 2015 at 01:25:53AM +0530, Niklesh Lalwani wrote:
> Updated patch.
> Compiles without any warnings. Tested too.
this changes the fate checksum
--- ./tests/ref/fate/binsub-movtextenc 2015-06-23 21:52:17.741843656 +0200
+++ tests/data/fate/binsub-movtextenc 2015-06-23 22:06:37.389
Updated patch.
Compiles without any warnings. Tested too.
Thanks,
Niklesh
On Tue, Jun 23, 2015 at 9:42 PM, Niklesh Lalwani wrote:
>
> On 23-Jun-2015 8:41 PM, "Philip Langdale" wrote:
> >
> > On Tue, 23 Jun 2015 16:54:08 +0200
> > wm4 wrote:
> >
> > > In my opinion these warnings should either
On Mon, Jun 22, 2015 at 12:01:33AM +0200, Mariusz Szczepańczyk wrote:
> ---
> configure | 2 ++
> libavformat/file.c | 34 ++
> 2 files changed, 36 insertions(+)
this and the previous patch fails to build
make distclean ; ./configure --disable-sdl && mak
On Tue, Jun 23, 2015 at 12:35:36PM -0500, Rodger Combs wrote:
> ---
> tests/fate/demux.mak | 4
> tests/ref/fate/bcstm | 1 +
> tests/ref/fate/bfstm | 1 +
> 3 files changed, 6 insertions(+)
> create mode 100644 tests/ref/fate/bcstm
> create mode 100644 tests/ref/fate/bfstm
applied
thanks
---
doc/general.texi| 2 +-
libavcodec/adpcm.c | 4 ++--
libavcodec/codec_desc.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/doc/general.texi b/doc/general.texi
index 471a11b..dc4d06e 100644
--- a/doc/general.texi
+++ b/doc/general.texi
@@ -878,7 +878,7 @@
---
tests/fate/demux.mak | 4
tests/ref/fate/bcstm | 1 +
tests/ref/fate/bfstm | 1 +
3 files changed, 6 insertions(+)
create mode 100644 tests/ref/fate/bcstm
create mode 100644 tests/ref/fate/bfstm
diff --git a/tests/fate/demux.mak b/tests/fate/demux.mak
index 0eccc9b..05ce4bf 100644
---
---
libavformat/brstm.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/libavformat/brstm.c b/libavformat/brstm.c
index 1d190c9..62940f0 100644
--- a/libavformat/brstm.c
+++ b/libavformat/brstm.c
@@ -93,6 +93,7 @@ static int read_header(AVFormatContext *s)
---
libavformat/brstm.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/libavformat/brstm.c b/libavformat/brstm.c
index 62940f0..bf75d5b 100644
--- a/libavformat/brstm.c
+++ b/libavformat/brstm.c
@@ -369,6 +369,15 @@ static int read_packet(AVFormatContext *s, AVPacket *pkt)
s
On Tue, 23 Jun 2015 17:33:42 +0200
Nicolas George wrote:
> Le quintidi 5 messidor, an CCXXIII, wm4 a écrit :
> > People don't follow mathematic rules, and neither do human arguments.
> > Not even software development does.
>
> And yet, even so, the reasoning discipline gives valuable results eve
On 23/06/15 7:48 AM, Michael Niedermayer wrote:
> On Tue, Jun 23, 2015 at 01:23:23AM -0300, James Almer wrote:
>> Signed-off-by: James Almer
>> ---
>> libswscale/x86/rgb2rgb_template.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> LGTM
>
> thanks
All three patches pushed.
_
This was suggested in the discussion about these functions
With this change the functions are available internally but are not
part of the public API
Signed-off-by: Michael Niedermayer
---
doc/APIchanges |4
libavformat/avio.c |4 ++--
libavformat/avio.h |4 ++--
3 files ch
On 23-Jun-2015 8:41 PM, "Philip Langdale" wrote:
>
> On Tue, 23 Jun 2015 16:54:08 +0200
> wm4 wrote:
>
> > In my opinion these warnings should either be silenced, or an
> > av_bprint function taking void* should be added and used. While the
> > warning is indeed a false positive here, they can ob
On Tue, Jun 23, 2015 at 11:38:37AM +, Paul B Mahol wrote:
> On 6/23/15, Michael Niedermayer wrote:
> > On Sat, Jun 20, 2015 at 05:01:25AM -0500, Rodger Combs wrote:
> >> ---
> >> tests/fate/demux.mak | 4
> >> tests/ref/fate/bfstm | 1 +
> >> 2 files changed, 5 insertions(+)
> >> create
On 6/23/15, Ronald S. Bultje wrote:
> Hi,
>
> On Tue, Jun 23, 2015 at 10:45 AM, Ronald S. Bultje
> wrote:
>
>> On Tue, Jun 23, 2015 at 10:42 AM, Paul B Mahol wrote:
>>
>>> On 6/22/15, Paul B Mahol wrote:
>>> > On 6/22/15, Nicolas George wrote:
>>> >> Le quartidi 4 messidor, an CCXXIII, Paul B
Le quintidi 5 messidor, an CCXXIII, Paul B Mahol a écrit :
> Well tiny_ssim computes PSNR from SSIM but numbers do not match other
> implementations.
> I'm sure that our MSE(and PSNR) calculations in vf_psnr.c matches
> numbers from some page
> linked from wikipedia.
>
> Computations of PSNR and S
Le quintidi 5 messidor, an CCXXIII, wm4 a écrit :
> People don't follow mathematic rules, and neither do human arguments.
> Not even software development does.
And yet, even so, the reasoning discipline gives valuable results even in
these areas. Wonderful, isn't it?
> The current architecture ju
This has better go to the mailing list.
Le quintidi 5 messidor, an CCXXIII, Stephan Holljes a écrit :
> So far I have split ff_listen_bind() into ff_listen_bind() and
> ff_accept() and added an url_accept field to URLProtocol (see attached
> patch).
I do not believe this is the correct approach.
On Tue, 23 Jun 2015 16:54:08 +0200
wm4 wrote:
> In my opinion these warnings should either be silenced, or an
> av_bprint function taking void* should be added and used. While the
> warning is indeed a false positive here, they can obscure interesting
> warnings.
A fair point.
Niklesh, why don'
On 6/23/15, Nicolas George wrote:
> Le quintidi 5 messidor, an CCXXIII, Paul B Mahol a ecrit :
>> Looks like there are no new comments so I can safely assume current
>> state as is is good enough.
>
> If you want to be really safe, you can observe that there is an unanswered
> question and assume
On Tue, 23 Jun 2015 11:14:36 +0530
Niklesh Lalwani wrote:
> On 6/23/15, Philip Langdale wrote:
> > I got a bunch of warnings when I compiled it. Please fix.
> >
> > Thanks.
> >
> > --
> >
> > CC libavcodec/movtextenc.o
> > libavcodec/movtex
Le quintidi 5 messidor, an CCXXIII, Paul B Mahol a écrit :
> Looks like there are no new comments so I can safely assume current
> state as is is good enough.
If you want to be really safe, you can observe that there is an unanswered
question and assume that <20 hours is not enough to be sure ther
Hi,
On Tue, Jun 23, 2015 at 10:45 AM, Ronald S. Bultje
wrote:
> On Tue, Jun 23, 2015 at 10:42 AM, Paul B Mahol wrote:
>
>> On 6/22/15, Paul B Mahol wrote:
>> > On 6/22/15, Nicolas George wrote:
>> >> Le quartidi 4 messidor, an CCXXIII, Paul B Mahol a ecrit :
>> >>> Signed-off-by: Paul B Mahol
Hi,
On Tue, Jun 23, 2015 at 10:42 AM, Paul B Mahol wrote:
> On 6/22/15, Paul B Mahol wrote:
> > On 6/22/15, Nicolas George wrote:
> >> Le quartidi 4 messidor, an CCXXIII, Paul B Mahol a ecrit :
> >>> Signed-off-by: Paul B Mahol
> >>> ---
> >>> Changelog| 1 +
> >>> doc/filt
On Tue, Jun 23, 2015 at 01:56:57PM +, Ludmila Glinskih wrote:
> Do you have any ideas why it differs from framecrc result on the same file?
[...]
> > --- /dev/null
> > +++ b/tests/ref/fate/api-h264
> > @@ -0,0 +1,18 @@
> > +#tb 0: 1/120
the timebase and timestamps differ as ffmpeg*.c does
On 6/22/15, Paul B Mahol wrote:
> On 6/22/15, Nicolas George wrote:
>> Le quartidi 4 messidor, an CCXXIII, Paul B Mahol a ecrit :
>>> Signed-off-by: Paul B Mahol
>>> ---
>>> Changelog| 1 +
>>> doc/filters.texi | 53
>>> libavfilter/Makefile | 1 +
>>>
On Tue, 23 Jun 2015 11:14:36 +0530
Niklesh Lalwani wrote:
> On 6/23/15, Philip Langdale wrote:
> > I got a bunch of warnings when I compiled it. Please fix.
> >
> > Thanks.
> >
> > --
> >
> > CC libavcodec/movtextenc.o
> > libavcodec/movtex
.vp6 files may contain two video streams: one for the primary video
stream and another for the alpha mask. The file format uses identical
data structures for both streams.
Signed-off-by: Peter Ross
---
libavformat/electronicarts.c | 136 +--
1 file changed
Do you have any ideas why it differs from framecrc result on the same file?
пн, 22 июня 2015 г. в 12:50, Ludmila Glinskih :
> Result differs in pkt_duration and time_base.den for some reason.
> Right now it tests only one example (adjusted to match the output).
>
> Signed-off-by: Ludmila Glinskih
Hi,
On Tue, Jun 23, 2015 at 9:27 AM, wm4 wrote:
> On Tue, 23 Jun 2015 16:05:38 +0300
> Ludmila Glinskih wrote:
>
> > Result differs in pkt_duration and time_base.den for some reason.
> > Right now it tests only one example (adjusted to match the output).
> >
> > Signed-off-by: Ludmila Glinskih
On Tue, 23 Jun 2015 16:05:38 +0300
Ludmila Glinskih wrote:
> Result differs in pkt_duration and time_base.den for some reason.
> Right now it tests only one example (adjusted to match the output).
>
> Signed-off-by: Ludmila Glinskih
> ---
> libavformat/Makefile| 1 +
> libavformat/ap
Hi,
On Tue, Jun 23, 2015 at 9:05 AM, Ludmila Glinskih
wrote:
> +do {
> +if (pkt.stream_index != video_stream)
> +break;
That check shouldn't be necessary for the last frame. Sorry for missing
that on the first iteration.
Ronald
_
Now there are no warnings, more checks, more error messages. I changed the loop
for the last frames.
If the error occures program returns 1.
Thank you for comments!
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo
Result differs in pkt_duration and time_base.den for some reason.
Right now it tests only one example (adjusted to match the output).
Signed-off-by: Ludmila Glinskih
---
libavformat/Makefile| 1 +
libavformat/api-h264-test.c | 187
tests/fat
2015-06-23 13:10 GMT+02:00 Michael Niedermayer :
> On Tue, Jun 23, 2015 at 11:50:52AM +0200, Gwenole Beauchesne wrote:
>> Use new H264Ref.reference field to track field picture flags. The
>> H264Picture.reference flag in DPB is now irrelevant here.
>>
>> This is a regression from git commit d8151a7
On 6/23/15, Michael Niedermayer wrote:
> On Sat, Jun 20, 2015 at 05:01:25AM -0500, Rodger Combs wrote:
>> ---
>> tests/fate/demux.mak | 4
>> tests/ref/fate/bfstm | 1 +
>> 2 files changed, 5 insertions(+)
>> create mode 100644 tests/ref/fate/bfstm
>
> seems to fail
>
> --- ./tests/ref/fate
On Sat, Jun 20, 2015 at 05:01:25AM -0500, Rodger Combs wrote:
> ---
> tests/fate/demux.mak | 4
> tests/ref/fate/bfstm | 1 +
> 2 files changed, 5 insertions(+)
> create mode 100644 tests/ref/fate/bfstm
seems to fail
--- ./tests/ref/fate/bfstm 2015-06-23 13:24:53.153202270 +0200
+++ t
On Tue, 23 Jun 2015 12:51:18 +0200
Nicolas George wrote:
> Le quintidi 5 messidor, an CCXXIII, wm4 a écrit :
> > I think you're alone with this.
>
> I do not intend to push for it, it was just an extreme example. I do maths,
> and there is one thing we learn: if you want to know how solid an arg
On Tue, Jun 23, 2015 at 11:50:52AM +0200, Gwenole Beauchesne wrote:
> Use new H264Ref.reference field to track field picture flags. The
> H264Picture.reference flag in DPB is now irrelevant here.
>
> This is a regression from git commit d8151a7, and that affected
> multiple interlaced video stream
On Tue, Jun 23, 2015 at 01:23:24AM -0300, James Almer wrote:
> Signed-off-by: James Almer
> ---
> libswscale/x86/rgb2rgb_template.c | 4
> 1 file changed, 4 insertions(+)
LGTM
thanks
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
No snowflake in an aval
On Tue, Jun 23, 2015 at 01:23:25AM -0300, James Almer wrote:
> Signed-off-by: James Almer
> ---
> libswscale/x86/rgb2rgb_template.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
LGTM
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The real ebay
Le quintidi 5 messidor, an CCXXIII, wm4 a écrit :
> I think you're alone with this.
I do not intend to push for it, it was just an extreme example. I do maths,
and there is one thing we learn: if you want to know how solid an argument
is, push it to the extreme. If you suspect f is monotonic and w
On Tue, Jun 23, 2015 at 01:23:23AM -0300, James Almer wrote:
> Signed-off-by: James Almer
> ---
> libswscale/x86/rgb2rgb_template.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
LGTM
thanks
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The real eb
On Tue, 23 Jun 2015 11:05:31 +0200
Nicolas George wrote:
> Yes, libavspellcheck! I used it as an absurd example, but if you think
> carefully on it, it is not actually absurd.
I think you're alone with this.
libav* are for (de)muxing and decoding/encoding. That's why people are
using it. Everyt
Use new H264Ref.reference field to track field picture flags. The
H264Picture.reference flag in DPB is now irrelevant here.
This is a regression from git commit d8151a7, and that affected
multiple interlaced video streams.
Signed-off-by: Gwenole Beauchesne
---
libavcodec/vaapi_h264.c | 3 ++-
1
Le quintidi 5 messidor, an CCXXIII, Derek Buitenhuis a écrit :
> The crux of the issue here is that there is disagreement on whether some
> features
> should be in libav* at all. It's separation of functionality. It's not really
> possible to show something satisfactory when it's the wrong place f
On Sat, Jun 20, 2015 at 01:19:29PM +0200, Sebastien Zwickert wrote:
> The pixel buffer base address is never unlocked this causes
> a bug with some pixel format types that are produced natively
> by the hardware decoder: the first buffer was always used.
> Unlock the pixel buffer base address fixes
62 matches
Mail list logo
