Re: [FFmpeg-devel] [PATCH 1/2] id3v2: do not export APIC description if empty

On Thu, May 07, 2015 at 11:56:36PM +0200, wm4 wrote: > APIC tags always have a description. Tag writers obviously leave it > empty if there is no description. In this case, libavformat would export > "" as title. Do not set the title instead. > --- > Somewhat questionable. Take it or leave it. > --

Re: [FFmpeg-devel] [PATCH] pngdec: set correct range

On Thu, May 07, 2015 at 11:37:18PM +0200, wm4 wrote: > AV_PIX_FMT_GRAY8/16 are considered YUV formats, and the color_range is > not set - so the API user will have to assume limitted range. (Unless > the API user adds a special-case for the PNG decoder.) > > Just export the correct range - full ra

Re: [FFmpeg-devel] [PATCH] pngdec: set correct range

On Thu, 7 May 2015 22:00:32 + (UTC) Carl Eugen Hoyos wrote: > wm4 googlemail.com> writes: > > > > I believe this is slightly misleading: gray8 and > > > gray16 are interpreted as full-range by default > > > since years. > > > > Really? Where? > > In the software scaler. Doesn't matter

Re: [FFmpeg-devel] [PATCH] pngdec: set correct range

wm4 googlemail.com> writes: > > I believe this is slightly misleading: gray8 and > > gray16 are interpreted as full-range by default > > since years. > > Really? Where? In the software scaler. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@

[FFmpeg-devel] [PATCH 1/2] id3v2: do not export APIC description if empty

APIC tags always have a description. Tag writers obviously leave it empty if there is no description. In this case, libavformat would export "" as title. Do not set the title instead. --- Somewhat questionable. Take it or leave it. --- libavformat/id3v2.c | 3 ++- 1 file changed, 2 insertions(+),

[FFmpeg-devel] [PATCH 2/2] id3v2: strip trailing spaces from APIC tag

The APIC description must be unique, and some ID3v2 tag writers add spaces to write several APIC entries with the same description. The trailing spaces simply serve as a way to disambiguate the description. Do this so that API users do not have to special-case mp3 to fix this cosmetic issue. --- Al

Re: [FFmpeg-devel] [PATCH] pngdec: set correct range

On Thu, 7 May 2015 21:47:22 + (UTC) Carl Eugen Hoyos wrote: > wm4 googlemail.com> writes: > > > AV_PIX_FMT_GRAY8/16 are considered YUV formats, > > and the color_range is not set - so the API user > > will have to assume limitted range. (Unless the > > API user adds a special-case for th

Re: [FFmpeg-devel] [PATCH] pngdec: set correct range

wm4 googlemail.com> writes: > AV_PIX_FMT_GRAY8/16 are considered YUV formats, > and the color_range is not set - so the API user > will have to assume limitted range. (Unless the > API user adds a special-case for the PNG decoder.) I believe this is slightly misleading: gray8 and gray16 are

[FFmpeg-devel] [PATCH] pngdec: set correct range

AV_PIX_FMT_GRAY8/16 are considered YUV formats, and the color_range is not set - so the API user will have to assume limitted range. (Unless the API user adds a special-case for the PNG decoder.) Just export the correct range - full range. --- libavcodec/pngdec.c | 2 ++ 1 file changed, 2 inserti

Re: [FFmpeg-devel] [PATCH] avcodec/s3tc: fix alpha decoding when dimensions are not a multiple of 4

On Thu, May 07, 2015 at 09:21:46PM +0100, Tom Butterworth wrote: > Fix alpha position error for edge blocks of odd-dimensioned frames > --- > libavcodec/s3tc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) patch applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6

[FFmpeg-devel] [PATCH] avcodec/s3tc: fix alpha decoding when dimensions are not a multiple of 4

Fix alpha position error for edge blocks of odd-dimensioned frames --- libavcodec/s3tc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/s3tc.c b/libavcodec/s3tc.c index 9886b1d..a422874 100644 --- a/libavcodec/s3tc.c +++ b/libavcodec/s3tc.c @@ -71,8 +71,10 @@ sta

Re: [FFmpeg-devel] [PATCH] avcodec/s3tc: fix decoding when dimensions are not a multiple of 4

Ashamed to discover I omitted to progress the alpha position for edge blocks < 4 pixels, patch to follow. The problem can be seen on the right edge of decodes of my previous sample http://files.kriss.cx/387x249DXT3.txd Profound apologies for the noise/extra patch. On 7 May 2015 at 18:09, Michael

Re: [FFmpeg-devel] [PATCH] avcodec: Add av_packet_side_data_name()

On Sun, May 03, 2015 at 04:11:04AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/avcodec.h |2 ++ > libavcodec/avpacket.c | 23 +++ > 2 files changed, 25 insertions(+) applied [...] -- Michael GnuPG fingerprint: 9FF2128

Re: [FFmpeg-devel] [PATCH] avcodec/s3tc: fix decoding when dimensions are not a multiple of 4

On Thu, May 07, 2015 at 03:37:46PM +, Tom Butterworth wrote: > I took variables bx and by to be shorthand for block x and block y, so I > renamed them because they now refer to pixel and not block positions - > would you rather they remain bx, by? > > Examples at > > http://files.kriss.cx/387

Re: [FFmpeg-devel] [libav-devel] [PATCH] aacsbr: break infinite loop in sbr_hf_calc_npatches

On Tue, May 05, 2015 at 09:16:44PM +0200, Andreas Cadhalpun wrote: > On 23.04.2015 17:50, Claudio Freire wrote: > > On Thu, Apr 23, 2015 at 12:43 PM, Michael Niedermayer > > wrote: > >> ok, so is the patch the correct solution or are the fields already > >> invalid before this loop and should hav

Re: [FFmpeg-devel] [PATCH] avcodec/s3tc: fix decoding when dimensions are not a multiple of 4

I took variables bx and by to be shorthand for block x and block y, so I renamed them because they now refer to pixel and not block positions - would you rather they remain bx, by? Examples at http://files.kriss.cx/387x249DXT1.txd http://files.kriss.cx/387x249DXT3.txd On Thu, May 7, 2015 at 4:

Re: [FFmpeg-devel] [PATCH] avcodec/s3tc: fix decoding when dimensions are not a multiple of 4

On Thu, May 07, 2015 at 04:17:10PM +0100, Tom Butterworth wrote: > Image dimensions were rounded down causing rows to wrap early if dimensions > were not a multiple of 4. > --- > libavcodec/s3tc.c | 23 +-- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/

[FFmpeg-devel] [PATCH] avcodec/s3tc: fix decoding when dimensions are not a multiple of 4

Image dimensions were rounded down causing rows to wrap early if dimensions were not a multiple of 4. --- libavcodec/s3tc.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/libavcodec/s3tc.c b/libavcodec/s3tc.c index 4743d78..9886b1d 100644 --- a/libav

Re: [FFmpeg-devel] [PATCH] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for HEVC uni copy, uni horizontal and uni vertical mc functions

On Thu, May 07, 2015 at 12:27:48PM +, Nedeljko Babic wrote: > LGTM applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB it is not once nor twice but times without number that the same ideas make their appearance in the world. -- Aristotle signat

Re: [FFmpeg-devel] [PATCH] ripemd: move ripemd{256, 320} into separate functions

On Thu, May 07, 2015 at 01:58:50AM -0300, James Almer wrote: > This allows the removal of a few branches. > > Before: > lavu RIPEMD-160 size: 1048576 runs: 1024 time:7.052 +- 0.010 > > After: > lavu RIPEMD-160 size: 1048576 runs: 1024 time:6.865 +- 0.015 > > Signe

Re: [FFmpeg-devel] [PATCH]Also support real-world qdraw samples

Michael Niedermayer gmx.at> writes: > > Attached patch allows decoding of the qdraw files I found. > > > > Please comment, Carl Eugen > > if that works, i guess its an improvment and should be ok The patch that works for several public samples was merged by Michael. Thank you, Carl Eugen __

Re: [FFmpeg-devel] [PATCH]qdraw autodetection

Carl Eugen Hoyos ag.or.at> writes: > Attached patch allows the autodetection of qdraw images > as decoded by libavcodec. A variant of this was merged. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinf

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9dsp: Replace assert by av_assert0()

On Thu, May 07, 2015 at 08:13:46AM -0400, Ronald S. Bultje wrote: > Hi, > > On Thu, May 7, 2015 at 8:08 AM, Michael Niedermayer > wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vp9dsp.c |3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/x86/vp9dsp_init: Fix mix of declaration and statement

On Thu, May 07, 2015 at 08:14:14AM -0400, Ronald S. Bultje wrote: > Hi, > > On Thu, May 7, 2015 at 8:08 AM, Michael Niedermayer > wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/x86/vp9dsp_init.c |5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > d

Re: [FFmpeg-devel] [PATCH 6/9] vp9: add keyframe profile 2/3 support.

On Wed, 6 May 2015 17:40:20 + (UTC) Carl Eugen Hoyos wrote: > Ronald S. Bultje gmail.com> writes: > > > +static void vert_4x4_c(uint8_t *_dst, ptrdiff_t stride, > > + const uint8_t *left, const uint8_t *_top) > > Once upon a time, it was claimed that we must not > us

[FFmpeg-devel] [PATCH] vp9: de-duplicate some functions that are identical between 10/12 bpp.

--- libavcodec/vp9dsp_template.c | 112 +-- 1 file changed, 98 insertions(+), 14 deletions(-) diff --git a/libavcodec/vp9dsp_template.c b/libavcodec/vp9dsp_template.c index 18b14e8..8f10ccf 100644 --- a/libavcodec/vp9dsp_template.c +++ b/libavcodec/vp9dsp_t

Re: [FFmpeg-devel] [PATCH] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for HEVC uni copy, uni horizontal and uni vertical mc functions

LGTM Thanks, Nedeljko Od: ffmpeg-devel-boun...@ffmpeg.org [ffmpeg-devel-boun...@ffmpeg.org] u ime korisnika Shivraj Patil Poslato: 4. maj 2015 14:21 Za: ffmpeg-devel@ffmpeg.org Cc: Rob Isherwood; Shivraj Patil Tema: [FFmpeg-devel] [PATCH] avcodec/mips: MSA

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/x86/vp9dsp_init: Fix mix of declaration and statement

Hi, On Thu, May 7, 2015 at 8:08 AM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/x86/vp9dsp_init.c |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/x86/vp9dsp_init.c b/libavcodec/x86/vp9dsp_init.c > index f2ac6e8.

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9dsp: Replace assert by av_assert0()

Hi, On Thu, May 7, 2015 at 8:08 AM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/vp9dsp.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/vp9dsp.c b/libavcodec/vp9dsp.c > index d78c453..5ff18b4 100644 > --- a/libavc

[FFmpeg-devel] [PATCH 2/2] avcodec/x86/vp9dsp_init: Fix mix of declaration and statement

Signed-off-by: Michael Niedermayer --- libavcodec/x86/vp9dsp_init.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/x86/vp9dsp_init.c b/libavcodec/x86/vp9dsp_init.c index f2ac6e8..979bd93 100644 --- a/libavcodec/x86/vp9dsp_init.c +++ b/libavcodec/x86/vp9dsp_

[FFmpeg-devel] [PATCH 1/2] avcodec/vp9dsp: Replace assert by av_assert0()

Signed-off-by: Michael Niedermayer --- libavcodec/vp9dsp.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp9dsp.c b/libavcodec/vp9dsp.c index d78c453..5ff18b4 100644 --- a/libavcodec/vp9dsp.c +++ b/libavcodec/vp9dsp.c @@ -21,6 +21,7 @@ * Foundation, Inc., 5

[FFmpeg-devel] [PATCH] avcodec/libx265: use x265 Multi-library Interface to query the API

Hello, this patch is ffmpeg can now use the x265 multi-library interface to make a run-time selection between a number of libx265 libraries (perhaps 8bpp and 16bpp). I have attached the patch with this mail, 0001-avcodec-libx265-use-x265-Multi-library-Interface-to-.patch Description: Binary dat