On Wed, Apr 22, 2015, at 12:55 PM, Carl Eugen Hoyos wrote:
>
> Shouldn't this be deprecated and removed after
> the next release?
I'm fine with that, but I don't think I'll have the motivation or time
to do so (I should really be working on the server), so it will block
this patch.
However, feel
On Tue, Apr 28, 2015 at 07:27:06PM +0200, Michael Niedermayer wrote:
> On Tue, Apr 28, 2015 at 05:45:35PM +0300, foo86 wrote:
> > Check extended sync word for 16-bit LE and BE core streams to reduce
> > probability of alias sync detection. Previously sync word extension was
> > checked only for 14
On Tue, Apr 28, 2015 at 10:39:40PM +0200, Andreas Cadhalpun wrote:
> On 28.04.2015 22:21, Michael Niedermayer wrote:
> > On Tue, Apr 28, 2015 at 08:57:39PM +0200, Andreas Cadhalpun wrote:
> >> The existing check has two problems:
> >> 1) i + count can overflow, so that the check '< 256' returns tr
On 28.04.2015 22:55, Michael Niedermayer wrote:
> On Tue, Apr 28, 2015 at 08:58:21PM +0200, Andreas Cadhalpun wrote:
>> Signed-off-by: Andreas Cadhalpun
> [...]
>> @@ -806,7 +811,10 @@ static int nut_read_header(AVFormatContext *s)
>>
>> ff_metadata_conv_ctx(s, NULL, ff_nut_metadata_conv);
On Tue, Apr 28, 2015 at 08:58:21PM +0200, Andreas Cadhalpun wrote:
> Signed-off-by: Andreas Cadhalpun
[...]
> @@ -806,7 +811,10 @@ static int nut_read_header(AVFormatContext *s)
>
> ff_metadata_conv_ctx(s, NULL, ff_nut_metadata_conv);
>
> -return 0;
> +end:
> +if (ret < 0)
> +
On Tue, Apr 28, 2015 at 08:58:21PM +0200, Andreas Cadhalpun wrote:
> Signed-off-by: Andreas Cadhalpun
> ---
> libavformat/nutdec.c | 18 +-
> 1 file changed, 13 insertions(+), 5 deletions(-)
applied
thanks
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC78
On 28.04.2015 22:33, Michael Niedermayer wrote:
> On Tue, Apr 28, 2015 at 08:57:59PM +0200, Andreas Cadhalpun wrote:
>> This fixes a segmentation fault when accessing the metadata.
>>
>> Signed-off-by: Andreas Cadhalpun
>> ---
>> libavformat/nutdec.c | 4
>> 1 file changed, 4 insertions(+)
>
On 28.04.2015 22:21, Michael Niedermayer wrote:
> On Tue, Apr 28, 2015 at 08:57:39PM +0200, Andreas Cadhalpun wrote:
>> The existing check has two problems:
>> 1) i + count can overflow, so that the check '< 256' returns true.
>> 2) In the (i == 'N') case occurs a j-- so that the loop runs once m
On Tue, Apr 28, 2015 at 08:57:59PM +0200, Andreas Cadhalpun wrote:
> This fixes a segmentation fault when accessing the metadata.
>
> Signed-off-by: Andreas Cadhalpun
> ---
> libavformat/nutdec.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavformat/nutdec.c b/libavformat/nut
On Tue, Apr 28, 2015 at 08:57:39PM +0200, Andreas Cadhalpun wrote:
> The existing check has two problems:
> 1) i + count can overflow, so that the check '< 256' returns true.
> 2) In the (i == 'N') case occurs a j-- so that the loop runs once more.
>
> This can trigger the assertion 'nut->header
Signed-off-by: Andreas Cadhalpun
---
libavformat/nutdec.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c
index 2049f70..191b285 100644
--- a/libavformat/nutdec.c
+++ b/libavformat/nutdec.c
@@ -745,12 +745,14 @@ f
The existing check has two problems:
1) i + count can overflow, so that the check '< 256' returns true.
2) In the (i == 'N') case occurs a j-- so that the loop runs once more.
This can trigger the assertion 'nut->header_len[0] == 0' or cause
segmentation faults or infinite hangs.
Signed-off-by:
This fixes a segmentation fault when accessing the metadata.
Signed-off-by: Andreas Cadhalpun
---
libavformat/nutdec.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c
index 46946d3..2049f70 100644
--- a/libavformat/nutdec.c
+++ b/libavformat/nu
On Tue, Apr 28, 2015 at 08:31:56PM +0200, Andreas Cadhalpun wrote:
> A negative frame rate triggers an av_assert2 in av_rescale_rnd.
>
> Signed-off-by: Andreas Cadhalpun
> ---
> libavformat/nutdec.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
applied
thanks
[...]
--
Michael
A negative frame rate triggers an av_assert2 in av_rescale_rnd.
Signed-off-by: Andreas Cadhalpun
---
libavformat/nutdec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c
index 4f5037f..191b285 100644
--- a/libavformat/nutdec.c
+++
On Thu, Apr 23, 2015 at 11:41 AM, Thilo Borgmann
wrote:
> Am 23.04.15 um 11:07 schrieb Daniel Ly:
> > +info->device_name = av_asprintf("[%d] %s: %s", index, description,
> model);
>
> So I assume that this is not parsed later.
> However, it changes current output format and should interfere w
On Tue, Apr 28, 2015 at 05:47:53PM +0300, foo86 wrote:
> Check extended sync word for 16-bit LE and BE core streams to reduce
> probability of alias sync detection. Previously sync word extension was
> checked only for 14-bit streams.
>
> This follows up the similar change in avcodec/dca_parser.
>
---
libavfilter/vf_colorkey.c | 36 +++-
1 file changed, 27 insertions(+), 9 deletions(-)
diff --git a/libavfilter/vf_colorkey.c b/libavfilter/vf_colorkey.c
index 6c76991..6964809 100644
--- a/libavfilter/vf_colorkey.c
+++ b/libavfilter/vf_colorkey.c
@@ -29,6 +29,8
Still not fully intended for merging, as there are a few issues/questions left.
First thing is the conversion of the float based algorithm to integer math.
The code i came up with works, i can't spot a visual difference. But i have no
idea if this is the most optimal way to approach this.
I left t
---
Changelog | 1 +
MAINTAINERS | 1 +
doc/filters.texi | 39 +++
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/vf_colorkey.c | 264 ++
6 files changed, 307 insertions(+
On Tue, Apr 28, 2015 at 05:45:35PM +0300, foo86 wrote:
> Check extended sync word for 16-bit LE and BE core streams to reduce
> probability of alias sync detection. Previously sync word extension was
> checked only for 14-bit streams.
>
> This is sufficient to make the sample in ticket #4492 par
I can't think of a better way of avoiding forward declaration due to the
nested nature of the F4F Boxes and AMF data.
2015-04-28 15:32 GMT+02:00 Clément Bœsch :
> > +static int f4fbox_parse_single_box(AVIOContext *in, void *opaque);
>
> Again, isn't this avoidable?
> +static int amf_metadata_
This makes avdevice_list_input_sources() available for
device_name = "avfoundation". avf_read_header is retrofitted
to use the new method.
Signed-off-by: Daniel Ly
---
libavdevice/avfoundation.m | 139 +
1 file changed, 104 insertions(+), 35 deletions(
Check extended sync word for 16-bit LE and BE core streams to reduce
probability of alias sync detection. Previously sync word extension was
checked only for 14-bit streams.
This follows up the similar change in avcodec/dca_parser.
---
libavformat/dtsdec.c | 6 --
1 file changed, 4 insertions
Check extended sync word for 16-bit LE and BE core streams to reduce
probability of alias sync detection. Previously sync word extension was
checked only for 14-bit streams.
This is sufficient to make the sample in ticket #4492 parse successfully.
The proper solution, however, would involve taki
On 04/28/2015 02:14 PM, Clément Bœsch wrote:
Then FATE test patch should be applied after the CC patch.
New patch attached. I have used other ass api.
+fate-sub-cc: CMD = fmtstdout ass -f lavfi -i
"movie=$(TARGET_SAMPLES)/sub/Closedcaption_atsc_rollup.ts[out0+subcc]"
BTW, do we really need
I will try to fix all the problems, although I'm not the original author of
most of the code, I just added better fragments/segment calculation for
live streams, and other small changes.
2015-04-28 15:32 GMT+02:00 Clément Bœsch :
> On Tue, Apr 28, 2015 at 02:48:42PM +0200, Gorilla Maguila wrote:
On Thu, Apr 23, 2015 at 02:29:47PM +0200, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer
> ---
> ffmpeg.c |1 -
> 1 file changed, 1 deletion(-)
applied
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Its not that you shouldnt use gotos but
On Tue, Apr 28, 2015 at 02:48:42PM +0200, Gorilla Maguila wrote:
[...]
> From 5bb2e85f2e7c4dfeb3569225e263ddc6a4f127cd Mon Sep 17 00:00:00 2001
> From: Developer Mobdro
> Date: Tue, 28 Apr 2015 14:38:35 +0200
> Subject: [PATCH] hds demuxer
>
> ---
> configure | 8 +
> libavform
On 28.04.2015 14:35, Luca Barbato wrote:
> On 27/04/15 23:56, Andreas Cadhalpun wrote:
>> s->decoded_buffer is allocated with a min_size of:
>> 2 * FFALIGN(blockstodecode, 8) * sizeof(*s->decoded_buffer)
>>
>> Then it is assigned to s->decoded[0], which is passed as out buffer to
>> decode_arra
I will work on it and I will upload a new patch soon.
2015-04-28 15:00 GMT+02:00 Carl Eugen Hoyos :
> Gorilla Maguila gmail.com> writes:
>
> > +static int hds_probe(AVProbeData *p)
> > +{
> > +if(p->filename && av_stristr(p->filename, ".f4m"))
> > +return AVPROBE_SCORE_MAX;
> > +
On Tue, 28 Apr 2015 14:48:42 +0200
Gorilla Maguila wrote:
> From 5bb2e85f2e7c4dfeb3569225e263ddc6a4f127cd Mon Sep 17 00:00:00 2001
> From: Developer Mobdro
> Date: Tue, 28 Apr 2015 14:38:35 +0200
> Subject: [PATCH] hds demuxer
>
> ---
> +mdat->data = av_mallocz(sizeof(uint8_t)*data_size);
Gorilla Maguila gmail.com> writes:
> +static int hds_probe(AVProbeData *p)
> +{
> +if(p->filename && av_stristr(p->filename, ".f4m"))
> +return AVPROBE_SCORE_MAX;
> +return 0;
> +}
Remove this function, instead add ".f4m" as
.extentions to the AVInputFormat.
Carl Eugen
___
Gorilla Maguila gmail.com> writes:
> New patch with some fixes:
Thank you for working on this!
> +if(type != AMF_DATA_TYPE_STRING) {
Please add a space after "if", same below.
> +av_log(NULL, AV_LOG_ERROR, "amfmetadata Expected type 2
Please pass the context to this function and
New patch with some fixes:
- use of av_freep
- use of context in av_log when possible
- corrected else-if format
- improved fragment/segment calculation for live streams
2014-09-18 12:01 GMT+02:00 Gorilla Maguila :
> I'll try to correct the patch and post it back.
>
> 2014-09-17 19:34 GMT+02:00
On Tue, Apr 28, 2015 at 11:22:22AM +0200, Andreas Cadhalpun wrote:
> On 28.04.2015 03:18, Michael Niedermayer wrote:
> > On Mon, Apr 27, 2015 at 11:56:15PM +0200, Andreas Cadhalpun wrote:
> >> s->decoded_buffer is allocated with a min_size of:
> >> 2 * FFALIGN(blockstodecode, 8) * sizeof(*s->de
On Tue, Apr 28, 2015 at 07:43:48AM +, Gupta, Maneesh wrote:
> > -Original Message-
> > From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel-
> > boun...@ffmpeg.org] On Behalf Of Michael Niedermayer
> > Sent: Monday, April 27, 2015 4:57 PM
> > To: FFmpeg development discussions and
On Tue, Apr 28, 2015 at 07:43:51AM +, Gupta, Maneesh wrote:
> > -Original Message-
> > From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel-
> > boun...@ffmpeg.org] On Behalf Of Michael Niedermayer
> > Sent: Monday, April 27, 2015 4:49 PM
> > To: FFmpeg development discussions and
On 28.04.2015 03:18, Michael Niedermayer wrote:
> On Mon, Apr 27, 2015 at 11:56:15PM +0200, Andreas Cadhalpun wrote:
>> s->decoded_buffer is allocated with a min_size of:
>> 2 * FFALIGN(blockstodecode, 8) * sizeof(*s->decoded_buffer)
>>
>> Then it is assigned to s->decoded[0], which is passed a
On Tue, Apr 28, 2015 at 02:05:20PM +0530, Anshul wrote:
[...]
> >Where are the line breaks?
> I have added patch in closed caption decoder.
> but that will make fate test fail till closed caption decoder patch is
> applied.
Then FATE test patch should be applied after the CC patch.
> since I hav
On 04/27/2015 10:38 PM, Clément Bœsch wrote:
On Mon, Apr 27, 2015 at 10:35:49PM +0530, Anshul wrote:
Hello,
I am attaching patch for closed caption decoder.
Thanks
Anshul
From 230cd5d9de356a8e84d2c36f91510631317986db Mon Sep 17 00:00:00 2001
From: Anshul Maheshwari
Date: Mon, 27 Apr 2015 2
> -Original Message-
> From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel-
> boun...@ffmpeg.org] On Behalf Of Michael Niedermayer
> Sent: Monday, April 27, 2015 4:49 PM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH 2/2] OpenCL: Avoid potential
> -Original Message-
> From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel-
> boun...@ffmpeg.org] On Behalf Of Michael Niedermayer
> Sent: Monday, April 27, 2015 4:57 PM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH 1/2] OpenCL: Fix ABI incompa
43 matches
Mail list logo
