On Thu, Apr 16, 2015 at 05:32:21PM -0700, Vignesh Venkatasubramanian wrote:
> Return appropriate error codes and propagate the error codes from
> helper functions to the outer calls. Also fix a potential leak in
> call to av_realloc.
>
> Signed-off-by: Vignesh Venkatasubramanian
> ---
> libavfor
On Thu, Apr 16, 2015 at 09:06:55PM -0400, Helmut K. C. Tessarek wrote:
> Hmm, I believe my mail client screwed it up. I had to use git imap-send
> and then the mail client to actually send the patch, because git
> send-email gives me the following error on all my machines:
>
> perl5.16(58025,0x7ff
Hmm, I believe my mail client screwed it up. I had to use git imap-send
and then the mail client to actually send the patch, because git
send-email gives me the following error on all my machines:
perl5.16(58025,0x7fff776c2310) malloc: *** error for object
0x7fff90af47dd: pointer being freed was n
On Thu, Apr 16, 2015 at 5:51 PM, Helmut K. C. Tessarek
wrote:
> Hi Timothy,
>
> On 2015-04-16 20:33, Timothy Gu wrote:
>> Applying: remove the www. from the URL - http://evermeet.cx/ffmpeg/
>> fatal: corrupt patch at line 18
>
> Thanks for fixing the patch.
> What was the problem with the patch, s
Hi Timothy,
On 2015-04-16 20:33, Timothy Gu wrote:
> Applying: remove the www. from the URL - http://evermeet.cx/ffmpeg/
> fatal: corrupt patch at line 18
Thanks for fixing the patch.
What was the problem with the patch, so that this won't happen again.
Cheers,
K. C.
--
regards Helmut K. C.
On Thu, Apr 16, 2015 at 5:19 PM, Helmut K. C. Tessarek
wrote:
> ---
> src/download | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applying: remove the www. from the URL - http://evermeet.cx/ffmpeg/
fatal: corrupt patch at line 18
Patch failed at 0001 remove the www. from the URL - http:
---
src/download | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/download b/src/download
index a9d5cc2..7d50786 100644
--- a/src/download
+++ b/src/download
@@ -89,7 +89,7 @@
OS X Packages
- http://www.evermeet.cx/ffmpeg/";>
+
On 16/04/15 2:02 PM, Michael Niedermayer wrote:
> On Thu, Apr 16, 2015 at 01:12:16PM -0300, James Almer wrote:
>> On 16/04/15 9:52 AM, Michael Niedermayer wrote:
>>> On Thu, Apr 16, 2015 at 10:48:35AM +0200, Hendrik Leppkes wrote:
On Wed, Apr 15, 2015 at 7:40 PM, Simon Thelen wrote:
> Sig
On Thu, Apr 16, 2015 at 3:09 PM James Almer wrote:
> On 16/04/15 4:18 PM, Urvang Joshi wrote:
> > Hi,
> > Here's the patch without whitespace changes.
> >
> > Thanks,
> > Urvang
>
> This patch doesn't apply cleanly. Looks like something weird with the
> indentation still.
> Was this patch handmad
Hi!
Completely untested.
Please review, Carl Eugen
diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
index 0b8dfd6..f7c3008 100644
--- a/libavformat/mxfenc.c
+++ b/libavformat/mxfenc.c
@@ -1655,12 +1655,15 @@ AVPacket *pkt)
case 1241:
sc->index = 27;
sc->component_de
On 16/04/15 4:18 PM, Urvang Joshi wrote:
> Hi,
> Here's the patch without whitespace changes.
>
> Thanks,
> Urvang
This patch doesn't apply cleanly. Looks like something weird with the
indentation still.
Was this patch handmade? It says the hash for libwebpenc.c is 95d56ac (same as
git head),
On 16.04.2015 23:04, Michael Niedermayer wrote:
> On Thu, Apr 16, 2015 at 09:25:26PM +0200, Andreas Cadhalpun wrote:
>> This fixes an invalid read if end is 0:
>> band_end = ff_ac3_bin_to_band_tab[end-1] + 1;
>>
>> Depending on what is before the array, this can cause stack smashing,
>> when
On Wed, Apr 15, 2015 at 09:10:49PM +0200, wm4 wrote:
> ---
> gapless.mp3: https://0x0.st/AG.mp3
>
> Possibly a bit over-complicated, but it doesn't even test everything
> I wanted to test. At least the lavc skip_manual flag is not tested,
> because there's apparently no way yet to test AVFrame sid
On Thu, Apr 16, 2015 at 09:25:26PM +0200, Andreas Cadhalpun wrote:
> This fixes an invalid read if end is 0:
> band_end = ff_ac3_bin_to_band_tab[end-1] + 1;
>
> Depending on what is before the array, this can cause stack smashing,
> when band_end becomes too large.
>
> Signed-off-by: Andre
On Thu, Apr 16, 2015 at 05:55:10PM +0200, wm4 wrote:
> On Thu, 16 Apr 2015 10:35:11 -0500
> Rodger Combs wrote:
>
> >
> > > On Apr 9, 2015, at 06:55, wm4 wrote:
> > >
> > > On Thu, 9 Apr 2015 06:12:53 -0500
> > > Rodger Combs wrote:
> > >
> > >>
> > >>> On Apr 8, 2015, at 14:25, Michael Nie
This fixes an invalid read if end is 0:
band_end = ff_ac3_bin_to_band_tab[end-1] + 1;
Depending on what is before the array, this can cause stack smashing,
when band_end becomes too large.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/ac3.c | 3 +++
1 file changed, 3 insertions(+)
dif
Hi,
Here's the patch without whitespace changes.
Thanks,
Urvang
On Thu, Apr 16, 2015 at 11:50 AM Urvang Joshi wrote:
> Hi Michael,
> Sorry for my misunderstanding earlier.
> I was told offline that the usual practice in FFmpeg is to land the
> non-whitespace diff first, followed by a separate r
Hi Michael,
Sorry for my misunderstanding earlier.
I was told offline that the usual practice in FFmpeg is to land the
non-whitespace diff first, followed by a separate reindent commit.
Let me separate out the two and send the non-whitespace diff shortly.
On Thu, Apr 16, 2015 at 11:35 AM Urvang J
On Thu, Apr 16, 2015 at 03:26:55PM -0300, Claudio Freire wrote:
> On Thu, Apr 16, 2015 at 3:19 PM, Andreas Cadhalpun
> wrote:
> > On 16.04.2015 19:41, Claudio Freire wrote:
> >> It should be if band->thr > 0.0f, all divisions by zero return
> >> something that casts into an ~1:
> >
> > OK, new pat
Hello Michael,
On Thu, Apr 16, 2015 at 5:26 AM Michael Niedermayer
wrote:
> On Thu, Apr 16, 2015 at 12:28:22AM +, Urvang Joshi wrote:
> > Hi,
> > Here's an updated patch that used 'HAVE_WEBP_MUX_H' as you suggested. I
> > also updated the patch to work with the latest libwebp code (from
> >
On Thu, Apr 16, 2015 at 3:19 PM, Andreas Cadhalpun
wrote:
> On 16.04.2015 19:41, Claudio Freire wrote:
>> It should be if band->thr > 0.0f, all divisions by zero return
>> something that casts into an ~1:
>
> OK, new patch attached.
>
> If band->thr is 0.0f and band->active_lines is not, it takes
On 16.04.2015 19:41, Claudio Freire wrote:
> It should be if band->thr > 0.0f, all divisions by zero return
> something that casts into an ~1:
OK, new patch attached.
If band->thr is 0.0f and band->active_lines is not, it takes
a bit longer to get to NaN.
I assume band->thr < 0.0f is not possible
On Thu, Apr 16, 2015 at 02:41:39PM -0300, Claudio Freire wrote:
> On Thu, Apr 16, 2015 at 1:00 PM, Andreas Cadhalpun
> wrote:
> > If both band->active_lines and band->thr are 0.0f, the division is
> > undefined, making norm_fac not a number.
> >
> > NaN is passed on to other variables until it fin
On Thu, Apr 16, 2015 at 05:47:50PM +, Timothy Gu wrote:
> On Thu, Apr 16, 2015 at 10:41 AM Claudio Freire
> wrote:
> >
> > It should be if band->thr > 0.0f, all divisions by zero return
> > something that casts into an ~1:
>
> Isn't division by zero undefined behavior?
for floats its defined
On Thu, Apr 16, 2015 at 10:41 AM Claudio Freire
wrote:
>
> It should be if band->thr > 0.0f, all divisions by zero return
> something that casts into an ~1:
Isn't division by zero undefined behavior?
Timothy
___
ffmpeg-devel mailing list
ffmpeg-devel@f
On Thu, Apr 16, 2015 at 1:00 PM, Andreas Cadhalpun
wrote:
> If both band->active_lines and band->thr are 0.0f, the division is
> undefined, making norm_fac not a number.
>
> NaN is passed on to other variables until it finally reaches
> sce->sf_idx and is converted to an integer (-2147483648).
>
>
On Thu, Apr 16, 2015 at 07:12:02PM +0200, Andreas Cadhalpun wrote:
> Signed-off-by: Andreas Cadhalpun
> ---
> libavcodec/aasc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied
thanks
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Those who ar
Signed-off-by: Andreas Cadhalpun
---
libavcodec/aasc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/aasc.c b/libavcodec/aasc.c
index 65ef782..469fc5e 100644
--- a/libavcodec/aasc.c
+++ b/libavcodec/aasc.c
@@ -137,7 +137,7 @@ static int aasc_decode_frame(AVCodecCo
On Thu, Apr 16, 2015 at 04:58:32PM +0200, Andreas Cadhalpun wrote:
> ac may be NULL and then accessing ac->avctx results in a segmentation fault.
>
> Signed-off-by: Andreas Cadhalpun
> ---
> libavcodec/aacdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied
thanks
[...]
--
M
On Thu, Apr 16, 2015 at 01:12:16PM -0300, James Almer wrote:
> On 16/04/15 9:52 AM, Michael Niedermayer wrote:
> > On Thu, Apr 16, 2015 at 10:48:35AM +0200, Hendrik Leppkes wrote:
> >> On Wed, Apr 15, 2015 at 7:40 PM, Simon Thelen wrote:
> >>> Signed-off-by: Simon Thelen
> >>> ---
> >>> configur
On 16/04/15 7:29 AM, Michael Niedermayer wrote:
> On Thu, Apr 16, 2015 at 03:01:52AM -0300, James Almer wrote:
>> Signed-off-by: James Almer
>> ---
>> configure | 4
>> 1 file changed, 4 insertions(+)
>
> LGTM
Pushed, thanks.
___
ffmpeg-devel ma
On 16/04/15 9:52 AM, Michael Niedermayer wrote:
> On Thu, Apr 16, 2015 at 10:48:35AM +0200, Hendrik Leppkes wrote:
>> On Wed, Apr 15, 2015 at 7:40 PM, Simon Thelen wrote:
>>> Signed-off-by: Simon Thelen
>>> ---
>>> configure | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff
If both band->active_lines and band->thr are 0.0f, the division is
undefined, making norm_fac not a number.
NaN is passed on to other variables until it finally reaches
sce->sf_idx and is converted to an integer (-2147483648).
This causes a segmentation fault when it is used as array index.
Sign
On Thu, 16 Apr 2015 10:35:11 -0500
Rodger Combs wrote:
>
> > On Apr 9, 2015, at 06:55, wm4 wrote:
> >
> > On Thu, 9 Apr 2015 06:12:53 -0500
> > Rodger Combs wrote:
> >
> >>
> >>> On Apr 8, 2015, at 14:25, Michael Niedermayer wrote:
> >>>
> >>> On Sat, Apr 04, 2015 at 05:31:22AM -0500, Rod
> On Apr 9, 2015, at 06:55, wm4 wrote:
>
> On Thu, 9 Apr 2015 06:12:53 -0500
> Rodger Combs wrote:
>
>>
>>> On Apr 8, 2015, at 14:25, Michael Niedermayer wrote:
>>>
>>> On Sat, Apr 04, 2015 at 05:31:22AM -0500, Rodger Combs wrote:
---
libavformat/assenc.c | 28
ac may be NULL and then accessing ac->avctx results in a segmentation fault.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/aacdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c
index 1a2ddc2..f1576e6 100644
--- a/libavcodec/aacde
On Thu, Apr 16, 2015 at 02:49:08PM +0200, Andreas Cadhalpun wrote:
> This fixes segmentation faults, when pic->linesize[0] is negative.
> In that case 'line * pic->linesize[0] + pixel_ptr' is treated as
> unsigned and wraps around.
>
> This reverts commit 7d78a964.
> The problem was introduced in
On Wed, Apr 15, 2015 at 05:18:58PM +0200, Simon Thelen wrote:
> Signed-off-by: Simon Thelen
> ---
> Implemented like the check for libx264 without the warn on fallback. Tested
> on my system with pkg-config.
> configure | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
tested, works
app
On Thu, Apr 16, 2015 at 10:48:35AM +0200, Hendrik Leppkes wrote:
> On Wed, Apr 15, 2015 at 7:40 PM, Simon Thelen wrote:
> > Signed-off-by: Simon Thelen
> > ---
> > configure | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index 389de92..93
This fixes segmentation faults, when pic->linesize[0] is negative.
In that case 'line * pic->linesize[0] + pixel_ptr' is treated as
unsigned and wraps around.
This reverts commit 7d78a964.
The problem was introduced in commit f7e1367f, which should obsolete
that commit.
Signed-off-by: Andreas Cad
On Thu, Apr 16, 2015 at 12:28:22AM +, Urvang Joshi wrote:
> Hi,
> Here's an updated patch that used 'HAVE_WEBP_MUX_H' as you suggested. I
> also updated the patch to work with the latest libwebp code (from
> https://gerrit.chromium.org/gerrit/gitweb?p=webm/libwebp.git)
please dont reindent the
Apparently, some live streams can delete segments too early, maybe
because the client is too far behind. In this case, it's better to skip
the segment, instead of returning EOF. (Yes, the HLS demuxer actually
returns AVERROR_EOF if opening the segment returns a 404 HTTP error.)
---
I'd say this is
On Wed, Apr 15, 2015 at 11:51:59PM +0700, Victor Anjin wrote:
> VP80 fourcc are writed for all contexts (without ctx->codec_tag)
> how to reproduce the issue:
> 1) Get any vp9 video (for example http://base-n.de/webm/out9.webm)
> 2) ffmpeg -i out9.webm -vcodec copy out9.ivf
> 3) out9.ivf have VP8
On Thu, Apr 16, 2015 at 11:31:23AM +0200, Nicolas George wrote:
> Signed-off-by: Nicolas George
> ---
> libavfilter/avf_showcqt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> If deemed correct, do not wait for me to apply.
applied
thanks
[...]
--
Michael GnuPG fingerpri
On Thu, Apr 16, 2015 at 03:01:52AM -0300, James Almer wrote:
> Signed-off-by: James Almer
> ---
> configure | 4
> 1 file changed, 4 insertions(+)
LGTM
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The real ebay dictionary, page 1
"Used only once"-
Signed-off-by: Nicolas George
---
libavfilter/avf_showcqt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
If deemed correct, do not wait for me to apply.
diff --git a/libavfilter/avf_showcqt.c b/libavfilter/avf_showcqt.c
index e862dc7..8c6ce1f 100644
--- a/libavfilter/avf_showcqt.c
++
>>> I want to let av_read_frame() tell us (user application) what to do next,
>>> by returning limited code, at least limited on special situation
>>> which need more handling, including
>>> AV_ERROR_EAGIN;
>>> AV_ERROR_END_OF_STREAM_YOU_NAME_IT;
>>> AV_ERROR_EXIT; // interrupted with interrupt cal
On Wed, Apr 15, 2015 at 7:40 PM, Simon Thelen wrote:
> Signed-off-by: Simon Thelen
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 389de92..93aebcb 100755
> --- a/configure
> +++ b/configure
> @@ -5012,7 +5012,7 @@ enabled
2015-04-15 18:38 GMT+08:00 wm4 :
> On Tue, 14 Apr 2015 11:24:23 +0800
> Zhang Rui wrote:
>
>> 2015-04-14 1:09 GMT+08:00 wm4 :
>> > On Mon, 13 Apr 2015 12:02:29 +0800
>> > Zhang Rui wrote:
>> >
>> >> 2015-04-12 22:45 GMT+08:00 Michael Niedermayer :
>> >> > On Sun, Apr 12, 2015 at 12:00:18PM +0800,
On Wed, 15 Apr 2015 20:24:23 -0300
James Almer wrote:
> On 15/04/15 8:14 PM, Carl Eugen Hoyos wrote:
> > Simon Thelen c-14.de> writes:
> >
> >> I don't particularly mind either way. I can resend
> >> a version without fallback.
> >
> > Please keep the fallback, not all OS have pkg-config.
> >
On 15/04/15 1:29 PM, Nedeljko Babic wrote:
> From: Nedeljko Babic
>
> Signed-off-by: Nedeljko Babic
> ---
> tests/fate/aac.mak | 63
> ++
> 1 file changed, 63 insertions(+)
>
> diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak
> index 348
51 matches
Mail list logo