[FFmpeg-devel] [PATCH] configure: add missing dependencies for MIPS and PPC features

2015-04-15 Thread James Almer
Signed-off-by: James Almer --- configure | 4 1 file changed, 4 insertions(+) diff --git a/configure b/configure index 389de92..c5bae3f 100755 --- a/configure +++ b/configure @@ -2012,14 +2012,18 @@ setend_deps="arm" map 'eval ${v}_inline_deps=inline_asm' $ARCH_EXT_LIST_ARM +loongson_d

[FFmpeg-devel] [PATCH] ivfenc: incorrect fourcc for VP9 video

2015-04-15 Thread Victor Anjin
VP80 fourcc are writed for all contexts (without ctx->codec_tag) how to reproduce the issue: 1) Get any vp9 video (for example http://base-n.de/webm/out9.webm) 2) ffmpeg -i out9.webm -vcodec copy out9.ivf 3) out9.ivf have VP80 fourcc at ivf header The proposed fix solves this issue --- libavform

Re: [FFmpeg-devel] [PATCH] avformat/utils: Preserve packet duration when parsing is done only for headers

2015-04-15 Thread Michael Niedermayer
On Wed, Apr 15, 2015 at 12:32:14AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/utils.c |2 +- > tests/ref/fate/mkv | 144 ++-- > tests/ref/fate/vp8-alpha | 240 > +++---

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libdcadec

2015-04-15 Thread James Almer
On 15/04/15 8:14 PM, Carl Eugen Hoyos wrote: > Simon Thelen c-14.de> writes: > >> I don't particularly mind either way. I can resend >> a version without fallback. > > Please keep the fallback, not all OS have pkg-config. > > Carl Eugen There's no OS without pkg-config. Only broken or badly m

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libdcadec

2015-04-15 Thread Carl Eugen Hoyos
Simon Thelen c-14.de> writes: > I don't particularly mind either way. I can resend > a version without fallback. Please keep the fallback, not all OS have pkg-config. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org

Re: [FFmpeg-devel] [PATCH] fate: add mp3 gapless test

2015-04-15 Thread Michael Niedermayer
On Wed, Apr 15, 2015 at 09:10:49PM +0200, wm4 wrote: > --- > gapless.mp3: https://0x0.st/AG.mp3 uploaded [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What does censorship reveal? It reveals fear. -- Julian Assange signature.asc Description: Digital signatur

Re: [FFmpeg-devel] [PATCH 2/2] libavutil: Make changes in softfloat needed for fixed point aac decoder.

2015-04-15 Thread Michael Niedermayer
On Wed, Apr 15, 2015 at 03:14:07PM +0200, Nedeljko Babic wrote: > From: Djordje Pesut > > Functions for sqrt and sincos are added. > > Div function is improved. > > Some changes are made in order for code in softfloat to be usable in fixed aac > decoder code. > > This doesn't create any impact

[FFmpeg-devel] [PATCH] fate: add mp3 gapless test

2015-04-15 Thread wm4
--- gapless.mp3: https://0x0.st/AG.mp3 Possibly a bit over-complicated, but it doesn't even test everything I wanted to test. At least the lavc skip_manual flag is not tested, because there's apparently no way yet to test AVFrame side data? --- tests/Makefile | 1 + tests/fate-run.sh

Re: [FFmpeg-devel] [PATCH v4] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution for AAC

2015-04-15 Thread Michael Niedermayer
On Wed, Apr 15, 2015 at 01:55:28PM -0300, Claudio Freire wrote: > On Wed, Apr 15, 2015 at 8:18 AM, Rostislav Pehlivanov > wrote: > > @@ -828,9 +882,17 @@ static void > > search_for_quantizers_twoloop(AVCodecContext *avctx, > > > > fflag = 0; > > minscaler = av_clip(minscaler, 60

Re: [FFmpeg-devel] [PATCH v4] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution for AAC

2015-04-15 Thread Rostislav Pehlivanov
I did consider putting the whole thing outside however I noticed that the outer loop modifies sf->idx[0] (by having w and g start from 0) which is also the initial value for both the noise and the normal minscaler vars. I'm pretty sure it wouldn't have caused a problem to just put it outside and on

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/softfloat: Change order of fields in SoftFloat structure.

2015-04-15 Thread Michael Niedermayer
On Wed, Apr 15, 2015 at 03:14:06PM +0200, Nedeljko Babic wrote: > Softfloat will be used in implementation of AAC fixed point decoder. > This change is needed in order to more easily integrate ffmpegs softfloat in > already developed algorithm for AAC. > > Signed-off-by: Nedeljko Babic > --- > l

[FFmpeg-devel] Warning when compiling ffmpeg using msvc toolchain with --enable-pthreads

2015-04-15 Thread Ramprasad N
Hi, When using an ffmpeg.exe built using msys and the msvc toolchain, at run time a warning is displayed [udp @ 00395860] 'circular_buffer_size' option was set but it is not supported on this build (pthread support is required) So, I wanted to enable pthread I downloaded pthread-win32 Added the

[FFmpeg-devel] [PATCH] configure: use pkg-config to find libdcadec

2015-04-15 Thread Simon Thelen
Signed-off-by: Simon Thelen --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 389de92..93aebcb 100755 --- a/configure +++ b/configure @@ -5012,7 +5012,7 @@ enabled libcelt && require libcelt celt/celt.h celt_decode -lcelt0 &&

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libdcadec

2015-04-15 Thread Simon Thelen
On 15-04-15 at 14:03, James Almer wrote: > On 15/04/15 2:00 PM, wm4 wrote: > > On Wed, 15 Apr 2015 17:18:58 +0200 > > Simon Thelen wrote: > >> Signed-off-by: Simon Thelen [..] > > Isn't the fallback not needed anymore? > Yeah, the pkg-config check alone is enough. > There's currently no release o

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libdcadec

2015-04-15 Thread James Almer
On 15/04/15 2:00 PM, wm4 wrote: > On Wed, 15 Apr 2015 17:18:58 +0200 > Simon Thelen wrote: > >> Signed-off-by: Simon Thelen >> --- >> Implemented like the check for libx264 without the warn on fallback. Tested >> on my system with pkg-config. >> configure | 3 ++- >> 1 file changed, 2 insertio

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libdcadec

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 17:18:58 +0200 Simon Thelen wrote: > Signed-off-by: Simon Thelen > --- > Implemented like the check for libx264 without the warn on fallback. Tested > on my system with pkg-config. > configure | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/confi

Re: [FFmpeg-devel] AAC Decoder - fixed point implementation

2015-04-15 Thread Claudio Freire
On Wed, Apr 15, 2015 at 1:29 PM, Nedeljko Babic wrote: > Hello, > > I am again resending patch set with the implementation of fixed point AAC > decoder. > > Patch set is rebased to the newest code as requested. Cool, I'll test them when I get some free time, hopefully during this week.

Re: [FFmpeg-devel] [PATCH v4] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution for AAC

2015-04-15 Thread Claudio Freire
On Wed, Apr 15, 2015 at 8:18 AM, Rostislav Pehlivanov wrote: > @@ -828,9 +882,17 @@ static void search_for_quantizers_twoloop(AVCodecContext > *avctx, > > fflag = 0; > minscaler = av_clip(minscaler, 60, 255 - SCALE_MAX_DIFF); > + > +for (w = 0; w < sce->ics.num_windows;

[FFmpeg-devel] [PATCH 05/14] libavcodec: Implementation of AAC_fixed_decoder (SBR-module) [1/4]

2015-04-15 Thread Nedeljko Babic
From: Djordje Pesut Move the existing code to a new template file. Signed-off-by: Nedeljko Babic --- libavcodec/aacsbr.c | 1413 -- libavcodec/aacsbr.h | 45 ++ libavcodec/aacsbr_template.c | 1395 +

[FFmpeg-devel] [PATCH 11/14] libavcodec: Implementation of AAC_fixed_decoder (PS-module) [3/3]

2015-04-15 Thread Nedeljko Babic
From: Djordje Pesut Add fixed point implementation. Signed-off-by: Nedeljko Babic --- libavcodec/Makefile| 14 +- libavcodec/aac_defines.h | 36 + libavcodec/aacps.c | 344 ++--- libavcodec/aacps.h | 32 ++--

[FFmpeg-devel] [PATCH 10/14] libavcodec: Implementation of AAC_fixed_decoder (PS-module) [2/3]

2015-04-15 Thread Nedeljko Babic
From: Jovan Zelincevic Add fixed point implementation of functions for generating tables. Signed-off-by: Nedeljko Babic --- libavcodec/aacps_fixed_tablegen.c| 24 +++ libavcodec/aacps_fixed_tablegen.h| 402 +++ libavcodec/aacps_tablegen.c | 73

[FFmpeg-devel] [PATCH 07/14] libavcodec: Implementation of AAC_fixed_decoder (SBR-module) [3/4]

2015-04-15 Thread Nedeljko Babic
From: Djordje Pesut Add fixed poind code. Signed-off-by: Nedeljko Babic --- libavcodec/aac.h | 51 +--- libavcodec/aac_defines.h | 76 ++ libavcodec/aacsbr.c | 3 + libavcodec/aacsbr.h | 12 +- libavcodec/aacsbr_fixed.c| 586 ++

[FFmpeg-devel] [PATCH 12/14] libavcodec: Minor macro polishing

2015-04-15 Thread Nedeljko Babic
Use macros from aac_defines.h for adding suffixes instead of local macros. Signed-off-by: Nedeljko Babic --- libavcodec/cbrt_tablegen.h | 5 ++--- libavcodec/cbrt_tablegen_template.c| 2 +- libavcodec/sinewin.h | 17 + libavcodec/sinewin_table

[FFmpeg-devel] [PATCH 06/14] libavcodec: Implementation of AAC_fixed_decoder (SBR-module) [2/4]

2015-04-15 Thread Nedeljko Babic
From: Jovan Zelincevic Create tables for fixed point code. Signed-off-by: Nedeljko Babic --- libavcodec/Makefile | 5 +- libavcodec/aacsbr_fixed_tablegen.c | 40 +++ libavcodec/aacsbr_fixed_tablegen.h | 32 +++ libavcodec/aacsbr_tablegen.c| 1 + libavcodec/aacsb

[FFmpeg-devel] [PATCH 03/14] libavcodec/libavutil: Implementation of AAC_fixed_decoder (LC-module) [3/4]

2015-04-15 Thread Nedeljko Babic
From: Djordje Pesut Add fixed point implementation Signed-off-by: Nedeljko Babic --- libavcodec/aac.h | 101 -- libavcodec/aacdec.c | 5 + libavcodec/aacdec_fixed.c| 448 +++ libavcodec/aacdec_template.c | 433 +

[FFmpeg-devel] [PATCH 13/14] tests: Add aac_fixed decoder test

2015-04-15 Thread Nedeljko Babic
From: Nedeljko Babic Signed-off-by: Nedeljko Babic --- tests/fate/aac.mak | 63 ++ 1 file changed, 63 insertions(+) diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak index 34823be..d90b143 100644 --- a/tests/fate/aac.mak +++ b/tests/fate/a

[FFmpeg-devel] [PATCH 14/14] Edit documentation and versioning

2015-04-15 Thread Nedeljko Babic
From: Jovan Zelincevic Signed-off-by: Nedeljko Babic --- Changelog | 1 + doc/general.texi| 2 +- doc/mips.txt| 5 + libavutil/version.h | 2 +- 4 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Changelog b/Changelog index 2e30b24..d634853 100644 --- a/Cha

[FFmpeg-devel] [PATCH 02/14] libavcodec: Implementation of AAC_fixed_decoder (LC-module) [2/4]

2015-04-15 Thread Nedeljko Babic
From: Jovan Zelincevic Add fixed point implementation of functions for generating tables Signed-off-by: Nedeljko Babic --- libavcodec/aacdectab.h | 34 +-- libavcodec/aactab.c| 486 + libavcodec/aactab.h|

[FFmpeg-devel] [PATCH 09/14] libavcodec: Implementation of AAC_fixed_decoder (PS-module) [1/3]

2015-04-15 Thread Nedeljko Babic
From: Djordje Pesut Move existing code to a new file. Signed-off-by: Nedeljko Babic --- libavcodec/aacps.c | 157 - libavcodec/aacps_float.c | 177 +++ 2 files changed, 177 insertions(+), 157 deletions(-)

[FFmpeg-devel] AAC Decoder - fixed point implementation

2015-04-15 Thread Nedeljko Babic
Hello, I am again resending patch set with the implementation of fixed point AAC decoder. Patch set is rebased to the newest code as requested. Patches for softfloat moved to separate patch set as proposed in last review. Other changes requested in last review are done. Small changes done to

[FFmpeg-devel] [PATCH 04/14] libavcodec: Implementation of AAC_fixed_decoder (LC-module) [4/4]

2015-04-15 Thread Nedeljko Babic
From: Jovan Zelincevic Build system modified Signed-off-by: Nedeljko Babic --- configure | 1 + libavcodec/Makefile | 13 ++--- libavcodec/aacdec.c | 1 - libavcodec/aacdec_fixed.c | 1 - libavcodec/allcodecs.c| 1 + 5 files changed, 12 insertions(+)

[FFmpeg-devel] [PATCH 08/14] libavcodec: Implementation of AAC_fixed_decoder (SBR-module) [4/4]

2015-04-15 Thread Nedeljko Babic
From: Jovan Zelincevic Build system modified. Signed-off-by: Nedeljko Babic --- libavcodec/Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 07b1899..6d2a4b9 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefi

[FFmpeg-devel] [PATCH] configure: add pkg-config support for libdcadec

2015-04-15 Thread Simon Thelen
Signed-off-by: Simon Thelen --- Implemented like the check for libx264 without the warn on fallback. Tested on my system with pkg-config. configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 389de92..1d98828 100755 --- a/configure +++ b/conf

[FFmpeg-devel] [PATCH 1/2] libavutil/softfloat: Change order of fields in SoftFloat structure.

2015-04-15 Thread Nedeljko Babic
Softfloat will be used in implementation of AAC fixed point decoder. This change is needed in order to more easily integrate ffmpegs softfloat in already developed algorithm for AAC. Signed-off-by: Nedeljko Babic --- libavutil/softfloat.h | 14 +++--- 1 file changed, 7 insertions(+), 7 d

[FFmpeg-devel] Changes to libavutil/softfloat

2015-04-15 Thread Nedeljko Babic
The next two patches are making some changes in softfloat. These changes don't have any impact on current ffmpeg code since softfloat is currently not in use. They are needed as preparation for submitting implementation of fixed point aac decoder that will follow soon. -Nedeljko ___

[FFmpeg-devel] [PATCH 2/2] libavutil: Make changes in softfloat needed for fixed point aac decoder.

2015-04-15 Thread Nedeljko Babic
From: Djordje Pesut Functions for sqrt and sincos are added. Div function is improved. Some changes are made in order for code in softfloat to be usable in fixed aac decoder code. This doesn't create any impact on current ffmpeg code since softfloat is currently not in use and this way we don'

Re: [FFmpeg-devel] [PATCH 0/5] Fix mp3 gapless support (second try)

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 13:47:48 +0200 Michael Niedermayer wrote: > On Wed, Apr 15, 2015 at 01:32:11PM +0200, wm4 wrote: > > On Wed, 15 Apr 2015 13:16:20 +0200 > > Michael Niedermayer wrote: > > > > > On Wed, Apr 15, 2015 at 01:12:27PM +0200, wm4 wrote: > > > > On Wed, 15 Apr 2015 12:43:36 +0200 >

Re: [FFmpeg-devel] [PATCH 0/5] Fix mp3 gapless support (second try)

2015-04-15 Thread Michael Niedermayer
On Wed, Apr 15, 2015 at 01:32:11PM +0200, wm4 wrote: > On Wed, 15 Apr 2015 13:16:20 +0200 > Michael Niedermayer wrote: > > > On Wed, Apr 15, 2015 at 01:12:27PM +0200, wm4 wrote: > > > On Wed, 15 Apr 2015 12:43:36 +0200 > > > Michael Niedermayer wrote: > > > > > > > On Wed, Apr 15, 2015 at 11:08

Re: [FFmpeg-devel] [PATCH 0/5] Fix mp3 gapless support (second try)

2015-04-15 Thread Michael Niedermayer
On Wed, Apr 15, 2015 at 01:16:45PM +0200, wm4 wrote: > On Wed, 15 Apr 2015 12:42:04 +0200 > Michael Niedermayer wrote: > > > On Wed, Apr 15, 2015 at 11:08:02AM +0200, wm4 wrote: > > > On Tue, 14 Apr 2015 22:44:22 +0200 > > > Michael Niedermayer wrote: > > > > > > > On Tue, Apr 14, 2015 at 09:24

Re: [FFmpeg-devel] [PATCH 0/5] Fix mp3 gapless support (second try)

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 13:16:20 +0200 Michael Niedermayer wrote: > On Wed, Apr 15, 2015 at 01:12:27PM +0200, wm4 wrote: > > On Wed, 15 Apr 2015 12:43:36 +0200 > > Michael Niedermayer wrote: > > > > > On Wed, Apr 15, 2015 at 11:08:02AM +0200, wm4 wrote: > > > [...] > > > > the start of the file. (S

[FFmpeg-devel] [PATCH v4] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution for AAC

2015-04-15 Thread Rostislav Pehlivanov
This commit implements the perceptual noise substitution AAC extension. This is a proof of concept implementation, and as such, is not enabled by default. This is the fourth revision of this patch, made after some problems were noted out. Any changes made since the previous revisions have been i

Re: [FFmpeg-devel] [PATCH 0/5] Fix mp3 gapless support (second try)

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 12:42:04 +0200 Michael Niedermayer wrote: > On Wed, Apr 15, 2015 at 11:08:02AM +0200, wm4 wrote: > > On Tue, 14 Apr 2015 22:44:22 +0200 > > Michael Niedermayer wrote: > > > > > On Tue, Apr 14, 2015 at 09:24:32PM +0200, wm4 wrote: > > > > Seeking was slightly broken. The 4th

Re: [FFmpeg-devel] [PATCH 0/5] Fix mp3 gapless support (second try)

2015-04-15 Thread Michael Niedermayer
On Wed, Apr 15, 2015 at 01:12:27PM +0200, wm4 wrote: > On Wed, 15 Apr 2015 12:43:36 +0200 > Michael Niedermayer wrote: > > > On Wed, Apr 15, 2015 at 11:08:02AM +0200, wm4 wrote: > > [...] > > > the start of the file. (Seeking to anywhere else likely won't work, > > > because libavformat tries to

Re: [FFmpeg-devel] [PATCH 0/5] Fix mp3 gapless support (second try)

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 12:43:36 +0200 Michael Niedermayer wrote: > On Wed, Apr 15, 2015 at 11:08:02AM +0200, wm4 wrote: > [...] > > the start of the file. (Seeking to anywhere else likely won't work, > > because libavformat tries to use the imperfect xing toc, instead of > > scanning the frames.) >

Re: [FFmpeg-devel] [PATCH 0/5] Fix mp3 gapless support (second try)

2015-04-15 Thread Michael Niedermayer
On Wed, Apr 15, 2015 at 11:08:02AM +0200, wm4 wrote: [...] > the start of the file. (Seeking to anywhere else likely won't work, > because libavformat tries to use the imperfect xing toc, instead of > scanning the frames.) btw, you can disable the imperfect xing toc for seeking with "-usetoc 0" [

Re: [FFmpeg-devel] [PATCH 0/5] Fix mp3 gapless support (second try)

2015-04-15 Thread Michael Niedermayer
On Wed, Apr 15, 2015 at 11:08:02AM +0200, wm4 wrote: > On Tue, 14 Apr 2015 22:44:22 +0200 > Michael Niedermayer wrote: > > > On Tue, Apr 14, 2015 at 09:24:32PM +0200, wm4 wrote: > > > Seeking was slightly broken. The 4th patch seems to fix this (everything > > > else is noise). > > > > > > > >

Re: [FFmpeg-devel] [RFC][PATCH] avformat/flvdec: avoid reseting eof_reached to 0 silently

2015-04-15 Thread wm4
On Tue, 14 Apr 2015 11:24:23 +0800 Zhang Rui wrote: > 2015-04-14 1:09 GMT+08:00 wm4 : > > On Mon, 13 Apr 2015 12:02:29 +0800 > > Zhang Rui wrote: > > > >> 2015-04-12 22:45 GMT+08:00 Michael Niedermayer : > >> > On Sun, Apr 12, 2015 at 12:00:18PM +0800, Zhang Rui wrote: > >> >> 2015-04-10 22:04 G

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 12:21:01 +0200 Nicolas George wrote: > Le sextidi 26 germinal, an CCXXIII, wm4 a écrit : > > Both ffmpeg.c and the API are very complex, so it's obvious that > > ffmpeg.c can't possibly be using all possible ways the API can be used. > > FUD again. > > > If you really want a

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread Nicolas George
Le sextidi 26 germinal, an CCXXIII, wm4 a écrit : > Both ffmpeg.c and the API are very complex, so it's obvious that > ffmpeg.c can't possibly be using all possible ways the API can be used. FUD again. > If you really want a concrete example: av_seek_frame() is not used in > any of the command li

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 12:01:51 +0200 Nicolas George wrote: > Le sextidi 26 germinal, an CCXXIII, wm4 a écrit : > > How hard is it to understand that a program built for a specific > > purpose can not be made to use an API in all possible ways? Unless you > > add dozens of redundant code paths to ff

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread Nicolas George
Le sextidi 26 germinal, an CCXXIII, wm4 a écrit : > How hard is it to understand that a program built for a specific > purpose can not be made to use an API in all possible ways? Unless you > add dozens of redundant code paths to ffmpeg.c (do you want this?), you > won't be able to get full API cov

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 11:34:28 +0200 Nicolas George wrote: > Le sextidi 26 germinal, an CCXXIII, wm4 a écrit : > > [ I skip over the usual jealousy rants. ] > > > Your attitude also shows an amazing chauvinism: who cares about the API > > users (and any downstream projects), as long as the comman

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mp3dec: alwas prefer xing toc for seeking if present

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 09:36:09 + (UTC) Carl Eugen Hoyos wrote: > wm4 googlemail.com> writes: > > > > > > this breaks seeking in CBR files with a xing toc > > > > > > > > > > see: https://trac.ffmpeg.org/ticket/2590 for testcase/example > > > From what I can tell, this can't be used to repro

Re: [FFmpeg-devel] [PATCH 0/5] Fix mp3 gapless support (second try)

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 09:31:06 + (UTC) Carl Eugen Hoyos wrote: > wm4 googlemail.com> writes: > > > > do you have a file/sample/testcase for patch 4 ? > > > > https://0x0.st/AG.mp3 > > What is wrong with seeking in this file? It's not gapless. It destroys the discarding of samples from begi

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mp3dec: alwas prefer xing toc for seeking if present

2015-04-15 Thread Carl Eugen Hoyos
wm4 googlemail.com> writes: > > > > this breaks seeking in CBR files with a xing toc > > > > > > > > see: https://trac.ffmpeg.org/ticket/2590 for testcase/example > From what I can tell, this can't be used to reproduce the problem. I tested the following: $ ffmpeg -ss 50 -i Underworld_sample_c

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread Nicolas George
Le sextidi 26 germinal, an CCXXIII, wm4 a écrit : [ I skip over the usual jealousy rants. ] > Your attitude also shows an amazing chauvinism: who cares about the API > users (and any downstream projects), as long as the command line tools > are fine? And you fail to understand. Once again. The

Re: [FFmpeg-devel] [PATCH 0/5] Fix mp3 gapless support (second try)

2015-04-15 Thread Carl Eugen Hoyos
wm4 googlemail.com> writes: > > do you have a file/sample/testcase for patch 4 ? > > https://0x0.st/AG.mp3 What is wrong with seeking in this file? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/f

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mp3dec: alwas prefer xing toc for seeking if present

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 09:25:02 + (UTC) Carl Eugen Hoyos wrote: > wm4 googlemail.com> writes: > > > > this breaks seeking in CBR files with a xing toc > > > > > > see: https://trac.ffmpeg.org/ticket/2590 for testcase/example > > > > The sample file is gone. > > $ curl -O > https://trac.ffmp

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mp3dec: alwas prefer xing toc for seeking if present

2015-04-15 Thread Michael Niedermayer
On Wed, Apr 15, 2015 at 11:17:24AM +0200, wm4 wrote: > On Tue, 14 Apr 2015 23:12:37 +0200 > Michael Niedermayer wrote: > > > On Tue, Apr 14, 2015 at 09:24:37PM +0200, wm4 wrote: > > > For consistency. This masked another bug before. > > > --- > > > libavformat/mp3dec.c | 12 ++-- > > > 1

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 11:07:16 +0200 Nicolas George wrote: > Le sextidi 26 germinal, an CCXXIII, wm4 a écrit : > > Because we want to test the API, not the command line tools. > > And the command line tools, as everybody knows, operate by magic instead of > using the API. The command line tools a

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mp3dec: alwas prefer xing toc for seeking if present

2015-04-15 Thread Carl Eugen Hoyos
wm4 googlemail.com> writes: > > this breaks seeking in CBR files with a xing toc > > > > see: https://trac.ffmpeg.org/ticket/2590 for testcase/example > > The sample file is gone. $ curl -O https://trac.ffmpeg.org/raw-attachment/ticket/2590/Underworld_sample_cut.mp3 % Total% Received % X

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mp3dec: alwas prefer xing toc for seeking if present

2015-04-15 Thread wm4
On Tue, 14 Apr 2015 23:12:37 +0200 Michael Niedermayer wrote: > On Tue, Apr 14, 2015 at 09:24:37PM +0200, wm4 wrote: > > For consistency. This masked another bug before. > > --- > > libavformat/mp3dec.c | 12 ++-- > > 1 file changed, 6 insertions(+), 6 deletions(-) > > this breaks seeki

Re: [FFmpeg-devel] [PATCH 0/5] Fix mp3 gapless support (second try)

2015-04-15 Thread wm4
On Tue, 14 Apr 2015 22:44:22 +0200 Michael Niedermayer wrote: > On Tue, Apr 14, 2015 at 09:24:32PM +0200, wm4 wrote: > > Seeking was slightly broken. The 4th patch seems to fix this (everything > > else is noise). > > > > > Note that ffmpeg can't correctly implement mp3 gapless audio if seeking

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread Nicolas George
Le sextidi 26 germinal, an CCXXIII, wm4 a écrit : > Because we want to test the API, not the command line tools. And the command line tools, as everybody knows, operate by magic instead of using the API. If there is a point of the API that can not be accessed with the command-line tools, fix that

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 09:23:04 +0200 Nicolas George wrote: > But for this particular case, I wonder why there is so much code for a > specific codec test while all other codecs are tested using the standard > command-line tools. Because we want to test the API, not the command line tools.

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread wm4
On Tue, 14 Apr 2015 23:08:02 + Ludmila Glinskih wrote: > > > +{ > > > +if (result != enc_pkt.size) > > > +{ > > > +av_log(NULL, AV_LOG_INFO, "Decoder consumed only > > part of a packet, it is allowed to do so -- need to update th

Re: [FFmpeg-devel] Question regarding inter-filter communication

2015-04-15 Thread wm4
On Mon, 13 Apr 2015 08:28:18 -0700 Bahram Dahi wrote: > This is my first email to the list and I apologize in advance if I'm > breaking some sort of rule by doing a mass email. > > I am developing a couple of specialized filters for ffmpeg, where the first > filter would find some regions of int

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread Nicolas George
Le quintidi 25 germinal, an CCXXIII, Michael Niedermayer a écrit : > please avoid float/double > see tests/audiogen.c as an example or maybe better use tests/audiogen > so no code is duplicated Just for the record, there is also asrc_sine.c in lavfi that generates a bit-exact sine signal. I have