[FFmpeg-devel] [PATCH] WIP: lavf/segment: provide a virtual AVIOContext representing all the segments

2015-03-29 Thread Rodger Combs
This needs a fair bit of testing and review before merge. Re: mini: > if the header does get updated at the end this would mismatch if only a > subset of segments get concatenated This is one reason why I have the `seekback` option disabled by default (the other being that it avoids potential int

Re: [FFmpeg-devel] [PATCH 1/4] lavf: add directory listing API

2015-03-29 Thread Michael Niedermayer
On Mon, Mar 30, 2015 at 12:36:34AM +0200, Lukasz Marek wrote: > On 29.03.2015 01:14, Mariusz Szczepańczyk wrote: > >diff --git a/doc/APIchanges b/doc/APIchanges > >index 3f153e9..814f752 100644 > >--- a/doc/APIchanges > >+++ b/doc/APIchanges > >@@ -15,6 +15,15 @@ libavutil: 2014-08-09 > > > >

Re: [FFmpeg-devel] [PATCH 1/4] lavf: add directory listing API

2015-03-29 Thread Michael Niedermayer
On Sun, Mar 29, 2015 at 01:14:54AM +0100, Mariusz Szczepańczyk wrote: > On Fri, Mar 27, 2015 at 6:52 PM, Michael Niedermayer > wrote: > > > On Thu, Mar 26, 2015 at 03:31:27PM +0100, Mariusz Szczepańczyk wrote: > > > On Thu, Mar 26, 2015 at 2:31 PM, Michael Niedermayer > > > wrote: > > > > > > >

Re: [FFmpeg-devel] [PATCH 3/4] lavu/avstring: add av_append_path_component() funcion

2015-03-29 Thread Michael Niedermayer
On Thu, Mar 26, 2015 at 05:39:49PM +0100, Mariusz Szczepańczyk wrote: > On Thu, Mar 26, 2015 at 3:40 PM, Michael Niedermayer > wrote: > > > On Thu, Mar 26, 2015 at 01:25:19AM +0100, Mariusz Szczepańczyk wrote: > > > From: Lukasz Marek > > > > > > Convinient function to build paths. > > > --- > >

Re: [FFmpeg-devel] [PATCH 1/4] lavf: add directory listing API

2015-03-29 Thread Lukasz Marek
On 29.03.2015 01:14, Mariusz Szczepańczyk wrote: diff --git a/doc/APIchanges b/doc/APIchanges index 3f153e9..814f752 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -15,6 +15,15 @@ libavutil: 2014-08-09 API changes, most recent first: +2015-03-27 - 184084c - lavf 56.27.100 - avio.h ur

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/tinterlace: Change enum to int, which is accessed via AVOption as int

2015-03-29 Thread Michael Niedermayer
On Sat, Mar 28, 2015 at 10:28:54PM +0100, Michael Niedermayer wrote: > This fixes depending on implementation defined behavior > > Signed-off-by: Michael Niedermayer > --- > libavfilter/tinterlace.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patchset applied [...] -- Michael

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-03-29 Thread Wiebe Cazemier
- Original Message - > From: "Kieran Kunhya" > To: "Wiebe Cazemier" > Cc: "Kieran Kunhya" > Sent: Sunday, 29 March, 2015 10:03:05 PM > Subject: Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression > (drc_scale) is now 0 by default > > > There was another thread about it (

Re: [FFmpeg-devel] [PATCH 4/4] lavf/matroskaenc: don't try to end the segment when the output isn't seekable

2015-03-29 Thread Michael Niedermayer
On Sun, Mar 29, 2015 at 11:08:51PM +0200, Michael Niedermayer wrote: > On Sun, Mar 29, 2015 at 02:56:00PM -0600, Rodger Combs wrote: > > I can see the reasoning here, but as "small enough" here means 32K, > > my concern was that some app might use a single large buffer without > seek function. > 3

Re: [FFmpeg-devel] [PATCH 4/4] lavf/matroskaenc: don't try to end the segment when the output isn't seekable

2015-03-29 Thread Michael Niedermayer
On Sun, Mar 29, 2015 at 02:56:00PM -0600, Rodger Combs wrote: > I can see the reasoning here, but as "small enough" here means 32K, my concern was that some app might use a single large buffer without seek function. 32k is too small i agree > I don't think this would be worth doing on a per-muxe

Re: [FFmpeg-devel] [PATCH 4/4] lavf/matroskaenc: don't try to end the segment when the output isn't seekable

2015-03-29 Thread Rodger Combs
I can see the reasoning here, but as "small enough" here means 32K, I don't think this would be worth doing on a per-muxer basis. Maybe if we had a more general way to tell the muxer about segment boundaries, or if segment.c provided a single AVIOContext, with a write() function that passes thro

Re: [FFmpeg-devel] [PATCH 4/4] lavf/matroskaenc: don't try to end the segment when the output isn't seekable

2015-03-29 Thread Michael Niedermayer
On Sun, Mar 29, 2015 at 11:54:59AM -0600, Rodger Combs wrote: > In the case of most calls to end_ebml_master, the target is within the > current segment, but in this case, it's in the first segment or header file, > so if the context was marked as non-seekable manually (as in segment.c), > avio_

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-03-29 Thread madshi
2015-03-29 20:06 GMT+02:00 Kieran Kunhya : > > On 29 March 2015 at 18:01, Wiebe Cazemier wrote: > > Signed-off-by: Wiebe Cazemier > Why can't you just set this in your application? > Not everyone is listening on a full setup where they can hear the dynamic range. There are 2 possible situations:

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-03-29 Thread Kieran Kunhya
On 29 March 2015 at 18:01, Wiebe Cazemier wrote: > Signed-off-by: Wiebe Cazemier Why can't you just set this in your application? Not everyone is listening on a full setup where they can hear the dynamic range. Kieran ___ ffmpeg-devel mailing list ffm

Re: [FFmpeg-devel] [PATCH 4/4] lavf/matroskaenc: don't try to end the segment when the output isn't seekable

2015-03-29 Thread Rodger Combs
In the case of most calls to end_ebml_master, the target is within the current segment, but in this case, it's in the first segment or header file, so if the context was marked as non-seekable manually (as in segment.c), avio_seek will ignore that and execute it anyway. This is fine in other use

Re: [FFmpeg-devel] [PATCH 4/4] lavf/matroskaenc: don't try to end the segment when the output isn't seekable

2015-03-29 Thread Michael Niedermayer
On Sat, Mar 28, 2015 at 07:25:21PM -0600, Rodger Combs wrote: > --- > libavformat/matroskaenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index 6b2e390..c242a0e 100644 > --- a/libavformat/matroskaenc.c > +++ b/

Re: [FFmpeg-devel] Default dynamic range compression on AC3

2015-03-29 Thread Wiebe Cazemier
- Original Message - > From: "Michael Niedermayer" > To: "FFmpeg development discussions and patches" > Sent: Thursday, 26 March, 2015 12:40:45 PM > Subject: Re: [FFmpeg-devel] Default dynamic range compression on AC3 > > and yes, please post a patch, this also should bump the version nu

Re: [FFmpeg-devel] [PATCH] lavf/segment: Mark output contexts as non-seekable when applicable

2015-03-29 Thread Michael Niedermayer
On Sun, Mar 29, 2015 at 10:57:09AM -0600, Rodger Combs wrote: > This prevents sub-muxers from trying to seek back to the beginning of the > whole stream, only to find themselves overwriting some video data in the > current (often last) segment. > > We only do this when not writing individual heade

[FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-03-29 Thread Wiebe Cazemier
Signed-off-by: Wiebe Cazemier --- Changelog | 1 + doc/decoders.texi | 2 +- libavcodec/ac3dec_fixed.c | 2 +- libavcodec/ac3dec_float.c | 2 +- libavutil/version.h | 2 +- 5 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Changelog b/Changelog index 109

[FFmpeg-devel] [PATCH] lavf/segment: Mark output contexts as non-seekable when applicable

2015-03-29 Thread Rodger Combs
This prevents sub-muxers from trying to seek back to the beginning of the whole stream, only to find themselves overwriting some video data in the current (often last) segment. We only do this when not writing individual header/trailers. --- libavformat/segment.c | 6 ++ 1 file changed, 6 ins

Re: [FFmpeg-devel] [PATCH 5/8] png: Only init zlib once

2015-03-29 Thread Michael Niedermayer
On Sun, Mar 29, 2015 at 11:05:43AM +, Donny Yang wrote: > Signed-off-by: Donny Yang > --- > libavcodec/pngenc.c | 27 ++- > 1 file changed, 14 insertions(+), 13 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B

Re: [FFmpeg-devel] [PATCH 4/8] png: Calculate pixel format information only once

2015-03-29 Thread Michael Niedermayer
On Sun, Mar 29, 2015 at 11:05:42AM +, Donny Yang wrote: > Signed-off-by: Donny Yang > --- > libavcodec/pngenc.c | 124 > +++- > 1 file changed, 65 insertions(+), 59 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128

Re: [FFmpeg-devel] [PATCH 8/8] apng: Add a basic APNG muxer

2015-03-29 Thread Paul B Mahol
Dana 29. 3. 2015. 13:06 osoba "Donny Yang" napisala je: > > Additionally, update some documentation with support for APNG > Make sure muxer works with -c:v copy. > Signed-off-by: Donny Yang > --- > Changelog| 1 + > doc/general.texi | 2 + > libavformat/Makefile

Re: [FFmpeg-devel] [GSoC] Proof-of-concept HTTP Server

2015-03-29 Thread wm4
On Sun, 29 Mar 2015 04:13:18 +0200 Stephan Holljes wrote: > I hope this addresses the issues mentioned. > I added a new label in case of failure in http_open() in favor of > duplicated code (i.e. calling av_dict_free() multiple times). I copied > the style from the other functions. > > Signed-of

Re: [FFmpeg-devel] [PATCH 3/8] png: Return slightly more meaningful error codes

2015-03-29 Thread Michael Niedermayer
On Sun, Mar 29, 2015 at 11:05:42AM +, Donny Yang wrote: > Signed-off-by: Donny Yang > --- > libavcodec/pngenc.c | 22 ++ > 1 file changed, 10 insertions(+), 12 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH 1/8] png: Clear up the calculation of max packet size

2015-03-29 Thread wm4
On Sun, 29 Mar 2015 11:05:40 + Donny Yang wrote: > Signed-off-by: Donny Yang > --- > libavcodec/pngenc.c | 19 +++ > 1 file changed, 15 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c > index d6233d0..3697dbb 100644 > --- a/libavcode

Re: [FFmpeg-devel] [PATCH 2/8] png: Don't fail when a packet is larger than INT_MAX

2015-03-29 Thread Michael Niedermayer
On Sun, Mar 29, 2015 at 11:05:41AM +, Donny Yang wrote: > Signed-off-by: Donny Yang > --- > libavcodec/pngenc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c > index 3697dbb..bd3aae5 100644 > --- a/libavcodec/pngenc.c > +++ b/libavcodec/p

Re: [FFmpeg-devel] [PATCH 1/8] png: Clear up the calculation of max packet size

2015-03-29 Thread Michael Niedermayer
On Sun, Mar 29, 2015 at 11:05:40AM +, Donny Yang wrote: > Signed-off-by: Donny Yang > --- > libavcodec/pngenc.c | 19 +++ > 1 file changed, 15 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c > index d6233d0..3697dbb 100644 > --- a/liba

Re: [FFmpeg-devel] Fwd: GSoC: APNG

2015-03-29 Thread Michael Niedermayer
On Sun, Mar 29, 2015 at 04:30:27AM +, Donny Yang wrote: > On 29 March 2015 at 03:15, Michael Niedermayer wrote: > > > you can try AVCodecContext->frame_number, if that doesnt work > > you need to keep track of if you already had received a frame > > > I've tried both, but it turns out that AV

Re: [FFmpeg-devel] [PATCH 3/4] libavformat/segment: add an option to write the header to a separate file

2015-03-29 Thread Michael Niedermayer
On Sat, Mar 28, 2015 at 07:25:20PM -0600, Rodger Combs wrote: > This permits some interesting segmenting techniques with formats like > Matroska, > where you can concatenate the header and segments [N, nb_segments) and get > a working file that starts at segment N's start time. > --- > libavforma

Re: [FFmpeg-devel] [PATCH 2/4] lavf/segment: Mark output contexts as non-seekable

2015-03-29 Thread Michael Niedermayer
On Sat, Mar 28, 2015 at 07:25:19PM -0600, Rodger Combs wrote: > This prevents sub-muxers from trying to seek back to the beginning of the > whole stream, only to find themselves overwriting some video data in the > current (often last) segment. > --- > libavformat/segment.c | 3 +++ > 1 file chang

Re: [FFmpeg-devel] [PATCH]Add an ignore_delay option to the gif demuxer

2015-03-29 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > On Sat, Mar 28, 2015 at 05:54:49PM +, Carl Eugen Hoyos wrote: > > Michael Niedermayer gmx.at> writes: > > > > > was this the intent of the creator of the sample file we have ? > > > i mean that the frames display more then 10 minutes > > > > There is

Re: [FFmpeg-devel] [PATCH 1/4] libavformat/segment: don't leave the list pb open when not in use

2015-03-29 Thread Michael Niedermayer
On Sat, Mar 28, 2015 at 07:25:18PM -0600, Rodger Combs wrote: > --- > libavformat/segment.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) applied i wonder if it would make sense to leave it open and update its content thanks [...] -- Michael GnuPG fingerprint: 9FF2128B1

Re: [FFmpeg-devel] [PATCH] libavformat/hls: add an option to start from a given segment in a live stream

2015-03-29 Thread Michael Niedermayer
On Sat, Mar 28, 2015 at 06:27:35PM -0600, Rodger Combs wrote: > --- > libavformat/hls.c | 28 > 1 file changed, 24 insertions(+), 4 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Democracy is the form o

[FFmpeg-devel] [PATCH] avcodec/libdcadec: remove av_assert and check bits_per_sample more completely

2015-03-29 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/libdcadec.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/libdcadec.c b/libavcodec/libdcadec.c index 6e89262..3ac4bcb 100644 --- a/libavcodec/libdcadec.c +++ b/libavcodec/libdcadec.c @@ -21,7 +21,6 @@ #inc

[FFmpeg-devel] [PATCH 8/8] apng: Add a basic APNG muxer

2015-03-29 Thread Donny Yang
Additionally, update some documentation with support for APNG Signed-off-by: Donny Yang --- Changelog| 1 + doc/general.texi | 2 + libavformat/Makefile | 1 + libavformat/allformats.c | 2 +- libavformat/apngenc.c| 250

[FFmpeg-devel] [PATCH 5/8] png: Only init zlib once

2015-03-29 Thread Donny Yang
Signed-off-by: Donny Yang --- libavcodec/pngenc.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c index 0a215f2..410a829 100644 --- a/libavcodec/pngenc.c +++ b/libavcodec/pngenc.c @@ -299,7 +299,6 @@ stati

[FFmpeg-devel] [PATCH 6/8] png: Clearly separate encoding header and frames

2015-03-29 Thread Donny Yang
Signed-off-by: Donny Yang --- libavcodec/pngenc.c | 146 +++- 1 file changed, 86 insertions(+), 60 deletions(-) diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c index 410a829..0264575 100644 --- a/libavcodec/pngenc.c +++ b/libavcodec/pngenc.c

[FFmpeg-devel] [PATCH 2/8] png: Don't fail when a packet is larger than INT_MAX

2015-03-29 Thread Donny Yang
Signed-off-by: Donny Yang --- libavcodec/pngenc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c index 3697dbb..bd3aae5 100644 --- a/libavcodec/pngenc.c +++ b/libavcodec/pngenc.c @@ -373,8 +373,6 @@ static int encode_frame(AVCodecContext *avctx, AVP

[FFmpeg-devel] [PATCH 7/8] apng: Make PNG encoder only write headers once in APNG mode

2015-03-29 Thread Donny Yang
Signed-off-by: Donny Yang --- configure | 1 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 2 +- libavcodec/pngenc.c| 53 ++ 4 files changed, 52 insertions(+), 5 deletions(-) diff --git a/configure b/configure index e

[FFmpeg-devel] [PATCH 4/8] png: Calculate pixel format information only once

2015-03-29 Thread Donny Yang
Signed-off-by: Donny Yang --- libavcodec/pngenc.c | 124 +++- 1 file changed, 65 insertions(+), 59 deletions(-) diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c index 6c8fec2..0a215f2 100644 --- a/libavcodec/pngenc.c +++ b/libavcodec/pngenc.c

[FFmpeg-devel] [PATCH 3/8] png: Return slightly more meaningful error codes

2015-03-29 Thread Donny Yang
Signed-off-by: Donny Yang --- libavcodec/pngenc.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c index bd3aae5..6c8fec2 100644 --- a/libavcodec/pngenc.c +++ b/libavcodec/pngenc.c @@ -382,19 +382,19 @@ static i

[FFmpeg-devel] [PATCH 1/8] png: Clear up the calculation of max packet size

2015-03-29 Thread Donny Yang
Signed-off-by: Donny Yang --- libavcodec/pngenc.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c index d6233d0..3697dbb 100644 --- a/libavcodec/pngenc.c +++ b/libavcodec/pngenc.c @@ -360,12 +360,23 @@ static int e

Re: [FFmpeg-devel] [PATCH] tiff: Return more meaningful error codes

2015-03-29 Thread Carl Eugen Hoyos
James Almer gmail.com> writes: > > case TIFF_LZW: > > return ff_lzw_encode(s->lzws, src, n); > > default: > > -return -1; > > +return AVERROR_BUG; > > AVERROR(EINVAL) here. > > If i do "ffmpeg -i INPUT -compression_algo 2 OUTPUT.tiff" > I'm not triggering a b