Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-16 Thread Philip Langdale
On Fri, 16 Jan 2015 22:17:56 +0100 Nicolas George wrote: > Le septidi 27 nivôse, an CCXXIII, Philip Langdale a écrit : > > Right. It is display aspect ratio, not sample aspect ratio. And then > > you have the 45/44 problem, unless that's somehow just affecting me. > > IIRC, the tests you ran wer

[FFmpeg-devel] [PATCH] ffmpeg: Make CFR frame drop threshold user adjustable

2015-01-16 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- ffmpeg.c |4 +++- ffmpeg.h |1 + ffmpeg_opt.c |3 +++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ffmpeg.c b/ffmpeg.c index 2501e2c..42ab379 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -963,7 +963,9 @@ static void do_video_o

Re: [FFmpeg-devel] [PATCH 1/3] 10 Bit support for Decklink input device

2015-01-16 Thread Michael Niedermayer
On Sun, Jan 11, 2015 at 09:01:20PM +0530, Anshul wrote: > On 01/11/2015 08:08 PM, Georg Lippitsch wrote: > > --- > > libavdevice/decklink_common_c.h | 1 + > > libavdevice/decklink_dec.cpp| 18 ++ > > libavdevice/decklink_dec_c.c| 1 + > > 3 files changed, 16 insertions(+

Re: [FFmpeg-devel] Adding Closed caption in nut muxer

2015-01-16 Thread Michael Niedermayer
On Tue, Jan 13, 2015 at 02:20:42PM +0100, Michael Niedermayer wrote: > On Tue, Jan 13, 2015 at 12:00:36PM +0100, Nicolas George wrote: > > Le quartidi 24 nivôse, an CCXXIII, Anshul a écrit : > > > Please find attachment. > > > Using this people can also mux cc608 stream in nut muxer > > > > IIRC,

[FFmpeg-devel] [PATCH] ffmpeg: Reduce noisiness of frame clipping in rate convertion

2015-01-16 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- ffmpeg.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ffmpeg.c b/ffmpeg.c index 633dadd..01458d2 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -944,7 +944,10 @@ static void do_video_out(AVFormatContext *s, format_video_sync !

[FFmpeg-devel] [PATCH] ffmpeg: Favor filter graph based duration over ost->frame_rate in fps code

2015-01-16 Thread Michael Niedermayer
The fate change adds a last frame with a subtitle not displayed in the previous Signed-off-by: Michael Niedermayer --- ffmpeg.c | 11 --- tests/ref/fate/sub2video |1 + 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index 2501e2c.

[FFmpeg-devel] [PATCH] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-16 Thread Timo Rothenpieler
--- libavcodec/nvenc.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 90856be..3fcfc9b 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -471,6 +471,7 @@ static av_cold int nvenc_encode_init(AVCodecCont

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-16 Thread Nicolas George
Le septidi 27 nivôse, an CCXXIII, Philip Langdale a écrit : > Right. It is display aspect ratio, not sample aspect ratio. And then > you have the 45/44 problem, unless that's somehow just affecting me. IIRC, the tests you ran were not accurate enough to know for sure. I suggest the following test

Re: [FFmpeg-devel] [PATCH] Force text files to be downloaded in UNIX line ending (LF)

2015-01-16 Thread Timotius Margo
I verified that GNU Make 4.1 in MSYS2 environment builds FFmpeg without any issue regardless of the line ending. This is good and I recommend MSYS2 usage for building FFmpeg for WinRT in the wiki below: https://trac.ffmpeg.org/wiki/CompilationGuide/WinRT However, the official documentation and t

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-16 Thread Philip Langdale
On 2015-01-15 23:48, Nicolas George wrote: Le septidi 27 nivôse, an CCXXIII, Timo Rothenpieler a écrit : +av_reduce(&dw, &dh, avctx->sample_aspect_ratio.num, avctx->sample_aspect_ratio.den, 4096); +ctx->init_encode_params.darHeight = dw; +ctx->init_encode_params.darWidth

Re: [FFmpeg-devel] [RFC] Support dynamic loading of third-party libs

2015-01-16 Thread Reimar Döffinger
On Wed, Jan 14, 2015 at 06:26:06PM +0100, Michael Niedermayer wrote: > ive no idea how portable it is but one way to avoid most of the > mess would be to use attribute weak / lazy linking > that way as long as lib functions arent called nothing should try to > load the lib and so it should work wit

Re: [FFmpeg-devel] [RFC] Support dynamic loading of third-party libs

2015-01-16 Thread Derek Buitenhuis
On 1/16/2015 12:47 AM, Stephen Hutchinson wrote: > There have been times I've run into issues > because a shared library FFmpeg was linked against somehow > got removed or was updated and broke compatibility. [...] > Dynamic loading allows the main binary to still function > correctly if this occ

Re: [FFmpeg-devel] aversion to .cpp files?

2015-01-16 Thread Derek Buitenhuis
On 1/16/2015 9:02 AM, Clément Bœsch wrote: > I believe there is a large perference for C. Not only that, but our configure is downright broken for C++ files, so to speak. We hardcode libstdc++, which is de facto wrong. - Derek ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] aversion to .cpp files?

2015-01-16 Thread Clément Bœsch
On Thu, Jan 15, 2015 at 07:45:57AM -0700, Roger Pack wrote: > Hello. I've noticed there are a few .cpp files in the codebase, but > not many (most seem to be tied to windows). > > I have the choice, with the dshow stuff, to write in its "native" cpp > style (much easier/clearer IMO) or to convert