Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-24 Thread arwa arif
Merry Christmas! :D I have attached 2 patches: 1. For deleting the mp=fspp filter. 2. For porting pp7 I have tested the ouput for pp7, it is bitexact with mp=pp7 filter. Also, I haven't completed the patch. There are just codes. Once the previous patches are pushed, I will update the patch. From

Re: [FFmpeg-devel] [PATCHv3] vf_scale: Use correct chroma positions for YUV420P

2014-12-24 Thread Michael Niedermayer
On Wed, Dec 24, 2014 at 11:52:46PM +, Kieran Kunhya wrote: > Merry Christmas! > > --- > libavfilter/vf_scale.c | 11 +++ > 1 file changed, 11 insertions(+) applied merry Christmess thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you

[FFmpeg-devel] [PATCHv3] vf_scale: Use correct chroma positions for YUV420P

2014-12-24 Thread Kieran Kunhya
Merry Christmas! --- libavfilter/vf_scale.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 64b88c2..f77884c 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_scale.c @@ -373,6 +373,17 @@ static int config_props(AVFilte

Re: [FFmpeg-devel] libavutil: added camellia block cipher

2014-12-24 Thread supraja reddy
Hello, Thank you for your reviews. I have attached the updated patch . You are using a single array K for all the keys, without distinguishing > between > kw, k and ke as in the rfc. This makes code harder to read/maintain with no > real gain I guess. Any reason why you made this decision? > I h

Re: [FFmpeg-devel] libavutil/opencl: output program build log

2014-12-24 Thread Michael Niedermayer
On Wed, Dec 24, 2014 at 07:55:13PM +, Titov, Alexey wrote: > Attached corrected patch should be ok if wei gao is ok with it then i can apply it [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have never wished to cater to the crowd; for what I know they d

Re: [FFmpeg-devel] libavutil/opencl: output program build log

2014-12-24 Thread Michael Niedermayer
On Wed, Dec 24, 2014 at 07:02:11PM +, Titov, Alexey wrote: > Patch attached > diff --git a/libavutil/opencl.c b/libavutil/opencl.c index 36cb6fe..3cd2bf8 100644 --- a/libavutil/opencl.c +++ b/libavutil/opencl.c @@ -449,10 +449,32 @@ cl_program av_opencl_compile(const char *program_name, const

Re: [FFmpeg-devel] libavfilter/unsharpen: patch fixes and resubmission

2014-12-24 Thread Michael Niedermayer
On Tue, Dec 23, 2014 at 09:26:04PM +, Titov, Alexey wrote: > Hi, > > I've fixed the patch according to the reviewers suggestions. Attached are the > two patches (original and fixes) > > Regards, > Alexey > > From e94ea7add32791a1c9ac04dbd68b78cf799ca92d Mon Sep 17 00:00:00 2001 > From: atit

Re: [FFmpeg-devel] [PATCHv2] vf_scale: Use correct chroma position in YUV420P interlaced conversions

2014-12-24 Thread Kieran Kunhya
> >> + >> av_opt_set_int(*s, "src_h_chr_pos", scale->in_h_chr_pos, 0); >> av_opt_set_int(*s, "src_v_chr_pos", scale->in_v_chr_pos, 0); >> av_opt_set_int(*s, "dst_h_chr_pos", scale->out_h_chr_pos, 0); >> @@ -520,8 +527,8 @@ static int filter_frame(AVFilterLink

Re: [FFmpeg-devel] [PATCHv2] vf_scale: Use correct chroma position in YUV420P interlaced conversions

2014-12-24 Thread Michael Niedermayer
On Wed, Dec 24, 2014 at 03:10:56PM +, Kieran Kunhya wrote: > Fixed wrong chroma line use > --- > libavfilter/vf_scale.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c > index 64b88c2..9189103 100644 > --- a/

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-24 Thread Stefano Sabatini
On date Tuesday 2014-12-23 22:22:41 +0100, Michael Niedermayer encoded: > On Tue, Dec 23, 2014 at 10:51:09PM +0530, arwa arif wrote: > [...] > > > Test with a fixed qp value for comparison, as the mp=fspp is broken > > > with regards to qp passing. Also it should generate the same > > > output as w

[FFmpeg-devel] [PATCHv2] vf_scale: Use correct chroma position in YUV420P interlaced conversions

2014-12-24 Thread Kieran Kunhya
Fixed wrong chroma line use --- libavfilter/vf_scale.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 64b88c2..9189103 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_scale.c @@ -373,6 +373,13 @@ static

[FFmpeg-devel] [PATCH] avfilter/showwaves: add single_pic option

2014-12-24 Thread Clément Bœsch
TODO: bump minor --- doc/filters.texi| 12 +++ libavfilter/avf_showwaves.c | 175 +++- 2 files changed, 169 insertions(+), 18 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 7fac8fb..7953e62 100644 --- a/doc/filters.texi +++

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-24 Thread Stefano Sabatini
On date Tuesday 2014-12-23 22:51:09 +0530, arwa arif encoded: [...] > mp=fspp and fspp filter are giving same output. But, fspp with -cpuflags 0 > is giving different output (visually, it > looks same, but its not bitexact). [...] > From 1ee7b1098809dd1e62703ba76a136dd27d243f20 Mon Sep 17 00:00:00

Re: [FFmpeg-devel] [RFC][PATCH] Use correct chroma position in YUV420P interlaced conversions

2014-12-24 Thread Carl Eugen Hoyos
Kieran Kunhya obe.tv> writes: > I think this is right but would be useful to > get it checked. Visually the output looks ok Is this related to ticket #4168? If yes, please add a comment. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-de

[FFmpeg-devel] [RFC][PATCH] Use correct chroma position in YUV420P interlaced conversions

2014-12-24 Thread Kieran Kunhya
I think this is right but would be useful to get it checked. Visually the output looks ok --- libavfilter/vf_scale.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 64b88c2..83a0666 100644 --- a/libavfi

Re: [FFmpeg-devel] [PATCH] tools/probetest: support testing a single specified input format

2014-12-24 Thread Reimar Döffinger
On Tue, Dec 23, 2014 at 03:39:43AM +0100, Michael Niedermayer wrote: > On Mon, Dec 22, 2014 at 12:45:43AM +0100, Michael Niedermayer wrote: > > This reduces the time the test takes significantly when only one > > formats needs to be tested > > > > Signed-off-by: Michael Niedermayer > > --- > > t

Re: [FFmpeg-devel] Frame threaded encoders

2014-12-24 Thread Reimar Döffinger
On Mon, Dec 22, 2014 at 10:57:21PM +, Kieran Kunhya wrote: > Hi, > > Does the CODEC_CAP_FRAME_THREADS API support frame threaded encoding? It should, at the very least quite a few intra codecs use it to support multithreading, see pngenc.c and mjpegenc.c for example. It is however possible th

Re: [FFmpeg-devel] libavutil: added camellia block cipher

2014-12-24 Thread Giorgio Vazzana
Hello Supraja, 2014-12-23 18:38 GMT+01:00 supraja reddy : > I have attached the patch to the basic implementation of camellia block > cipher. Please let me know if there are any bugs to be fixed or if any > further optimization needed. thanks for the patch and thank you Michael for the first revi

Re: [FFmpeg-devel] [PATCH] qdm2: Allow hard-coding VLC tables.

2014-12-24 Thread Reimar Döffinger
On Sat, Dec 20, 2014 at 12:38:38AM +, Carl Eugen Hoyos wrote: > Reimar Döffinger gmx.de> writes: > > This patch has broken "make checkheaders". > > Should the header just not be checked or is there > another fix? Sorry, I missed the mail. Assuming tableprint_vlc.h is the only one that fail

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-24 Thread Reimar Döffinger
On Tue, Dec 23, 2014 at 08:12:50AM +0100, Stefano Sabatini wrote: > On date Monday 2014-12-22 17:57:34 +0100, Reimar Döffinger encoded: > > On 22.12.2014, at 17:23, Stefano Sabatini wrote: > [...] > > > I'm testing with: > > > ffmpeg -i matrixbench_mpeg2.mpg -b:v 200k matrixbench_mpeg2-lq.mpg > >

Re: [FFmpeg-devel] [PATCH] libavfilter/af_showvolume: A Simple Audio Filter for Extracting Volume Information

2014-12-24 Thread Clément Bœsch
On Wed, Dec 24, 2014 at 12:57:07AM +0100, Lars Kiesow wrote: > Hi Stefano, > my first idea was to have ffmpeg generate the image but you are right, > that the unknown length is a problem. The only solution I could come up > with was to have something like a two-pass encoding so that you know > how