[FFmpeg-devel] [PATCH] ffmpeg: fix accurate seeking with -copyts

2014-11-23 Thread Rodger Combs
--- ffmpeg.h| 1 + ffmpeg_filter.c | 18 -- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/ffmpeg.h b/ffmpeg.h index 1ace8be..8107fe7 100644 --- a/ffmpeg.h +++ b/ffmpeg.h @@ -483,6 +483,7 @@ extern int do_deinterlace; extern int do_hex_dump; extern int d

Re: [FFmpeg-devel] [PATCH] ffmpeg: fix accurate seeking with -copyts

2014-11-23 Thread Rodger Combs
Fixed; now passes all FATE tests. Corrected multiple issues with the patch. Behavior between -copyts, -start_at_zero, -ss, and -t/-to might still be unexpected, but shouldn't be any different than what we have now. ___ ffmpeg-devel mailing list ffmpeg-dev

Re: [FFmpeg-devel] [PATCH 2/2] lavc/options: fix leaks in avcodec_copy_context

2014-11-23 Thread Lukasz Marek
On 24-Nov-2014 5:17 am, "Lukasz Marek" wrote: > > Signed-off-by: Lukasz Marek > --- > libavcodec/options.c | 23 +++ > 1 file changed, 11 insertions(+), 12 deletions(-) > > diff --git a/libavcodec/options.c b/libavcodec/options.c > index 7f9fb07..8ba997c 100644 > --- a/libavc

[FFmpeg-devel] [PATCH 2/2] lavc/options: fix leaks in avcodec_copy_context

2014-11-23 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- libavcodec/options.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/libavcodec/options.c b/libavcodec/options.c index 7f9fb07..8ba997c 100644 --- a/libavcodec/options.c +++ b/libavcodec/options.c @@ -190,6 +190,11 @@ i

[FFmpeg-devel] [PATCH 1/2] lavc/options: fix leaks in avcodec_free_context

2014-11-23 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- libavcodec/options.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/options.c b/libavcodec/options.c index 44f3e90..7f9fb07 100644 --- a/libavcodec/options.c +++ b/libavcodec/options.c @@ -170,6 +170,9 @@ void avcodec_free_context(AVCodecContext

Re: [FFmpeg-devel] [PATCH 2/3] lavc/libxvid: return meaningful error codes

2014-11-23 Thread Michael Niedermayer
On Mon, Nov 24, 2014 at 04:14:06AM +0100, Lukasz Marek wrote: > On 24.11.2014 03:07, Michael Niedermayer wrote: > >On Mon, Nov 24, 2014 at 01:17:29AM +0100, Lukasz Marek wrote: > >>Signed-off-by: Lukasz Marek > >>--- > >> libavcodec/libxvid.c | 4 > >> 1 file changed, 4 insertions(+) > >> >

[FFmpeg-devel] [PATCH] lavc/avuienc: fix mem leak in case of init failure

2014-11-23 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- libavcodec/avuienc.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/avuienc.c b/libavcodec/avuienc.c index 700b8cb..db640bb 100644 --- a/libavcodec/avuienc.c +++ b/libavcodec/avuienc.c @@ -25,16 +25,10 @@ static av_col

Re: [FFmpeg-devel] [PATCH 05/11] ffserver: allow skip setting defaults

2014-11-23 Thread Reynaldo H. Verdejo Pinochet
Hi On 11/21/2014 09:13 PM, Lukasz Marek wrote: > [...] > @@ -1032,6 +1059,14 @@ static int ffserver_parse_config_stream(FFServerConfig > *config, const char *cmd, > } else if (!av_strcasecmp(cmd, "File") || !av_strcasecmp(cmd, > "ReadOnlyFile")) { > ffserver_get_arg(stream->feed_fi

Re: [FFmpeg-devel] [PATCH 1/3] lavc/libxvid: fix mem leak in case of init failure

2014-11-23 Thread Lukasz Marek
On 24.11.2014 03:02, Michael Niedermayer wrote: On Mon, Nov 24, 2014 at 01:17:28AM +0100, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- libavcodec/libxvid.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) LGTM pushed this one and huffyuvdec, smvjpegdec ___

Re: [FFmpeg-devel] [PATCH 2/3] lavc/libxvid: return meaningful error codes

2014-11-23 Thread Lukasz Marek
On 24.11.2014 03:07, Michael Niedermayer wrote: On Mon, Nov 24, 2014 at 01:17:29AM +0100, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- libavcodec/libxvid.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c index 020af32..70d52b9 100644

Re: [FFmpeg-devel] bprint.h can't be included in C++ code

2014-11-23 Thread Vadim Kalinsky
> identifiers starting with a double > underscode are reserved for the implementation, and therefore can not be > used. Yep, my bad. > Apart from the fact that it makes the macro hackery vastly less readable > (maybe some indentation would help), Maybe I'm little contaminated with modern PLs,

Re: [FFmpeg-devel] [PATCH 2/3] lavc/libxvid: return meaningful error codes

2014-11-23 Thread Michael Niedermayer
On Mon, Nov 24, 2014 at 01:17:29AM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > libavcodec/libxvid.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c > index 020af32..70d52b9 100644 > --- a/libavcodec/libxvid.c > +++ b/l

Re: [FFmpeg-devel] [PATCH 1/3] lavc/libxvid: fix mem leak in case of init failure

2014-11-23 Thread Michael Niedermayer
On Mon, Nov 24, 2014 at 01:17:28AM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > libavcodec/libxvid.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The misfortun

Re: [FFmpeg-devel] [PATCH] Fix undefined reference to xcb_shape_rectangles in xcbgrab.c

2014-11-23 Thread Carl Eugen Hoyos
Boris Reisig boris.ca> writes: > LD ffmpeg_g > libavdevice/libavdevice.a(xcbgrab.o): In function `xcbgrab_read_header': > xcbgrab.c:(.text.unlikely+0x52c): undefined reference to > `xcb_shape_rectangles' Could you test if my patch fixes the issue for you? http://ffmpeg.org/pipermail/ffmpeg

Re: [FFmpeg-devel] [PATCH] lavu/opt: add const to av_opt_copy arg

2014-11-23 Thread Michael Niedermayer
On Sun, Nov 23, 2014 at 10:25:39PM +0100, Lukasz Marek wrote: > On 23.11.2014 02:29, Michael Niedermayer wrote: > >On Sun, Nov 23, 2014 at 01:01:19AM +0100, Lukasz Marek wrote: > >>On 23.11.2014 00:58, Lukasz Marek wrote: > >>>Signed-off-by: Lukasz Marek > >>>--- > >>> libavutil/opt.c | 2 +- > >>

Re: [FFmpeg-devel] [PATCH] lavc/huffyuvdec: fix mem leak in case of init failure

2014-11-23 Thread Michael Niedermayer
On Sun, Nov 23, 2014 at 10:09:38PM +0100, Lukasz Marek wrote: > On 23.11.2014 11:42, Michael Niedermayer wrote: > >On Sun, Nov 23, 2014 at 12:58:30AM +0100, Lukasz Marek wrote: > >>Signed-off-by: Lukasz Marek > >>--- > >> libavcodec/huffyuvdec.c | 24 > >> 1 file changed,

Re: [FFmpeg-devel] [PATCH] ffmpeg: fix accurate seeking with -copyts

2014-11-23 Thread Michael Niedermayer
On Sun, Nov 23, 2014 at 03:40:44PM -0600, Rodger Combs wrote: > --- > ffmpeg.h| 1 + > ffmpeg_filter.c | 22 -- > 2 files changed, 21 insertions(+), 2 deletions(-) breaks make fate-sub2video TESTsub2video --- ./tests/ref/fate/sub2video 2014-11-23 02:01:33.386906

Re: [FFmpeg-devel] [PATCH] lavc/huffyuvdec: fix mem leak in case of init failure

2014-11-23 Thread Lukasz Marek
On 24.11.2014 00:52, Michael Niedermayer wrote: i think calling decode_end() is better than duplicating what it does if it works I have no opinion about that, but changed. I had to move decode_end above. I could add prototype but from these 2 I prefer move it as it is not long. Perfectly de

Re: [FFmpeg-devel] [PATCH 3/3] lavc/libxvid: workaround for bug in libxvidcore

2014-11-23 Thread Lukasz Marek
On 24.11.2014 01:17, Lukasz Marek wrote: libxvidcore calculate number of threads basing on video height. If height is small enough it allocates 0 bytes long memory and writes to it. Setting thread_count to 0 uses 1 thread and skips bugged code. Signed-off-by: Lukasz Marek --- libavcodec/libxv

[FFmpeg-devel] [PATCH 3/3] lavc/libxvid: workaround for bug in libxvidcore

2014-11-23 Thread Lukasz Marek
libxvidcore calculate number of threads basing on video height. If height is small enough it allocates 0 bytes long memory and writes to it. Setting thread_count to 0 uses 1 thread and skips bugged code. Signed-off-by: Lukasz Marek --- libavcodec/libxvid.c | 11 +++ 1 file changed, 11 in

[FFmpeg-devel] [PATCH 2/3] lavc/libxvid: return meaningful error codes

2014-11-23 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- libavcodec/libxvid.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c index 020af32..70d52b9 100644 --- a/libavcodec/libxvid.c +++ b/libavcodec/libxvid.c @@ -488,6 +488,7 @@ static av_cold int xvid_encode_init(AVCo

[FFmpeg-devel] [PATCH 1/3] lavc/libxvid: fix mem leak in case of init failure

2014-11-23 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- libavcodec/libxvid.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c index aee9dac..020af32 100644 --- a/libavcodec/libxvid.c +++ b/libavcodec/libxvid.c @@ -359,7 +359,7 @@ static void xvid

Re: [FFmpeg-devel] [PATCH] lavc/huffyuvdec: fix mem leak in case of init failure

2014-11-23 Thread Michael Niedermayer
On Sun, Nov 23, 2014 at 10:09:38PM +0100, Lukasz Marek wrote: > On 23.11.2014 11:42, Michael Niedermayer wrote: > >On Sun, Nov 23, 2014 at 12:58:30AM +0100, Lukasz Marek wrote: > >>Signed-off-by: Lukasz Marek > >>--- > >> libavcodec/huffyuvdec.c | 24 > >> 1 file changed,

Re: [FFmpeg-devel] [PATCH] lavc/smvjpegdec: fix mem leak in case of init failure

2014-11-23 Thread Michael Niedermayer
On Sun, Nov 23, 2014 at 10:10:10PM +0100, Lukasz Marek wrote: > On 23.11.2014 17:25, Michael Niedermayer wrote: > >On Sat, Nov 22, 2014 at 11:26:04PM +0100, Lukasz Marek wrote: > >>Signed-off-by: Lukasz Marek > >>--- > >> libavcodec/smvjpegdec.c | 9 - > >> 1 file changed, 8 insertions(+)

Re: [FFmpeg-devel] [PATCH] Fix undefined reference to xcb_shape_rectangles in xcbgrab.c

2014-11-23 Thread Michael Niedermayer
Hi On Sun, Nov 23, 2014 at 02:48:54PM -0600, Boris Reisig wrote: > It seems when using the latest ffmpeg from master git, there's an > incompatible change in the last few weeks that prevents libxcb-shape > from being detected properly in ffmpeg so it wouldn't compile > properly. I have written a

[FFmpeg-devel] [PATCH] v210enc: Directly encode YUV422P to v210. About 6 times faster than existing (broken) swscale based path

2014-11-23 Thread Kieran Kunhya
--- libavcodec/v210enc.c | 151 +++--- libavcodec/v210enc.h | 4 +- libavcodec/x86/v210enc.asm| 104 - libavcodec/x86/v210enc_init.c | 13 +++- libavutil/x86/x86util.asm | 5 ++ 5 files changed, 218 inse

Re: [FFmpeg-devel] [libav-devel] [PATCH] v210enc: Add x86 SIMD

2014-11-23 Thread Kieran Kunhya
> You may be able to use mova below as well, but I don't know if AVFrame->data > and AVPacket->data > are aligned here. > It's probably worth a try. Won't work because 12 bytes at a time are processed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.o

[FFmpeg-devel] [PATCH] ffmpeg: fix accurate seeking with -copyts

2014-11-23 Thread Rodger Combs
--- ffmpeg.h| 1 + ffmpeg_filter.c | 22 -- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/ffmpeg.h b/ffmpeg.h index 1ace8be..8107fe7 100644 --- a/ffmpeg.h +++ b/ffmpeg.h @@ -483,6 +483,7 @@ extern int do_deinterlace; extern int do_hex_dump; extern i

Re: [FFmpeg-devel] [PATCH] lavu/opt: add const to av_opt_copy arg

2014-11-23 Thread Lukasz Marek
On 23.11.2014 02:29, Michael Niedermayer wrote: On Sun, Nov 23, 2014 at 01:01:19AM +0100, Lukasz Marek wrote: On 23.11.2014 00:58, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- libavutil/opt.c | 2 +- libavutil/opt.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --gi

Re: [FFmpeg-devel] [PATCH] lavc/smvjpegdec: fix mem leak in case of init failure

2014-11-23 Thread Lukasz Marek
On 23.11.2014 17:25, Michael Niedermayer wrote: On Sat, Nov 22, 2014 at 11:26:04PM +0100, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- libavcodec/smvjpegdec.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavcodec/smvjpegdec.c b/libavcodec/smvjpegdec.c

Re: [FFmpeg-devel] [PATCH] lavc/huffyuvdec: fix mem leak in case of init failure

2014-11-23 Thread Lukasz Marek
On 23.11.2014 11:42, Michael Niedermayer wrote: On Sun, Nov 23, 2014 at 12:58:30AM +0100, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- libavcodec/huffyuvdec.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/libavcodec/huffyuvdec.c b/libavc

[FFmpeg-devel] [PATCH] Fix undefined reference to xcb_shape_rectangles in xcbgrab.c

2014-11-23 Thread Boris Reisig
It seems when using the latest ffmpeg from master git, there's an incompatible change in the last few weeks that prevents libxcb-shape from being detected properly in ffmpeg so it wouldn't compile properly. I have written a patch to fix the detection to make ffmpeg compile properly. Example

Re: [FFmpeg-devel] [PATCH] lavc/mss1: fix mem leak in case of init failure

2014-11-23 Thread Lukasz Marek
On 23.11.2014 00:28, Michael Niedermayer wrote: On Sat, Nov 22, 2014 at 10:57:05PM +0100, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- libavcodec/mss1.c | 2 ++ 1 file changed, 2 insertions(+) LGTM pushed ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] libavcodec/rv30: fix mem leak in case of init failure

2014-11-23 Thread Lukasz Marek
On 23.11.2014 00:52, Michael Niedermayer wrote: On Sat, Nov 22, 2014 at 11:12:53PM +0100, Lukasz Marek wrote: Also replaced return -1 with return AVERROR(EINVAL) Signed-off-by: Lukasz Marek --- libavcodec/rv30.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) LGTM pushed

Re: [FFmpeg-devel] Modified force_key_frames option to accept frame numbers

2014-11-23 Thread Michael Niedermayer
On Sat, Nov 22, 2014 at 08:46:09PM +, Sylvester Zaluga wrote: > I am sorry for the spam, but as I have not published any changes to ffmpeg > before, I thought I should double-check. > > Nicolas, you replied earlier that you would not oppose the feature described > below. Does that mean I can

Re: [FFmpeg-devel] [PATCH] flacenc: calculate lower sum levels in-place.

2014-11-23 Thread Michael Niedermayer
On Sat, Nov 22, 2014 at 08:07:47PM +0100, Reimar Döffinger wrote: > Should improve cache usage and reduces stack usage. > Also reduces number of copies in case many levels > have the same number of bits. > --- > libavcodec/flacenc.c | 34 +++--- > 1 file changed, 19 ins

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: fix timestamp conversion

2014-11-23 Thread Nicolas George
Le nonidi 29 brumaire, an CCXXIII, Stefano Sabatini a écrit : > I agree. At the moment nor the code nor the documentation mentions > this. Ideally the library should complain in case different settings > are detected. The documentation says: "All files must have the same streams (same codecs, same

Re: [FFmpeg-devel] Modified force_key_frames option to accept frame numbers

2014-11-23 Thread Nicolas George
Sorry for the late answer, busy weeks. Le sextidi 26 brumaire, an CCXXIII, Sylvester Zaluga a écrit : > You are right, this should probably work, although, in use cases like mine > (when the key frames have to be inserted at exact indexes, not times, in > multiple videos), > I still find it more

Re: [FFmpeg-devel] [PATCH] lavc/smvjpegdec: fix mem leak in case of init failure

2014-11-23 Thread Michael Niedermayer
On Sat, Nov 22, 2014 at 11:26:04PM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > libavcodec/smvjpegdec.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/smvjpegdec.c b/libavcodec/smvjpegdec.c > index 69327cd..261a441 100644 > --- a/l

Re: [FFmpeg-devel] [PATCH] lavf/apngdec: print currently unsupported in-stream tags in a more readable form

2014-11-23 Thread James Almer
On 23/11/14 10:22 AM, Benoit Fouet wrote: > Hi, > > On November 22, 2014 5:45:17 PM GMT+01:00, James Almer > wrote: >> Also use length and not stream position >> >> Signed-off-by: James Almer >> --- >> libavformat/apngdec.c | 7 ++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> dif

Re: [FFmpeg-devel] Dshow Crossbar support

2014-11-23 Thread Zach Swena
Do we know how much it would cost to get this done? A capture card like the ESCAP.TV ones are pretty cheap so getting a device to test isn't hard or expensive. As I understand it basically any capture device with multiple analog inputs uses this feature. Zach On Nov 22, 2014 11:15 AM, "Roger Pac

Re: [FFmpeg-devel] [PATCH] lavfi: add tdiff filter

2014-11-23 Thread Clément Bœsch
On Sun, Nov 23, 2014 at 02:50:51PM +0100, Stefano Sabatini wrote: > On date Sunday 2014-11-23 02:01:16 +0100, Clément Bœsch encoded: > > On Sat, Nov 22, 2014 at 11:44:29PM +0100, Stefano Sabatini wrote: > > > TODO: bump minor > > > --- > > > Changelog| 1 + > > > doc/filters.texi

Re: [FFmpeg-devel] [PATCH] lavfi: add tdiff filter

2014-11-23 Thread Stefano Sabatini
On date Sunday 2014-11-23 02:01:16 +0100, Clément Bœsch encoded: > On Sat, Nov 22, 2014 at 11:44:29PM +0100, Stefano Sabatini wrote: > > TODO: bump minor > > --- > > Changelog| 1 + > > doc/filters.texi | 4 ++ > > libavfilter/Makefile | 1 + > > libavfilter/allfi

Re: [FFmpeg-devel] [PATCH] lavf/apngdec: print currently unsupported in-stream tags in a more readable form

2014-11-23 Thread Benoit Fouet
Hi, On November 22, 2014 5:45:17 PM GMT+01:00, James Almer wrote: >Also use length and not stream position > >Signed-off-by: James Almer >--- > libavformat/apngdec.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/libavformat/apngdec.c b/libavformat/apngdec.c >index

Re: [FFmpeg-devel] [PATCH] xface: Fix encoder crashes due to too small on-stack array.

2014-11-23 Thread Michael Niedermayer
On Sun, Nov 23, 2014 at 12:01:57PM +0100, Stefano Sabatini wrote: > On date Sunday 2014-11-23 06:53:04 +0100, Reimar Döffinger encoded: > > On Sat, Nov 22, 2014 at 11:14:45PM +0100, Reimar Döffinger wrote: > > > Also add a FATE test. > > > > > > Signed-off-by: Reimar Döffinger > > > --- > > > li

Re: [FFmpeg-devel] [PATCH 01/10] avfilter/signalstats: fix different buffers for out frame if burn is enabled

2014-11-23 Thread Michael Niedermayer
On Sun, Nov 23, 2014 at 12:38:57AM +0100, Clément Bœsch wrote: > This was the original intend. > --- > libavfilter/vf_signalstats.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay di

Re: [FFmpeg-devel] [PATCH] xface: Fix encoder crashes due to too small on-stack array.

2014-11-23 Thread Stefano Sabatini
On date Sunday 2014-11-23 06:53:04 +0100, Reimar Döffinger encoded: > On Sat, Nov 22, 2014 at 11:14:45PM +0100, Reimar Döffinger wrote: > > Also add a FATE test. > > > > Signed-off-by: Reimar Döffinger > > --- > > libavcodec/xface.h | 9 + > > libavcodec/xfaceenc.c |

Re: [FFmpeg-devel] [PATCH] lavu/opt: add const to av_opt_copy arg

2014-11-23 Thread Michael Niedermayer
On Sun, Nov 23, 2014 at 12:58:52AM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > libavutil/opt.c | 2 +- > libavutil/opt.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I hav

Re: [FFmpeg-devel] [PATCH] lavc/huffyuvdec: fix mem leak in case of init failure

2014-11-23 Thread Michael Niedermayer
On Sun, Nov 23, 2014 at 12:58:30AM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > libavcodec/huffyuvdec.c | 24 > 1 file changed, 16 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/huffyuvdec.c b/libavcodec/huffyuvdec.c > index 3b2b0f7..553532