Re: [FFmpeg-devel] [PATCH] matroskadec: execute seekheads recursively

2014-10-16 Thread Rodger Combs
> On Oct 17, 2014, at 01:52, Rodger Combs wrote: > > >> On Oct 17, 2014, at 01:16, Rodger Combs > > wrote: >> >> This fixes https://trac.ffmpeg.org/ticket/3934 >> , but I'm not sure if there was a good >> reason for this to

Re: [FFmpeg-devel] [PATCH] matroskadec: execute seekheads recursively

2014-10-16 Thread Rodger Combs
> On Oct 17, 2014, at 01:16, Rodger Combs wrote: > > This fixes https://trac.ffmpeg.org/ticket/3934 > , but I'm not sure if there was a good > reason for this to be here to begin with. Perhaps a protection against > infinite recursion (though I believe EBM

[FFmpeg-devel] [PATCH] matroskadec: execute seekheads recursively

2014-10-16 Thread Rodger Combs
This fixes https://trac.ffmpeg.org/ticket/3934 , but I'm not sure if there was a good reason for this to be here to begin with. Perhaps a protection against infinite recursion (though I believe EBML_MAX_DEPTH serves that purpose to some degree)? _

Re: [FFmpeg-devel] [PATCH] doc/filters.texi: fix several typos in the vidstab* sections

2014-10-16 Thread Michael Niedermayer
On Wed, Oct 15, 2014 at 04:02:03PM +0200, Moritz Barsnick wrote: > Hi, > > there are two minor typos and a stray bracket in the vidstab* sections > of the filters documentation. Patch is attached. > > I also took the liberty to add references to the other filter (unsharp) > which is mentioned, an

Re: [FFmpeg-devel] Patch for Cast128 algorithm implementation

2014-10-16 Thread Michael Niedermayer
On Thu, Oct 16, 2014 at 11:09:27PM +0530, supraja reddy wrote: > Updated the patch . > Please let me know if there are any other changes needed . > > Thanks , > > Supraja > > On Thu, Oct 16, 2014 at 1:37 PM, Giorgio Vazzana wrote: > > > Hi, > > > > 2014-10-16 5:32 GMT+02:00 Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] x86/vf_noise: move asm code to a separate file

2014-10-16 Thread James Almer
On 17/10/14 12:09 AM, Michael Niedermayer wrote: > On Thu, Oct 16, 2014 at 10:33:58PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavfilter/vf_noise.c | 164 >> +++-- >> libavfilter/vf_noise.h | 64 ++ >> li

Re: [FFmpeg-devel] [PATCH] x86/vf_noise: move asm code to a separate file

2014-10-16 Thread Michael Niedermayer
On Thu, Oct 16, 2014 at 10:33:58PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/vf_noise.c | 164 > +++-- > libavfilter/vf_noise.h | 64 ++ > libavfilter/x86/Makefile | 1 + > libavfilter/x86/vf_no

Re: [FFmpeg-devel] [PATCH] libutvideo: remove libutvideo wrapper

2014-10-16 Thread Michael Niedermayer
On Thu, Oct 16, 2014 at 04:29:13PM -0800, Lou Logan wrote: > Native decoder and encoder exists. > > Signed-off-by: Lou Logan > --- > I don't know if libutvideo has any advantages over native; maybe Derek > can elaborate (and answer other questions). > > Native seemed faster for decoding and enco

[FFmpeg-devel] [PATCH] x86/vf_noise: move asm code to a separate file

2014-10-16 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vf_noise.c | 164 +++-- libavfilter/vf_noise.h | 64 ++ libavfilter/x86/Makefile | 1 + libavfilter/x86/vf_noise.c | 144 +++ 4 files changed, 218 in

[FFmpeg-devel] [PATCH] libutvideo: remove libutvideo wrapper

2014-10-16 Thread Lou Logan
Native decoder and encoder exists. Signed-off-by: Lou Logan --- I don't know if libutvideo has any advantages over native; maybe Derek can elaborate (and answer other questions). Native seemed faster for decoding and encoding in my lazy, quick tests. Mostly a boredom patch/RFC... Todo: = *

Re: [FFmpeg-devel] [PATCH] avformat/id3v2: support buggy id3v2.3 tag length in id3v2.4

2014-10-16 Thread Michael Niedermayer
On Thu, Oct 16, 2014 at 06:06:39PM +0200, Benoit Fouet wrote: > Hi, > > On 16 October 2014 17:10:38 CEST, Michael Niedermayer > wrote: > >On Thu, Oct 16, 2014 at 11:44:47AM +0200, Benoit Fouet wrote: > >> Some encoders do not use syncsafe sizes in v2.4 id3 tags. Check the > >next > >> tag to try

Re: [FFmpeg-devel] [PATCH]Don't claim 16bit support for the noise filter

2014-10-16 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > > Attached patch removes the 16bit support, fixes > > ticket #4017, ticket #4029 for 16bit support > > already exists. > > fixed differently Thank you! Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffm

Re: [FFmpeg-devel] [PATCHv2] ffplay: update documentation

2014-10-16 Thread Lou Logan
On Wed, 15 Oct 2014 23:46:21 +0200, Marton Balint wrote: > Thank you for all your feedback, apparently there was some confusion because I > have used "set" both as a synonym to "enabled" and as an imperative. I have > changed all occurences of it to "enabled" or "use", so hopefully it will be > mo

Re: [FFmpeg-devel] [PATCH] doc/encoders: add basic libx265 documentation

2014-10-16 Thread Lou Logan
On Tue, 14 Oct 2014 04:41:44 +0200, Michael Niedermayer wrote: > On Thu, Oct 02, 2014 at 03:19:21PM -0800, Lou Logan wrote: > > Fixes ticket #3944. > > > > Signed-off-by: Lou Logan > > --- > > doc/encoders.texi | 28 > > 1 file changed, 28 insertions(+) > > LGTM P

Re: [FFmpeg-devel] [PATCH] doc/filters: update link to OpenCV docs

2014-10-16 Thread Lou Logan
On Tue, 14 Oct 2014 04:40:08 +0200, Michael Niedermayer wrote: > On Mon, Oct 13, 2014 at 04:42:05PM -0800, Lou Logan wrote: > > Signed-off-by: Lou Logan > > --- > > doc/filters.texi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/doc/filters.texi b/doc/filters.tex

Re: [FFmpeg-devel] Patch for Cast128 algorithm implementation

2014-10-16 Thread supraja reddy
Updated the patch . Please let me know if there are any other changes needed . Thanks , Supraja On Thu, Oct 16, 2014 at 1:37 PM, Giorgio Vazzana wrote: > Hi, > > 2014-10-16 5:32 GMT+02:00 Michael Niedermayer : > > On Thu, Oct 16, 2014 at 03:25:42AM +0530, supraja reddy wrote: > >> Extremely so

Re: [FFmpeg-devel] [PATCH] avformat/id3v2: support buggy id3v2.3 tag length in id3v2.4

2014-10-16 Thread Benoit Fouet
Hi, On 16 October 2014 17:10:38 CEST, Michael Niedermayer wrote: >On Thu, Oct 16, 2014 at 11:44:47AM +0200, Benoit Fouet wrote: >> Some encoders do not use syncsafe sizes in v2.4 id3 tags. Check the >next >> tag to try to choose between the two. >> >> Fixes ticket #4003 >> --- >> libavformat/id

Re: [FFmpeg-devel] [PATCH] avformat/id3v2: support buggy id3v2.3 tag length in id3v2.4

2014-10-16 Thread Michael Niedermayer
On Thu, Oct 16, 2014 at 11:44:47AM +0200, Benoit Fouet wrote: > Some encoders do not use syncsafe sizes in v2.4 id3 tags. Check the next > tag to try to choose between the two. > > Fixes ticket #4003 > --- > libavformat/id3v2.c | 42 +- > 1 file changed, 41

Re: [FFmpeg-devel] [PATCH] avformat/id3v2: silence a warning when CONFIG_ZLIB is unset.

2014-10-16 Thread Michael Niedermayer
On Thu, Oct 16, 2014 at 11:44:46AM +0200, Benoit Fouet wrote: > dlen is only read when CONFIG_ZLIB is set, so mark it as possibly > unused. > --- > libavformat/id3v2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730B

Re: [FFmpeg-devel] [PATCH]Don't claim 16bit support for the noise filter

2014-10-16 Thread Michael Niedermayer
On Thu, Oct 16, 2014 at 11:57:08AM +0200, Carl Eugen Hoyos wrote: > Hi! > > The noise filter claims to support 16bit formats but the output looks broken: > $ ffmpeg -f lavfi -i testsrc=s=3840x2160 -vf > format=yuv444p16le,noise=c0s=10:allf=t -vcodec mpeg4 -qscale 2 -t 1 out.mov > > Attached patc

Re: [FFmpeg-devel] [PATCH] mpegts: add the judgement if a new program is ctreated successfully

2014-10-16 Thread Reynaldo H. Verdejo Pinochet
Hello Di Wu On 10/15/2014 05:24 AM, di1028...@samsung.com wrote: From: Di Wu Add the judement after create a new program to avoid segment fault. [..] Thanks for your patch. Can you spell check your commit summary though?, you have at least two typos there. Thanks, -- Reynaldo H. Verdejo Pi

Re: [FFmpeg-devel] [PATCH]Fix initialiser in dct-test.c

2014-10-16 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > > Attached patch fixes a (fate) compilation warning on > > unusual platforms, I did not really check if the > > warning is correct though. > LGTM Patch applied. Thank you, Carl Eugen ___ ffmpeg-devel mailing l

[FFmpeg-devel] [PATCH]Don't claim 16bit support for the noise filter

2014-10-16 Thread Carl Eugen Hoyos
Hi! The noise filter claims to support 16bit formats but the output looks broken: $ ffmpeg -f lavfi -i testsrc=s=3840x2160 -vf format=yuv444p16le,noise=c0s=10:allf=t -vcodec mpeg4 -qscale 2 -t 1 out.mov Attached patch removes the 16bit support, fixes ticket #4017, ticket #4029 for 16bit support

[FFmpeg-devel] [PATCH] avformat/id3v2: support buggy id3v2.3 tag length in id3v2.4

2014-10-16 Thread Benoit Fouet
Some encoders do not use syncsafe sizes in v2.4 id3 tags. Check the next tag to try to choose between the two. Fixes ticket #4003 --- libavformat/id3v2.c | 42 +- 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/libavformat/id3v2.c b/libavforma

[FFmpeg-devel] [PATCH] avformat/id3v2: silence a warning when CONFIG_ZLIB is unset.

2014-10-16 Thread Benoit Fouet
dlen is only read when CONFIG_ZLIB is set, so mark it as possibly unused. --- libavformat/id3v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c index a1d0ebe..3e1eca2 100644 --- a/libavformat/id3v2.c +++ b/libavformat/id3v2.c @@ -743,

Re: [FFmpeg-devel] [PATCH] Added STL demuxer and decoder

2014-10-16 Thread Clément Bœsch
On Thu, Oct 16, 2014 at 02:26:30AM +0530, Eejya Singh wrote: > From: Eejya > > --- > Changelog| 1 + > doc/general.texi | 1 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h | 1 + > libavcodec/codec_desc.c | 7

Re: [FFmpeg-devel] Patch for Cast128 algorithm implementation

2014-10-16 Thread Giorgio Vazzana
Hi, 2014-10-16 5:32 GMT+02:00 Michael Niedermayer : > On Thu, Oct 16, 2014 at 03:25:42AM +0530, supraja reddy wrote: >> Extremely sorry for resending the patch . There was a trailing whitespace >> which I hadn't corrected . >> All the changes are done . >> Please let me if any changes needed furth