Re: [FFmpeg-devel] in preparation of changing the internal form of decoded text subtitles

2014-09-20 Thread wm4
On Sat, 20 Sep 2014 22:27:40 +0200 Clément Bœsch wrote: > Just a patchset to ease the transition to a sane internal form for the decoded > text subtitles. > > [PATCH 01/17] avcodec/jacosubdec: add some memory checks > [PATCH 02/17] avcodec/microdvddec: add some memory checks > [PATCH 03/17] avco

Re: [FFmpeg-devel] [PATCH 13/17] avformat/assdec: make sure "Comments:" events end up in the header

2014-09-20 Thread wm4
On Sat, 20 Sep 2014 22:27:53 +0200 Clément Bœsch wrote: > --- > libavformat/assdec.c | 26 -- > 1 file changed, 8 insertions(+), 18 deletions(-) > > diff --git a/libavformat/assdec.c b/libavformat/assdec.c > index 5480171..2187c7d 100644 > --- a/libavformat/assdec.c > ++

Re: [FFmpeg-devel] [PATCH 12/17] avformat/assdec: output ASS packets

2014-09-20 Thread wm4
On Sat, 20 Sep 2014 22:27:52 +0200 Clément Bœsch wrote: > After this the order from the original file is stored through readorder > when doing ffmpeg -i input.ass -c copy output.mkv. > > And now that the ASS muxer honors the ReadOrder, extracting the ass back > (without transcoding) restores the

Re: [FFmpeg-devel] [PATCH 11/17] avformat/assenc: mux all extradata at once

2014-09-20 Thread wm4
On Sat, 20 Sep 2014 22:27:51 +0200 Clément Bœsch wrote: > Before this commit, the code was muxing up to the 2nd line after > "[Events]" (assuming it to be the "Format:" line). The remaining are > generally "Comment:" directives which can stay in that place. mkvextract > behaves that way so it see

Re: [FFmpeg-devel] [PATCH] avformat/assenc: mux all extradata at once

2014-09-20 Thread wm4
On Sat, 20 Sep 2014 18:40:57 +0200 Clément Bœsch wrote: > Before this commit, the code was muxing up to the 2nd line after > "[Event]" (assuming it to be the "Format:" line). The remaining are > generally "Comment:" directives which can stay in that place. mkvextract > behaves that way so it seem

Re: [FFmpeg-devel] [PATCH 0/2] Support for TrueHD streams with an Atmos substream

2014-09-20 Thread James Almer
On 20/09/14 10:59 PM, Michael Niedermayer wrote: > On Sun, Sep 21, 2014 at 02:29:26AM +0200, Hendrik Leppkes wrote: >> >> Hey, >> >> this patchset adds support for playing TrueHD streams on new Blu-ray discs >> which carry an additional Atmos substream inside the TrueHD stream. >> >> The Atmos stre

Re: [FFmpeg-devel] [PATCH 0/2] Support for TrueHD streams with an Atmos substream

2014-09-20 Thread Michael Niedermayer
On Sun, Sep 21, 2014 at 02:29:26AM +0200, Hendrik Leppkes wrote: > > Hey, > > this patchset adds support for playing TrueHD streams on new Blu-ray discs > which carry an additional Atmos substream inside the TrueHD stream. > > The Atmos stream is simply discarded right now, since we don't have a

[FFmpeg-devel] [PATCH 1/2] mlpdec: support major sync headers with optional extension blocks

2014-09-20 Thread Hendrik Leppkes
--- libavcodec/mlp_parser.c | 29 - libavcodec/mlp_parser.h | 1 + libavcodec/mlpdec.c | 7 ++- 3 files changed, 31 insertions(+), 6 deletions(-) diff --git a/libavcodec/mlp_parser.c b/libavcodec/mlp_parser.c index 4bb82ee..deaa844 100644 --- a/libavcodec/mlp

[FFmpeg-devel] [PATCH 2/2] mlpdec: support TrueHD streams with an Atmos substream

2014-09-20 Thread Hendrik Leppkes
The fourth substream is being discarded, since its not raw audio data, but an encoded Atmos stream which needs a specialized decoder. --- libavcodec/mlp.h| 2 +- libavcodec/mlpdec.c | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/mlp.h b/libavcodec/mlp.h ind

[FFmpeg-devel] [PATCH 0/2] Support for TrueHD streams with an Atmos substream

2014-09-20 Thread Hendrik Leppkes
Hey, this patchset adds support for playing TrueHD streams on new Blu-ray discs which carry an additional Atmos substream inside the TrueHD stream. The Atmos stream is simply discarded right now, since we don't have any way to decode or expose it, but it might be feasible to shove it into side d

[FFmpeg-devel] [PATCH 17/17] avformat/assenc: return correct error code

2014-09-20 Thread Clément Bœsch
--- libavformat/assenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/assenc.c b/libavformat/assenc.c index 5779e92..8593b6c 100644 --- a/libavformat/assenc.c +++ b/libavformat/assenc.c @@ -45,7 +45,7 @@ static int write_header(AVFormatContext *s) if (s->nb_

[FFmpeg-devel] [PATCH 16/17] avformat/assenc: mux an event header if none are found in extradata

2014-09-20 Thread Clément Bœsch
--- libavformat/assenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/assenc.c b/libavformat/assenc.c index 236d021..5779e92 100644 --- a/libavformat/assenc.c +++ b/libavformat/assenc.c @@ -54,6 +54,8 @@ static int write_header(AVFormatContext *s) if (avctx->extradata

[FFmpeg-devel] [PATCH 15/17] avformat/assdec: add myself to Copyright

2014-09-20 Thread Clément Bœsch
--- libavformat/assdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/assdec.c b/libavformat/assdec.c index d33830e..41d1dac 100644 --- a/libavformat/assdec.c +++ b/libavformat/assdec.c @@ -1,6 +1,7 @@ /* * SSA/ASS demuxer * Copyright (c) 2008 Michael Niedermayer + * Copyri

[FFmpeg-devel] [PATCH 14/17] avformat/assdec: reindent after previous commit

2014-09-20 Thread Clément Bœsch
--- libavformat/assdec.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/libavformat/assdec.c b/libavformat/assdec.c index 2187c7d..d33830e 100644 --- a/libavformat/assdec.c +++ b/libavformat/assdec.c @@ -120,28 +120,27 @@ static int ass_read_h

[FFmpeg-devel] [PATCH 13/17] avformat/assdec: make sure "Comments:" events end up in the header

2014-09-20 Thread Clément Bœsch
--- libavformat/assdec.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/libavformat/assdec.c b/libavformat/assdec.c index 5480171..2187c7d 100644 --- a/libavformat/assdec.c +++ b/libavformat/assdec.c @@ -104,7 +104,7 @@ static int ass_read_header(AV

[FFmpeg-devel] [PATCH 12/17] avformat/assdec: output ASS packets

2014-09-20 Thread Clément Bœsch
After this the order from the original file is stored through readorder when doing ffmpeg -i input.ass -c copy output.mkv. And now that the ASS muxer honors the ReadOrder, extracting the ass back (without transcoding) restores the original order. --- libavformat/assdec.c | 31 +++

[FFmpeg-devel] [PATCH 11/17] avformat/assenc: mux all extradata at once

2014-09-20 Thread Clément Bœsch
Before this commit, the code was muxing up to the 2nd line after "[Events]" (assuming it to be the "Format:" line). The remaining are generally "Comment:" directives which can stay in that place. mkvextract behaves that way so it seems there is no reason for that extra complexity. --- libavformat/

[FFmpeg-devel] [PATCH 09/17] avcodec/textdec: add some memory checks

2014-09-20 Thread Clément Bœsch
--- libavcodec/textdec.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavcodec/textdec.c b/libavcodec/textdec.c index d904023..0cd1735 100644 --- a/libavcodec/textdec.c +++ b/libavcodec/textdec.c @@ -44,6 +44,7 @@ static const AVOption options[] = { static

[FFmpeg-devel] [PATCH 10/17] avcodec/webvttdec: add some memory checks

2014-09-20 Thread Clément Bœsch
--- libavcodec/webvttdec.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavcodec/webvttdec.c b/libavcodec/webvttdec.c index 6b86bed..411abf0 100644 --- a/libavcodec/webvttdec.c +++ b/libavcodec/webvttdec.c @@ -74,6 +74,7 @@ static int webvtt_event_to_ass(AVBPrin

[FFmpeg-devel] [PATCH 08/17] avcodec/subviewerdec: add some memory checks

2014-09-20 Thread Clément Bœsch
--- libavcodec/subviewerdec.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/libavcodec/subviewerdec.c b/libavcodec/subviewerdec.c index 63be418..470cd7b 100644 --- a/libavcodec/subviewerdec.c +++ b/libavcodec/subviewerdec.c @@ -51,6 +51,7 @@ static int subviewe

[FFmpeg-devel] [PATCH 06/17] avcodec/realtextdec: add some memory checks

2014-09-20 Thread Clément Bœsch
--- libavcodec/realtextdec.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/libavcodec/realtextdec.c b/libavcodec/realtextdec.c index 4578897..603c3c9 100644 --- a/libavcodec/realtextdec.c +++ b/libavcodec/realtextdec.c @@ -59,6 +59,7 @@ static int rt_event_to_a

[FFmpeg-devel] [PATCH 07/17] avcodec/srtdec: add some memory checks

2014-09-20 Thread Clément Bœsch
--- libavcodec/srtdec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/srtdec.c b/libavcodec/srtdec.c index b16645a..794a25a 100644 --- a/libavcodec/srtdec.c +++ b/libavcodec/srtdec.c @@ -223,7 +223,7 @@ static int srt_decode_frame(AVCodecContext *avctx,

[FFmpeg-devel] [PATCH 05/17] avcodec/samidec: add some memory checks

2014-09-20 Thread Clément Bœsch
--- libavcodec/samidec.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/samidec.c b/libavcodec/samidec.c index 39ac608..ce05cf6 100644 --- a/libavcodec/samidec.c +++ b/libavcodec/samidec.c @@ -114,6 +114,7 @@ end: static int sami_decode_frame(AVCodecContext

[FFmpeg-devel] [PATCH 04/17] avcodec/mpl2dec: add some memory checks

2014-09-20 Thread Clément Bœsch
--- libavcodec/mpl2dec.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpl2dec.c b/libavcodec/mpl2dec.c index a777c7c..ecf4d81 100644 --- a/libavcodec/mpl2dec.c +++ b/libavcodec/mpl2dec.c @@ -66,6 +66,7 @@ static int mpl2_event_to_ass(AVBPrint *buf,

[FFmpeg-devel] [PATCH 03/17] avcodec/movtextdec: add some memory checks

2014-09-20 Thread Clément Bœsch
--- libavcodec/movtextdec.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index 05ff53a..deb7553 100644 --- a/libavcodec/movtextdec.c +++ b/libavcodec/movtextdec.c @@ -60,7 +60,7 @@ static int mov_text_decode_fram

[FFmpeg-devel] [PATCH 02/17] avcodec/microdvddec: add some memory checks

2014-09-20 Thread Clément Bœsch
--- libavcodec/microdvddec.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/libavcodec/microdvddec.c b/libavcodec/microdvddec.c index 7df3e48..9db44e0 100644 --- a/libavcodec/microdvddec.c +++ b/libavcodec/microdvddec.c @@ -261,7 +261,6 @@ static int microd

[FFmpeg-devel] in preparation of changing the internal form of decoded text subtitles

2014-09-20 Thread Clément Bœsch
Just a patchset to ease the transition to a sane internal form for the decoded text subtitles. [PATCH 01/17] avcodec/jacosubdec: add some memory checks [PATCH 02/17] avcodec/microdvddec: add some memory checks [PATCH 03/17] avcodec/movtextdec: add some memory checks [PATCH 04/17] avcodec/mpl2dec:

[FFmpeg-devel] [PATCH 01/17] avcodec/jacosubdec: add some memory checks

2014-09-20 Thread Clément Bœsch
--- libavcodec/jacosubdec.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libavcodec/jacosubdec.c b/libavcodec/jacosubdec.c index b64fac8..ef847e2 100644 --- a/libavcodec/jacosubdec.c +++ b/libavcodec/jacosubdec.c @@ -168,6 +168,7 @@ static void jacosub_to_ass(AV

Re: [FFmpeg-devel] [PATCH v2 1/1] configure: Refactor setting of feature test macro _XOPEN_SOURCE

2014-09-20 Thread Jörg Krause
On 09/18/2014 07:10 PM, Reimar Döffinger wrote: On 18.09.2014, at 17:26, Michael Niedermayer wrote: On Thu, Sep 18, 2014 at 04:22:27PM +0200, Jörg Krause wrote: glibc, uclibc, and musl uses feature test macros to expose definitions conforming to the standards ISO C, POSIX and extensions. Acco

Re: [FFmpeg-devel] [PATCH v2 1/1] configure: Refactor setting of feature test macro _XOPEN_SOURCE

2014-09-20 Thread Jörg Krause
On 09/19/2014 01:05 PM, Hendrik Leppkes wrote: On Thu, Sep 18, 2014 at 8:24 PM, Jörg Krause wrote: On 09/18/2014 07:10 PM, Reimar Döffinger wrote: On 18.09.2014, at 17:26, Michael Niedermayer wrote: On Thu, Sep 18, 2014 at 04:22:27PM +0200, Jörg Krause wrote: glibc, uclibc, and musl us

Re: [FFmpeg-devel] [PATCH 2/2] alacenc: remove unneeded masking

2014-09-20 Thread Michael Niedermayer
On Sat, Sep 20, 2014 at 08:25:15PM +0200, Christophe Gisquet wrote: > 2014-09-20 20:23 GMT+02:00 Christophe Gisquet : > > The extra bits have already properly masked, so this was not doing anything. > > have already *been* masked. If the patch is ok, please amend locally. amended applied thanks

Re: [FFmpeg-devel] [PATCH 1/2] alacenc: fix incorrect buffer use

2014-09-20 Thread Michael Niedermayer
On Sat, Sep 20, 2014 at 06:23:08PM +, Christophe Gisquet wrote: > The issue lies in actually dead code ("for now it's not used"). > --- > libavcodec/alacenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BAD

Re: [FFmpeg-devel] [PATCH 2/2] alacenc: remove unneeded masking

2014-09-20 Thread Christophe Gisquet
2014-09-20 20:23 GMT+02:00 Christophe Gisquet : > The extra bits have already properly masked, so this was not doing anything. have already *been* masked. If the patch is ok, please amend locally. Best regards, Christophe ___ ffmpeg-devel mailing list f

[FFmpeg-devel] [PATCH 2/2] alacenc: remove unneeded masking

2014-09-20 Thread Christophe Gisquet
The extra bits have already properly masked, so this was not doing anything. --- libavcodec/alacenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/alacenc.c b/libavcodec/alacenc.c index fd5bf66..4e6113b 100644 --- a/libavcodec/alacenc.c +++ b/libavcodec/alacenc.c

[FFmpeg-devel] [PATCH 1/2] alacenc: fix incorrect buffer use

2014-09-20 Thread Christophe Gisquet
The issue lies in actually dead code ("for now it's not used"). --- libavcodec/alacenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/alacenc.c b/libavcodec/alacenc.c index b9ad899..fd5bf66 100644 --- a/libavcodec/alacenc.c +++ b/libavcodec/alacenc.c @@ -444,7 +44

[FFmpeg-devel] [PATCH 0/2] Fix some benign issues with alacenc

2014-09-20 Thread Christophe Gisquet
Justin Ruggles noticed some issues which are fixed in the following patches. Christophe Gisquet (2): alacenc: fix incorrect buffer use alacenc: remove unneeded masking libavcodec/alacenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 1.9.2.msysgit.0 ___

[FFmpeg-devel] [PATCH] Only decode forced subtitles frames.

2014-09-20 Thread Nicholas Robbins
--- libavcodec/dvdsubdec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/dvdsubdec.c b/libavcodec/dvdsubdec.c index 7355c03..de1ecbf 100644 --- a/libavcodec/dvdsubdec.c +++ b/libavcodec/dvdsubdec.c @@ -39,6 +39,7 @@ typedef struct DVDSubContext uint8_t alpha[256]; uint

[FFmpeg-devel] ffplay -fs fix (ticket #3964)

2014-09-20 Thread Jeff Dwork
On MS Windows, 'ffplay.exe -fs' does not start fullscreen. Behavior on linux is correct. On Windows, the initial placement of the SDL screen triggers the SDL_VIDEORESIZE event. This executes the code in the event_loop which calls SDL_SetVideoMode with the SDL_RESIZEABLE bit set. On linux the

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: fix gapless audio support

2014-09-20 Thread Michael Niedermayer
On Sat, Sep 20, 2014 at 01:48:05PM +0200, wm4 wrote: > The code already had skipping of initial padding, but discarding > trailing frame padding was missing. > > This is somewhat questionable, because it will make the decoder discard > any data after the declared file size in the LAME header. But

Re: [FFmpeg-devel] [PATCH] avformat/assenc: mux all extradata at once

2014-09-20 Thread Clément Bœsch
On Sat, Sep 20, 2014 at 06:40:57PM +0200, Clément Bœsch wrote: > Before this commit, the code was muxing up to the 2nd line after > "[Event]" (assuming it to be the "Format:" line). The remaining are EventS* typo fixed locally > generally "Comment:" directives which can stay in that place. mkvext

[FFmpeg-devel] [PATCH] avformat/assenc: mux all extradata at once

2014-09-20 Thread Clément Bœsch
Before this commit, the code was muxing up to the 2nd line after "[Event]" (assuming it to be the "Format:" line). The remaining are generally "Comment:" directives which can stay in that place. mkvextract behaves that way so it seems there is no reason for that extra complexity. --- libavformat/a

[FFmpeg-devel] [PATCH] libavcodec/dvdsubdec: Add option forced_subs_only to only decode forced subtitle frames.

2014-09-20 Thread Nicholas Robbins
Signed-off-by: Nicholas Robbins --- libavcodec/dvdsubdec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/dvdsubdec.c b/libavcodec/dvdsubdec.c index c7973f0..bb28d9e 100644 --- a/libavcodec/dvdsubdec.c +++ b/libavcodec/dvdsubdec.c @@ -39,6 +39,7 @@ typedef struct DVDSubContex

[FFmpeg-devel] [PATCH] avformat/mp3dec: fix gapless audio support

2014-09-20 Thread wm4
The code already had skipping of initial padding, but discarding trailing frame padding was missing. This is somewhat questionable, because it will make the decoder discard any data after the declared file size in the LAME header. But note that skipping full frames at the end of the stream is requ

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: fix gapless audio support

2014-09-20 Thread Michael Niedermayer
On Sat, Sep 20, 2014 at 11:10:19AM +0200, wm4 wrote: > The code already had skipping of initial padding, but discarding > trailing frame padding was missing. > > This is somewhat questionable, because it will make the decoder discard > any data after the declared file size in the LAME header. But

Re: [FFmpeg-devel] [PATCH] avfilter/idet: typo fix: PROGRSSIVE -> PROGRESSIVE

2014-09-20 Thread Michael Niedermayer
On Sat, Sep 20, 2014 at 12:54:54AM -0700, Pascal Massimino wrote: > Hi, > > see $subject > > /skal > vf_idet.c | 16 > vf_idet.h |2 +- > 2 files changed, 9 insertions(+), 9 deletions(-) > 956eb2351319ac437a79656d1666e51a122733c5 > 0001-avfilter-idet-typo-fix-PROGRSSIVE

[FFmpeg-devel] [PATCH] avformat/mp3dec: fix gapless audio support

2014-09-20 Thread wm4
The code already had skipping of initial padding, but discarding trailing frame padding was missing. This is somewhat questionable, because it will make the decoder discard any data after the declared file size in the LAME header. But note that skipping full frames at the end of the stream is requ

[FFmpeg-devel] [PATCH] avfilter/idet: typo fix: PROGRSSIVE -> PROGRESSIVE

2014-09-20 Thread Pascal Massimino
Hi, see $subject /skal 0001-avfilter-idet-typo-fix-PROGRSSIVE-PROGRESSIVE.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel