[FFmpeg-devel] [PATCH] lavc/libwebpenc: use WebPMemoryWriterClear()

2014-08-26 Thread James Almer
WebPMemoryWriterClear() must be used instead of free() when libwebp ABI version is > 0x0202. Signed-off-by: James Almer --- Untested. Latest stable libwebp release (0.4.1) is still 0x0202. libavcodec/libwebpenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/libwebpenc.c b

Re: [FFmpeg-devel] [PATCH] Improved AC3 decoder level support (heavy drc, dialnorm)

2014-08-26 Thread Jean-Francois Thibert
On Tue, Aug 26, 2014 at 7:40 PM, Michael Niedermayer wrote: > do you have a testcase/sample to test this ? > I don't have any specific sample but this can be tested with any broadcast or most disc source using AC3 audio. I just tried with the Broadway-5.1 clip from samples.mplayerhq.hu/A-codecs/AC

[FFmpeg-devel] [PATCH] lavf/mp3enc: don't abort if audio packets can't be buffered

2014-08-26 Thread James Almer
Instead skip the picture streams and flush the queued audio packets. Should address ticket #3851. Signed-off-by: James Almer --- This is more a workaround than a "fix" to the issue, with the intent of not aborting the entire muxing process just because a picture couldn't be written to the id3v2

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: dont warn about d10_channelcount being ignored if its not set

2014-08-26 Thread Michael Niedermayer
On Fri, Aug 22, 2014 at 10:58:41PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/mxfenc.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Breaking D

Re: [FFmpeg-devel] [PATCH] Improved AC3 decoder level support (heavy drc, dialnorm)

2014-08-26 Thread Michael Niedermayer
On Tue, Aug 26, 2014 at 07:16:06PM -0400, Jean-Francois Thibert wrote: > Added support for AC3 heavy dynamic range compression used > to restrict the output range and added a setting to specify > the output target level and use the dialog normalization > field to apply it in the digital domain. do

[FFmpeg-devel] [PATCH] bktr: Fix Fabrice's name

2014-08-26 Thread Timothy Gu
Signed-off-by: Timothy Gu --- libavdevice/bktr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/bktr.c b/libavdevice/bktr.c index d09d452..52d090c 100644 --- a/libavdevice/bktr.c +++ b/libavdevice/bktr.c @@ -3,7 +3,7 @@ * Copyright (c) 2002 Steve O'Hara-Smith

Re: [FFmpeg-devel] [PATCH] Add a license to the LESS file

2014-08-26 Thread Timothy Gu
On Tue, Aug 26, 2014 at 12:38 PM, db0company wrote: > --- > LICENSE.txt | 21 + > src/less/style.less |6 -- > 2 files changed, 25 insertions(+), 2 deletions(-) > create mode 100644 LICENSE.txt > > diff --git a/LICENSE.txt b/LICENSE.txt > new file mode 10064

Re: [FFmpeg-devel] [PATCH] libavdevice/v4l2: fix of crash caused by assert

2014-08-26 Thread Michael Niedermayer
On Wed, Aug 13, 2014 at 07:04:01PM +0400, Dmitry Volyntsev wrote: > From: Dmitry Volyntsev > > s->buffers_queued constantly decremented and not incremented > in case of (s->frame_size > 0 && buf.bytesused != s->frame_size) > condition (caught on long run capture of Logitech C310) can you explain

Re: [FFmpeg-devel] [PATCH] Add a license to the LESS file

2014-08-26 Thread Andreas Cadhalpun
On 26.08.2014 21:38, db0company wrote: --- LICENSE.txt | 21 + src/less/style.less |6 -- 2 files changed, 25 insertions(+), 2 deletions(-) create mode 100644 LICENSE.txt Thanks. diff --git a/LICENSE.txt b/LICENSE.txt new file mode 100644 index

[FFmpeg-devel] [PATCH] Add a license to the LESS file

2014-08-26 Thread db0company
--- LICENSE.txt | 21 + src/less/style.less |6 -- 2 files changed, 25 insertions(+), 2 deletions(-) create mode 100644 LICENSE.txt diff --git a/LICENSE.txt b/LICENSE.txt new file mode 100644 index 000..c5983d2 --- /dev/null +++ b/LICENSE.txt @@ -0,0 +1,

Re: [FFmpeg-devel] [PATCH] Adds support for setting aq_mode in libvpx encoder

2014-08-26 Thread James Almer
On 25/08/14 9:17 PM, Deb Mukherjee wrote: > Sets aq_mode in the [0, 3] range for the libvpx encode wrapper. > 0: none > 1: variance aq > 2: complexity aq > 3: cyclic refresh aq > --- > doc/encoders.texi | 5 - > libavcodec/libvpxenc.c | 9 + > 2 files changed, 13 insertions(+), 1

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec_h261: sanity checks

2014-08-26 Thread Michael Niedermayer
On Tue, Aug 26, 2014 at 02:23:00PM +0200, Thomas Volkert wrote: > From: ThomasVolkert > > --- > libavformat/rtpdec_h261.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) made commit message a bit more verbose applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF67

Re: [FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-26 Thread James Zern
On Tue, Aug 26, 2014 at 10:30 AM, Deb Mukherjee wrote: > Changes in the parameter mapping for libvpx to support the constant > quality mode in VP9. The assumption in the patch is that if crf is > provided but bitrate is 0, then the 'constant quality' mode of VP9 > is used. However if both are pres

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Michael Niedermayer
On Tue, Aug 26, 2014 at 08:12:58PM +0200, Andreas Cadhalpun wrote: > On 26.08.2014 19:45, Michael Niedermayer wrote: > >On Tue, Aug 26, 2014 at 07:28:13PM +0200, Michael Niedermayer wrote: > >>On Tue, Aug 26, 2014 at 01:42:17AM +0200, Michael Niedermayer wrote: > >>>From: Andreas Cadhalpun > >> >

Re: [FFmpeg-devel] [PATCH] libx264: fix -b_qfactor and -chromaoffset

2014-08-26 Thread Michael Niedermayer
On Tue, Aug 26, 2014 at 02:58:32PM +0800, Hii wrote: > Hi, > > On 2014-08-25 01:24, Michael Niedermayer wrote: > > On Sat, Aug 23, 2014 at 08:59:41PM +0800, Hii wrote: > >> Currently -b_qfactor and -chromaoffset have no effect in libx264, > >> the attached patch is an attempt to fix the issue. > >

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Andreas Cadhalpun
On 26.08.2014 19:45, Michael Niedermayer wrote: On Tue, Aug 26, 2014 at 07:28:13PM +0200, Michael Niedermayer wrote: On Tue, Aug 26, 2014 at 01:42:17AM +0200, Michael Niedermayer wrote: From: Andreas Cadhalpun in absence of any better ideas or pictures i intend to apply this soon of course

[FFmpeg-devel] [PATCH] avformat/rtpdec_h261: sanity checks

2014-08-26 Thread Thomas Volkert
From: ThomasVolkert --- libavformat/rtpdec_h261.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/rtpdec_h261.c b/libavformat/rtpdec_h261.c index c1d79a8..b902d2a 100644 --- a/libavformat/rtpdec_h261.c +++ b/libavformat/rtpdec_h261.c @@ -117,8 +117,8 @@ int ff

Re: [FFmpeg-devel] [PATCH] libx264: fix -b_qfactor and -chromaoffset

2014-08-26 Thread Hii
Hi, On 2014-08-25 01:24, Michael Niedermayer wrote: > On Sat, Aug 23, 2014 at 08:59:41PM +0800, Hii wrote: >> Currently -b_qfactor and -chromaoffset have no effect in libx264, >> the attached patch is an attempt to fix the issue. >> >> Move the corresponding lines after x264_param_default_preset(

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Michael Niedermayer
On Tue, Aug 26, 2014 at 07:28:13PM +0200, Michael Niedermayer wrote: > On Tue, Aug 26, 2014 at 01:42:17AM +0200, Michael Niedermayer wrote: > > From: Andreas Cadhalpun > > in absence of any better ideas or pictures i intend to apply this soon of course if people object to this then we can also l

[FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-26 Thread Deb Mukherjee
Changes in the parameter mapping for libvpx to support the constant quality mode in VP9. The assumption in the patch is that if crf is provided but bitrate is 0, then the 'constant quality' mode of VP9 is used. However if both are present, the 'constrained quality' mode is used as before. --- liba

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Michael Niedermayer
On Tue, Aug 26, 2014 at 01:42:17AM +0200, Michael Niedermayer wrote: > From: Andreas Cadhalpun in absence of any better ideas or pictures i intend to apply this soon [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Frequently ignored answer#1 FFmpeg bugs should

Re: [FFmpeg-devel] [PATCH 2/2] fate: Add basic tests for WebM Dash Manifest

2014-08-26 Thread Michael Niedermayer
On Tue, Aug 26, 2014 at 08:26:10AM -0700, Vignesh Venkatasubramanian wrote: > On Mon, Aug 25, 2014 at 4:35 PM, Lou Logan wrote: > > On Mon, 25 Aug 2014 16:26:16 -0700, Vignesh Venkatasubramanian wrote: > > > >> i sent the files associated with this fate test as a tarball to this > >> mailing list

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Andreas Cadhalpun
Hi, On 26.08.2014 18:26, James Almer wrote: On 26/08/14 9:39 AM, Michael Niedermayer wrote: either way, i suggest that until we have a consensus, andreas should probably pick any of the solutions for debian so theres no delay on the debian side How is this a problem for Debian? lena.pnm is al

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread James Almer
On 26/08/14 9:39 AM, Michael Niedermayer wrote: > either way, i suggest that until we have a consensus, andreas > should probably pick any of the solutions for debian so theres > no delay on the debian side How is this a problem for Debian? lena.pnm is also available on Libav's git tree and it do

Re: [FFmpeg-devel] [PATCH 2/2] fate: Add basic tests for WebM Dash Manifest

2014-08-26 Thread Vignesh Venkatasubramanian
On Mon, Aug 25, 2014 at 4:35 PM, Lou Logan wrote: > On Mon, 25 Aug 2014 16:26:16 -0700, Vignesh Venkatasubramanian wrote: > >> i sent the files associated with this fate test as a tarball to this >> mailing list and got a reply saying "message is awaiting moderator >> approval because the attachme

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Andreas Cadhalpun
On 26.08.2014 16:50, Derek Buitenhuis wrote: On 8/26/2014 3:47 PM, Andreas Cadhalpun wrote: We can't use the defacto DSP testing image because it is not *FREE* enough for Debian? It is utterly asinine to remove it because Debian doesn't want to distribute Lena with source deb. They can remove it

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Derek Buitenhuis
On 8/26/2014 3:47 PM, Andreas Cadhalpun wrote: >> We can't use the defacto DSP testing image because it is not *FREE* enough >> for Debian? It is utterly asinine to remove it because Debian doesn't want >> to distribute Lena with source deb. They can remove it themselves. > > You could still use i

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Andreas Cadhalpun
On 26.08.2014 16:15, Derek Buitenhuis wrote: On 8/26/2014 12:42 AM, Michael Niedermayer wrote: [...] tests/lena.pnm | 109 I'm sorry but this is beyond stupid. I don't think so. We can't use the defacto DSP testing image because

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Derek Buitenhuis
On 8/26/2014 12:42 AM, Michael Niedermayer wrote: [...] > tests/lena.pnm | 109 > I'm sorry but this is beyond stupid. We can't use the defacto DSP testing image because it is not *FREE* enough for Debian? It is utterly asinine to remov

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Andreas Cadhalpun
On 26.08.2014 14:40, Nicolas George wrote: Also: aimlin /tmp $ apt-get source libav >& /dev/null aimlin /tmp $ ls -l libav-10.4/tests/lena.pnm -rw-r--r-- 1 cigaes cigaes 196668 Aug 17 16:31 libav-10.4/tests/lena.pnm (Of course it does not prove anything beyond the fact that people do not really

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Ensure cues_end is initialized

2014-08-26 Thread ooe

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Andreas Cadhalpun
On 26.08.2014 14:39, Michael Niedermayer wrote: On Tue, Aug 26, 2014 at 02:32:00PM +0200, Clément Bœsch wrote: On Tue, Aug 26, 2014 at 02:27:45PM +0200, Michael Niedermayer wrote: On Tue, Aug 26, 2014 at 02:22:08PM +0200, Andreas Cadhalpun wrote: On 26.08.2014 14:11, Clément Bœsch wrote: On T

Re: [FFmpeg-devel] [PATCH] Adds support for setting aq_mode in libvpx encoder

2014-08-26 Thread Michael Niedermayer
On Tue, Aug 26, 2014 at 03:39:26AM +0200, Michael Niedermayer wrote: > On Mon, Aug 25, 2014 at 05:17:39PM -0700, Deb Mukherjee wrote: > > Sets aq_mode in the [0, 3] range for the libvpx encode wrapper. > > 0: none > > 1: variance aq > > 2: complexity aq > > 3: cyclic refresh aq > > --- > > doc/enc

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Michael Niedermayer
On Tue, Aug 26, 2014 at 02:32:00PM +0200, Clément Bœsch wrote: > On Tue, Aug 26, 2014 at 02:27:45PM +0200, Michael Niedermayer wrote: > > On Tue, Aug 26, 2014 at 02:22:08PM +0200, Andreas Cadhalpun wrote: > > > On 26.08.2014 14:11, Clément Bœsch wrote: > > > >On Tue, Aug 26, 2014 at 01:52:19PM +020

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Nicolas George
Le nonidi 9 fructidor, an CCXXII, Clément Bœsch a écrit : > Last, it adds a wget dependency. ffmpeg -f data -i http://samples.ffmpeg.org/image-samples/lena.pnm -c copy -f data -map 0 -y lena.pnm :) Also: aimlin /tmp $ apt-get source libav >& /dev/null aimlin /tmp $ ls -l libav-10.4/te

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Clément Bœsch
On Tue, Aug 26, 2014 at 02:27:45PM +0200, Michael Niedermayer wrote: > On Tue, Aug 26, 2014 at 02:22:08PM +0200, Andreas Cadhalpun wrote: > > On 26.08.2014 14:11, Clément Bœsch wrote: > > >On Tue, Aug 26, 2014 at 01:52:19PM +0200, Michael Niedermayer wrote: > > >[...] > > >>>I'm fine with the patch

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Michael Niedermayer
On Tue, Aug 26, 2014 at 02:27:45PM +0200, Michael Niedermayer wrote: > On Tue, Aug 26, 2014 at 02:22:08PM +0200, Andreas Cadhalpun wrote: > > On 26.08.2014 14:11, Clément Bœsch wrote: > > >On Tue, Aug 26, 2014 at 01:52:19PM +0200, Michael Niedermayer wrote: > > >[...] > > >>>I'm fine with the patch

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Michael Niedermayer
On Tue, Aug 26, 2014 at 02:22:08PM +0200, Andreas Cadhalpun wrote: > On 26.08.2014 14:11, Clément Bœsch wrote: > >On Tue, Aug 26, 2014 at 01:52:19PM +0200, Michael Niedermayer wrote: > >[...] > >>>I'm fine with the patch, even though Lena has a special meaning in video > >>>processing... > >> > >>y

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Andreas Cadhalpun
On 26.08.2014 14:11, Clément Bœsch wrote: On Tue, Aug 26, 2014 at 01:52:19PM +0200, Michael Niedermayer wrote: [...] I'm fine with the patch, even though Lena has a special meaning in video processing... yep, i wonder if this is the best solution after sleepng over it. the lena image is well k

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Clément Bœsch
On Tue, Aug 26, 2014 at 01:52:19PM +0200, Michael Niedermayer wrote: [...] > > I'm fine with the patch, even though Lena has a special meaning in video > > processing... > > yep, i wonder if this is the best solution after sleepng over it. > the lena image is well known, also people know how girls

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Michael Niedermayer
On Tue, Aug 26, 2014 at 12:32:32PM +0200, Andreas Cadhalpun wrote: > On 26.08.2014 01:42, Michael Niedermayer wrote: > >From: Andreas Cadhalpun > > > >--- > > LICENSE.md |1 + > > tests/Makefile |2 +- > > tests/flower.pnm

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Michael Niedermayer
On Tue, Aug 26, 2014 at 11:16:24AM +0200, Clément Bœsch wrote: > On Tue, Aug 26, 2014 at 01:42:17AM +0200, Michael Niedermayer wrote: > > From: Andreas Cadhalpun > > > > --- > > LICENSE.md |1 + > > tests/Makefile |2 +- > > tes

[FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree

2014-08-26 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- tests/Makefile |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/Makefile b/tests/Makefile index 07557f9..2f095df 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -24,13 +24,16 @@ $(VREF): tests/videogen$(HOSTEXESUF) | tests

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Andreas Cadhalpun
On 26.08.2014 01:42, Michael Niedermayer wrote: From: Andreas Cadhalpun --- LICENSE.md |1 + tests/Makefile |2 +- tests/flower.pnm | Bin 0 -> 196623 bytes tests/lena.pnm

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Clément Bœsch
On Tue, Aug 26, 2014 at 01:42:17AM +0200, Michael Niedermayer wrote: > From: Andreas Cadhalpun > > --- > LICENSE.md |1 + > tests/Makefile |2 +- > tests/flower.pnm | Bin 0 -> 196623 bytes > tests/len

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Ensure cues_end is initialized

2014-08-26 Thread Reimar Döffinger
On 25.08.2014, at 18:15, Vignesh Venkatasubramanian wrote: > avio_seek(matroska->ctx->pb, before_pos, SEEK_SET); > +if (cues_start == -1 || cues_end == -1) return -1; Shouldn't this use something more descriptive than -1? ___ ffmpeg-devel mai

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-26 Thread Reimar Döffinger
On 25.08.2014, at 19:33, Christophe Gisquet wrote: > Hi, > > 2014-08-25 6:41 GMT+02:00 Reimar Döffinger : >> The colorspace is supposed to be authoritative. >> If it says 16 bit, then showing it as 16 bit must work properly. >> The only intention of bits_per_raw_sample is to indicate that there