Re: [FFmpeg-devel] FFmpeg and OPW

2014-08-07 Thread Michael Niedermayer
Hi all On Fri, Aug 01, 2014 at 03:16:31AM +0200, Michael Niedermayer wrote: > Hi all > > OPW (Outreach Program for Women) is twice per year (compared to google > summer of code which is just once a year) > > FFmpeg can participate in the next round but we need to fund at least > 1 intern/student

Re: [FFmpeg-devel] Stereo channel layout mapping

2014-08-07 Thread Michael Niedermayer
On Thu, Aug 07, 2014 at 04:52:43PM +0200, Robert Krüger wrote: > Hi, > > could someone explain, what the difference between those two is and > when to use which one? > > #define AV_CH_LAYOUT_STEREO(AV_CH_FRONT_LEFT|AV_CH_FRONT_RIGHT) > #define AV_CH_LAYOUT_STEREO_DOWNMIX(AV_CH_STE

Re: [FFmpeg-devel] [PATCH 2/2] replace calls to url_feof() with avio_feof()

2014-08-07 Thread Michael Niedermayer
On Thu, Aug 07, 2014 at 05:12:41PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > ffplay.c | 4 ++-- > libavformat/4xm.c| 2 +- > libavformat/adp.c| 2 +- > libavformat/aiffdec.c| 2 +- > libavformat/amr.c| 2 +-

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avio: rename url_feof() to avio_feof()

2014-08-07 Thread Michael Niedermayer
On Thu, Aug 07, 2014 at 05:12:40PM -0300, James Almer wrote: > It's a public function and should use the avio_ namespace > > Signed-off-by: James Almer > --- > I'm scheduling the removal to lavf 57 since libav is about to force a bump. applied thanks [...] -- Michael GnuPG fingerprint: 9F

Re: [FFmpeg-devel] [PATCH v2] read reel_name metadata from tmcd atom

2014-08-07 Thread Michael Niedermayer
On Thu, Aug 07, 2014 at 10:20:36AM -0700, Mark Reid wrote: > --- > libavformat/mov.c | 20 > 1 file changed, 20 insertions(+) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Republics decline into democracies and democracies

Re: [FFmpeg-devel] [PATCH]Make subtitle properties code in lavc more robust

2014-08-07 Thread Carl Eugen Hoyos
Marton Balint passwd.hu> writes: > So before applying this patch, I think we should decide > what these properties mean exactly... I have no opinion on this, just wanted to show why (imo) libzvbi cannot currently have other properties. Carl Eugen _

Re: [FFmpeg-devel] [PATCH 02/14] libavcodec: Implementation of AAC_fixed_decoder (LC-module) [2/5]

2014-08-07 Thread Reimar Döffinger
On Thu, Aug 07, 2014 at 09:51:36AM +, Nedeljko Babic wrote: > >> +Q30(0.95), Q30(0.9922480620), Q30(0.9846153846), > >> Q30(0.9770992366), > > > >I'm a bit unsure btw. if this makes more sense than coding the converted > >numbers. > >It feels like it combines the disadvantages, sin

[FFmpeg-devel] [PATCH 2/2] replace calls to url_feof() with avio_feof()

2014-08-07 Thread James Almer
Signed-off-by: James Almer --- ffplay.c | 4 ++-- libavformat/4xm.c| 2 +- libavformat/adp.c| 2 +- libavformat/aiffdec.c| 2 +- libavformat/amr.c| 2 +- libavformat/anm.c| 2 +- libavformat/ape.c| 2 +-

[FFmpeg-devel] [PATCH 1/2] lavf/avio: rename url_feof() to avio_feof()

2014-08-07 Thread James Almer
It's a public function and should use the avio_ namespace Signed-off-by: James Almer --- I'm scheduling the removal to lavf 57 since libav is about to force a bump. doc/APIchanges| 3 +++ libavformat/avio.h| 7 +++ libavformat/aviobuf.c | 9 - libavformat/lib

[FFmpeg-devel] [PATCH] NULL-check Matroska chapters when reading header

2014-08-07 Thread Justin Jacobs
I have a Matroska file that contains a broken chapter (end time is before start time) that caused any ffmpeg-linked program to crash when accessing it. I've attached a patch that fixes the crash. Also, here is the backtrace of the crash for reference: (gdb) backtrace #0 av_dict_set (pm=0x20, key=

Re: [FFmpeg-devel] [PATCH] avfilter/dctdnoiz: rewrite [f/i]dct

2014-08-07 Thread Clément Bœsch
On Mon, Aug 04, 2014 at 05:08:21PM +0200, Michael Niedermayer wrote: [...] > > > > +const float xd_2 = 1.306562964876380*xc_2 + > > > > 0.541196100146197*xc_3; > > > > +const float xd_3 = 0.541196100146197*xc_2 - > > > > 1.306562964876380*xc_3; > > > > +const float x1_9 =

Re: [FFmpeg-devel] XMP in mov files

2014-08-07 Thread Michael Niedermayer
On Thu, Aug 07, 2014 at 04:19:15PM +0200, Marek Fort wrote: > Yes, here is one: > > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket3707/Untitled_dnhd.mov ok, seems to work, patch applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely t

Re: [FFmpeg-devel] [PATCH]Make subtitle properties code in lavc more robust

2014-08-07 Thread Marton Balint
On Thu, 7 Aug 2014, Carl Eugen Hoyos wrote: Hi! Attached patch should allow to set the teletext decoder properties to (AV_CODEC_PROP_TEXT_SUB | AV_CODEC_PROP_BITMAP_SUB). At the moment, the documentation states that if a property of this kind is set, then the decoder will provide subtitles

[FFmpeg-devel] [PATCH v2] read reel_name metadata from tmcd atom

2014-08-07 Thread Mark Reid
Changes since v1: * corrected overflow issues on extradata size checking * added additional size check before malloc * removed strcmp Mark Reid (1): read reel_name metadata from tmcd atom libavformat/mov.c | 20 1 file changed, 20 insertions(+) -- 2.0.0 __

[FFmpeg-devel] [PATCH v2] read reel_name metadata from tmcd atom

2014-08-07 Thread Mark Reid
--- libavformat/mov.c | 20 1 file changed, 20 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index ab85918..afdb9b0 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -1529,6 +1529,26 @@ static int mov_parse_stsd_data(MOVContext *c, AVIOContext *pb,

[FFmpeg-devel] [PATCH] avutil: turn arm setend into a cpuflag

2014-08-07 Thread Michael Niedermayer
this allows disabling and enabling it it also prevents crashes if vfpv3 and neon are disabled which previously would have enabled the flag Signed-off-by: Michael Niedermayer --- configure |3 +++ libavutil/arm/cpu.c |9 - libavutil/arm/cpu.h |7 +-- libavutil/cp

[FFmpeg-devel] Stereo channel layout mapping

2014-08-07 Thread Robert Krüger
Hi, could someone explain, what the difference between those two is and when to use which one? #define AV_CH_LAYOUT_STEREO(AV_CH_FRONT_LEFT|AV_CH_FRONT_RIGHT) #define AV_CH_LAYOUT_STEREO_DOWNMIX(AV_CH_STEREO_LEFT|AV_CH_STEREO_RIGHT) E.g. when I extract metadata and want to use th

Re: [FFmpeg-devel] XMP in mov files

2014-08-07 Thread Marek Fort
Yes, here is one: http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket3707/Untitled_dnhd.mov On 7 August 2014 15:37, Michael Niedermayer wrote: > On Thu, Aug 07, 2014 at 11:20:23AM +0200, Marek Fort wrote: > > Hi, > > > > I'd like to integrate this patch. > > > > It adds a support for reading/wr

Re: [FFmpeg-devel] [PATCH] avdevice/lavfi: Simplify non-AV stream check

2014-08-07 Thread Michael Niedermayer
On Tue, Aug 05, 2014 at 05:03:27PM +0200, Michael Niedermayer wrote: > Fixes a clang warning > Signed-off-by: Michael Niedermayer > --- > libavdevice/lavfi.c | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730

Re: [FFmpeg-devel] XMP in mov files

2014-08-07 Thread Michael Niedermayer
On Thu, Aug 07, 2014 at 11:20:23AM +0200, Marek Fort wrote: > Hi, > > I'd like to integrate this patch. > > It adds a support for reading/writing XMP data in mov file format. > > The patch is made according to XMP SPECIFICATION PART 3 - STORAGE IN FILES > ch. 1.2.4.1 Placement of XMP. Spec avail

Re: [FFmpeg-devel] [PATCH 1/3] lavd/pulse_audio_dec: use default source when no input provided

2014-08-07 Thread Michael Niedermayer
On Thu, Aug 07, 2014 at 01:58:55AM +0200, Lukasz Marek wrote: > PulseAudio expilitly requires name of the source. > This patch makes it use default source when not provided. > It simplifies programistic use. > > Signed-off-by: Lukasz Marek > --- > libavdevice/pulse_audio_dec.c | 2 +- > 1 file c

Re: [FFmpeg-devel] [PATCH 2/3] lavu/log: add device category macros

2014-08-07 Thread Michael Niedermayer
On Thu, Aug 07, 2014 at 01:58:56AM +0200, Lukasz Marek wrote: > --- > libavutil/log.h | 10 ++ > 1 file changed, 10 insertions(+) should be ok unless someone has a better idea [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No human being will ever know

Re: [FFmpeg-devel] [PATCH]Do not select a default subtitle output stream with incorrect subtitle type

2014-08-07 Thread Michael Niedermayer
On Thu, Aug 07, 2014 at 11:22:22AM +, Carl Eugen Hoyos wrote: > Michael Niedermayer gmx.at> writes: > > > should be ok > > Please merge from github. merged thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Old school: Use the lowest level language i

Re: [FFmpeg-devel] [PATCH]Make subtitle properties code in lavc more robust

2014-08-07 Thread Michael Niedermayer
On Thu, Aug 07, 2014 at 02:02:33PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch should allow to set the teletext decoder properties to > (AV_CODEC_PROP_TEXT_SUB | AV_CODEC_PROP_BITMAP_SUB). > > Please comment, Carl Eugen > utils.c |9 ++--- > 1 file changed, 6 insertions(+),

[FFmpeg-devel] [PATCH]Make subtitle properties code in lavc more robust

2014-08-07 Thread Carl Eugen Hoyos
Hi! Attached patch should allow to set the teletext decoder properties to (AV_CODEC_PROP_TEXT_SUB | AV_CODEC_PROP_BITMAP_SUB). Please comment, Carl Eugen diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 6071380..3db2a1c 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -1595,

Re: [FFmpeg-devel] [PATCH 2/2] lavf: remove nonexistent functions from the version file

2014-08-07 Thread Michael Niedermayer
On Thu, Aug 07, 2014 at 02:12:46AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > The rest (at least those not used by ffprobe/ffplay/ffmpeg) should *really* > be > removed on the next bump > > libavformat/libavformat.v | 11 --- > 1 file changed, 11 deletions(-) appli

Re: [FFmpeg-devel] [PATCH 1/2] lavc: remove nonexistent functions from the version file

2014-08-07 Thread Michael Niedermayer
On Thu, Aug 07, 2014 at 02:12:45AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > The rest should *really* be removed on the next bump applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Complexity theory is the science of finding th

Re: [FFmpeg-devel] [PATCH]Do not select a default subtitle output stream with incorrect subtitle type

2014-08-07 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > should be ok Please merge from github. > but why does dvb teletext not have a TEXT/BITMAP prop ? I believe this would break avcodec_decode_subtitle2() which sets the format depending on the properties. This should be fixed but I don't know the relevant co

Re: [FFmpeg-devel] [PATCH] lavd/dshow: use av_codec_get_id()

2014-08-07 Thread Michael Niedermayer
On Thu, Aug 07, 2014 at 12:43:03AM -0300, James Almer wrote: > ff_codec_get_id() is a lavf internal function > > Signed-off-by: James Almer > --- > libavdevice/dshow.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF21

Re: [FFmpeg-devel] [PATCH] avcodec/raw: add avpriv_get_raw_pix_fmt_tags()

2014-08-07 Thread Michael Niedermayer
On Thu, Aug 07, 2014 at 01:22:48AM -0300, James Almer wrote: > Used to expose ff_raw_pix_fmt_tags[] to other libav* libraries > > Signed-off-by: James Almer > --- > libavcodec/raw.c| 5 + > libavcodec/raw.h| 6 ++ > libavdevice/dshow.c | 2 +- > libavformat/utils.c | 2 +- > 4 fi

Re: [FFmpeg-devel] [PATCH]Do not select a default subtitle output stream with incorrect subtitle type

2014-08-07 Thread Michael Niedermayer
On Tue, Aug 05, 2014 at 09:59:13PM +0200, Carl Eugen Hoyos wrote: > On Friday 01 August 2014 10:04:17 am Clément Bœsch wrote: > > On Fri, Aug 01, 2014 at 01:54:57AM +0200, Carl Eugen Hoyos wrote: > > > When transcoding an input file with subtitles to mkv, ffmpeg by default > > > tries to encode the

Re: [FFmpeg-devel] [PATCH 06/14] libavcodec: Implementation of AAC_fixed_decoder (SBR-module) [1/4]

2014-08-07 Thread Nedeljko Babic
> On Fri, Aug 01, 2014 at 03:53:12PM +0200, Nedeljko Babic wrote: > > From: Djordje Pesut > > > > Move the existing code to a new template file. > > If code was only moved (I have not checked), I don't think > adding your copyright is appropriate. In this patch code was only moved to a new file,

Re: [FFmpeg-devel] [PATCH 02/14] libavcodec: Implementation of AAC_fixed_decoder (LC-module) [2/5]

2014-08-07 Thread Nedeljko Babic
Thanks on your review, >On Fri, Aug 01, 2014 at 03:53:08PM +0200, Nedeljko Babic wrote: >> +#if !defined(_AAC_FLOAT_EMU_) >> +#define _AAC_FLOAT_EMU_ > >That is not out usual style >1) We use #ifndef >2) Identifiers starting with _ + upper case letter are reserved by POSIX >and never should be use

[FFmpeg-devel] XMP in mov files

2014-08-07 Thread Marek Fort
Hi, I'd like to integrate this patch. It adds a support for reading/writing XMP data in mov file format. The patch is made according to XMP SPECIFICATION PART 3 - STORAGE IN FILES ch. 1.2.4.1 Placement of XMP. Spec available here: http://www.adobe.com/devnet/xmp.html The XMP is stored under "xm

Re: [FFmpeg-devel] rectification filter

2014-08-07 Thread Clément Bœsch
On Thu, Aug 07, 2014 at 10:38:03AM +0200, Daniel Oberhoff wrote: > Hello, > > Did anyone get my last mail? Wrote it last night and it shows up on my > mailing host too, but somehow not in the list archives... > Seems it's here: http://ffmpeg.org/pipermail/ffmpeg-devel/2014-August/160764.html [.

Re: [FFmpeg-devel] rectification filter

2014-08-07 Thread Daniel Oberhoff
Hello, Did anyone get my last mail? Wrote it last night and it shows up on my mailing host too, but somehow not in the list archives... Best On Thu, Aug 7, 2014 at 12:15 AM, Daniel Oberhoff wrote: > > Am 06.08.2014 um 12:12 schrieb Clément Bœsch : > > > On Sun, Aug 03, 2014 at 06:43:18PM +020

[FFmpeg-devel] [PATCH]Do not mux invalid hevc into transport streams

2014-08-07 Thread Carl Eugen Hoyos
Hi! Attached patch checks if the hevc stream contains a startcode when muxed into transport streams. Please review, Carl Eugen diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index c286249..4259318 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -1157,6 +1157