Re: [FFmpeg-cvslog] lavc/libutvideoenc: Cast an unsigned constant to int.

2016-05-13 Thread Carl Eugen Hoyos
Reimar Döffinger gmx.de> writes: > Where does it get converted from unsigned to int? I absolutely may misunderstand your question but afaict, there is an assignment of an unsigned value to an variable with type int. > If we want valid code, we can never ever convert anything > that contains

Re: [FFmpeg-cvslog] lavc/libutvideoenc: Cast an unsigned constant to int.

2016-05-13 Thread Reimar Döffinger
On 13.05.2016, at 10:51, Carl Eugen Hoyos wrote: > Reimar Döffinger gmx.de> writes: > >> >> On 13.05.2016, at 02:49, Carl Eugen Hoyos ag.or.at> wrote: >> >>> Reimar Döffinger gmx.de> writes: >>> > -AV_CODEC_CAP_AUTO_THREADS | AV_CODEC_CAP_LOSSLESS > +AV_CODEC_CAP_AUTO_THRE

Re: [FFmpeg-cvslog] lavc/libutvideoenc: Cast an unsigned constant to int.

2016-05-13 Thread Carl Eugen Hoyos
Reimar Döffinger gmx.de> writes: > > On 13.05.2016, at 02:49, Carl Eugen Hoyos ag.or.at> wrote: > > > Reimar Döffinger gmx.de> writes: > > > >>> -AV_CODEC_CAP_AUTO_THREADS | AV_CODEC_CAP_LOSSLESS > >>> +AV_CODEC_CAP_AUTO_THREADS | (int)AV_CODEC_CAP_LOSSLESS > >> > >> That doesn't

Re: [FFmpeg-cvslog] lavc/libutvideoenc: Cast an unsigned constant to int.

2016-05-12 Thread Reimar Döffinger
On 13.05.2016, at 02:49, Carl Eugen Hoyos wrote: > Reimar Döffinger gmx.de> writes: > >>> -AV_CODEC_CAP_AUTO_THREADS | AV_CODEC_CAP_LOSSLESS >>> +AV_CODEC_CAP_AUTO_THREADS | (int)AV_CODEC_CAP_LOSSLESS >> >> That doesn't seem like a good idea, AV_CODEC_CAP_LOSSLESS does >> not fit in

Re: [FFmpeg-cvslog] lavc/libutvideoenc: Cast an unsigned constant to int.

2016-05-12 Thread Carl Eugen Hoyos
Reimar Döffinger gmx.de> writes: > > -AV_CODEC_CAP_AUTO_THREADS | AV_CODEC_CAP_LOSSLESS > > +AV_CODEC_CAP_AUTO_THREADS | (int)AV_CODEC_CAP_LOSSLESS > > That doesn't seem like a good idea, AV_CODEC_CAP_LOSSLESS does > not fit in int, Why does 0x8000 not fit in int? > so we should not

Re: [FFmpeg-cvslog] lavc/libutvideoenc: Cast an unsigned constant to int.

2016-05-12 Thread Reimar Döffinger
On 12.05.2016, at 09:08, g...@videolan.org (Carl Eugen Hoyos) wrote: > ffmpeg | branch: master | Carl Eugen Hoyos | Thu May 12 > 09:07:02 2016 +0200| [d1cacbbea946f39fb7a7ff9852bc5d8c1e67143c] | committer: > Carl Eugen Hoyos > > lavc/libutvideoenc: Cast an unsigned constant to int. > > Fixe

[FFmpeg-cvslog] lavc/libutvideoenc: Cast an unsigned constant to int.

2016-05-12 Thread Carl Eugen Hoyos
ffmpeg | branch: master | Carl Eugen Hoyos | Thu May 12 09:07:02 2016 +0200| [d1cacbbea946f39fb7a7ff9852bc5d8c1e67143c] | committer: Carl Eugen Hoyos lavc/libutvideoenc: Cast an unsigned constant to int. Fixes the following warning / error: libavcodec/libutvideoenc.cpp:281:1: warning: narrowin