Re: [FFmpeg-cvslog] configure: Check if libwebp compilation will succeed.

2014-08-08 Thread Clément Bœsch
On Fri, Aug 08, 2014 at 09:05:20PM +, Carl Eugen Hoyos wrote: > Clément Bœsch pkh.me> writes: > > > It's simpler, it's faster, it explicits the > > required version, > > > and I can test it for you if you don't want to. > > There is no need for another test: > With your change, some workin

Re: [FFmpeg-cvslog] configure: Check if libwebp compilation will succeed.

2014-08-08 Thread Carl Eugen Hoyos
Clément Bœsch pkh.me> writes: > It's simpler, it's faster, it explicits the > required version, > and I can test it for you if you don't want to. There is no need for another test: With your change, some working versions would fail configure. Carl Eugen _

Re: [FFmpeg-cvslog] configure: Check if libwebp compilation will succeed.

2014-08-08 Thread Clément Bœsch
On Fri, Aug 08, 2014 at 08:40:33PM +, Carl Eugen Hoyos wrote: > Clément Bœsch pkh.me> writes: > > > enabled libwebp && require_pkg_config "libwebp >= 0.2.0" > > Sorry, I honestly cannot understand why you want to > replace an exact check (that I tested) against one > that is (not even) an

Re: [FFmpeg-cvslog] configure: Check if libwebp compilation will succeed.

2014-08-08 Thread Carl Eugen Hoyos
Clément Bœsch pkh.me> writes: > enabled libwebp && require_pkg_config "libwebp >= 0.2.0" Sorry, I honestly cannot understand why you want to replace an exact check (that I tested) against one that is (not even) an approximation and would at least in theory break compilation for some users wi

Re: [FFmpeg-cvslog] configure: Check if libwebp compilation will succeed.

2014-08-08 Thread Clément Bœsch
On Fri, Aug 08, 2014 at 05:05:00PM +, Carl Eugen Hoyos wrote: > Clément Bœsch pkh.me> writes: > > > > + { check_code cc webp/encode.h "WebPPicture wp; wp.use_argb++" || > > > + die "ERROR: libwebp too old."; } > > > > ... ? > > > > Why don't you just include the version check in t

Re: [FFmpeg-cvslog] configure: Check if libwebp compilation will succeed.

2014-08-08 Thread Carl Eugen Hoyos
Clément Bœsch pkh.me> writes: > > + { check_code cc webp/encode.h "WebPPicture wp; wp.use_argb++" || > > + die "ERROR: libwebp too old."; } > > ... ? > > Why don't you just include the version check in the libwebp name? I didn't find a version bump near the relevant commit. > What's

Re: [FFmpeg-cvslog] configure: Check if libwebp compilation will succeed.

2014-08-08 Thread Clément Bœsch
On Fri, Aug 08, 2014 at 05:23:43PM +0200, Carl Eugen Hoyos wrote: > ffmpeg | branch: master | Carl Eugen Hoyos | Fri Aug 8 > 16:06:10 2014 +0200| [e4d983e2db0e73e711ae63dc9495316e121ec3da] | committer: > Carl Eugen Hoyos > > configure: Check if libwebp compilation will succeed. > > > http://g

[FFmpeg-cvslog] configure: Check if libwebp compilation will succeed.

2014-08-08 Thread Carl Eugen Hoyos
ffmpeg | branch: master | Carl Eugen Hoyos | Fri Aug 8 16:06:10 2014 +0200| [e4d983e2db0e73e711ae63dc9495316e121ec3da] | committer: Carl Eugen Hoyos configure: Check if libwebp compilation will succeed. > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=e4d983e2db0e73e711ae63dc949531