Re: [Ffc] Fwd: Issue with optimized quadrature representation

2013-02-28 Thread Anders Logg
On Thu, Feb 28, 2013 at 11:13:57PM +, Garth N. Wells wrote: > On 28 February 2013 22:53, Anders Logg wrote: > > ok, good. > > > > Things are building mostly fine now except for some DOLFIN unit tests > > related to new interfaces for finite_element::evaluate_foo. > > > > We need to discuss at

Re: [Ffc] Fwd: Issue with optimized quadrature representation

2013-02-28 Thread Garth N. Wells
On 28 February 2013 22:53, Anders Logg wrote: > ok, good. > > Things are building mostly fine now except for some DOLFIN unit tests > related to new interfaces for finite_element::evaluate_foo. > > We need to discuss at some point the role of dolfin::FiniteElement > and dolfin::DofMap. I'd like to

Re: [Ffc] Fwd: Issue with optimized quadrature representation

2013-02-28 Thread Anders Logg
ok, good. Things are building mostly fine now except for some DOLFIN unit tests related to new interfaces for finite_element::evaluate_foo. We need to discuss at some point the role of dolfin::FiniteElement and dolfin::DofMap. I'd like to get rid of the duplication of the finite_element, dof_map

Re: [Ffc] Fwd: Issue with optimized quadrature representation

2013-02-28 Thread Martin Sandve Alnæs
It's safe. I won't do siginficant ffc-side work now. Martin On 28 February 2013 23:12, Anders Logg wrote: > I assume it's safe to continue working in the > ffc-uflacs-ufc-geometry-merged > branch. Or should I fork it to a safer branch? > > -- > Anders > > > On Thu, Feb 28, 2013 at 02:21:24PM +

Re: [Ffc] Fwd: Issue with optimized quadrature representation

2013-02-28 Thread Anders Logg
I assume it's safe to continue working in the ffc-uflacs-ufc-geometry-merged branch. Or should I fork it to a safer branch? -- Anders On Thu, Feb 28, 2013 at 02:21:24PM +0100, Martin Sandve Alnæs wrote: > Actually it is populated elsewhere (think it's in symbolics.py) in a helper > function usi

Re: [Ffc] Fwd: Issue with optimized quadrature representation

2013-02-28 Thread Martin Sandve Alnæs
Actually it is populated elsewhere (think it's in symbolics.py) in a helper function using a different name for it, but the bug was in quadraturetransformerbase.py where I had done some refactoring. It was only triggered when using -e, which is probably because the demos don't cover enough non-triv

Re: [Ffc] Fwd: Issue with optimized quadrature representation

2013-02-28 Thread Anders Logg
On Thu, Feb 28, 2013 at 02:00:27PM +0100, Martin Sandve Alnæs wrote: > Found, fixed, and pushed to ffc-uflacs-ufc-geometry-merged/. Great, thanks. I spent a few hours last night trying to track down the bug but it was very difficult. In particular I couldn't figure out where the data ir["geo_cons

[Ffc] Fwd: Issue with optimized quadrature representation

2013-02-28 Thread Martin Sandve Alnæs
Found, fixed, and pushed to ffc-uflacs-ufc-geometry-merged/. I had to add -e to building of AdaptivePoisson.ufl in the ffc regression test to make the bug visible there, which is why I didn't catch it earlier. Although it had nothing to do with error control. It would be good to add some demo files

Re: [Ffc] Issue with optimized quadrature representation

2013-02-28 Thread Martin Alnæs
But Anders, I never intended you to work on the uflacs branch. I pushed my merge to a separate branch exactly because you should just get your stuff running and push without the risk of my bugs tripping you up like this. I can handle any additional merging as needed. Martin Den 27. feb. 2013 kl.

Re: [Ffc] Issue with optimized quadrature representation

2013-02-28 Thread Martin Alnæs
Ok, I know where to look. Basically, when a symbol is created with GEO access instead of IP, it becomes part of the G array? Martin Den 28. feb. 2013 kl. 07:45 skrev Kristian Ølgaard : > On 27 February 2013 23:48, Anders Logg wrote: >> I'm trying to get DOLFIN to build against the new UFC bran