Org-cite: Replace basic follow-processor with transient menu?

2024-09-14 Thread Tor-björn Claesson
-mode, in case you would be interested. Best regards, Tor-björn Claesson (transient-define-prefix tbc/follow-reference (datum &optional _) "How should we follow references?" [["Open" ("b" "bibliography entry" (lambda () (interacti

Re: Org-cite: Replace basic follow-processor with transient menu?

2024-10-28 Thread Tor-björn Claesson
Hi again! Den lör 26 okt. 2024 kl 14:45 skrev Jonas Bernoulli : > [Obviously completely untested:] > > (defcustom org-cite-basic-follow-actions > '[["Open" > ("b" "bibliography entry" org-cite-basic-follow.open-bibliography (...))] > ["Copy" > ("d" "DOI" org-cite-basic-follow.copy-

Re: Org-cite: Replace basic follow-processor with transient menu?

2024-10-22 Thread Tor-björn Claesson
Ihor Radchenko writes: > Thanks! This looks much more clean. > Even better would be having a defcustom that defines the transient > layout. The idea is to avoid hard-coding [["Open" ... ] ["Copy" ...] > ...] and instead make it defcustom. Here is a solution that works for me. Is this an OK use of

Re: Org-cite: Replace basic follow-processor with transient menu?

2024-11-05 Thread Tor-björn Claesson
Ihor Radchenko writes: > Tor-björn Claesson writes: > >> I feel that the guard option does the right thing by directly fixing >> the pattern matching - but what approach do you prefer? > > I provided the guard example just for your reference. > The preference for a

Re: Org-cite: Replace basic follow-processor with transient menu?

2024-10-31 Thread Tor-björn Claesson
Good ideas! (transient-define-prefix org-cite-basic-follow (citation &optional prefix) [:class transient-columns :setup-children org-cite-basic-follow--setup :pad-keys t] (interactive) (if (or org-cite-basic-follow-ask (eq prefix '(-4))) (transient-setup 'org-cite-basic

Re: Org-cite: Replace basic follow-processor with transient menu?

2024-11-02 Thread Tor-björn Claesson
Ihor Radchenko writes: > Rather than going into recursive replacements, simply let-bind > !citation, !prefix, and anything else we may want to provide around the > lambda/function call. Clever! I had to put the let inside the lambda for it to work. (defun org-cite-basic-follow--parse-suffix-spec

Re: Org-cite: Replace basic follow-processor with transient menu?

2024-11-02 Thread Tor-björn Claesson
Ihor Radchenko writes: > AFIU, you need to match against lambda simply to avoid the next clause > matching it. Exactly. > If so, you can change the clause to match all ,fn, except > lambda like the following: > > `(,key > ,desc > (,(and fn (guard (not (eq fn 'lambda >. ,fn-args) >

Re: Org-cite: Replace basic follow-processor with transient menu?

2024-10-27 Thread Tor-björn Claesson
Hi and thanks for these suggestions! I have some time away from the family tomorrow evening, and will try to make a new prototype along those lines:) Getting back! Cheers/Tor-björn Den sön 27 okt. 2024 10.07Ihor Radchenko skrev: > Jonas Bernoulli writes: > > > ... > > But the approach I used

Re: Org-cite: Replace basic follow-processor with transient menu?

2024-11-11 Thread Tor-björn Claesson
Here is my first attempt. I have read the commit guidelines, but it is very possible that I have misunderstood or just missed something, so I'm grateful for any feedback! Cheers, Tor-björn Den sön 10 nov. 2024 kl 18:40 skrev Ihor Radchenko : > > Tor-björn Claesson writes: > >

Re: Org-cite: Replace basic follow-processor with transient menu?

2024-11-12 Thread Tor-björn Claesson
Ihor Radchenko writes: > See my comments below. Thanks for taking the time to look at this! >> +*** Menu for choosing how to follow citations >> +If invoked with a prefix of C-- C-u, following citations with >> +the org-cite-basic citation backend will no present a transient menu, >> +offering ch

Re: Org-cite: Replace basic follow-processor with transient menu?

2024-10-31 Thread Tor-björn Claesson
Thanks! Here is another take=) (defcustom org-cite-basic-follow-actions '[["Open" ("b" "bibliography entry" (org-cite-basic-goto !citation !prefix))] ["Copy" ("d" "DOI" org-cite-basic-follow.copy-doi)] ["Browse" ("u" "url" org-cite-basic-follow.browse-url)]] "Hepp"

Re: Org-cite: Replace basic follow-processor with transient menu?

2024-11-01 Thread Tor-björn Claesson
'vector #'org-cite-basic-follow--parse-suffix-specification group)) org-cite-basic-follow-actions))) Cheers! Tor-björn Den tors 31 okt. 2024 kl 22:48 skrev Tor-björn Claesson : > > Thanks! > > Here is another take=) > > (defcustom org-cite

Re: Org-cite: Replace basic follow-processor with transient menu?

2024-10-29 Thread Tor-björn Claesson
This is a great learning experience, thank you Ihor and Jonas for the friendly feedback! (defcustom org-cite-basic-follow-actions '[["Open" ("b" "bibliography entry" org-cite-basic-goto (list (transient-scope) 0))] ["Copy" ("d" "DOI" org-cite-basic-follow.copy-doi)] ["Brow

Re: Org-cite: Replace basic follow-processor with transient menu?

2024-11-10 Thread Tor-björn Claesson
Den lör 9 nov. 2024 kl 16:07 skrev Ihor Radchenko : > > Would it make sense to add two functions for getting the doi and url > > from a citation? That would be generally useful, and simplify the > > transient menu specification. > > Do you mean opening citation URL derived from URL/DOI fields in br

Re: Org-cite: Replace basic follow-processor with transient menu?

2024-09-24 Thread Tor-björn Claesson
Ihor Radchenko writes: > Tor-björn Claesson writes: > >>> I do think that having extended menus for org-open-at-point could be >>> useful. Not by default, but, for example, with a prefix argument. >>> >> This is a good point, but of much larger scope tha

Re: Org-cite: Replace basic follow-processor with transient menu?

2024-09-17 Thread Tor-björn Claesson
doi.org/"; "" doi))]] (interactive) (transient-setup 'org-cite-basic-follow nil nil :scope (list datum _))) Best regards, Tor-björn Claesson

Re: Fwd: Org-cite: Replace basic follow-processor with transient menu?

2024-11-25 Thread Tor-björn Claesson
Thank you for taking the time to look at this! Ihor Radchenko writes: >> +(defcustom org-cite-basic-follow-actions >> + '[["Open" >> + ("b" "bibliography entry" (org-cite-basic-goto !citation !prefix))]] >> + "Actions in the `org-cite-basic-follow' transient menu. >> + >> +This option uses

Re: [RFC] The best way to choose an "action" at point: context-menu-mode, transient, which-key or embark?

2024-12-24 Thread Tor-björn Claesson
Excellent! I'll finish the citation follower prototype, so we know what kind of shape we are aiming for:) Merry christmas! Torbjörn Den tis 24 dec. 2024 09.17Juri Linkov skrev: > > What I am leaning towards now (although, I hope that more ideas can > > still surface in this thread), is simply r

Re: Fwd: Org-cite: Replace basic follow-processor with transient menu?

2024-12-11 Thread Tor-björn Claesson
> Two comments here: > 1. It should not be a lambda. Better have a function or even command > 2. The logic is not right. You should better follow >`org-cite-basic--key-completion-table': >`org-cite-basic--parse-bibliography', `org-cite-basic--get-entry', >and `org-cite-basic--get-field'

Re: Fwd: Org-cite: Replace basic follow-processor with transient menu?

2024-12-11 Thread Tor-björn Claesson
Ihor Radchenko writes: >> +(defcustom org-cite-basic-follow-actions >> + '[["Open" >> + ("b" "bibliography entry" (org-cite-basic-goto !citation !prefix))] >> +["Copy" >> + ("d" "DOI" >> + (kill-new >> + (save-excursion >> + (with-temp-buffer >> + (mapc #'

Fwd: Org-cite: Replace basic follow-processor with transient menu?

2024-11-17 Thread Tor-björn Claesson
Ihor Radchenko writes: > Tor-björn Claesson writes: > >> Den tis 12 nov. 2024 kl 20:02 skrev Ihor Radchenko : >>> >>> I am not sure if it is a good idea. >>> Commands in org-cite-basic-follow-actions may or may not need it, while >>> your code w

Re: [RFC] The best way to choose an "action" at point: context-menu-mode, transient, which-key or embark?

2025-01-26 Thread Tor-björn Claesson
Hi! (I'm trying to send this again, since it hasn't shown up in the list archives for a week.) Den sön 19 jan. 2025 kl 15:32 skrev Ihor Radchenko : > It looks like we got no more ideas other than what have been already > discussed. > > So, my tentative plan is the following: > Sounds good! > >

Re: [RFC] The best way to choose an "action" at point: context-menu-mode, transient, which-key or embark?

2024-12-22 Thread Tor-björn Claesson
Hi! Thanks all for the great discussion! Just so I understand: we are talking about simple cases of offering multiple actions (possibly on objects), and not more complex things such as the export menu, with async options etc? > Tentatively, I am thinking about the following: > > For a given Emac

Re: [RFC] The best way to choose an "action" at point: context-menu-mode, transient, which-key or embark?

2025-02-21 Thread Tor-björn Claesson
Thanks! I have some questions. Den tis 28 jan. 2025 kl 20:18 skrev Ihor Radchenko : > > Thanks! > Here are more comments: > > 1. I am looking at C-- C-u prefix, and I am not sure if it is ideal >What I think might be better is: >- make a short C-- ('- argument) the switch >- make the

Re: [RFC] The best way to choose an "action" at point: context-menu-mode, transient, which-key or embark?

2025-02-22 Thread Tor-björn Claesson
Thanks again, I'll be back :-) Cheers, Torbjörn Den lör 22 feb. 2025 16.18Ihor Radchenko skrev: > Tor-björn Claesson writes: > > >> 1. I am looking at C-- C-u prefix, and I am not sure if it is ideal > >>What I think might be better is: > >>- mak

Re: [RFC] The best way to choose an "action" at point: context-menu-mode, transient, which-key or embark?

2025-02-27 Thread Tor-björn Claesson
ry to follow citations. Cheers Tor-björn Den lör 22 feb. 2025 kl 21:41 skrev Tor-björn Claesson : > Thanks again, I'll be back :-) > > Cheers, > Torbjörn > > Den lör 22 feb. 2025 16.18Ihor Radchenko skrev: > >> Tor-björn Claesson writes: >> >> >&g

Re: [RFC] The best way to choose an "action" at point: context-menu-mode, transient, which-key or embark?

2025-03-17 Thread Tor-björn Claesson
er, during runtime. Something like `(progn (setq ..) > (transient-define-prefix ...)) Thanks! I was wondering how to to (begin ...) in elisp=) This still does not fix the problem for some reason, I will dig some more! > Tor-björn Claesson writes: > >> It adds om.el, which contains the sta