[PATCH] Use completing-read-multiple for org-set-tags-command

FSF documents (I have packages on ELPA). Clemens >From c8be9106110f266db774d73af4dcb6fbcef3bef8 Mon Sep 17 00:00:00 2001 From: Clemens Radermacher Date: Sun, 19 Jul 2020 14:30:37 +0200 Subject: [PATCH] org.el: Use `completing-read-multiple' for `org-set-tags-command' * lisp/or

Re: [PATCH] Use completing-read-multiple for org-set-tags-command

I just noticed org has a test suit *surprise*. With my patch it fails, sorry for that I will look into it and update. Clemens

Re: [PATCH] Use completing-read-multiple for org-set-tags-command

I just noticed org has a test suit *surprise*. With my patch it fails, sorry for that I will look into it and update.     Clemens I updated the tests and it's working now. Let me know if anything else is missing. Clemens

Re: [PATCH] Use completing-read-multiple for org-set-tags-command

Find the updated patch attached. Clemens >From 1b50d7450fb23110603792e63c329d7db3115ae8 Mon Sep 17 00:00:00 2001 From: Clemens Radermacher Date: Sun, 19 Jul 2020 14:30:37 +0200 Subject: [PATCH] org.el: Use `completing-read-multiple' for `org-set-tags-command' * lisp/or

Re: [PATCH] Use completing-read-multiple for org-set-tags-command

> Note, though, that org-set-tags-command already supports completing > multiple tags through org-tags-completion-function, which it passes as > the COLLECTION argument to completing-read. In order to see that in > action, you may need to tell the completion library you use to fall back > to the

Re: [PATCH] Use completing-read-multiple for org-set-tags-command

With the built-in completion, org-set-tags-command already supports completing multiple tags. Interesting, I couldn't figure out how. I tried with emacs -Q (v 26.3) and I get only completion for the first tag. If you try to get completion after entering the first you get an [no match] message

Re: [PATCH] Use completing-read-multiple for org-set-tags-command

Sorry, I just figured out you get indeed completion after the first tag my sandbox wasn't clean (usually that shouldn't affect the completion behavior but somehow it did, I have to check why). In this case your are also right that `org-tags-completion-function` need to be adjusted. My patch sti

Re: [PATCH] Use completing-read-multiple for org-set-tags-command

Now that I know that completion works for multiple tags with default completion I'm unsure if it is worth to proceed with this. I wondered how this would go unnoticed for such a long time in org and now I know that the failure was on my part. On the other hand switching to `completing-read-mult