Re: org-timer: let done hook access time, allow silencing notification

2025-01-12 Thread Ihor Radchenko
"Stefan van der Walt" writes: >>> Could we reset the variable *after* the hooks are run instead, so that they >>> can access the timer value? >> >> Yes, that would make sense. See the attached tentative patch. > > Thanks, Ihor! That patch looks great. In the description: `ran` -> `run`. Applied,

Re: [BUG] Bug with org-open-at-point [9.6.15 (release_9.6.15 @ /usr/share/emacs/29.4/lisp/org/)]

2025-01-12 Thread Ihor Radchenko
Christoph writes: > How to reproduce: Start Emacs -q and load an org-mode file. Try to open > a file link in that org file like file:abc.odt or file:abc.pdf with > org-open-at-point. > > Expected behavior: Emacs opens the file in the external application, > i.e. Libre Office or a pdf viewer lik

Re: [BUG] Cannot tangle src block in capture buffer [9.7.6]

2025-01-12 Thread Derek Chen-Becker
OK, I've attached the patch. It wasn't clear from https://orgmode.org/worg/org-contribute.html#first-patch whether this should be sent in the thread or as a new thread. I can start a new one if needed. Thanks, Derek 0001-ob-tangle-Ensure-proper-tangling-within-a-capture-bu.patch Description: Bi

Re: Cannot yank media when image come from Gnome screenshot

2025-01-12 Thread Ihor Radchenko
Ihor Radchenko writes: >> Ihor> May you create such a patch against Org mode repository? >> >> This week I am a bit busy, so not before middle of next week at the >> earliest. Looks like this thread slipped through the cracks. Robert, are you still interested in creating the patch? -- Ihor

Re: [BUG] "Invalid search bound (wrong side of point)" [9.8-pre (release_9.7.16-169-ge87ecf @ ~/.emacs.d/org-mode-git/lisp/)]

2025-01-12 Thread Paul Stansell
> > Please try and let me know if you still see anything suspicious. > I will do, thanks.

Re: [PATCH v3] Re: [FR] Automatically display images in resutls of evaluation

2025-01-12 Thread Ihor Radchenko
Ihor Radchenko writes: > We need to come up with same safe way to only display inline images in > the results when those images are actually updated interactively. > We might even need a new kind of hook that is given more contextual info > about code evaluation. Any ideas? This patch seems stuc

Re: [BUG] Cannot tangle src block in capture buffer [9.7.6]

2025-01-12 Thread Ihor Radchenko
Derek Chen-Becker writes: > OK, I've attached the patch. It wasn't clear from > https://orgmode.org/worg/org-contribute.html#first-patch whether this > should be sent in the thread or as a new thread. I can start a new one if > needed. Thanks! The same thread is the right place - we want everyth

Re: [PATCH] lisp/org-collector.el: Add support for TBLFM

2025-01-12 Thread Ihor Radchenko
Slava Barinov writes: > The :tblfm keyword adds formulas to the end of table so they are applied right > after collection is done and the table is generated. > > * lisp/org-collector.el (org-dblock-write:propview): Add support for the > :tblfm keyword. Thanks for the patch, and do note that org-

Re: org-babel python lost a feature?

2025-01-12 Thread Jack Kamm
Panayotis Manganaris writes: > Thanks for the sanity check, Ihor. I must have had some piece of > configuration that enabled this for me -- Super useful, I'll share it if > I find it. Perhaps you were using emacs-jupyter [1]? They use drawers to capture multiple results from source blocks. [1]

Re: [PATCH] Fix ox-icalendar export of diary timestamps

2025-01-12 Thread Jack Kamm
Ihor Radchenko writes: > Jack Kamm writes: > >> Ihor Radchenko writes: >> >>> I agree that it makes sense. >>> However, it is technically a breaking change. >>> May you please add a news entry as well? >> >> Thanks, I've updated the patch with a news entry now. > > Thanks! > Applied, onto main.

[ERROR] org-todo [C-c C-t] change task todo state raised error

2025-01-12 Thread stardiviner
When I change a task from "TODO" to "DONE", or "DONE" to "TODO", or other todo keywords with [C-c C-t]. Org mode will raise bellowing error "*randomly*". (I can't reproduce it in stable.) #+begin_example Debugger entered--Lisp error: (args-out-of-range # 0 3092985) replace-match("") (progn (go

Re: [BUG] Cannot tangle src block in capture buffer [9.7.6]

2025-01-12 Thread Derek Chen-Becker
On Sun, Jan 12, 2025 at 9:43 AM Ihor Radchenko wrote: > What if BUFFER is provided, but that buffer is already a base buffer? > Your function will then return file name for _current buffer_, not BUFFER. > Hmmm, I thought I tested that but I can take a look and fix it. > > Also, what about oth