Re: [PATCH] Fixing a regression in org-persists ability to handle non-list container arguments.

2024-09-22 Thread Karthik Chikmagalur
LRA, thanks for the fix. Ihor, `org-persist--find-index' is singularly confusing. I've been over it with edebug a few times and still can't figure out what it's doing, because `container' means different things at different points in the function because of the macro `org-persist-collection-let'.

[PATCH] Async sessions: Fix prompt removal regression in ob-R

2024-09-22 Thread Jack Kamm
Consider the following R block, which prints the occurrences of each element in a list, including NAs: #+begin_src R :session :results output :async table(c("ab","ab","c",NA,NA), useNA='always') #+end_src #+RESULTS: : abc :212 Since Org 9.7, it instead prints: #+RESULTS: :

org2blog 20230501.2319 from melpa gets strange formatting on diff of HTML file

2024-09-22 Thread Steinar Bang
Versions: debian 12.7 bookworm, amd64 GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-07-22, modified by Debian Org mode version 9.6.15 (release_9.6.15 @ /usr/share/emacs/29.4/lisp/org/) org2blog 20230501.2319 from me

Re: [PATCH v6] Inline image display as part of a new org-link-preview system

2024-09-22 Thread Karthik Chikmagalur
Latest version attached. >> If you think it's a good idea, I can add pending previews to the queue >> in a LIFO fashion instead, so that if you call `org-link-preview' in two >> different sections before the first one is done previewing, the later >> one is processed first. > > Yes, it would make

Re: Org-Capture Window Behavior

2024-09-22 Thread Amol Vaidya
What a silly error on my part. Thank you for your time. Apologies about it being something so simple that I did not see. On Sun, Sep 22, 2024 at 12:45 PM Ihor Radchenko wrote: > Amol Vaidya writes: > > > I'm curious, then, why would what I've done in Test 2 nor corral it? > > > > (add-to-list

Re: Org-Capture Window Behavior

2024-09-22 Thread Ihor Radchenko
Amol Vaidya writes: > I'm curious, then, why would what I've done in Test 2 nor corral it? > > (add-to-list 'display-buffer-alist '("\\*CAPTURE*" > (display-buffer-same-window))) Oops. I missed that part. It does not work for very simple reason - "\\*CAPTURE*" regexp does not match buffer name

Re: Differentiating org element properties from built-ins?

2024-09-22 Thread tomas
On Sun, Sep 22, 2024 at 05:15:25PM +, Ihor Radchenko wrote: > writes: > > > I do see foo and bar (well, OK, :FOO and :BAR) with their values, but lots > > of other (let's call them "built-ins") like :begin and :post-affiliated. > > > > How do I keep those apart? Or do I have to resort to runn

Re: [PATCH] Fixing a regression in org-persists ability to handle non-list container arguments.

2024-09-22 Thread Ihor Radchenko
l...@phdk.org writes: > And it is *with* the attachment. Thanks! Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=a8790ed09e I also added you to the contributor list. https://git.sr.ht/~bzg/worg/commit/466cfcf2 P.S. We really need tests for org-persist. -- I

Re: [BUG] org-id-find might change the major-mode of a buffer [9.8-pre (release_9.7.8-713-g62cbac @ /home/viz/lib/emacs/straight/build/org/)]

2024-09-22 Thread Visuwesh
[ஞாயிறு செப்டம்பர் 22, 2024] Ihor Radchenko wrote: > Visuwesh writes: > >> The patch below is what I had in mind. With it, I can no longer >> reproduce the recipe above. >> ... > > The patch looks reasonable. > May you format it properly, adding a proper commit message? See > https://orgmode.org

Re: [BUG] org-id-find might change the major-mode of a buffer [9.8-pre (release_9.7.8-713-g62cbac @ /home/viz/lib/emacs/straight/build/org/)]

2024-09-22 Thread Ihor Radchenko
Visuwesh writes: > The patch below is what I had in mind. With it, I can no longer > reproduce the recipe above. > ... The patch looks reasonable. May you format it properly, adding a proper commit message? See https://orgmode.org/worg/org-contribute.html#commit-messages -- Ihor Radchenko //

[BUG] Regression: org-duration fails to support duration ranges since Org 9.0.6 (was: support range durations)

2024-09-22 Thread Ihor Radchenko
Guido Stevens writes: >> May you please provide more details on how to trigger the error? > > Sure. I'm providing the Doom keybindings for the actions I'm taking. > > 1. Abbreviated snippet from my Doom config: > > (use-package! org >:defer t >(setq! > org-global-properties > `(("

Re: [BUG] What about excluding .dir-locals.el from GNU ELPA tarball?

2024-09-22 Thread Ihor Radchenko
Morgan Willcock writes: >> I do not see any downside of adding this to .dir-locals.el file. >> Would you mind submitting a patch? > > I've attached a patch. Thanks! Applied, onto bugfix, with amendments. I changed the commit message adding TINYCHANGE cookie (I do not see your FSF copyright assig

Re: Org-Capture Window Behavior

2024-09-22 Thread Ihor Radchenko
Amol Vaidya writes: > (Apologies for replying to this twice Ihor, forgot to reply-all last time.) > > The linked video was from an emacs -q, so I have made no modifications to > display-buffer-alist, and my understanding is that emacs -q is equivalent > to an empty init file. If that's not correc

Re: [BUG] org-refile-get-targets wrong-type-argument [9.6.15 (release_9.6.15 @ /Applications/Emacs.app/Contents/Resources/lisp/org/)]

2024-09-22 Thread Ihor Radchenko
[ Adding Org mailing list back to the CC ] > -(defun my-org-opened-buffer-files () > - "Return the list of org files currently opened in Emacs." > - (delq nil > -(mapcar (lambda (x) > - (if (and (buffer-file-name x) > - (string-match "\\.org$" >

Re: [PATCH] Add repeat-map for navigation commands

2024-09-22 Thread Ihor Radchenko
Visuwesh writes: > Please find attached. I tried my best to write the manual entry but it > still reads awkward. Thanks! > * lisp/org-keys.el (org-up-heading): Add new alias for > outline-up-heading. Please quote Elisp symbols as `outline-up-heading'. > +** Repeating commands > +:PROPERTIES:

Re: Org-cite: Replace basic follow-processor with transient menu?

2024-09-22 Thread Ihor Radchenko
Tor-björn Claesson writes: >> I do think that having extended menus for org-open-at-point could be >> useful. Not by default, but, for example, with a prefix argument. >> > This is a good point, but of much larger scope than just replacing the > follower of the basic citation-processor. No probl

Re: Org-Capture Window Behavior

2024-09-22 Thread Amol Vaidya
Hello, Again, I apologize for sending this email to you twice Ihor. I keep forgetting to hit reply-all. Anyway... Thank you for your clarification. Just a minor point: my concern is that org-capture is not adhering to general display-buffer settings rather than specifically display-buffer-alist.

Re: Org-Capture Window Behavior

2024-09-22 Thread Ihor Radchenko
Amol Vaidya writes: > Thank you for your clarification. Just a minor point: my concern is that > org-capture is not adhering to general display-buffer settings rather than > specifically display-buffer-alist. In my case display-buffer-alist is nil > when I run emacs -q, but according to section 2

Re: WORG commit o-c/b/l/ob-doc-elisp.org: add new section on tangling and :var

2024-09-22 Thread Ihor Radchenko
Hi, I am looking at the commit https://git.sr.ht/~bzg/worg/commit/1ba9e8397571da0e3297994b6f2c3518602c78e9 and wondering if it fits babel backend documentation scope. It currently reads like a blog post describing some bug/design problem with ob-emacs-lisp. In a view of the problems you described

Re: [FR] yank media: allow customization of absolute path a filter for type candidates

2024-09-22 Thread Pedro
On 2024-09-22 10:01, Visuwesh wrote: I am leaning towards doing it in the Emacs side since it would get rid of similar annoyance(s) in other yank-media handlers, not just Org. If no one beats me to it before the end of this week, I will propose a patch to take care of (1). It would be preferabl

Re: What is the difference between :raw-value and :title?

2024-09-22 Thread Ihor Radchenko
mb...@mbork.pl writes: > I am reading the Org element API docs and I don't understand the > difference between :raw-value of a headline and its :title. I performed > a few experiments with putting various things in the headline > (timestamps, links, markup) to find a case where these two differ,

Re: please, report on current status of orgmode timestamps with timezone

2024-09-22 Thread Ihor Radchenko
pinmacs writes: > From #11 OrgMeetup content [1] I see that a date with timestamp and > timezone is used: > >     <2024-09-11 Wed 19:00-21:00 @+03,Europe/Istanbul> > ... > Is this something is going to arrive on 9.8 ? Is this something that > only works in development version? This is an ide

Re: [PATCH] put `org-attach-after-change-hook` at the end of org-attach

2024-09-22 Thread Ihor Radchenko
"Christopher M. Miles" writes: > Subject: [PATCH] org-attach.el: put org-attach-after-change-hook at the end > > lisp/org-attach.el (org-attach-attach): Put org-attach-after-change-hook > at the end to make sure user can access attach link in org-store-links. I have no problem with the change, b

Re: Should "org-element-parse-buffer" check whether the buffer's major mode is org mode?

2024-09-22 Thread Ihor Radchenko
Antonio Romano writes: > The situation is a bit more complex than I imagined and am not > experienced enough to have a strong opinion on the matter. If things > are to stay as they are right now, I guess emphasizing even more in the > docstring that this function may have undefined behavior in di

Re: org-cut-subtree should respect org-ctrl-k-protect-subtree

2024-09-22 Thread Ihor Radchenko
Rudolf Adamkovič writes: >> May you list the editing commands that you think can benefit from an >> extra confirmation dialog? > > Me? I regularly archive subtrees by mistake. :) You can re-bind C-c C-x C-a to `org-archive-subtree-default-with-confirmation' then. >> ... which are `org-ctrl-k-p

Re: [BUG] export blocks no longer fontifying [9.7.10 (release_9.7.10 @ /Users/ben/Scripts/emacs/lisp/org/)]

2024-09-22 Thread Ihor Radchenko
[ Adding Org mailing list back to CC to keep the conversation public ] Benjamin McMillan writes: > Dear Ihor, > I am happy to make the changes. > I am not sure what exactly made the last commit message read like a new > feature, but hopefully the following is better: > lisp/org.el: Add "export"

Re: [PATCH] Fix ox-icalendar export of diary timestamps

2024-09-22 Thread Ihor Radchenko
Jack Kamm writes: > Ihor Radchenko writes: > >> I agree that it makes sense. >> However, it is technically a breaking change. >> May you please add a news entry as well? > > Thanks, I've updated the patch with a news entry now. Thanks! Applied, onto main. https://git.savannah.gnu.org/cgit/emacs

Re: [BUG] org-id-find might change the major-mode of a buffer [9.8-pre (release_9.7.8-713-g62cbac @ /home/viz/lib/emacs/straight/build/org/)]

2024-09-22 Thread Visuwesh
[ஞாயிறு செப்டம்பர் 22, 2024] Ihor Radchenko wrote: > Visuwesh writes: > >>> The patch looks reasonable. >>> May you format it properly, adding a proper commit message? See >>> https://orgmode.org/worg/org-contribute.html#commit-messages >> >> Please find attached. > > Thanks! > Applied, onto main

Re: [BUG] org-id-find might change the major-mode of a buffer [9.8-pre (release_9.7.8-713-g62cbac @ /home/viz/lib/emacs/straight/build/org/)]

2024-09-22 Thread Ihor Radchenko
Visuwesh writes: >> The patch looks reasonable. >> May you format it properly, adding a proper commit message? See >> https://orgmode.org/worg/org-contribute.html#commit-messages > > Please find attached. Thanks! Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id

Re: [PATCH] Add repeat-map for navigation commands

2024-09-22 Thread Ihor Radchenko
Visuwesh writes: >> 1. You can link to "9.11 Repeating a Command" section of Emacs manual > > Can you please tell how to link to an Info node? I see two different > style of linking to another manual in Introduction/Activation and I'm > confused. I do not know how ox-texinfo works. [[info:emac

Re: Archiving always adds a newline before entries

2024-09-22 Thread Ihor Radchenko
"John Wiegley" writes: > I like to avoid blank lines between Org-mode entries, but have found that when > archiving (and not use datetrees), that this is not supported by Org-mode > out-of-the-box. Mainly it’s due to these lines: > ... > ;; Subtree narrowing can let the buffer end on >

Re: [PATCH] Texinfo: Check for math support without warnings and quietly (was: Improve Texinfo math checking)

2024-09-22 Thread Ihor Radchenko
Rudolf Adamkovič writes: > Subject: [PATCH] ox-texinfo: Check for math support without warnings and > quietly > > * lisp/ox-texinfo.el (org-texinfo-supports-math-p): Two > improvements: (1) Fix the incorrect `.info' extension used for the > temporary `.texi' file. This removes the warning "make

Re: [PATCH] fix org-babel-view-src-block-info

2024-09-22 Thread Ihor Radchenko
Rodrigo Morales writes: > This is one of the first patches that I sent to the Org Mode > project. Please let me know if I have done something wrong, so > that I don't make the same mistake in the future. > > From 4453277ee0d9aa6318008a21c4f3f9b16d29c901 Mon Sep 17 00:00:00 2001 > From: Rodrigo Mo

Re: [FR] yank media: allow customization of absolute path a filter for type candidates

2024-09-22 Thread Ihor Radchenko
Visuwesh writes: >> 1. do a variable for selecting absolute path: to be able to have a file >> link that works with absolute path; and the reason is that being >> relative, this, does not combine good when you move your latex export >> somewhere else (in my case, I usually move it to /tmp/, a

Re: [PATCH] Add repeat-map for navigation commands

2024-09-22 Thread Visuwesh
[ஞாயிறு செப்டம்பர் 22, 2024] Ihor Radchenko wrote: > Visuwesh writes: > >> Please find attached. I tried my best to write the manual entry but it >> still reads awkward. > > Thanks! > >> * lisp/org-keys.el (org-up-heading): Add new alias for >> outline-up-heading. > > Please quote Elisp symbols

Re: [FR] yank media: allow customization of absolute path a filter for type candidates

2024-09-22 Thread Visuwesh
[ஞாயிறு செப்டம்பர் 22, 2024] Ihor Radchenko wrote: > Visuwesh writes: >>> 1. do a variable for selecting absolute path: to be able to have a file >>> link that works with absolute path; and the reason is that being >>> relative, this, does not combine good when you move your latex export >>> s

Re: Differentiating org element properties from built-ins?

2024-09-22 Thread Ihor Radchenko
writes: > I do see foo and bar (well, OK, :FOO and :BAR) with their values, but lots > of other (let's call them "built-ins") like :begin and :post-affiliated. > > How do I keep those apart? Or do I have to resort to running regexps through > the buffer? (defun org-element-headline-parser (&o

Re: How to treat events (headlines) without a title?

2024-09-22 Thread Ihor Radchenko
mb...@mbork.pl writes: > I have a bunch of entries in my agenda that don't have /titles/. I > enrolled in a school which has classes on Saturdays, usually every two > weeks, but this is not very rigid. So I need a separate headline per > Saturday: > > ** School on Super Important Stuff > <2

Re: Org-Capture Window Behavior

2024-09-22 Thread Amol Vaidya
I'm curious, then, why would what I've done in Test 2 nor corral it? (add-to-list 'display-buffer-alist '("\\*CAPTURE*" (display-buffer-same-window))) On Sun, Sep 22, 2024 at 12:00 PM Ihor Radchenko wrote: > Amol Vaidya writes: > > > Thank you for your clarification. Just a minor point: my con