Re: [BUG][SECURITY] ob-sqlite header args allows execution of arbitrary shell commands

2023-08-28 Thread Max Nikulin
On 22/08/2023 16:46, Ihor Radchenko wrote: See the updated version of the patches attached. Thank you, I do not see apparent issues with code any more. Commit message needs an update, apostrophes in the doc string should be escaped. Feel free to ignore other comments since there are other iss

Re: [BUG] FAILED test-ob-python/session-multiline

2023-08-28 Thread Ihor Radchenko
Jack Kamm writes: > This one might take some time to fix, since it's hard to reproduce and > I'm not sure the cause of it. But here are 3 different solutions I am > considering now: > > 1. In addition to printing `org-babel-python-eoe-indicator' after >execution, we could also print out a "be

Re: Warning(diary.org_archive): Got element without parent (cache active?: t)

2023-08-28 Thread Ihor Radchenko
Gregor Zattler writes: > I got these warnings when I followed an id: link > (org-open-at-point) within diary.org > > I have no idea why diary.org_archive was opened at that > time. The following is the complete contents of the > *Warnings* buffer at the moment: Thanks! This is again bizarre. Th

Re: [PATCH] Fix a possibly problematic string comparison

2023-08-28 Thread Ihor Radchenko
Rudolf Adamkovič writes: > * lisp/org-table.el (org-table-make-reference): Replace 'eq' with > 'string-empty-p' to resolve "Warning: 'eq' called with literal string > that may never match" issued on every 'make' invocation. > > - (if (and (eq elements "") (not keep-empty)) > + (if

Re: [BUG] Warning when creating preview

2023-08-28 Thread Ihor Radchenko
Edgar Lux writes: > On Aug 27, 2023 at 7:29 PM, Ihor Radchenko wrote: >> I recommend https://github.com/Malabarba/elisp-bug-hunter to narrow down >> which part of the config is the culprit. > > We have a winner: > > ;; Bug hunter error --- > ;; https://github.com/nicolaisingh/saveplace-pdf-view.

Re: [BUG] ob-python hangs on second start [9.5.4 (release_9.5.4-763-g06373a @ ~/emacs/org-mode/lisp/)]

2023-08-28 Thread Ihor Radchenko
Jack Kamm writes: > I think `python-shell-first-prompt-hook' is actually still triggered, > but rather it is `org-babel-comint-wait-for-output' that is hanging > while waiting for startup. However, we can just replace it with a > `sleep-for' instead, because we now wait for > `org-babel-python--i

Re: Text markup and TeX-style LaTeX fragments spanning more than three lines

2023-08-28 Thread Ihor Radchenko
"Tom Alexander" writes: > The documentation for both text markup and TeX-style LaTeX fragments states > that their contents (CONTENTS for text markup, BODY for TeX-style LaTeX > fragments) cannot span more than three lines, but I'm not seeing such > limitation for either in practice. I don't k

Re: [BUG] When calling org-tree-to-indirect-buffer: (wrong-type-argument listp org-fold-outline) in org-fold-core-get-folding-spec-from-alias [9.6.6 (release_9.6.6 @ /gnu/store/c7vqk20kf6zw73klr8bacnh

2023-08-28 Thread Ihor Radchenko
Adam Porter writes: >> This is a very strange backtrace. >> When I run that `alist-get' call manually, there is no error. And >> `alist-get' does not call `car'. >> >> May you try to re-generate the backtrace again? > > It is indeed strange. I generated the backtrace several times over > sever

Re: [FR] Aligning paragraphs in lists

2023-08-28 Thread Ihor Radchenko
Maske writes: > Could be used M-right or M-left to align paragraphs which are > immediately below a list? > ... > If there are subitems, the text could be needed to be aligned below a > superior item, and this must be done in a manual way: > + Item 1 >   Text indented, belongs to Item 1. >   

Re: What do you recommend for acronyms in org-mode?

2023-08-28 Thread John Kitchin
It is hard to say what the issue is without some working example that shows performance issues. Usually getting better performance means compromising some functionality, e.g. not validating citation keys (this requires some lookup which could take time for large documents/bibtex files), etc. There

Re: [PATCH] Fix a possibly problematic string comparison

2023-08-28 Thread Rudolf Adamkovič
Ihor Radchenko writes: > This is not as trivial. Applying this patch will break tests. > One needs to carefully examine the org-table logic to fix this > particular warning. Wow! You are right. How is that even possible? In other words, what value (of 'elements') can possibly be object-equal

[BUG][org-map-entries] Using (widen) in FUNC when SCOPE is equal to 'tree iterates through headlines outside the tree

2023-08-28 Thread Rodrigo Morales
The following result is expected behavior. We iterate through all headlines starting at headline =* 1=. #+HEADER: :results value #+HEADER: :results verbatim #+begin_src elisp (with-temp-buffer (org-mode) (insert "* 1 ,** 1.1 ,** 1.2 ,** 1.3 ,* 2 ,** 2.1 ,** 2.2 ,** 2.3 ") (goto-char (poin

Re: [PATCH] Fix a possibly problematic string comparison

2023-08-28 Thread Ihor Radchenko
Rudolf Adamkovič writes: > Ihor Radchenko writes: > >> This is not as trivial. Applying this patch will break tests. >> One needs to carefully examine the org-table logic to fix this >> particular warning. > > Wow! You are right. How is that even possible? In other words, what > value (of 'el

Re: [Pre-PATCH] Overhaul of the LaTeX preview system

2023-08-28 Thread Roshan Shariff
Hi Timothy and Karthik, Thanks for your wonderful work on this feature! I've been using it for several weeks and it's been working extremely well in my experience. I noticed a small visual glitch when inline latex previews wrap to the next line, that is apparent when org-highlight-latex-and-rela

[PATCH 1/1] Fix background color when line-wrapping latex previews

2023-08-28 Thread Roshan Shariff
If latex code is fontified with a face that has the :extend attribute, and the preview overlay wraps to the next line, then the empty space after the end of the line uses the background color of the latex code rather than that of the surrounding text. For example, setting org-highlight-latex-and-r