Re: org-babel support for haxe

2020-09-30 Thread ian martins
I wrote the ob-core patch I mentioned before but white writing the commit message I realized there's probably no need to modify ob-core at all. I was doing it in order to allow haxe and java to create subdirectories in the babel temp directory since both languages require class names to match file

Re: org-babel support for haxe

2020-09-24 Thread ian martins
with ob-java I assumed I shouldn't change ob-core, so I advised/overrode ob-core instead of changing it. But it would be much better to change ob-core. I'll submit those changes as a separate patch that modifies ob-core. On Sun, Sep 13, 2020 at 4:04 PM Kyle Meyer wrote: > ian martins writes: > >

Re: org-babel support for haxe

2020-09-13 Thread Kyle Meyer
ian martins writes: > ob-haxe and ob-java both involve a few changes to ob-core to allow temp > directories instead of just temp files. Should I submit that as a separate > patch? It looks like that change is included with your ob-java patch [0], which will be considered after 9.4 is released [1]

Re: org-babel support for haxe

2020-09-12 Thread ian martins
Thanks for the feedback. There's no special reason for the external test data file or repeated executable-find calls. I was following the convention from ob-C. I'll make those changes. ob-haxe and ob-java both involve a few changes to ob-core to allow temp directories instead of just temp files. S

Re: org-babel support for haxe

2020-09-06 Thread Kyle Meyer
Hi ian, It looks like this library is instead going to be available through an ELPA, but FWIW here are a couple of comments on the tests. ian martins writes: > diff --git a/testing/examples/ob-haxe-test.org > b/testing/examples/ob-haxe-test.org > new file mode 100644 > index 0..ba9119d5

Re: org-babel support for haxe

2020-09-05 Thread ian martins
artins writes: > > > Hello. The included patch adds org-babel support for haxe (https:// > > haxe.org/). It allows main class and function definitions to be > > optional, accepts variables and supports babel functional mode. > > Please review. > > I'm not an Hax

Re: org-babel support for haxe

2020-09-05 Thread Bastien
Hi Ian, ian martins writes: > Hello. The included patch adds org-babel support for haxe (https:// > haxe.org/). It allows main class and function definitions to be > optional, accepts variables and supports babel functional mode. > Please review. I'm not an Haxe user, so I

org-babel support for haxe

2020-06-11 Thread ian martins
Hello. The included patch adds org-babel support for haxe (https://haxe.org/). It allows main class and function definitions to be optional, accepts variables and supports babel functional mode. Please review. I believe the same approach should work for java also. If this is fine I could try to