Re: correct remote path handling

2020-02-29 Thread Jack Kamm
Hi Felipe, It looks like you've made some quite substantial changes to ob-shell. I think it would be a good idea to split this up into 2 patches, and to start a new thread for the ob-shell patch. I'm not as familiar with ob-shell, and it's also had some work lately. So it'd be good to get some m

Re: correct remote path handling

2020-02-26 Thread Felipe Lema
Hey, y'all I found out that ob-shell was more broken than I thought so I had to upgrade my sword and get a new shield to fix it. Tramp support for ob-python and ob-shell look OK now, although still no tests. I'll wait until this review is done until I start working on the tests. Will probably

Re: correct remote path handling

2020-02-25 Thread Bastien
Hi Felipe and Jack, > Felipe Lema writes: > >> I've signed the necessary papers from (to?) the FSF involving org >> mode, so I'm ready on my side to add tests and maybe add support >> for other tramp-related stuff. I've checked and the papers are not yet processed by the FSF. > Great, we should

Re: correct remote path handling

2020-02-25 Thread Jack Kamm
Hi Felipe, Felipe Lema writes: > I bumped into a problem running src blocks using a remote (tramp) :dir. I've > looked into it and found that the problem is that a temporary file is passed > as a remote path to the remote process (temp file should be local to remote > process). Thanks for fi

correct remote path handling

2020-02-24 Thread Felipe Lema
Hello, there I bumped into a problem running src blocks using a remote (tramp) :dir. I've looked into it and found that the problem is that a temporary file is passed as a remote path to the remote process (temp file should be local to remote process). I'm attaching fixes for python and shell