Re: URLs with brackets not recognised

2021-05-15 Thread Bastien
Ihor Radchenko writes: > Oops. Just realised that you already applied it. Sorry for the > noise. My bad, I thought your patch was fixing only part of the OP issue, I see now it fixes all of it. Thanks! -- Bastien

Re: URLs with brackets not recognised

2021-05-15 Thread Ihor Radchenko
Oops. Just realised that you already applied it. Sorry for the noise. Ihor Radchenko writes: > Bastien writes: >> Patch welcome, with the caveat that fixing this is more difficult than >> it seems, as the thread suggests. > > I have provided the patch in [1]. Are there any issues with it? > > [

Re: URLs with brackets not recognised

2021-05-15 Thread Ihor Radchenko
Bastien writes: > Patch welcome, with the caveat that fixing this is more difficult than > it seems, as the thread suggests. I have provided the patch in [1]. Are there any issues with it? [1] https://orgmode.org/list/87v99g4p3m.fsf@localhost/ Best, Ihor

Re: URLs with brackets not recognised

2021-05-15 Thread Bastien
Hi Colin, Colin Baxter writes: > https://en.wikipedia.org/wiki/Cathedral_Basilica_of_St._John_the_Baptist_(Savannah,_Georgia) I agree this is annoying. Patch welcome, with the caveat that fixing this is more difficult than it seems, as the thread suggests. -- Bastien

Re: URLs with brackets not recognised

2021-05-13 Thread Maxim Nikulin
On 13/05/2021 03:06, Rudolf Adamkovič wrote: Maxim Nikulin writes: I do not think it is a bug. Plain text links detection is a kind of heuristics. It will be always possible to win competition with regexp. Consider it as a limitation requiring some hints from an intelligent user. I disagree.

Re: URLs with brackets not recognised

2021-05-12 Thread Colin Baxter
> Ihor Radchenko writes: > Colin Baxter writes: >> Hello, >> >> If a URL link in an org file contains a bracket then the link is >> not fully recognised and may be misdirected. For example, > This is a known bug [1]. You just need to wait for the patch to be > m

Re: URLs with brackets not recognised

2021-05-12 Thread Tim Cross
Rudolf Adamkovič writes: > Maxim Nikulin writes: > >> I do not think it is a bug. Plain text links detection is a kind of >> heuristics. It will be always possible to win competition with regexp. >> Consider it as a limitation requiring some hints from an intelligent >> user. > > I disagree.

Re: URLs with brackets not recognised

2021-05-12 Thread Ihor Radchenko
Colin Baxter writes: > Hello, > > If a URL link in an org file contains a bracket then the link is not > fully recognised and may be misdirected. For example, This is a known bug [1]. You just need to wait for the patch to be merged. [1] https://orgmode.org/list/87v99g4p3m.fsf@localhost/

Re: URLs with brackets not recognised

2021-05-12 Thread Tom Gillespie
A quick fix is to percent encode the troublesome characters, but the underlying issue is in org-link-any-re which is defined in org-link-make-regexps which is what org uses to find the next link. Some improvements might be possible for some of the edge cases there, but a complete solution for bare

Re: URLs with brackets not recognised

2021-05-12 Thread Rudolf Adamkovič
Maxim Nikulin writes: > I do not think it is a bug. Plain text links detection is a kind of > heuristics. It will be always possible to win competition with regexp. > Consider it as a limitation requiring some hints from an intelligent > user. I disagree. URLs are well-specified. Per RFC 3986,

Re: URLs with brackets not recognised

2021-05-12 Thread Colin Baxter
It might be worthwhile to issue an warning each time a url is written in an org file without enclosing brackets < > or [[ ]].

Re: URLs with brackets not recognised

2021-05-12 Thread Colin Baxter
> Maxim Nikulin writes: > On 12/05/2021 17:38, Nick Savage wrote: >> I can confirm this as a bug. >> On 5/12/21 3:32 AM, Colin Baxter wrote: >>> https://en.wikipedia.org/wiki/Cathedral_Basilica_of_St._John_the_Baptist_(Savannah,_Georgia) > I do not think it is a bug. Pl

Re: URLs with brackets not recognised

2021-05-12 Thread Maxim Nikulin
On 12/05/2021 17:38, Nick Savage wrote: I can confirm this as a bug. > On 5/12/21 3:32 AM, Colin Baxter wrote: https://en.wikipedia.org/wiki/Cathedral_Basilica_of_St._John_the_Baptist_(Savannah,_Georgia) I do not think it is a bug. Plain text links detection is a kind of heuristics. It will

Re: URLs with brackets not recognised

2021-05-12 Thread Nick Savage
I can confirm this as a bug. On 5/12/21 3:32 AM, Colin Baxter wrote: Hello, If a URL link in an org file contains a bracket then the link is not fully recognised and may be misdirected. For example, 1. emacs -Q 2. C-x C-f test.org 3. Insert the URL https://en.wikipedia.org/wiki/Cathedral_Ba

URLs with brackets not recognised

2021-05-12 Thread Colin Baxter
Hello, If a URL link in an org file contains a bracket then the link is not fully recognised and may be misdirected. For example, 1. emacs -Q 2. C-x C-f test.org 3. Insert the URL https://en.wikipedia.org/wiki/Cathedral_Basilica_of_St._John_the_Baptist_(Savannah,_Georgia) 4. Click on the link