Ihor Radchenko writes:
> Stefan Monnier writes:
>
>> OK, changed it to `with-current-buffer`.
>>
>> I pushed the resulting patch (along with three other patches resulting
>> from running the tests) to `scratch/org` on `elpa.git`.
>>
>> You can also find them attached,
>
> Thanks!
>
>> Subject: [
On 20/05/2024 04:24, Stefan Monnier wrote:
Subject: [PATCH 3/4] testing/org-test.el (): Remove dead code
(featurep 'org) is always non-nil here since we have a (require 'org)
further up. I suspect other `require`s nearby could be removed or
moved to toplevel.
Just a guess. Perhaps earlier the
Stefan Monnier writes:
> OK, changed it to `with-current-buffer`.
>
> I pushed the resulting patch (along with three other patches resulting
> from running the tests) to `scratch/org` on `elpa.git`.
>
> You can also find them attached,
Thanks!
> Subject: [PATCH 1/4] (org-*-in-calendar): Prefer
>> I understand it's important in general, but the question is for this
>> specific use of `org-funcall-in-calendar` where all we do (apparently)
>> is to set `cursor-type` which shouldn't require any change to the
>> overlay (nor does it require to `select-window`), or should it?
> No, it should n
Stefan Monnier writes:
>>> - (org-eval-in-calendar '(setq cursor-type nil) t)
>>> + ;; FIXME: Could we use `with-current-buffer' or do we really
>>> + ;; need the `move-overlay' that's in `org-funcall-in-calendar'?
>>> + (org-funcall-in-calendar (lambda () (setq cursor-typ
>> -(org-eval-in-calendar '(setq cursor-type nil) t)
>> +;; FIXME: Could we use `with-current-buffer' or do we really
>> +;; need the `move-overlay' that's in `org-funcall-in-calendar'?
>> +(org-funcall-in-calendar (lambda () (setq cursor-type nil)) t)
>
> `move-over
Stefan Monnier writes:
> The patch below replaces a use of `eval` with `apply`, but along the way
> I wondered about some of the details of `org-eval-in-calendar` (see the
> FIXMEs), the most important of them being: why doesn't it use
> `with-selected-window`?
Thanks!
I do not see any clear rea
The patch below replaces a use of `eval` with `apply`, but along the way
I wondered about some of the details of `org-eval-in-calendar` (see the
FIXMEs), the most important of them being: why doesn't it use
`with-selected-window`?
Assuming the change from `eval` to `apply` is OK, I'll upgrade my p
