[PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode (was: Reconciling org-mode idiosyncrasies with Emacs core)

2020-05-06 Thread Kévin Le Gouguec
Hello folks, Here's a complete patch to make RET and C-j honor electric-indent-mode in org-mode, targeting Org's master branch. >From ec3b06f02aa875b3c78b076e846081ce4560ec18 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Le=20Gouguec?= Date: Tue, 5 May 2020 19:01:07 +0200 Subject: [PATCH

Re: Reconciling org-mode idiosyncrasies with Emacs core

2020-05-04 Thread Kévin Le Gouguec
Nicolas Goaziou writes: > Tests for `org-return' (named "test-org/return") are in the > "test-org.el" file in the "testing/lisp" directory. We only need to test > if electric-indent-mode has an effect, but only in regular cases. Thanks for the pointer! (I forgot to mention that AFAICT, all curr

Re: Reconciling org-mode idiosyncrasies with Emacs core

2020-05-04 Thread Nicolas Goaziou
Hello, Kévin Le Gouguec writes: > I took a stab at making RET obey electric-indent-mode in org-mode. Thank you! > I've got something working; I'd like to ask for a review before moving > on to Changelog and ORG-NEWS entries (and tackling C-j… and maybe > writing a few unit tests?). Tests for

Re: Reconciling org-mode idiosyncrasies with Emacs core

2020-05-04 Thread Kévin Le Gouguec
Hi Nicolas, I took a stab at making RET obey electric-indent-mode in org-mode. I've got something working; I'd like to ask for a review before moving on to Changelog and ORG-NEWS entries (and tackling C-j… and maybe writing a few unit tests?). Here's the patch, with some additional comments belo

Re: Reconciling org-mode idiosyncrasies with Emacs core

2020-04-29 Thread Nicolas Goaziou
Hello, Kévin Le Gouguec writes: > Nicolas Goaziou writes: > >> For example, having RET >> inserting a plain newline would be a disaster in many locations. > > I don't think I've seen anybody advocating for that! If you are > referring to this bit: