Re: ob-clojure session support (was: ob-clojure eval error when has comment at end of code line)

2022-10-30 Thread Ihor Radchenko
Daniel Kraus writes: >> Let me know if you need any help with the fix. > > I feel adding session support for babashka and nbb (and maybe a future > clojure-cli backend) > makes most sense. > Relying on `inf-clojure` would make this task simpler but this is also the > package the least amount of

Re: ob-clojure session support (was: ob-clojure eval error when has comment at end of code line)

2022-10-30 Thread Daniel Kraus
Ihor Radchenko writes: > > If Bastien removed session support, and you do not see any justification, > it was most likely an oversight. We generally avoid feature regressions: > https://bzg.fr/en/the-software-maintainers-pledge/ > > So, if sessions are currently not supported, it should be consi

Re: ob-clojure session support

2022-10-29 Thread Bastien Guerry
Hi Ihor and Daniel, Ihor Radchenko writes: > If Bastien removed session support, and you do not see any justification, > it was most likely an oversight. >From memory, I removed session support in ob-clojure.el because it was too buggy. > We generally avoid feature regressions: > https://bzg.

Re: ob-clojure session support (was: ob-clojure eval error when has comment at end of code line)

2022-10-28 Thread Ihor Radchenko
Daniel Kraus writes: > Looking in the history, Christopher added session support 5 years ago, > then (3 years ago) I see Bastien also adding something with initiate-session > but > then removing all session support the following commit. > I guess something was broken and got removed but stayed i

Re: ob-clojure session support

2022-10-28 Thread Bastien Guerry
Hi Daniel, Daniel Kraus writes: > Does anyone remember what's the status of ob-clojure session > support? I'm randomly connected for the next days so I won't risk a reply here, I hope others can help. -- Bastien