On 07 Apr 2022, Ihor Radchenko wrote:
Karl Fogel writes:
Unfortunately, the 'CONTRIBUTE' file at the top level of the
Org
Mode source tree gives incomplete guidance on commit messages
(it
just says to follow what Emacs does, so I did that). I didn't
realize that
https://orgmode.org/worg/
Karl Fogel writes:
> Unfortunately, the 'CONTRIBUTE' file at the top level of the Org
> Mode source tree gives incomplete guidance on commit messages (it
> just says to follow what Emacs does, so I did that). I didn't
> realize that
> https://orgmode.org/worg/org-contribute.html#commit-messa
On 05 Apr 2022, Ihor Radchenko wrote:
Sorry for not being clear. I was referring to the commit message
- it is
what you commonly see in git log.
Having something like
commit-hash Mark function obsolete & fix spelling of its name
in git log is confusing because it is unclear what the commit
s.el is meant to store general-purpose functions that can be
useful for development of the whole Org mode ecosystem.
If we decide that org-truely-invisible-p stays in org-macs, we should
fix the issue with its name. Renaming requires creating obsolete
function name alias in org-compat.el to make sure
aming sounds reasonable. Just need to define obsolete alias
for the
old name in org-compat.el.
My patch was based on the above, and on the fact that obsolete
(i.e., unused) functions apparently get moved to org-compat.el, at
least based on what I see already in that file.
From: Ihor Radchen
renaming it.
2. Rename it without obsoletion. Then, there is not much point moving
the function definition to org-compat.
> From: Ihor Radchenko
> Subject: Re: Removing obsolete function `org-truely-invisible-p'.
> To: Karl Fogel
> Cc: Org Mode
> Date: Sun, 19 Dec
ssed
whether to remove it entirely, and for now seem to have tentatively
decided not to remove it. See this thread for more details:
From: Ihor Radchenko
Subject: Re: Removing obsolete function `org-truely-invisible-p'.
To: Karl Fogel
Cc: Org Mode
Date: Sun, 19 Dec 2021 17:14:32 +080
Karl Fogel writes:
> Should we just remove `org-truely-invisible-p'? Or at least
> correct the spelling of its name ("truely" should be "truly")?
I feel slightly reluctant about removal. If nothing, this function can
be a reminder about visible-mode and keeping it has little downside.
Though i
idk and will go along with whatever developers decide, but your note
was a good reminder that visible mode can be checked.
also made me wonder if it is possible to move anything from org-macs
out to topic-specific files like org-visibility.el or so? no?
[idk what org visibility functions do what
