Re: Public API change: How to handle function signature change gracefully

2020-04-21 Thread General discussions about Org-mode.
Thanks John and Nicolas. I sort of arrived at the same point with my over-engineered approach and change of public API. modified   lisp/org.el @@ -5081,10 +5081,18 @@ This includes angle, plain, and bracket links." (link (org-element-property :raw-link link-object)) (type (org-element-property :

Re: Public API change: How to handle function signature change gracefully

2020-04-21 Thread John Kitchin
I think what Nicolas suggests is probably the easiest path. Here is one example that does what I think you are looking for. I use a simple string comparison on the contents, you could do something more sophisticated. #+BEGIN_SRC emacs-lisp (defun fruit-link-face (path) (let* ((ln (org-element-co

Re: Public API change: How to handle function signature change gracefully

2020-04-21 Thread Nicolas Goaziou
Hello, Benjamin Andresen writes: > > I would like to change the public API of the :face part of > `org-link-set-parameters': > >     (org-link-set-parameters "file" :face 'org-link) > > My ultimate goal is to have org-links be able to be have their face changed > based on the contents, not j