Ihor Radchenko writes:
> I have no further comments.
> Feel free to push.
Pushed now. Thank you and happy new year!
Jack Kamm writes:
> Thanks for the feedback. I attach a squashed updated patch for part 2.
> You can also see the unsquashed changes at
> https://github.com/jackkamm/org-mode/tree/2024-grouped-weektree-rebase
> ...
I have no further comments.
Feel free to push.
--
Ihor Radchenko // yantar92,
Thanks for the feedback. I attach a squashed updated patch for part 2.
You can also see the unsquashed changes at
https://github.com/jackkamm/org-mode/tree/2024-grouped-weektree-rebase
>> +(defun org-datetree-find-create-entry
> Please also document how `org-datetree-add-timestamp' affects this f
Jack Kamm writes:
> Does `org-element-cache-map' traverse elements in the order they're in
> the buffer? That is something we need for this.
Yes, it does.
You can even edit buffer along the way.
`org-element-cache-map' combines regexp search and parser cache trying
to be as fast as possible.
>
Ihor Radchenko writes:
>> +;; Support the old way of tree placement, using a property
>> +(let ((prop (and legacy-prop (org-find-property legacy-prop
>> + (if prop
>> + (progn
>> +(goto-char prop)
>> +(org-narrow-to-subtree)
>>
Jack Kamm writes:
> I attach a pair of patches for this.
Thanks! See my comments inline.
> +(defun org-datetree-find-create-entry
> +(time-grouping d &optional keep-restriction)
> + "Find or create an entry for date D.
> +TIME-GROUPING specifies the grouping levels of the datetree, and
> +
Ihor Radchenko writes:
> Jack Kamm writes:
>
>>> The API of `org-datetree--find-create' is generally very limiting.
>>> It would be nice to come up with something less limiting.
>>
>> Thanks for the feedback -- I'll start working on something along these
>> lines. Though this might take me a li
Ihor Radchenko writes:
> Jack Kamm writes:
>
>>> The API of `org-datetree--find-create' is generally very limiting.
>>> It would be nice to come up with something less limiting.
>>
>> Thanks for the feedback -- I'll start working on something along these
>> lines. Though this might take me a li
Jack Kamm writes:
>> The API of `org-datetree--find-create' is generally very limiting.
>> It would be nice to come up with something less limiting.
>
> Thanks for the feedback -- I'll start working on something along these
> lines. Though this might take me a little while since the holiday is
>
Ihor Radchenko writes:
>> https://gitlab.com/jackkamm/org-grouped-weektree
>>
>> I'd appreciate feedback on 2 points:
>>
>> 1. Are any of these datetree formats worth upstreaming into org-mode
>>proper?
>
> That would make sense.
>
>> 2. Can we add a public interface for `org-datetree--find-c
Jack Kamm writes:
> https://gitlab.com/jackkamm/org-grouped-weektree
>
> I'd appreciate feedback on 2 points:
>
> 1. Are any of these datetree formats worth upstreaming into org-mode
>proper?
That would make sense.
> 2. Can we add a public interface for `org-datetree--find-create', and
>
11 matches
Mail list logo
