Re: A few changes to test in master

2020-02-07 Thread Bastien
Hi Jack, Jack Kamm writes: > Hmm, I'm experience the problem worse now -- the header is always > getting stuck on the first row it appears on. Also, I'm seeing the > follow error in my *Messages*: A silly oversight on my side (I need a little break.) Fixed. > Sure, see the patch below. Appli

Re: A few changes to test in master

2020-02-07 Thread Jack Kamm
Hi Bastien, Bastien writes: >> I have noticed a new bug, where the header line randomly gets "stuck" >> on some row of the table, so even when I scroll and that row is no >> longer on top of the buffer, that row is still replaced by the header >> line. > > Yes, fixed now. Hmm, I'm experience th

Re: A few changes to test in master

2020-02-07 Thread Bastien
Hi Jack, Jack Kamm writes: > FWIW, I wouldn't mind if this were a global minor mode, I intend to > activate it globally with `org-table-header-line-p'. Well, it only makes sense in org buffers, so activating it through this variable is okay IMO. > Since updating and testing for a few minutes,

Re: A few changes to test in master

2020-02-07 Thread Jack Kamm
Hi Bastien, Bastien writes: >> The variable `org-table-header-line-p' doesn't seem to have any effect >> for me, I find that I need to call "M-x org-table-header-line-mode" even >> when it's set. > > Should be fixed now. Confirmed, it works correctly for me now. >> Also, "M-x org-table-header-

Re: A few changes to test in master

2020-02-04 Thread Fraga, Eric
On Wednesday, 5 Feb 2020 at 08:08, Bastien wrote: > I just fixed the scroll-bar issue, thanks! Confirmed! Many thanks. -- : Eric S Fraga via Emacs 28.0.50, Org release_9.3.2-198-g06d36e

Re: A few changes to test in master

2020-02-04 Thread Bastien
"Fraga, Eric" writes: > Much better. See attached screenshots. One with scroll bar (which I > normally don't have turned on) and one with line numbers (which I do > usually have). I just fixed the scroll-bar issue, thanks! -- Bastien

Re: A few changes to test in master

2020-02-04 Thread Fraga, Eric
On Wednesday, 5 Feb 2020 at 00:21, Bastien wrote: > This should be fixed now, thanks! Much better. See attached screenshots. One with scroll bar (which I normally don't have turned on) and one with line numbers (which I do usually have). >> org-table-header-line-mode: Symbol’s function definit

Re: A few changes to test in master

2020-02-04 Thread Bastien
Hi Jack, Jack Kamm writes: > Bastien writes: > >> - M-x org-table-electric-header-mode RET will display the first row >> of the table at point in the header line when the first row is not >> visible anymore. > > This is great, it's a huge quality-of-life improvement for working with > long

Re: A few changes to test in master

2020-02-04 Thread Bastien
Hi Eric, "Fraga, Eric" writes: > the latest on the table header. With emacs -Q and org from a few > minutes ago, I get the following: > > screendu > > when I open the file, invoke M-x org-table-header-line-mode RET and > scroll down in the attached org file. This should be fixed now, thanks! >

Re: A few changes to test in master

2020-02-03 Thread Jack Kamm
Bastien writes: > - M-x org-table-electric-header-mode RET will display the first row > of the table at point in the header line when the first row is not > visible anymore. This is great, it's a huge quality-of-life improvement for working with long tables. Below are some issues I noticed w

Re: A few changes to test in master

2020-02-03 Thread Fraga, Eric
Bastien, the latest on the table header. With emacs -Q and org from a few minutes ago, I get the following: [screendump-20200204064315.png] when I open the file, invoke M-x org-table-header-line-mode RET and scroll down in the attached org file. Note also that if I invoke the above command befo

Re: A few changes to test in master

2020-02-03 Thread Fraga, Eric
On Monday, 3 Feb 2020 at 09:17, Bastien wrote: > "Fraga, Eric" writes: > >> The header line is now 2 characters to the right of where it should be! >> I have looked at the code briefly but cannot figure out why this would >> be. >> >> I have not seen any difference in behaviour for shrunken col

Re: A few changes to test in master

2020-02-03 Thread Bastien
Hi Eric, "Fraga, Eric" writes: > The header line is now 2 characters to the right of where it should be! > I have looked at the code briefly but cannot figure out why this would > be. > > I have not seen any difference in behaviour for shrunken columns. What is M-x org-version RET ? Can you

Re: A few changes to test in master

2020-02-02 Thread Fraga, Eric
On Friday, 31 Jan 2020 at 21:31, Bastien wrote: > "Fraga, Eric" writes: > >> 1. the header contents are placed at the leftmost column means the first >>row does not align with the table in two cases: >>1. when display-line-number-mode is active and/or >>2. when org-indent-mode is used.

Re: A few changes to test in master

2020-02-02 Thread Bastien
Hi Eric, "Fraga, Eric" writes: > On Friday, 31 Jan 2020 at 17:50, Bastien wrote: >> "Fraga, Eric" writes: >>> 2. the display of the first row does not have column widths adjusted and >>>so the entries do not line up if the table itself has adjusted column >>>widths (C-c TAB). >> >> `org

Re: A few changes to test in master

2020-02-02 Thread Fraga, Eric
On Friday, 31 Jan 2020 at 17:50, Bastien wrote: > "Fraga, Eric" writes: >> 2. the display of the first row does not have column widths adjusted and >>so the entries do not line up if the table itself has adjusted column >>widths (C-c TAB). > > `org-table-automatic-realign' being t by defau

Re: A few changes to test in master

2020-02-01 Thread Bastien
Hi Axel, Axel Kielhorn writes: > I now get: > > Error running timer: (invalid-function (ov (first (overlays-in > (point) (1+ (point)) [10 times] That was due to the use of `if-let' - this should be fixed now. Thanks, -- Bastien

Re: A few changes to test in master

2020-02-01 Thread Axel Kielhorn
> Am 01.02.2020 um 17:39 schrieb Bastien : > > Hi Axel, > > Axel Kielhorn writes: > >> There is another issue when a column is reduced in width by C-C TAB. >> The header line still has the original width, thus the columns are >> not aligned. > > Ah, I know understand - this should be fixed

Re: A few changes to test in master

2020-02-01 Thread Bastien
Hi Axel, Axel Kielhorn writes: > There is another issue when a column is reduced in width by C-C TAB. > The header line still has the original width, thus the columns are > not aligned. Ah, I know understand - this should be fixed too, thanks. -- Bastien

Re: A few changes to test in master

2020-02-01 Thread Axel Kielhorn
Hi Bastien, > Hi Axel, > > thanks for testing the feature and reporting these issues. > > I pushed a fix on master - can you confirm it solves your issues? It does, thanks for the quick response. There is another issue when a column is reduced in width by C-C TAB. The header line still has the

Re: A few changes to test in master

2020-02-01 Thread Bastien
Hi Axel, thanks for testing the feature and reporting these issues. I pushed a fix on master - can you confirm it solves your issues? -- Bastien

Re: A few changes to test in master

2020-02-01 Thread Axel Kielhorn
> Am 31.01.2020 um 12:26 schrieb Bastien : > > Dear all, > > I would like to highlight three changes from master that need to be > carefully tested before Org 9.4 can be released: > > - M-x org-table-electric-header-mode RET will display the first row > of the table at point in the header li

Re: A few changes to test in master

2020-02-01 Thread Bastien
Samuel Wales writes: > org-table-header-line-mode? That's indeed better - I pushed the change. Thanks to both of you! -- Bastien

Re: A few changes to test in master

2020-01-31 Thread Kaushal Modi
On Fri, Jan 31, 2020, 9:45 PM Samuel Wales wrote: > org-table-header-line-mode? > +1 >

Re: A few changes to test in master

2020-01-31 Thread Samuel Wales
org-table-header-line-mode?

Re: A few changes to test in master

2020-01-31 Thread Kaushal Modi
On Fri, Jan 31, 2020, 6:28 AM Bastien wrote: > Dear all, > > I would like to highlight three changes from master that need to be > carefully tested before Org 9.4 can be released: > > - M-x org-table-electric-header-mode RET will display the first row > of the table at point in the header line

Re: A few changes to test in master

2020-01-31 Thread Bastien
Hi Eric, "Fraga, Eric" writes: > 1. the header contents are placed at the leftmost column means the first >row does not align with the table in two cases: >1. when display-line-number-mode is active and/or >2. when org-indent-mode is used. This concern should be gone now - if you ca

Re: A few changes to test in master

2020-01-31 Thread Bastien
Hi Eric, "Fraga, Eric" writes: > This is very appealing and I'll be using it by default (despite issues; > see below) as I often have long tables in my documents. Thanks, I also start to use it by default to test it more. > Some issues which may or may not be easily fixable or may require more

Re: A few changes to test in master

2020-01-31 Thread Bastien
Hi stardiviner, stardiviner writes: > I can't added numeric priorities with default =[C-c ,]= keybinding.* The keybinding respect the current priority, which either depends on org-priority-lowest/highest/default or on #+PRIORITIES for buffer-local setting. Please change the setting (either gl

Re: A few changes to test in master

2020-01-31 Thread stardiviner
Bastien writes: > Dear all, > > I would like to highlight three changes from master that need to be > carefully tested before Org 9.4 can be released: > > - M-x org-table-electric-header-mode RET will display the first row > of the table at point in the header line when the first row is not >

Re: A few changes to test in master

2020-01-31 Thread Fraga, Eric
On Friday, 31 Jan 2020 at 12:26, Bastien wrote: > I would like to highlight three changes from master that need to be > carefully tested before Org 9.4 can be released: > > - M-x org-table-electric-header-mode RET will display the first row > of the table at point in the header line when the firs