Re: [RFC] C-c C-c in agenda

2020-02-01 Thread Samuel Wales
fwiw i /think/ most of the rest of emacs makes c-c c-c complete/send/do stuff with entered or modified text, while c-c c-k cancels. but we are not talking about cancelling edits so c-c c-k wouldn't be quite right either. i just know newcomers will want something. what is best idk.

Re: [RFC] C-c C-c in agenda

2020-02-01 Thread Marco Wahl
Samuel Wales writes: > i think it can be confusing to new users to have column mode > accidentally activated. what are the things they will try to get out > of it? maybe worth considering all the panic commands they'd try, and > either deactivate or message what to do to deactivate? Indeed. E

Re: [RFC] C-c C-c in agenda

2020-02-01 Thread Marco Wahl
Hi Adam, Adam Porter writes: >> For some days now C-c C-c disables column view in Org files. This helps >> me a bit and never got in my way. And I thought it would be quite >> natural and consistent to use this binding for the agenda too. >> >> What do you think about all that? > > Hi Marco, >

Re: [RFC] C-c C-c in agenda

2020-01-31 Thread Bastien
Hi Adam, Adam Porter writes: > I don't use column view very often, so I may be biased, but anyway: in > the general context of an Agenda buffer, I don't feel like enabling or > disabling column view is the most obviously useful or natural thing to > do, so "C-c C-c" doesn't seem like an appropri

Re: [RFC] C-c C-c in agenda

2020-01-28 Thread Adam Porter
Marco Wahl writes: > For some days now C-c C-c disables column view in Org files. This helps > me a bit and never got in my way. And I thought it would be quite > natural and consistent to use this binding for the agenda too. > > What do you think about all that? Hi Marco, I've always had the

Re: [RFC] C-c C-c in agenda

2020-01-28 Thread Samuel Wales
i think it can be confusing to new users to have column mode accidentally activated. what are the things they will try to get out of it? maybe worth considering all the panic commands they'd try, and either deactivate or message what to do to deactivate? if c-c c-c is being weighed, maybe consid

Re: [RFC] C-c C-c in agenda

2020-01-28 Thread Marco Wahl
Bastien writes: >> Thanks - I still don't see any real usecase. > > Ok, I constructed one: > > #+COLUMNS: %30ITEM %MYPROP > #+PROPERTY: MYPROP_ALL "[x]" "[ ]" > > * NEXT Rien > :PROPERTIES: > :MYPROP: [ ] > :END: > > In this case, when the cursor is on the MYPROP column in column > (a

Re: [RFC] C-c C-c in agenda

2020-01-28 Thread Bastien
Bastien writes: > Thanks - I still don't see any real usecase. Ok, I constructed one: #+COLUMNS: %30ITEM %MYPROP #+PROPERTY: MYPROP_ALL "[x]" "[ ]" * NEXT Rien :PROPERTIES: :MYPROP: [ ] :END: In this case, when the cursor is on the MYPROP column in column (agenda or not) view, C-c

Re: [RFC] C-c C-c in agenda

2020-01-28 Thread Bastien
Hi Marco, Marco Wahl writes: >>> You miss the lines which have not been transformed into columns by >>> column view, and I think that's all. >> >> When I turn on `org-agenda-columns', all the lines of my agenda are >> transformed into columns. Can you give me an example where some lines >> are

Re: [RFC] C-c C-c in agenda

2020-01-28 Thread Marco Wahl
>> You miss the lines which have not been transformed into columns by >> column view, and I think that's all. > > When I turn on `org-agenda-columns', all the lines of my agenda are > transformed into columns. Can you give me an example where some lines > are not transformed into columns? My ex

Re: [RFC] C-c C-c in agenda

2020-01-28 Thread Bastien
Hi Marco, Marco Wahl writes: > You miss the lines which have not been transformed into columns by > column view, and I think that's all. When I turn on `org-agenda-columns', all the lines of my agenda are transformed into columns. Can you give me an example where some lines are not transformed

Re: [RFC] C-c C-c in agenda

2020-01-28 Thread Marco Wahl
Bastien writes: >> I've now tested this and see how it can be useful, but having C-c C-c >> perform this unique deactivation in agenda view seems unfinished. > > Also, when columns are activated in an agenda view, org-columns-map > already bind C-c C-c to org-columns-toggle-or-columns-quit, so C-

Re: [RFC] C-c C-c in agenda

2020-01-28 Thread Bastien
Hi Marco, Bastien writes: > I've now tested this and see how it can be useful, but having C-c C-c > perform this unique deactivation in agenda view seems unfinished. Also, when columns are activated in an agenda view, org-columns-map already bind C-c C-c to org-columns-toggle-or-columns-quit, s

Re: [RFC] C-c C-c in agenda

2020-01-28 Thread Bastien
Hi Marco and all, Marco Wahl writes: > Off list I have politely been pointed to possibly have gone too far with > a recent commit to master. Thanks for that. Yes - someone I overlooked this addition, my bad. > To the issue: With the current master branch C-c C-c disables column > view in the