Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters

2022-07-29 Thread Bastien Guerry
Hi Ihor and Hugo, Ihor Radchenko writes: > Bastien, can you please confirm that Hugo is listed in the FSF > records Yes I do! > and then add him to the contributors.org? Done. -- Bastien

Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters

2022-07-28 Thread Ihor Radchenko
Hugo Heagren writes: > On 18/07/2022 17:55, Max Nikulin wrote: > >> I am sorry if I am wrong, but I do not see you among known Org, >> contributors. You patch is likely greater than it is allowed for >> TINYCHANGE, so before you patch can be committed, copyright assignment >> should be signed, s

Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters

2022-07-24 Thread Ihor Radchenko
Max Nikulin writes: >>> It is `map-do' that causes the problem. Maybe earlier implementation in >>> Emacs-26 has some peculiarities. It is the version available from the >>> system repository for Ubuntu-20.04 LTS focal. >> >> Tests do not fail on my side using Emacs 26.3 > > Ihor, what is the or

Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters

2022-07-24 Thread Max Nikulin
On 23/07/2022 20:06, Ihor Radchenko wrote: Max Nikulin writes: If it still fails, could you try isolating whether it's a specific `should' clause which is the problem, if it fails with any of them? It is `map-do' that causes the problem. Maybe earlier implementation in Emacs-26 has some pecul

Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters

2022-07-23 Thread Max Nikulin
On 23/07/2022 20:06, Ihor Radchenko wrote: Max Nikulin writes: If it still fails, could you try isolating whether it's a specific `should' clause which is the problem, if it fails with any of them? It is `map-do' that causes the problem. Maybe earlier implementation in Emacs-26 has some pecul

Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters

2022-07-23 Thread Ihor Radchenko
Max Nikulin writes: >> If it still fails, could you try isolating whether it's a specific >> `should' clause which is the problem, if it fails with any of them? > > It is `map-do' that causes the problem. Maybe earlier implementation in > Emacs-26 has some peculiarities. It is the version availa

Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters

2022-07-23 Thread Max Nikulin
On 23/07/2022 14:48, Hugo Heagren wrote: I've already assigned copyright to the FSF for work on Emacs (see attached certificate). Do I need to do anything else for org-mode in particular? Great, I hope, it is enough, but my answer is not authoritative. Emacs-26.3: make test-dirty BTEST_RE=te