Re: [PATCH] ox-ascii.el: Fix justify when `indent-tabs-mode' is non-nil

2021-09-19 Thread Timothy
Hi Morgan, Thanks for clarifying this. That makes sense to me, and so I’ve just pushed your patch as 3a77e59 🙂, with a slightly tweaked commit message. Thanks for going to the effort of pinpointing and fixing this issue, and your patience in seeing this accepted. Morgan Willcock writes: > It s

Re: [PATCH] ox-ascii.el: Fix justify when `indent-tabs-mode' is non-nil

2021-09-19 Thread Morgan Willcock
Timothy writes: > Hi Morgan, > > I’ve just taken a look at your patch (it `git am's just fine), since nobody > else > seems to have had the time to look at your patch as of late. There’s one thing > which I now realise completely slipped by me last time — why are tabs bad? > Maybe I’m missing s

Re: [PATCH] ox-ascii.el: Fix justify when `indent-tabs-mode' is non-nil

2021-09-19 Thread Timothy
Hi Morgan, I’ve just taken a look at your patch (it `git am's just fine), since nobody else seems to have had the time to look at your patch as of late. There’s one thing which I now realise completely slipped by me last time — why are tabs bad? Maybe I’m missing something obvious, but exporting

Re: [PATCH] ox-ascii.el: Fix justify when `indent-tabs-mode' is non-nil

2021-08-31 Thread Timothy
Hi Morgan, > Great! Thank you for taking a look. No problem, thanks for making the patch :) > I used `git send-email` which is listed as being OK on the website: Huh, I guess it should be fine then. I’ve just never seen the commit message at the top like that so I assumed you’d done it by hand.

Re: [PATCH] ox-ascii.el: Fix justify when `indent-tabs-mode' is non-nil

2021-08-31 Thread Morgan Willcock
Timothy writes: > Hi Morgan, > >> I’ve attached a patch to fix an issue where tab characters are generated by >> the ASCII exporter when `indent-tabs-mode’ has its default value of t. > > Thanks for finding this bug, fixing it, and sending us it 🙂. I was able to > reproduce your test case with “e

Re: [PATCH] ox-ascii.el: Fix justify when `indent-tabs-mode' is non-nil

2021-08-31 Thread Timothy
Hi Morgan, > I’ve attached a patch to fix an issue where tab characters are generated by > the ASCII exporter when `indent-tabs-mode’ has its default value of t. Thanks for finding this bug, fixing it, and sending us it 🙂. I was able to reproduce your test case with “emacs -Q” (thanks for that, b