Re: [PATCH] org-refile.el: Fix the case of emtpy buffer name

2021-05-15 Thread satotake
I was just refactoring my earlier patch based on Maxim's suggestions. I attached it but it might be too late. If the revision make you confused, please ignore it. Anyway, thank you for your reviewing, Maxim and Bastien.

Re: [PATCH] org-refile.el: Fix the case of emtpy buffer name

2021-05-15 Thread Bastien
Hi, satotake writes: > * lisp/org-refile.el (org-refile-get-targets): Ensure > arg of `file-name-non' and `file-truename' is non-nil. > > If you set `org-refile-use-outline-path' `file' or `full-file-path', > and call `org-refile' in the buffer before visiting file, > errors are raised at these

Re: [PATCH] org-refile.el: Fix the case of emtpy buffer name

2021-05-14 Thread Maxim Nikulin
In my opinion, patch is the minimal change that fixes particular workflow and can be committed in the current form. Commit message may be improved a bit. I have a question (mainly to maintainer) if another approach could lead to undesired effects, see below. I have noticed a couple of old is