Re: [PATCH] org-protocol: Add void() to bookmarklets

2024-12-24 Thread Ihor Radchenko
Max Nikulin writes: >> Another variant from reddit is >> >> javascript:location.href='org-protocol://store-link?'+new >> URLSearchParams({url:location.href, title:document.title}); void(0); > > If you think that ";void(0)" variant is less prone to errors then I may > update my patch. I have no

Re: [PATCH] org-protocol: Add void() to bookmarklets

2024-12-24 Thread Max Nikulin
On 22/12/2024 19:42, Ihor Radchenko wrote: Max Nikulin writes: -javascript:location.href='org-protocol://store-link?' + - new URLSearchParams({url:location.href, title:document.title}); +javascript:void(location.href='org-protocol://store-link?' + + new URLSearchParams({url:location.h

Re: [PATCH] org-protocol: Add void() to bookmarklets

2024-12-22 Thread Ihor Radchenko
Max Nikulin writes: > On 16/12/2024 23:01, Max Nikulin wrote: >> A patch updating org-protocol.el comments, docstrings, and the manual is >> attached. > > Should ORG-NEWS be updated as well? Yes, I think. In announcement section. This is one of the cases when we want people to consider changing

Re: [PATCH] org-protocol: Add void() to bookmarklets

2024-12-22 Thread Ihor Radchenko
Max Nikulin writes: > A patch updating org-protocol.el comments, docstrings, and the manual is > attached. Thanks! > -javascript:location.href='org-protocol://store-link?' + > - new URLSearchParams({url:location.href, title:document.title}); > +javascript:void(location.href='org-protocol:

Re: [PATCH] org-protocol: Add void() to bookmarklets

2024-12-16 Thread Max Nikulin
On 16/12/2024 23:01, Max Nikulin wrote: A patch updating org-protocol.el comments, docstrings, and the manual is attached. Should ORG-NEWS be updated as well?